Commit Graph

34630 Commits

Author SHA1 Message Date
vadimt 30618db33f Add tracing for non-dragging icon
Bug: 138729456
Change-Id: Ib18f1544f2520509bd982f032bf3ed0c72ca9529
2019-09-05 14:08:39 -07:00
Xin Li 957b8a1d35 [automerger skipped] Merge "DO NOT MERGE - Merge Android 10 into master" am: 636e58424b -s ours
am: 2fe921d058

Change-Id: I94497696c7574e83ae627113c19ba69c816c1e70
2019-09-05 14:03:34 -07:00
Xin Li 2fe921d058 [automerger skipped] Merge "DO NOT MERGE - Merge Android 10 into master"
am: 636e58424b -s ours
am skip reason: subject contains skip directive

Change-Id: Ifbfc28597fdaf9beac8eed04800ae575530667f7
2019-09-05 13:30:14 -07:00
Vadim Tryshev b34f951e7e Merge "Adding a test method to get a Launcher object when it becomes non-null" into ub-launcher3-qt-qpr1-dev 2019-09-05 18:49:10 +00:00
Sunny Goyal ac6f69f78d Lazily binding folder pages and icons
Folders are bound before they are opened and unbound on close. This
allows us to recycle the views in folders

Bug: 139051851
Change-Id: Ic1ed3265c0f583af54d73dab6f2751bc95266ea9
2019-09-05 17:17:11 +00:00
Xin Li 636e58424b Merge "DO NOT MERGE - Merge Android 10 into master" 2019-09-05 16:53:27 +00:00
vadimt cf61e16a2c Adding a test method to get a Launcher object when it becomes non-null
Change-Id: I1c56777c87827b5edf1c7f55ad9639321e598311
2019-09-04 19:02:54 -07:00
vadimt 8c2efd0de0 Enabling some tests in landscape mode
Bug: 121280703
Change-Id: I285638d832594d5fed26ee812737a4356b110899
2019-09-04 17:33:52 -07:00
TreeHugger Robot e1335c2359 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev 2019-09-05 00:13:30 +00:00
vadimt 758a1d983d Removing flinging via UI Automator
UI Automator loses events. Switching to the homemade scrolling.

Bug: 138729157
Change-Id: Ib09bd5714e83eadfc65b54202867bf375e6b47c5
2019-09-04 16:35:19 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
TreeHugger Robot 18c691404f Merge "Update app open/close animations." into ub-launcher3-master 2019-09-04 21:37:26 +00:00
Samuel Fufa c04780c13f Merge "Don't persist invalid previews to cache" into ub-launcher3-master 2019-09-04 20:53:29 +00:00
Xin Li ecb37ee845 DO NOT MERGE - Merge Android 10 into master
Bug: 139893257
Change-Id: I157ff596deb419a57eca32a9b8d954d76294f627
2019-09-04 13:34:30 -07:00
Jon Miranda dff0de4730 Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 13:03:18 -07:00
Vadim Tryshev 3651a3dfbe Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev am: 846656f138
am: 72fddba837

Change-Id: I0040d45b55f87df8b11c1e1b872530b03f81513a
2019-09-04 12:47:41 -07:00
Vadim Tryshev 72fddba837 Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev
am: 846656f138

Change-Id: Ie40cc1d55d40ffefe6c1b2d3588b03ff92d2cb38
2019-09-04 12:37:40 -07:00
Vadim Tryshev 846656f138 Merge "Enabling debug tracing for all UI tests" into ub-launcher3-qt-qpr1-dev 2019-09-04 17:52:11 +00:00
Samuel Fufa 15357968db Don't persist invalid previews to cache
Test: Manual
Bug:137404499
Change-Id: I04a3a0e081fcb8de45601f028398670e7542ed22
2019-09-04 10:01:52 -07:00
Vadim Tryshev efef50cc34 Merge "Removing numbers from error message" into ub-launcher3-qt-qpr1-dev am: 5e893727f8
am: c6c63706fa

Change-Id: Ib257e80620657a5e3d34f2eb2931ac9e09637a1b
2019-09-03 18:18:30 -07:00
Vadim Tryshev c6c63706fa Merge "Removing numbers from error message" into ub-launcher3-qt-qpr1-dev
am: 5e893727f8

Change-Id: Ie5bfb48d233abc7c21c8ff6df97affb4c9339f8e
2019-09-03 18:11:10 -07:00
Vadim Tryshev 5e893727f8 Merge "Removing numbers from error message" into ub-launcher3-qt-qpr1-dev 2019-09-04 00:54:21 +00:00
Andy Wickham 897ff12466 Reduces padding of the Overview shelf in no button mode. am: 90c16ace8a
am: 44e1e4959c

Change-Id: Ia726a9ae9d0079c4517269d58f5132eb629b9afe
2019-09-03 17:36:18 -07:00
Andy Wickham 44e1e4959c Reduces padding of the Overview shelf in no button mode.
am: 90c16ace8a

Change-Id: I244c2bd957d0ec6cbae9ae72d0a305a5023c2509
2019-09-03 17:29:08 -07:00
vadimt 0ce38af957 Enabling debug tracing for all UI tests
Change-Id: I434ee378baf35de955c8a589b8380e1751e4107a
2019-09-03 17:16:34 -07:00
vadimt 849cdc803d Removing numbers from error message
They interfere with flake clustering

Change-Id: I845b6e080824e00b9442070d53a0a3b448670d67
2019-09-03 17:01:27 -07:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham 1f3b82ba6e Marks ScrimView unimportant for accessibility when Widgets screen is opened. am: c40872b913
am: 42cbb23d0d

Change-Id: I3f52c9905e73547fa885de33159f75d5fa4e5cb7
2019-09-03 15:35:26 -07:00
Andy Wickham 42cbb23d0d Marks ScrimView unimportant for accessibility when Widgets screen is opened.
am: c40872b913

Change-Id: Ic078f5dd44e57883041433ad001ed4fa684dcba2
2019-09-03 15:29:25 -07:00
Andy Wickham 90c16ace8a Reduces padding of the Overview shelf in no button mode.
Before: https://screenshot.googleplex.com/iw6baTCfoy2.png
After: https://screenshot.googleplex.com/8CcsQvLhYDo.png
Desired: https://b.corp.google.com/action/issues/139551306/attachments/26925873?download=false

Test: Examined before and after padding and verified 3-button is unaffected.
Fixes: 139551306

Change-Id: Ia416399cf25e7c6c2fb8aa84ad20e7ad74dcd31b
(cherry picked from commit ddc9622e92)
2019-09-03 22:05:20 +00:00
Andy Wickham c40872b913 Marks ScrimView unimportant for accessibility when Widgets screen is opened.
This prevents it from holding focus while the Widgets screen is visible
(after using Widgets action from the All Apps caret thingy).

Test: Manually followed steps provided in bug, and issue not seen after this change.
Fixes: 139918680
Change-Id: I280ac97fb7ff9fa67f1c6a1ce9cdfa9e451231eb
2019-09-03 21:20:22 +00:00
Jon Miranda 0b439b446d Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev am: 505a88140e
am: 3105f80e64

Change-Id: Ic8d685a5f9a9f2b2ede483402d6c80e40ec9cdc4
2019-09-03 11:24:46 -07:00
Sunny Goyal f6d5c67402 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev am: a42681f6d2
am: 71834aa186

Change-Id: Id5169fab20896a5e24e8856b714edc1b5cc738ad
2019-09-03 11:24:14 -07:00
Jon Miranda 3105f80e64 Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev
am: 505a88140e

Change-Id: I1bb3883810bde87ffc3b69b154f2f886c09e6e85
2019-09-03 11:17:48 -07:00
Sunny Goyal 71834aa186 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev
am: a42681f6d2

Change-Id: I05ca0e24324272e06087221fbbb50a6dbef7ed4f
2019-09-03 11:17:14 -07:00
TreeHugger Robot 505a88140e Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:27:11 +00:00
Pinyao Ting c2c4d8358c Merge "migrate custom widgets in comply with plugin framework" into ub-launcher3-master 2019-09-03 16:23:37 +00:00
Sunny Goyal a42681f6d2 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:23:18 +00:00
Jon Miranda a8c7c0b713 Only add promise icon if icon is provided in the SessionInfo.
- In some cases, SessionInfo is created without an icon until later on
  in the install process. This prevents promise icons with default Android
  logo from appearing.
- This will also prevent apps without a launching activity from appearing
  as a promise icon and then disappearing when the app is installed.

Bug: 135633159
Change-Id: I30adde8bf2cf583bffca8ed878f9cc20d6d41a13
2019-09-03 08:13:09 -07:00
TreeHugger Robot e512dd6ef9 Merge "Import translations. DO NOT MERGE" into ub-launcher3-master 2019-09-01 18:50:23 +00:00
Bill Yi 47d7d9718a Import translations. DO NOT MERGE
Change-Id: I712f6654aeaddfae096de2c96fc374f745006e96
Auto-generated-cl: translation import
2019-09-01 11:33:57 -07:00
vadimt 7e6ba0e5bf Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev
am: 78ebf57e9f

Change-Id: Ifac50ddd7ad0a689722e4911a735cf2d503d177a
2019-08-30 18:10:34 -07:00
TreeHugger Robot 78ebf57e9f Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev 2019-08-31 00:55:55 +00:00
vadimt 7bfc820d0c Adding tracing for mismatch between current and stable states
Bug: 140311911
Change-Id: Ie6196015a3f1b35b1403a12540ff7e3290f8cb3d
2019-08-30 17:13:43 -07:00
Tony Wickham 4feff8ba95 Don't update all apps content visibility during home animation
am: 7310bb4b5c

Change-Id: I92382497e4444e2ca1d1951c44646bc5047a6f36
2019-08-30 16:22:51 -07:00
Tony Wickham 7310bb4b5c Don't update all apps content visibility during home animation
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.

Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
2019-08-30 22:10:55 +00:00
Pinyao Ting c7a6c2979c migrate custom widgets in comply with plugin framework
Bug: 139888225
Change-Id: I8a3d0fe2689ad5ba24b19309728bbad0b6287f71
2019-08-30 12:06:22 -07:00
Jon Miranda 768cb139cc Fix bug where we incorrectly change the default profile id of the database.
Change-Id: I0fafc06f5e28c1fdff77003c984e686719a60cd2
2019-08-30 16:11:00 +00:00
Hyunyoung Song c1ff993a38 Merge "Setup owners for featureflag files" into ub-launcher3-qt-qpr1-dev
am: ce78e16884

Change-Id: I8bb9698280fe623d67a4809caa3cf0daed315fd0
2019-08-29 15:32:18 -07:00