Commit Graph

34630 Commits

Author SHA1 Message Date
TreeHugger Robot f982b0dcc8 Merge "[a11y] fix the issue where launcher announces item added to homescreen before it does" into ub-launcher3-master 2019-11-19 07:29:44 +00:00
Samuel Fufa a9e9444070 Merge "Report app pin/unpin to AppPredictor" into ub-launcher3-master 2019-11-19 01:18:15 +00:00
TreeHugger Robot 23ac34a42c Merge "When scrolling in All apps, scroll to last clickable row" into ub-launcher3-master 2019-11-19 00:01:10 +00:00
Winson Chung ea91205f66 Merge "Fix two small thumbnail leaks" into ub-launcher3-master 2019-11-18 18:41:49 +00:00
Samuel Fufa 4031d65171 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev
am: 9353b00616

Change-Id: I37fab57d0c01b413ca05049326ca519d6d74323e
2019-11-18 10:32:02 -08:00
Samuel Fufa 9353b00616 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev 2019-11-18 18:19:14 +00:00
Samuel Fufa 7a8be030aa Report app pin/unpin to AppPredictor
Test: Manual
Bug: 142753423
Change-Id: I380e58f31ed508d812d0bf8dfc35905a752dc029
2019-11-18 10:14:53 -08:00
android-build-team Robot 9e575e60ed Snap for 6013487 from c5027ce20d to rvc-release
Change-Id: Idcfc6074032a1874a876ffec88816a4cf95f4eb0
2019-11-17 00:04:38 +00:00
android-build-team Robot 6ac9b92443 Merge cherrypicks of [9740811, 9740883, 9740926, 9740927, 9740929, 9740931, 9741053, 9741055, 9741072, 9740884, 9740966, 9740968, 9740969, 9740971, 9741093, 9741094] into qt-qpr1-release
Change-Id: Ic73fb24511ee46b8fea77bc6bf73a73d4a1f2791
2019-11-16 00:28:33 +00:00
Jon Miranda 713b93d0c1 [DO NOT MERGE] Fix NPE caused by an install flow where we decode the LauncherActivityInfo
but we don't fill in the data Intent.

Adding do not merge tag here, as we want the fix to have soak time in QPR2 ASAP.
The fix for master will be added to master branch next time we drop code from
ub-launcher3-master.

Bug: 143190879
Change-Id: I8f774203b99f022b2cf1708de6d8fe2398b332ce
(cherry picked from commit 4459e3f6f9)
(cherry picked from commit 4783545808)
2019-11-16 00:27:40 +00:00
android-build-team Robot 9fd64284b3 Merge cherrypicks of [9739600, 9739601, 9739602, 9739716, 9739717] into rvc-release
Change-Id: Ic920640d9bd72fc2fbb0cafa08b93df75433914d
2019-11-15 22:53:48 +00:00
Winson Chung 3483020c9d Merging ub-launcher3-master, build 6003980
Bug:124967099 P2 Support 5 column layout for all apps (independent of what the workspace layout is)
Bug:126596417 P2 [Gesture Nav] Polish quick switch from home screen
Bug:136278866 P2 Temporary workarounds to make tests pass on Cuttlefish
Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:138473688 P4 Home settings can't be dismissed by swipe up
Bug:138944598 P4 Merge TaskIconCache into IconCache
Bug:139137636 P2 Create memory tests for Launcher
Bug:139661510 P1 Quickswitch over NGA half shelf doesn't work
Bug:139663018 P2 A home screen shortcut to the Files app keeps being added without my ok.
Bug:140242324 P2 Cache shortcutInfo icons in Launcher
Bug:140252765 P2 Audit Gesture Nav tests (including Back and Quick Switch)
Bug:140337263 P2 Empty launcher (DecorView visibility==4)
Bug:141265005 P4 Overview task should not be tiny if prediction list is shown instead of hotseat
Bug:141484300 P4 Re-enable flicker tests
Bug:141556707 P1 Non-badged work profile app shortcuts getting created on the launcher.
Bug:141568904 P1 Launcher: Unable to add Directions widget
Bug:141770616 P2 Flake: Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/deep_shortcuts_container\E'] (visible state: AllApps),
Bug:141886704 P2 Use app targets to determine input consumer instead of launcher state
Bug:141899192 P3 [TalkBack] Page number that TalkBack read doesn't match the current screen on recent apps
Bug:142088072 P2 Turning off the display and then back on takes user back to previous app in live tile mode
Bug:142498588 P4 Feature req: Automatic folder names / creation
Bug:142514365 P1 Failing test AddWidgetTest.testDragIcon
Bug:142753423 P4 Prototype predictive hotseat
Bug:142803200 P1 Broken binder tests
Bug:142828227 P2 Temporary tweaks to make Launcher tests pass in Inproc presubmit
Bug:143107728 P4 Crashes on boot, NPE in nexuslauncher
Bug:143153963 P1 Launcher crashing while trying to tap and launch apps from home screen multiple times.
Bug:143155020 P1 [Failing test] MomoryTests.testAppLaunchFromWorkspace*
Bug:143190879 P1 Pop up "Pixel launcher keeps stopping" when both OTA and mainline are updated before restarting device.
Bug:143249037 P1 Swipe up gesture does not work on wembley-eng
Bug:143285809 P1 [Failing test] TaplTestsQuickstep.testQuickSwitchFromApp
Bug:143307786 P1 Fix screenshot not getting cleaned up after recents animation cancelation
Bug:143353100 P2 [RVC] Stuck in "All set!" after cable restore
Bug:143361207 P3 Can't launch shortcut in live tile mode
Bug:143377934 P4 Tapping on QSB leaves user in live tile mode with empty background
Bug:143639898 P4 Notification dot should animate into popup on long press
Bug:143702640 P2 icon badge is hidden when dragging
Bug:143702700 P4 Drag and drop misbehave
Bug:143714109 P2 Flashing when swipe up and right to launch the previous task
Bug:143773683 P2 [Live tile] App open animation gets cancelled because of screenshot cleanup
Bug:143792840 P4 Pixel launcher keeps stopping
Bug:143803446 P2 "Files" app has one more icon appearing per day
Bug:143857157 P3 Live tile does not follow translationX change of RecentsView
Bug:143904998 P2 Launcher crashes when dragging now playing shortcut
Bug:143991628 P2 Launcher3 App - system apps must target API level 29 or higher
Bug:144081762 P2 Security Vulnerability in AOSP and Pixel Launchers
Bug:144180777 P1 Inproc tests in git_master: getting app icon LauncherTestApp on all apps; Unable to scroll to a clickable icon: LauncherTestApp (visible state: AllApps)
Bug:144290150 P2 Notification dot popups show the wrong notifications
Bug:38268585 P2 Lightning bolt icon missing on recents in Vimeo for OC MR1 and Android P

Test: Manual
Change-Id: I0e329eea927c49217c0446a9e62ceaf3cf0099f0
(cherry picked from commit fa4ecb35adfcdcaf928572f5f0c089b42bb12218)
2019-11-15 22:53:38 +00:00
Sunny Goyal 504b0ba055 Preventing dead lock in layout inflation
Bug: 143353100
Change-Id: I52d0794aad26c1d1de8cb373f3398f626c15b4af
(cherry picked from commit d1a67d0d72)
2019-11-15 22:53:32 +00:00
Tracy Zhou 897813aa34 Merge "Check if returned surface params are null before adding them for surface transform" into ub-launcher3-master 2019-11-15 21:45:25 +00:00
vadimt 73cd121122 When scrolling in All apps, scroll to last clickable row
Not the last row. This fixes tests broken after some assumption broke in
platform at an unknown moment.

Since the gesture distance became smaller in some cases, the speed of
the gesture became slower, and on some devices, the scroll gesture
triggers icon dragging.

To prevent this, I reduced the number of steps in the gesture to 10, but
added a slow-down at the end of the gesture to avoid inertia.

Also made some names and calculations clearer.

Bug: 144180777
Change-Id: Ie6c5776606ecff64d553fa836bdb3d90f32c5d9e
2019-11-15 13:40:29 -08:00
Tracy Zhou fdf954a353 Check if returned surface params are null before adding them for surface transform
We call finish recents animation before app switch animation finishes. When we finish, the live tile params are not cleared up.

This change takes care of
- clean up recents animation targets when it's finished
- do a sanity check on live tile surface params before adding them to the surface transform array

Fixes: 143889142
Test: Swipe up to Overview in live tile mode, switch to a different task, and make sure it doesn't crash anymore
Change-Id: I089cf0a97744461d1fec4d0c97e0c3c6c1049ae3
2019-11-15 13:06:36 -08:00
Winson Chung 9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
TreeHugger Robot 1dca644311 Merge "Disabling FallbackRecents tests" into ub-launcher3-master 2019-11-15 16:50:02 +00:00
Pinyao Ting 96df2cb8b3 [automerger skipped] Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev
am: f7b75392fc -s ours
am skip reason: change_id I296452faea67568b39a35968bb813dc4e51a51fc with SHA1 44677f7e88 is in history

Change-Id: I880b94cbc3f5dfcd98f8886c454657bba466885e
2019-11-14 18:16:26 -08:00
Pinyao Ting f7b75392fc Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev 2019-11-15 01:55:40 +00:00
Pinyao Ting 838f4393b6 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
Merged-In: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-15 01:55:13 +00:00
vadimt cbc9bffd7e Disabling FallbackRecents tests
Even though they don't block presubmit, the fact that they are failing:
1. Causes sheriffs no not notice other issues;
2. Would block switching to 24hr fix-it policy and Quarterdeck.

Bug: 143488140
Change-Id: I95e3e15b69e0487946919f3f6889e286a1fae141
2019-11-14 17:23:52 -08:00
Vadim Tryshev d82d667194 Merge "Revert "When scrolling in All apps, scroll to last clickable row"" into ub-launcher3-master 2019-11-15 00:58:22 +00:00
TreeHugger Robot 498c9d63e1 Merge "fix custom shortcut test" into ub-launcher3-master 2019-11-15 00:48:29 +00:00
Tony Wickham 37a0970bf5 Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 15:50:18 -08:00
Pinyao Ting c90742775b [a11y] fix the issue where launcher announces item added to homescreen before
it does

Test:
1. long press on home screen -> widgets
2. enable talkback
3. add a custom shortcut to home screen (i.e. 1x1 widgets, e.g. drive
scan in Google Drive, Driving Mode in Google Maps ... e.t.c )
4. verify talkback announces "item addded to homescreen" after it does
get added to the homescreen
5. repeat the same test for widgets (e.g. calendar)

Bug: 141527338
Change-Id: I232e6e796c9edb81128f816c71a33310c3700e73
2019-11-14 22:37:24 +00:00
Vadim Tryshev a354835c6e Revert "When scrolling in All apps, scroll to last clickable row"
This reverts commit 7afd271a17.

Reason for revert: b/144522058

Bug: 144522058

Change-Id: Ie104b092a44e3a2fee0803fa83f1af7f8fd0afdf
2019-11-14 22:34:08 +00:00
Pinyao Ting 44677f7e88 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-14 14:13:22 -08:00
Thiru Ramasamy 445cc2421e Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev
am: 9d9c42ef38

Change-Id: I1d67cb5a77c46e05ddfdfa547a12d8c64c7b4fdd
2019-11-14 14:07:42 -08:00
Samuel Fufa ddab25da6b Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev
am: 574e8413ba

Change-Id: I37c71d6f55d2478d029a9509ca61d32599582442
2019-11-14 14:04:35 -08:00
Thiru Ramasamy 9d9c42ef38 Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev 2019-11-14 22:02:09 +00:00
Samuel Fufa 574e8413ba Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev 2019-11-14 21:53:04 +00:00
Samuel Fufa 10b106dc8a Merge "Icon left side badging" into ub-launcher3-master 2019-11-14 21:10:47 +00:00
Samuel Fufa d145647301 Merge "Make home setting edge-to-edge" into ub-launcher3-qt-future-dev
am: 16691a72bf

Change-Id: I7b74c8171b26ea38b4b284e900abce03baf5ea79
2019-11-14 12:56:32 -08:00
Samuel Fufa 16691a72bf Merge "Make home setting edge-to-edge" into ub-launcher3-qt-future-dev 2019-11-14 20:40:02 +00:00
Tony Wickham 2785a5996c Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
Merged-In: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 12:31:01 -08:00
Tony Wickham 42a9ef0e9f Move shelf peeking anim code to ShelfPeekAnim class
Bug: 126596417
Change-Id: I5ba501b04b3eaf12a20ba1312ef362f9734761c3
Merged-In: I5ba501b04b3eaf12a20ba1312ef362f9734761c3
2019-11-14 12:30:32 -08:00
Samuel Fufa 1c8d90aed0 Fix folder available height calculation
Bug: 139456471
Test: Manual
Change-Id: Ic86c481e76f8b6629ad74109ef98900f1c00e16c
2019-11-14 11:02:49 -08:00
vadimt fa6f56761b Improving error message
The old one could be misunderstood as "the whole Launcher is missing".

Change-Id: I91cad52ee297b0250cba23215743a47c24757ae1
2019-11-13 18:26:28 -08:00
Samuel Fufa a4431f8abe Icon left side badging
Test: Manual
Bug:138947443
Change-Id: I8a7ce6e1cccfbfd6c2c6fad96768ab64cfdb41b1
2019-11-13 17:06:16 -08:00
Tony Wickham 4df42f85a4 Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-13 16:37:32 -08:00
vadimt 132b5a0bf8 [automerger skipped] Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev
am: 49e72ac059 -s ours
am skip reason: change_id I19e3ba7cfa25de75a47202845d0838bea46af92c with SHA1 480083490f is in history

Change-Id: I615cd69e7442139be0270ed655c578a29a799233
2019-11-13 14:13:18 -08:00
TreeHugger Robot 49e72ac059 Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev 2019-11-13 22:03:11 +00:00
vadimt ec7c044c89 Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the icon on AllApps is higher that 2 paddings.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
Merged-In: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 21:45:16 +00:00
Samuel Fufa 8fb487413c Enable a11y scrolling with item drag
Bug:142300278
Test:Manual
Change-Id: Ieb79dac8a793f5adfe715b1cbe5b7ecae95a26b5
2019-11-13 13:22:49 -08:00
TreeHugger Robot 236ef051fd Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-master 2019-11-13 20:52:36 +00:00
vadimt 480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting fed4d8e8da disable custom shortcut test in oop
am: d9dd8ef3ba

Change-Id: I6cb1f18c3e7ca1cd79aa5f58a0e03ef07eb797ee
2019-11-13 10:40:01 -08:00
Pinyao Ting d9dd8ef3ba disable custom shortcut test in oop
Bug: 142154748
Change-Id: I08ec8f665a3cc45610f8f2b27a60f7334a2b1b24
2019-11-12 23:37:20 -08:00
Pinyao Ting 88267345d8 [automerger skipped] include predicted_rank in app launch logging
am: 1397a42fc2 -s ours
am skip reason: change_id I07a62f07057537a6c09384cf944bbc5aa5888d22 with SHA1 2cf2871392 is in history

Change-Id: I7fe54e69c6a6ed9909264c771f423ade8dad868d
2019-11-12 18:04:05 -08:00