Commit Graph

34630 Commits

Author SHA1 Message Date
TreeHugger Robot 3fc7029818 Merge "Recycling accessibility event as the docs require" into ub-launcher3-master 2019-12-13 18:38:16 +00:00
Riddle Hsu 0ae61c8d29 Invalidate snapshot of home if its UI is changed
Snapshot may be enabled for home task when turning off
screen. If home UI has changed after screen off, the
snapshot should not be used to avoid ugly visual effect.

Bug: 140811348
Test: Lock/unlock device while home is on top with 4 cases:
      1. All apps is shown.
      2. Overview is shown.
      3. Options menu is shown.
      4. Quick search bar is active.
      The expected result should be no starting window
      when unlocking because the snapshot is dropped.

Change-Id: I4bd9926b6f9332ac16b1b3a25ffdd44706015a33
2019-12-13 16:55:54 +08:00
vadimt 08eca2fa2e Removing temporary workarounds to make tests pass on Cuttlefish
Bug: 136278866
Change-Id: Ie537a578bb871921c0cbea1f197261e703de98f5
2019-12-12 18:15:48 -08:00
vadimt 03cd58e575 Diagnosing visible windows' packages for Background mode
Change-Id: I3caeef4cd890500585f033024b1b6c3521b9e39d
2019-12-12 18:07:42 -08:00
vadimt a45ee97074 Recycling accessibility event as the docs require
Change-Id: I94a2ea7ab93690d0216110b5f77f0116177788a7
2019-12-12 17:43:38 -08:00
Tony Wickham 9298aa92fd Swipe up from nav bar in fallback recents to go home
- Extract swipe-up-to-home logic from OverviewWithoutFocusInputConsumer
  to TriggerSwipeUpTouchTracker util class
- Add FallbackNavBarTouchController for fallback recents to trigger home

Bug: 140845330
Change-Id: I846f1afdaf36529f348b0d3c9c479f01053a463b
2019-12-12 16:31:14 -08:00
vadimt f0c80528ab Starting swipe-to-all-apps outside of areas triggering long-press
I suspect that some tests using TAPL run under pressure (mem or CPU,
created either intentionally or as a result of a leak somewhere)
where test process may generate a pause between DOWN and MOVE events
enough to be recognized as a long tap, which opens a context menu
instead of swiping.

While the clean solution is b/140252325, this is a workaround.

Bug: 144853809
Change-Id: I135eaee608270b7e60bb072cb360632763cbe5c5
2019-12-12 16:27:25 -08:00
Peter Kalauskas 36774217a4 Merge "Remove Launcher3GoIconRecents" into ub-launcher3-master 2019-12-12 23:39:11 +00:00
vadimt 2eb48498b4 Improving navigation mode switch rule and around
Logging assertion failures.
Modifying waits for condition to avoid timing out the whole test if the
iteration takes too long in favor of failing with an actionable diag.

Bug: 145985438
Change-Id: Ie32d93e1548ce6ec64c38449eb1be1287ff9cf56
2019-12-12 15:10:52 -08:00
Automerger Merge Worker a11ff18d6b [automerger skipped] perform accessbility focus when the recyclerview doesn't gain focus am: 9c592e210e -s ours
am skip reason: Change-Id I100e646ad2aba0081b48b86ec408ce8e76a80713 with SHA-1 865dc9b3b1 is in history

Change-Id: If0b71cdd5977c6793c9ca44c6729904c77966174
2019-12-12 18:46:00 +00:00
android-build-team Robot bf1f7c801d Snap for 6066770 from e8dc428a02 to rvc-release
Change-Id: I9a3e8bcd3ddd60874476dbdeb608bd52cda946bd
2019-12-12 04:04:02 +00:00
vadimt 526c630500 Simplify diagnosing of the context menu being present when not expected
Change-Id: I3550a724665f908ef70570e2e151c53fc7fa1844
2019-12-11 18:09:39 -08:00
vadimt 5995e60d90 Logging state change events when in test to simplify diagnosing
Change-Id: I48f741802696f7ef1764a5745ae6243c407a19cc
2019-12-11 17:53:03 -08:00
vadimt 9f48a8ec3b Generating state-changed-to-home event for Widgets->Home transition
This event is required by TAPL is is not currently generated by
Launcher3.

Change-Id: Ibf38b6779cc8d0d6a62d415d07c874d00956435a
2019-12-11 17:24:59 -08:00
Winson Chung 72c5f1f58f Defer resetting the animation controller and targets on cancel
- In the case where the recents animation is canceled while the running
  window animation is running, we invalidate the handler, and force end
  the window animation, which results in the end target being calculated
  and transitioned to.  Because the handlers can still reference the
  animation controller at this point (even though the calls will be
  no-ops since it was canceled), we should not reset the vars until the
  state has been updated.

Bug: 145641576

Change-Id: I5a660026fabb5beb0c45dffeeb4cb4feef5dec30
2019-12-11 17:00:06 -08:00
TreeHugger Robot 98833d525c Merge "Updating some non-final static objects" into ub-launcher3-master 2019-12-11 22:07:53 +00:00
TreeHugger Robot 7d2f42d97a Merge "Moving logging Launcher and platform versions before matching" into ub-launcher3-master 2019-12-11 21:30:35 +00:00
TreeHugger Robot 41dd48a718 Merge "Diagnosing the reason for opening context menu" into ub-launcher3-master 2019-12-11 21:29:38 +00:00
Sunny Goyal 73b5a27b14 Updating some non-final static objects
Updating various static objects to use a standard pattern so that
it is easier to track and cleanup those objects

Bug: 141376165
Change-Id: Ia539cbfa338d544dddad771c5027b6748762768b
2019-12-11 13:22:58 -08:00
Peter Kalauskas 0842cf5f9d Remove Launcher3GoIconRecents
Bug: 144129431
Test: Build and check that Launcher3QuickStepGo is used instead
Change-Id: Ib2a30c9e1e78de7792f34c3505372c8af1cb307d
2019-12-11 12:18:52 -08:00
Vadim Tryshev e8dc428a02 Merge "Moving processing data received from Wellbeing to a supress-all block" 2019-12-11 19:42:37 +00:00
TreeHugger Robot 4f37a5e268 Merge "Removing static instances of UserManagerCompat and AppWidgetManager" into ub-launcher3-master 2019-12-11 18:41:04 +00:00
Winson Chung 42cfeadb03 Merge "Pass user id with call to get icon from task description" into ub-launcher3-master 2019-12-11 18:07:58 +00:00
Sunny Goyal 337c81f664 Removing static instances of UserManagerCompat and AppWidgetManager
> Changing the lifecycle to follow other static objects in Launcher
> Removing compat interface and inlining everything to helpers

Bug: 141376165
Change-Id: I82bd5db1969101de9a7eac77f32728d70195bb35
2019-12-11 10:03:19 -08:00
android-build-team Robot e70df0528d Snap for 6063671 from 24db3af6c0 to rvc-release
Change-Id: I82de875cb0bb065e4173d3a5c4dc495f90388102
2019-12-11 04:14:48 +00:00
TreeHugger Robot fbe947a223 Merge "Move the app to /system_ext" into ub-launcher3-master 2019-12-11 03:53:17 +00:00
TreeHugger Robot b4d4e1127a Merge "Move the app to /system_ext" 2019-12-11 03:53:17 +00:00
Samuel Fufa 78e7e5fcaa Add boolean to differentiate icons from workprofile
Bug:145825382
Test:Manual
Change-Id: I95e0cfe48b4a397eb54455374f11c7ea14c028f6
2019-12-10 13:33:37 -08:00
Winson Chung 1d8a582130 Pass user id with call to get icon from task description
Bug: 145708947
Test: Manual
Change-Id: Ic7da3d36af490ea568481576e26c927020659eda
(cherry picked from commit a8dee18ff1)
2019-12-10 19:55:37 +00:00
Winson Chung 24db3af6c0 Merge "Pass user id with call to get icon from task description" 2019-12-10 19:53:54 +00:00
Pinyao Ting 9c592e210e perform accessbility focus when the recyclerview doesn't gain focus
after fragment replacement in SettingsActivity

Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Enable Talkback
-> Gear Button next to Home app -> About -> Verify Talkback reads the
first item in the page

Change-Id: I100e646ad2aba0081b48b86ec408ce8e76a80713
Merged-In: I100e646ad2aba0081b48b86ec408ce8e76a80713
(cherry picked from commit 865dc9b3b1)
2019-12-10 11:28:50 -08:00
Tony Wickham 70f998471c Merge "Allow quick switch from 3P launcher home in 2 button mode" into ub-launcher3-master 2019-12-10 19:20:57 +00:00
TreeHugger Robot dfa1a20591 Merge "Add logging for hybrid hotseat" into ub-launcher3-master 2019-12-10 18:54:22 +00:00
Zak Cohen c98902af47 Merge "Overview actions - adds feature flag and base class for Overview Actions." into ub-launcher3-master 2019-12-10 18:13:41 +00:00
Tony Wickham a06ad834d0 Allow quick switch from 3P launcher home in 2 button mode
Only the FallbackSwipeHandler supports quickswitch mode on the
home screen, but we only used that handler for fully gestural
mode. Now we also use that handler for 2-button mode if both
of these conditions are met:
- User is on the home screen
- User swipes right on the nav region (instead of up)

Also fix issues with continuous quick switch gestures by setting
the appropriate end target NEW_TASK instead of HOME.

Bug: 140467002
Change-Id: I8f327638b48cf4c0acb1ebe265b7846afac6759b
2019-12-09 19:11:09 -08:00
vadimt 61e285245e Moving logging Launcher and platform versions before matching
I suspect that sometimes APIs return versions that are different from
ones in the bugreport. We want to see them before possible non-match
failures.

Bug: 145935261
Change-Id: Ia1a9208de111368245eac9147ae4a189db823105
2019-12-09 18:15:33 -08:00
vadimt 165a507a35 Disabling fallback tests
Improving state events accounting hasn't completely solved flakiness.
I've noticed that swiping up in 0-button mode sometimes doesn't open
Overview.

Bug: 143488140
Change-Id: I660885ed556aa2953c17d491fde267734b95890b
2019-12-10 02:06:16 +00:00
Zak Cohen e895869f47 Overview actions - adds feature flag and base class for Overview Actions.
Adds ENABLE_OVERVIEW_ACTIONS feature flag and base factory. Requires an
implementation in overlay to show any actions.

Test: run locally with flag on and off.
Bug: 145628186

Change-Id: I1c36330464cc01e1e987ebfea1a9f451067598a5
2019-12-09 16:43:54 -08:00
TreeHugger Robot 0aa4bfebcf Merge "fix app crash on settings for launcher" into ub-launcher3-master 2019-12-09 23:26:28 +00:00
TreeHugger Robot 372694ee30 Merge "Consistently checking state change messages" into ub-launcher3-master 2019-12-09 23:10:46 +00:00
vadimt 8398013533 Moving processing data received from Wellbeing to a supress-all block
Bug: 144927220
Change-Id: I25f02d5844b32abb73c2b4b6fcdaa68f438e6aa4
(cherry picked from commit c55f89c630)
2019-12-09 23:08:27 +00:00
Tracy Zhou c19d7783aa Merge "Render user's actual workspace in ThemePicker preview (Part 1)" into ub-launcher3-master 2019-12-09 23:04:17 +00:00
Pinyao Ting 80634893ab fix app crash on settings for launcher
Bug: 145941320
Test: Settings -> Apps & notifications -> Default apps -> Gear button
next to Home app -> Click on every item and make sure it doesn't crash

Change-Id: Ibad2ebf0c53a58a04327d0323f83de27efd8fda8
2019-12-09 14:39:09 -08:00
Automerger Merge Worker 7891a71d5f Persist predicted items when dragged to workspace am: 02c794578c
Change-Id: I63c93b16f549fb974c7c0e6c86f0939aff8c7b70
2019-12-09 22:31:38 +00:00
Tracy Zhou 44fa2940cd Render user's actual workspace in ThemePicker preview (Part 1)
This change takes care of icon rendering. Further work still needs to be done for folders and widgets.

Test: Go to grid options, choose a different grid option, and see user's workspace rendered in the preview
Bug: 144052839
Change-Id: I696153dec1d1f08c5ac82d0c75be5740325c0fc4
2019-12-09 14:06:38 -08:00
TreeHugger Robot 432e0513d1 Merge "perform accessbility focus when the recyclerview doesn't gain focus after fragment replacement in SettingsActivity" into ub-launcher3-master 2019-12-09 22:05:43 +00:00
vadimt bc5d7e68e8 Diagnosing the reason for opening context menu
Adding it permanently. System tests using TAPL sometimes run into
mysterious hard-to-diagnose problems (like, a menu opens for no apparent
reason), so we'll need to keep diags like this forever.

Change-Id: I25fcab94931fa4f6e1bda34d5705de5dd411188a
2019-12-09 13:53:05 -08:00
vadimt bdaa179b92 Consistently checking state change messages
Checking for events whenever Launcher sends them.
Checking for correct events (final events, not for events from
intermediate state changes).

This should simplify diagnosing of bugs involving TAPL.
This is also supposed to fix Fallback overview tests.

Bug: 143488140
Change-Id: If053ed808ec71bf2b652ab680be5bdfe9ff8cbb9
2019-12-09 12:33:39 -08:00
TreeHugger Robot ebc50f3095 Merge "Moving some tests to robolectric" into ub-launcher3-master 2019-12-09 20:04:35 +00:00
TreeHugger Robot ecd7cc0e4c Merge "migrate from deprecated fragment api to latest" into ub-launcher3-master 2019-12-09 19:45:29 +00:00