Commit Graph

34630 Commits

Author SHA1 Message Date
Vinit Nayak dcec265f0d Clear swipe region cache on nav mode switch
Fixes: 154955192, 150958400
Test: Switched from gesture nav to 3 button,
was no longer able to swipe up

Change-Id: Icc7b27eb7bd1eb5ddf25d7e7c3464a77a3a88f24
2020-04-24 15:05:17 -07:00
Tony Wickham 3d05148750 Stop computing scroll if handler is invalidated
Bug: 153589287
Change-Id: I0282ec82fe4ae1f74a0f4342471ffd53f43095d7
(cherry picked from commit 9df3f0cebf)
2020-04-24 21:42:22 +00:00
TreeHugger Robot 3176077614 Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev am: a29a69943a
Change-Id: I324727deb4c83401e9c1ed13d2c8b0add146ac7e
2020-04-24 20:15:50 +00:00
Tony Wickham bf2f066fff Use OverviewWithoutFocusInputConsumer for sharesheets over home
Test:
- start sharesheet from overview action, swipe up
- start sharesheet after taking screenshot on home, swipe up
- start sharesheet from an app, e.g. Chrome
The first two use OWFIC, last one uses OtherActivityInputConsumer
as normal.

Bug: 153673244
Change-Id: I7d7887e1f6818346ada75776ec63b43aaf3708f1
2020-04-24 15:01:32 -05:00
TreeHugger Robot a29a69943a Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev
* changes:
  Adds ripple effect for successful Back gestures in tutorial.
  Adds feedback to Home and Back tutorials.
2020-04-24 19:58:48 +00:00
Tracy Zhou 8908dc2c63 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev am: 879d3ade68
Change-Id: I0a8688f66bbe3312b22305639b62ac0c5e7e1b0c
2020-04-24 19:40:14 +00:00
Tracy Zhou 879d3ade68 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev
* changes:
  fix GridBackupTableTest in comply with grid size migration
  Turn on V2 migration algorithm feature flag
2020-04-24 19:26:44 +00:00
TreeHugger Robot b1b9f73f49 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev am: acafb3a287
Change-Id: Ifa261e649504c28b8b206b5b2cf7ab7b446bdb95
2020-04-24 19:11:18 +00:00
TreeHugger Robot acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham e992fab187 Adds ripple effect for successful Back gestures in tutorial.
Emanates from where the gesture was started.

Demo: https://drive.google.com/open?id=1oaXOSUiZP6Hi7J6W4H2NIFVVu0tQfKWm
Bug: 148542211
Change-Id: I38874b8b731864cbfdf963a5e44a59c8c3d30c51
2020-04-24 18:16:43 +00:00
Andy Wickham 64a91132c5 Adds feedback to Home and Back tutorials.
Back feedback:
 - Too far from edge of screen
 - Cancelled (reversed gesture, swiped upwards, etc.)
 - Inside nav bar region
 - Demo: https://drive.google.com/open?id=1pc_hr7i-iZmgF37CN8oijPjhOvvsJoEG

Home feedback:
 - Too far from edge of screen
 - Paused too long (Overview detected)
 - Swiped sideways instead of up
 - Demo: https://drive.google.com/open?id=1NGYAlqV2wJtM2DOJ1pZM-r8N1SYVtMos

Bug: 148542211
Test: Manual
Change-Id: I627ed7c6e9b005d35794e4ae568529b5613cbf70
2020-04-24 18:15:23 +00:00
Andy Wickham 6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak 00e9da0a48 Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev am: 49d3fe598c
Change-Id: I9ead961382546616e3d1907ce587022884447c35
2020-04-24 17:58:27 +00:00
Vinit Nayak 49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
TreeHugger Robot 8f70fd555a Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev am: 7e0a1ac606
Change-Id: I54c35b48f16ab77ddb39f33bf74d335e007f16c4
2020-04-24 15:23:06 +00:00
TreeHugger Robot 7e0a1ac606 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-04-24 15:06:28 +00:00
android-build-team Robot e085ff1853 Snap for 6425864 from 953ebebdb3 to mainline-release
Change-Id: I8a7c9edfb955bbfe6173a0c4738ba06a4e4aec4d
2020-04-24 07:10:07 +00:00
Ming-Shin Lu 67ea424e61 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91 am: 718720e18d am: 953ebebdb3 am: 77e51059c0
Change-Id: Ic1007572532dfdd15ea8e0774679b7244615456d
2020-04-24 03:04:30 +00:00
Adam Cohen 683714434b Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev am: 59d305fefe
Change-Id: I4739ae2a8bbd72ff1afd7be0ffc25056a89189d3
2020-04-24 03:03:25 +00:00
Ming-Shin Lu 77e51059c0 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91 am: 718720e18d am: 953ebebdb3
Change-Id: I8450fe5c993a1955a2389eaddb8a55462303fc55
2020-04-24 02:52:10 +00:00
Adam Cohen 59d305fefe Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev 2020-04-24 02:50:23 +00:00
Ming-Shin Lu e6e82fd966 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: 4cbe3f52a1 am: 7c44364a83 am: edb0745950
Change-Id: I9fc7ccb1db54bedd4e59b4dda73363b8485b1adf
2020-04-24 02:31:40 +00:00
Ming-Shin Lu 965f68cf28 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91 am: d93d87fcab am: 769383ff5a
Change-Id: I8d7366d333929bbd8b018034c4d0eab9c9ada864
2020-04-24 02:30:52 +00:00
Ming-Shin Lu 953ebebdb3 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91 am: 718720e18d
Change-Id: If17e2934ac50c71d880c6d241c82683af8ec0c41
2020-04-24 02:24:30 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
Ming-Shin Lu edb0745950 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: 4cbe3f52a1 am: 7c44364a83
Change-Id: Ia6ecd60e05273d947e023b1ed66d3a28ade43ac3
2020-04-24 02:17:52 +00:00
Ming-Shin Lu 769383ff5a Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91 am: d93d87fcab
Change-Id: I088f7bb296a6665863a18fe6d68dfd4d8df40b4b
2020-04-24 02:15:58 +00:00
Ming-Shin Lu 718720e18d Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91
Change-Id: Ia0fbc828c54afd598016e1278bcccb4516ac0f6b
2020-04-24 02:01:13 +00:00
Ming-Shin Lu 7c44364a83 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: 4cbe3f52a1
Change-Id: Ic9917650d10b1e5a46d24a9573029cf6eac1f170
2020-04-24 01:51:25 +00:00
Ming-Shin Lu d93d87fcab Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3 am: b5987a3e91
Change-Id: Ibd6b54e215a9d9123b5f0be4e9d814ae28d4991d
2020-04-24 01:50:42 +00:00
Ming-Shin Lu 4cbe3f52a1 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3
Change-Id: I0ca7e8992af3caf1f5137c3a9279dc4eba131be3
2020-04-24 01:35:08 +00:00
Ming-Shin Lu b5987a3e91 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev am: 992ef571d3
Change-Id: If84642a31b6677fc2edf939f242d0340aeb80202
2020-04-24 01:35:01 +00:00
Ming-Shin Lu 992ef571d3 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into rvc-dev 2020-04-24 01:33:26 +00:00
Adam Cohen 1d13c0bf13 Cleanup reorder animations to not require layout on every frame
=> Extending on previous CL to separate multiple translation properties
   and avoiding expensive layout pass

Test: manual

Change-Id: I058da7367fb320b9f432bef9482be2966d3a7d42
2020-04-24 01:28:39 +00:00
android-build-team Robot 89a0e0977d Snap for 6424828 from df280add9e to rvc-release
Change-Id: I4280a5624072ae37945b51e716c276a365ee32f7
2020-04-24 01:15:29 +00:00
Tracy Zhou 27b7bfa44e Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev am: f4e5a1a119
Change-Id: Idddef9cab7fe08066b670ac2edda2fa4b4c04169
2020-04-23 18:10:36 +00:00
Tracy Zhou f4e5a1a119 Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev 2020-04-23 17:47:29 +00:00
vadimt 1c2005151e Checking that there are no more than 2 live activities at any moment am: 0703464556
Change-Id: Ia2d09a1359a5af2b9688c130ffc1874f807d0bc9
2020-04-23 17:35:42 +00:00
vadimt 0703464556 Checking that there are no more than 2 live activities at any moment
This is tightening the makeshift strictmode criteria.

Starting with this moment, we will know that there is
no memory growth during tests execution, which is a big deal.

Big: 139137636

Change-Id: I5edc84524463bd1736d727496ad0fc031bb9624c
2020-04-23 16:35:09 +00:00
Pinyao Ting 26c4e23e9a fix GridBackupTableTest in comply with grid size migration
Bug: 154166808
Test: GridBackupTableTest
Change-Id: I7af35ceed7edb77ac0d9c443d7eccbcef19ae476
2020-04-23 09:18:46 -07:00
Tracy Zhou 219426f870 Turn on V2 migration algorithm feature flag
This flag is behind grid options master flag, so it won't go to all dogfood users yet.
I will turn on grid options flag after enough bug bash, hopefully at the end of this week.

Bug: 154154093
Test: N/A
Change-Id: I608af1cd3c5613f7cc33a940a145309ac90a6c00
2020-04-23 09:18:46 -07:00
android-build-team Robot 27857f808a Snap for 6421724 from cf7b09feac to mainline-release
Change-Id: Ib3b1d399c19a5be0ea14192669ba5d62da3023c9
2020-04-23 07:14:17 +00:00
TreeHugger Robot 413e570969 Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev am: d73d39b45a
Change-Id: I4d12fe2a1af697ba44e0b3c5b8516e2a11d16911
2020-04-23 03:37:22 +00:00
TreeHugger Robot d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot 7065c49cfe Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev am: 8d5a000071
Change-Id: Ie0dd431ea42c4dc1134d11dd12de624224884e10
2020-04-23 01:41:38 +00:00
TreeHugger Robot 8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
Tracy Zhou ed5f3082b0 Special handling when a db for one grid option is not setup yet
- Init KEY_MIGRATION_SRC_WORKSPACE_SIZE and KEY_MIGRATION_SRC_HOTSEAT_COUNT
- Load default workspace only when default db is created, not when peeking into dbs of other grid options during grid preview / migration

Fixes: 154184711
Test: run grid preview and migration right after a cleared cache Pixel Launcher
Change-Id: I86c7072b8c4a9da76e289c55ab440071f192fc38
2020-04-22 18:13:42 -07:00
TreeHugger Robot 345dd7a13c Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev am: 1bb37acb5d
Change-Id: I64d45689b9b7be921d07ef9cfef5363610bfb5af
2020-04-23 00:22:18 +00:00
Govinda Wasserman c131585c23 Merging from ub-launcher3-rvc-dev @ build 6418896 am: df280add9e am: 3aa30d3d33 am: 52846c4ca7 am: cf7b09feac am: bf85bd7c09
Change-Id: I5d8923149ce0dc0f89768f07891b4a4213a63aa5
2020-04-23 00:17:53 +00:00