Commit Graph

34630 Commits

Author SHA1 Message Date
thiruram d1137b8c89 Fixes missing folder label after launcher restarts. am: e148652075
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12003751

Change-Id: Id53a5f12ba7e83bc6d9551e9f4cbf67d17b06569
2020-06-26 18:29:13 +00:00
thiruram aa823d103e Fixes missing folder label after launcher restarts. am: e148652075
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12003751

Change-Id: I4ffa9bc2cb5a838db0d69accb4aaf3797f389c7c
2020-06-26 18:29:02 +00:00
TreeHugger Robot 4331cc9d45 Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-master 2020-06-26 18:18:00 +00:00
Jon Miranda 54003963d8 Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
2020-06-26 18:16:13 +00:00
Adam Cohen ef1d088a4c Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into ub-launcher3-rvc-dev am: f6edf98902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12005660

Change-Id: I1646d2a238e58d897351610963824229a8c853f9
2020-06-26 17:27:21 +00:00
Adam Cohen 9e3aebd8dd During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

Bug: 155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
(cherry picked from commit 6e7c37a205)
2020-06-26 17:15:03 +00:00
Adam Cohen f6edf98902 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into ub-launcher3-rvc-dev 2020-06-26 17:10:38 +00:00
thiruram e148652075 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
(cherry picked from commit 6ab4da8aa0)
2020-06-26 16:30:31 +00:00
Tracy Zhou cfe65240f3 Do preview grid migration in a worker thread am: 6b79a3767d am: b95fbd99f0 am: 22f9efe094 am: e579cfddc5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I3fd802ba4b8ff1c7a4abaa179c42f6538d8968f2
2020-06-26 08:35:51 +00:00
Automerger Merge Worker 5cf8a315ec Merge "Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 5dc6bbc830" into rvc-qpr-dev-plus-aosp am: 5e37afd503
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I8663db7a03cd908cf4d9ecda9d22b934b1389e44
2020-06-26 08:35:42 +00:00
Tracy Zhou 081b800e38 Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 4959b0f79f am: 02f3b9bf57
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I6092f5b7cf2b3145460374253e285a5350659767
2020-06-26 08:35:28 +00:00
Tracy Zhou e579cfddc5 Do preview grid migration in a worker thread am: 6b79a3767d am: b95fbd99f0 am: 22f9efe094
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: Id45ccb1cc5e170c992cde35bb447dd502d1a6d0d
2020-06-26 08:19:54 +00:00
Automerger Merge Worker 5e37afd503 Merge "Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 5dc6bbc830" into rvc-qpr-dev-plus-aosp 2020-06-26 08:19:51 +00:00
Tracy Zhou ddc93edc5a Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 5dc6bbc830
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: Ia5ac7c341f24e69314ec07f282e14f021c7a42c5
2020-06-26 08:19:46 +00:00
Tracy Zhou 02f3b9bf57 Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 4959b0f79f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: Ied2622921b7b036729394f4a4de99059ce109904
2020-06-26 08:19:43 +00:00
Tracy Zhou 22f9efe094 Do preview grid migration in a worker thread am: 6b79a3767d am: b95fbd99f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: Iefe8628aff39dd426b507fc22d119d0e573b3cc4
2020-06-26 08:07:36 +00:00
Tracy Zhou 5dc6bbc830 Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I23dc82239ccd1e39e66de291a0294502c125445c
2020-06-26 08:06:59 +00:00
Tracy Zhou 4959b0f79f Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: Ie6e3418bf5b75f230ae37c7ef4093b65669d35ca
2020-06-26 08:06:58 +00:00
TreeHugger Robot fe6d3c6221 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev am: f59922d0d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12000756

Change-Id: I7ecfc4c45bbc60fc29181ac81606e26d06196392
2020-06-26 08:06:49 +00:00
Tracy Zhou 217b39c7d7 Do preview grid migration in a worker thread am: 6b79a3767d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I8736505220ced22211f821c54a3c4360166df7c5
2020-06-26 07:48:04 +00:00
Tracy Zhou b95fbd99f0 Do preview grid migration in a worker thread am: 6b79a3767d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I8d6308cad0db1671d91fc141cb3542dc40d3deab
2020-06-26 07:47:45 +00:00
Tracy Zhou f1c369589a Do preview grid migration in a worker thread am: 6b79a3767d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I4841e06d7bdbaf71f4d61f7c1da14b40b87fc6cb
2020-06-26 07:47:40 +00:00
TreeHugger Robot f59922d0d7 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev 2020-06-26 07:42:38 +00:00
android-build-team Robot 830b56ff17 Snap for 6630650 from 670c17c48f to mainline-release
Change-Id: I7670a644dde93100e43f92a3c677f659dcebeb44
2020-06-26 03:05:56 +00:00
Adam Cohen 6e7c37a205 During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

b/155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
2020-06-26 02:34:36 +00:00
android-build-team Robot e2dc8541f1 Snap for 6630229 from ccf588d36b to rvc-release
Change-Id: I0113fc02cd8668fbbeadb8856e5957e17cb8e7e1
2020-06-26 01:11:10 +00:00
thiruram 07a31d04ac Fixes missing folder label after launcher restarts. am: 6ab4da8aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11999547

Change-Id: I839d910fcef8e6c1d432b68e68b2ba0f3d7550c2
2020-06-26 00:26:10 +00:00
thiruram 6ab4da8aa0 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
2020-06-25 23:48:17 +00:00
TreeHugger Robot afd8873505 Merge "Get rid of a weird shadow background when rendering smartspace in preview" into ub-launcher3-master 2020-06-25 22:33:37 +00:00
TreeHugger Robot ac802c2bdc Merge "Improving diagnostics when Launcher dies during a gesture" into ub-launcher3-master 2020-06-25 22:32:28 +00:00
TreeHugger Robot e997bd682e Merge "Improving diagnostics when can't find a widget" into ub-launcher3-master 2020-06-25 22:24:05 +00:00
Tracy Zhou 73f1937b6c Do preview grid migration in a worker thread am: f957ff9123
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002727

Change-Id: I56067831e0e5c3b43eb60d4f62459e251228e88c
2020-06-25 22:22:03 +00:00
Tony Wickham 3d6bfc2905 Merge "Fix tracking window being slightly off when swiping from an app" into ub-launcher3-master 2020-06-25 22:18:32 +00:00
Tracy Zhou 6b79a3767d Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:05:04 +00:00
Tracy Zhou f957ff9123 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:04:25 +00:00
Tracy Zhou 6d24c69e48 Merge "Do preview grid migration in a worker thread" into ub-launcher3-master 2020-06-25 21:04:04 +00:00
vadimt 56fe9150fa Improving diagnostics when Launcher dies during a gesture
Instead of crashing upon getting uninitialized event sequence, we show a
meaningful message.

Bug: 159921830
Change-Id: Ie42039b39a453c60bd5df3e54058d582137bba06
2020-06-25 13:32:20 -07:00
Tracy Zhou 633a4bdf57 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
2020-06-25 13:12:52 -07:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
Samuel Fufa 514df92bcf Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 13:08:55 -07:00
Tony Wickham f0a1b2ccd8 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
2020-06-25 11:51:28 -07:00
TreeHugger Robot 66a0594903 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e am: 2d062629af am: 048730d37b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I66e94485af4645cc855dfb716a6a822e2c6103ba
2020-06-25 18:09:34 +00:00
TreeHugger Robot 0ba4e72af9 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: a04df0eeff am: 1f076e9dff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I4a25b04d6c8eb783b9455a8bdcaef039b9c22fe1
2020-06-25 18:08:42 +00:00
TreeHugger Robot d9dd5cec0f Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: 40483a5399 am: 4073796ff7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic1582747cd4d16c5df22ce4e6d0e5716d17aebfd
2020-06-25 18:07:35 +00:00
TreeHugger Robot 048730d37b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e am: 2d062629af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic0a39f519fc6d90044a21b658eeedfd5f7214195
2020-06-25 18:01:24 +00:00
TreeHugger Robot 1f076e9dff Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: a04df0eeff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I3e01b753efbbcb097ced25620e0a79ac9d6de10c
2020-06-25 18:00:39 +00:00
TreeHugger Robot 4073796ff7 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: 40483a5399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I5027efb83c40b59c9a8e66ed8cc693cc8b79918b
2020-06-25 17:55:10 +00:00
TreeHugger Robot 2d062629af Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I68707d6786ccb793f7ed89e649bea55a5a3f1005
2020-06-25 17:13:03 +00:00
TreeHugger Robot a04df0eeff Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I0f76e1d3261b8bace3f9ccdf4862b62f6918f3d7
2020-06-25 17:12:16 +00:00
TreeHugger Robot 40483a5399 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I233f4b8d386421dde48dd61094ece14121bb6a07
2020-06-25 17:09:22 +00:00