Commit Graph

34630 Commits

Author SHA1 Message Date
Tracy Zhou 3f6c895186 Merge "Improve grid preview performance" into rvc-d1-dev am: 8951db2d23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12160681

Change-Id: I07b09882d4045048bdd03fb4bf6c4fa2cba58456
2020-07-15 19:56:23 +00:00
Sunny Goyal c3771e64d9 Fixing swiping up on home interrupting animation am: d481c5c58c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152002

Change-Id: I62a4e0cb58d2159730295129724b05cbfdc11af4
2020-07-15 19:56:21 +00:00
Tracy Zhou 39d900553a Merge "Improve grid preview performance" into rvc-d1-dev am: 8951db2d23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12160681

Change-Id: I54d534beee7cf9edea250198978656315a7a4444
2020-07-15 19:56:21 +00:00
Sunny Goyal 8d7fdfdd47 Fixing swiping up on home interrupting animation am: d481c5c58c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152002

Change-Id: Ia90054074ebd6c2bdf06f0971345678a26985e7b
2020-07-15 19:56:19 +00:00
Tracy Zhou 2c0cdfb100 Improve grid preview performance am: b023873bc3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153148

Change-Id: Ia849496c109fc3286e2a8ec1d2fcb8f4e0c0714c
2020-07-15 19:56:14 +00:00
Sreyas 68330a93fa Disabling overview actions when thumbnail is not loaded.
Bug: 160331177
Change-Id: I05eaec7d6f2e3f2ba71d8148a4e97dcf5a1522c6
2020-07-15 19:46:09 +00:00
Tracy Zhou 8951db2d23 Merge "Improve grid preview performance" into rvc-d1-dev 2020-07-15 19:38:01 +00:00
Sunny Goyal 5412f0f8f7 [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours am: 5416c5105e -s ours am: 2a71ebaaf2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: I2285512fb3c4d247155f02201cb9b04cdf9b2db5
2020-07-15 19:23:51 +00:00
Sunny Goyal 9168aee9c5 [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours am: aab240dded -s ours am: 23bccb5584 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: I51a9fb3a552cb92f3f92677589d75770050a8548
2020-07-15 19:23:41 +00:00
Sunny Goyal 2a71ebaaf2 [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours am: 5416c5105e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: I480726350a3a70e3027f5262d060ead6159eb9b4
2020-07-15 19:01:04 +00:00
Sunny Goyal 23bccb5584 [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours am: aab240dded -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: Ic14fe79bada09465c8826dfa1223a01d94b25bf1
2020-07-15 19:00:49 +00:00
Sunny Goyal 5416c5105e [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: I5fcedee27bccd48bae211e4d492464912cff12a1
2020-07-15 18:43:00 +00:00
Sunny Goyal aab240dded [automerger skipped] Import translations. DO NOT MERGE am: 6d6dca6d39 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12153142

Change-Id: Iea3f7bf7a88a65e7011d7710c2f003be4c5656b4
2020-07-15 18:42:45 +00:00
Tracy Zhou 92628f5305 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-15 17:09:57 +00:00
Sunny Goyal d481c5c58c Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
Merged-In: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-15 07:11:30 +00:00
Tracy Zhou b023873bc3 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-14 23:30:03 +00:00
vadimt 40c9cfa3c8 Productizing useful diags
The bug doesn't repro, but it makes sense to keep the diags

Bug: 156287114
Change-Id: I4a9f43e02eec1b1386067a90e4c17ad109adcfa5
2020-07-14 15:53:32 -07:00
Jon Miranda ee0ebe6875 Calculate all apps cell height based on actual sizes.
This ensures that the cell contents always fit.

Bug: 160716074
Change-Id: I3d85adec3e7e3652fe4a258bd659382a3e696211
(cherry picked from commit 3535944395)
2020-07-14 22:13:41 +00:00
Sunny Goyal 6d6dca6d39 Import translations. DO NOT MERGE
Force snapping translations from unbundled branch
Bug: 159176821

Test: N/A
Change-Id: I2406edf7eef6aa683f99b2b5f897d16b8968a28d
2020-07-14 22:04:42 +00:00
Sunny Goyal cf6bae49a3 Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-14 22:00:04 +00:00
Sunny Goyal 75bf867d96 Fixing swiping up on home interrupting animation am: 369501d8aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152001

Change-Id: I7dc92aae75718c5460a2a2981880b536339f39d9
2020-07-14 19:57:54 +00:00
Sunny Goyal 369501d8aa Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-14 19:07:51 +00:00
TreeHugger Robot 30f156ad82 Merge "Removing a method that simply returns false" into ub-launcher3-master 2020-07-14 17:41:20 +00:00
TreeHugger Robot 171b2ae917 Merge "Focuses on folder container for Accessibility when no contents to focus on." into ub-launcher3-rvc-qpr-dev am: 4c7ced91c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12146163

Change-Id: I7f2e6121a735b2c356958a74cdd9d2daa625f174
2020-07-14 16:56:14 +00:00
TreeHugger Robot 4c7ced91c0 Merge "Focuses on folder container for Accessibility when no contents to focus on." into ub-launcher3-rvc-qpr-dev 2020-07-14 16:41:25 +00:00
Sunny Goyal 9fbc80da6a Merge "Fixing swiping up on home interrupting animation" into ub-launcher3-rvc-qpr-dev am: ec78aef4fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12144100

Change-Id: If9f4248235d42be8d829d0837227202a0e30edc5
2020-07-14 16:19:12 +00:00
Sunny Goyal ec78aef4fc Merge "Fixing swiping up on home interrupting animation" into ub-launcher3-rvc-qpr-dev 2020-07-14 16:01:43 +00:00
Tracy Zhou 0ca024d259 Merge "Place launcher above the target app in live tile mode" into ub-launcher3-master 2020-07-14 05:35:28 +00:00
Andy Wickham f865551ff0 Focuses on folder container for Accessibility when no contents to focus on.
This happens when you drag an app into a folder when the current page is
already full. The new page has no apps in it until you drop the one you
want to add.

Fixes: 161040039
Change-Id: Iaa857e7a114e859fa7e6a0653028856a3a8a94a6
2020-07-13 20:56:38 -07:00
vadimt 4bc691b988 Removing workarounds for a fixed bug
Bug: 148422894
Change-Id: Ic6faa173ac5f28c8656daf68ac8304563264afdd
2020-07-13 20:02:13 -07:00
android-build-team Robot 3180034457 Snap for 6676900 from f130c29882 to rvc-release
Change-Id: Ia9a54139b5b9b819e10e96cb00ddd69a4cf1e322
2020-07-14 01:12:45 +00:00
Sunny Goyal 93188d61da Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
2020-07-13 17:44:56 -07:00
Sunny Goyal 6c76a08a5e Preventing disambiguation screen when swiping up am: f130c29882 am: 0ed6042555 am: f030dc602e am: a4a05574e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I2930828ebc247be326d6ca20c07a5f9d98ec02e5
2020-07-13 22:23:12 +00:00
Sunny Goyal 4218830027 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1 am: a0622a0786 am: 9e3ccab4e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: Idbb8f7e8dd9535d38ad40ceccfab4bc29ca674a0
2020-07-13 22:23:06 +00:00
TreeHugger Robot 2f457a6bbb Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-rvc-qpr-dev am: add69c70c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12142607

Change-Id: I6d2e67478dc5a98395aa8f25fe98b206c4fcba75
2020-07-13 22:22:19 +00:00
TreeHugger Robot 149758da21 Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-rvc-qpr-dev am: 054280dba4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12142606

Change-Id: I87b357e1ce4a30f255598d481ce99fee63ac9d9d
2020-07-13 22:22:13 +00:00
Pinyao Ting 24d44a7777 Fixes the issue Launcher state propagation is slower than onDeferredResume. am: 9d51e49cec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12142602

Change-Id: Ic042a5db68e492bedf58d6c328d151411a199ac2
2020-07-13 22:22:07 +00:00
Sunny Goyal e96edf4ee1 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1 am: 5a9dce4136 am: c659064f22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I5f5ce0b1142c4fe850e13a74327dea22d8a544c2
2020-07-13 22:21:57 +00:00
TreeHugger Robot add69c70c4 Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-rvc-qpr-dev 2020-07-13 22:20:33 +00:00
Sunny Goyal a4a05574e8 Preventing disambiguation screen when swiping up am: f130c29882 am: 0ed6042555 am: f030dc602e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I3fadec57c17ef42c30b2633660c5f0884980b40d
2020-07-13 22:10:27 +00:00
Sunny Goyal 9e3ccab4e9 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1 am: a0622a0786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I5f800f3706e6f93b7f50cb9e658a927275aa460b
2020-07-13 22:10:01 +00:00
Sunny Goyal c659064f22 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1 am: 5a9dce4136
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I978f967584dc8ccfec546438378f7beb6f0e0c80
2020-07-13 22:09:44 +00:00
TreeHugger Robot 054280dba4 Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-rvc-qpr-dev 2020-07-13 22:06:13 +00:00
Sunny Goyal f030dc602e Preventing disambiguation screen when swiping up am: f130c29882 am: 0ed6042555
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: Ic695bb447d76ecbb2cf7b664535c7a9d42f14e62
2020-07-13 21:57:19 +00:00
Sunny Goyal 5a9dce4136 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: Ib290b6b968e8612f03174c3ce88a7d0379c7d292
2020-07-13 21:57:00 +00:00
Sunny Goyal a0622a0786 Preventing disambiguation screen when swiping up am: f130c29882 am: 88e9c5dcb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I0ae7f7da7c356404598fb7c2811edc421acf5aa4
2020-07-13 21:56:46 +00:00
TreeHugger Robot d318bc6dda Merge "Calculate all apps cell height based on actual sizes." into ub-launcher3-rvc-qpr-dev am: 36a1600d66
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12121642

Change-Id: I6e78bb0491d37c39ece1b356d028a8dec6db434e
2020-07-13 21:51:50 +00:00
Jon Miranda aee792403d Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
(cherry picked from commit 54003963d8)
2020-07-13 21:48:19 +00:00
Sunny Goyal 55a9b544c9 Using original taskInfo to create the taskKey instead of fake data
Change-Id: Ie4e35b35484e0f6cb939febe6357b37381d81682
(cherry picked from commit fabfb3ae90)
2020-07-13 21:47:16 +00:00
Pinyao Ting 9d51e49cec Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
(cherry picked from commit 3bf889a02f)
2020-07-13 21:46:05 +00:00