Commit Graph

422 Commits

Author SHA1 Message Date
Stefan Andonian 9d7bffe37b Fix NPE in LauncherPreviewRenderer.
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.

Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.

Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
2023-05-15 22:41:04 +00:00
Brian Isganitis aa9bef2f31 Cleanup WIDGETS_IN_LAUNCHER_PREVIEW.
Test: Manual
Fix: 270393268
Change-Id: I2d90f92c6bc85d59d56f5e6c2d6005554f932895
2023-05-15 13:29:05 -04:00
Sunny Goyal 7bc6cdee56 Revert "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""""
This reverts commit 09905cfa90.

Reason for revert: Fixed the crashing issue

Change-Id: Ibcfc28a89356d262e67e8842d6bae37e230a70f5
2023-05-13 01:59:19 -07:00
Sunny Goyal 09905cfa90 Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""
This reverts commit bca4e694f0.

Reason for revert: post submit broken

Change-Id: I8afc63b5aa67ee14127f79e2245ef543bff8cf31
2023-05-11 22:22:16 +00:00
Sunny Goyal bca4e694f0 Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""
This reverts commit 3772b246c2.

Reason for revert: Fixed the test failure

Change-Id: Ibdc9e184fcb32c7caa4ab25d8753a46fa322b703
2023-05-10 17:49:16 +00:00
Sunny Goyal db19958b82 Removing unused wallpaper-scrim feature
Bug: 270393604
Test: Presubmit
Flag: N/A
Change-Id: I10df3a96eb26b9871eb1b330ea5b2c0797d0668d
2023-05-04 14:02:41 -07:00
Charlie Anderson 178802d35c Merge "Revert "Changing GridMigrationTask to use ModelDbController directly"" into udc-dev 2023-05-04 17:58:01 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Sunny Goyal 6c304b157d Always insetting the widget by a minimum of 6dp
Removing default widget padding logic. Also widget padding it applied
at ShortcutAndWidgetContainer so that the widgetView always has the
correct size.

Bug: 274826296
Bug: 257589413
Test: Verified using screenshots
Flags: N/A
Change-Id: Id4b5e94db6ec7b2aa3dca87b1e9ccc831b608cac
2023-05-03 12:18:33 -07:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
fbaron 28ad76fb64 Fix progress and plate width for download app
It looks like the plate width wasn't quite right as it's supposed to be half the width of the progress bar width. This should fix that.

Bug: 267272201
Test: Verify that the download app ux matches spec in bug
Change-Id: Ifbcb1e2d31cd8d9c20a69e8c64104198563f7cf9
2023-04-15 04:34:34 +00:00
Federico Baron 4ba9c11568 Improve color, contrast, and dimensions to match new spec for download icon
Here we update the values to the correct HCT values according to the specs, as well as the size of the icon

Bug: 267272201
Test: Turn on flag ENABLE_DOWNLOAD_APP_UX_V3 and download an app to see the changes.
Change-Id: I2cc2417f7500c4c08c41056bfeef3c33f4eab174
2023-04-13 23:53:20 +00:00
Stefan Andonian eac832aedd Merge "Load Delegate Items in correct order when loading Launcher Data." into udc-dev 2023-04-10 18:26:25 +00:00
Stefan Andonian e4609a27bd Load Delegate Items in correct order when loading Launcher Data.
Bug: 251502424
Test: Loaded and bound the workspace properly.
Change-Id: Ia6d609ffa21c5036cb48e464d3e8d4fa561cb008
2023-04-10 15:46:12 +00:00
fbaron 6664d8c80b Update the pending app icon to match new specs
Bug: 276950579
Test: Download apps and verify that they match the updated specs
Change-Id: I03b9a5c87514e91c646e961ec57f63f1305d0327
2023-04-04 13:40:55 -07:00
George Lin f469c4c006 [Launcher] Hide preview bottom components when overlay tabs are shown
For deciding show/hide of the bottom components, we need to take care of 2 cases
1. When on color update, we need to set the QSB flag and re-render the
   surface
2. When show/hide the wallpaper control, we specifically send a message
   to show/hide the workspace bottom components

Test: https://drive.google.com/file/d/1z1EG6KsLKFxAlS8GBLV16GoGvwI72IHc/view?usp=sharing&resourcekey=0-OGzB0RmiK5qvV2rwMYvUHQ
Test: https://drive.google.com/file/d/1gK54Y5MuHTt2tAuFDxY7z8RIL22J5c9f/view?usp=sharing&resourcekey=0-jPPC1pl1VkCS_tib2-pVxA
Test: https://drive.google.com/file/d/1ntUSgD7KbHPDGNpomQ5zE0D2fsYVeuNA/view?usp=sharing&resourcekey=0-TCuuvL4p022ATzKYuF-Q1A
Test: https://drive.google.com/file/d/1yA1K52N-orajamnrxWD17Qg7bCclmq53/view?usp=sharing&resourcekey=0-6LHnZGM5JpFQISNJ6X7jEg
Bug: 266618769
Change-Id: I428e6f50dc71369aa8fcdee31629023709e6503f
2023-03-23 18:36:18 +00:00
TreeHugger Robot e83196187a Merge "Adding dither to workspace scrim" into tm-qpr-dev 2023-03-08 02:00:36 +00:00
Federico Baron 5f811c9dad Set range of overlay for pending download app animation to 0-75% from 0-50%
The pending download app animation had an overlay that ranged from 0% to 50% opacity. With this CL we shift the range to 0-75%.

Fix: 271470372
Test: download an app and see the animation for pending download
Change-Id: Ib0332eca2dad37efa916a9410e9466cc63574b5a
2023-03-02 22:08:00 +00:00
Sunny Goyal 9c00567da2 Adding dither to workspace scrim
Bug: 237818532
Test: Verified on device
Change-Id: I8e238f88e46d20166a42197d175fb7194628ef9e
2023-03-01 12:18:36 -08:00
Alejandro Nijamkin e8dd1a78ff [Launcher] App grid support for reset (1/4).
This CL chain provides a rewritten implementation of the UI for the app
grid selector which supports the new wallpaper picker "reset"
functionality. A previous attempt that kept the UI's old implementation
required the introduction of many hacks in classes that are shared
across multiple selector-like experiences.

Bug: 267804479
Test: unit and integration JUnit tests added for the data, domain, and
ui layers of the wallpaper picker code
Test: manually made sure that the selector works to switch between
different launcher app icon grid options; the preview of the launcher
updates correctly; when exiting back to the main wallpaper picker
screen, the reset button appears and the section item is updated to show
the currently-selected option; touching the reset button and confirming
the reset correctly reverts to the original option, updating the section
item as well

Change-Id: If1f8c96ef5004125b61ff6b4ae19848932693e0f
2023-02-16 11:34:07 -08:00
Sebastián Franco aa6f00af01 Merge "Fix issue where bottom scrim appears in homescreen when it shouldn't" into tm-qpr-dev 2023-02-15 01:57:03 +00:00
Sebastian Franco 40f94c84f8 Fix issue where bottom scrim appears in homescreen when it shouldn't
The bottom scrim should be shown for the Pixel Launcher, other third
party launchers show it when the 3 bottom navigation is activated.

The existing condition for 3 bottom navigation is no longer valid
because the insets at the bottom can be greather than 0 in other
situations other than 3 bottom navigation.

Test: the scrom should not show at all
Test: It appears in some situations where the taskbar is showing
and the scrim gets updates which not always happens so it's hard to
manually recreate, but there is a test that is flaky because of it
HomeScreenImageTabletTest#comparePixelTablet2023HomeScreen.
Fix: 267614579

Change-Id: Iacaf93011aa3f2f643186560fe34b4b26ce52314
2023-02-14 13:46:44 -08:00
Sunny Goyal 799e12077b Updating Drawables as per GraphicsUtils changes
Bug: 266661614
Test: Presubmit
Change-Id: Ia3d0e0bc7a2b019d234e3bca71e893d5c4c54ca8
2023-02-09 16:14:04 -08:00
Sunny Goyal 669b71f5b3 Introducing CellPosMapper which allows mapping between UI position
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
2023-01-30 12:17:09 -08:00
Stefan Andonian 74471716ca Merge "Fix crash in LauncherPreviewRenderer." into tm-qpr-dev 2023-01-24 17:35:27 +00:00
Stefan Andonian dbff8cda6c Fix crash in LauncherPreviewRenderer.
The LauncherPrefs INSTANCE variable needs to be registered with the
sandbox context used by the LauncherPreview. This will stop the crash
from occuring.

Bug: 266164372
Test: Verified that crash no longer occurs.
Change-Id: I12ef12d082b7afdb08b38321527d13c637e84f2f
2023-01-23 18:11:49 +00:00
Sunny Goyal a992ac9e8d Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
Merged-In: Ib410e5bf02773cefde5bf0a0a1f2f1c108718d24
2023-01-22 05:24:48 +00:00
Federico Baron 3278715fd4 Change preload icon size to always be 0.7 scale when downloading
In order to match upcoming designs. We will keep the icon size when downloading at 0.7 scale

Test: download an app with ENABLE_DOWNLOAD_APP_UX_V2 on
Bug: 254858049
Change-Id: I7f22eb3a5c6f1e75f19e033ff11a70aa4010ea10
2023-01-17 16:42:43 -08:00
TreeHugger Robot 196569bb50 Merge "Add finish icon scale animation for downloading apps" into tm-qpr-dev 2023-01-17 19:38:47 +00:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Federico Baron 4eb502ae10 Add finish icon scale animation for downloading apps
We add an animation when we finish downloading an app where the scale of the icon increases to from scale 0.867 to scale 1

Bug: 254858049
Test: Download an app and visualize finish download animation
Change-Id: I67912f86b0e35091a5fe1b39c3463a1ff203bd3b
2023-01-13 15:35:14 -08:00
Federico Baron 2161985b50 Add icon scale and alpha animation for entering downloading state from pending state
When we enter downloading state from being in pending state, we want to run an animation that animates the process of scaling down the icon as well as removing the overlay with an animation

Bug: 254858049
Test: Download a couple of apps with ENABLE_DOWNLOAD_APP_UX_V2 flag on
Change-Id: Ie4f378874aa3cf6597c02b4d7043a34eb51d838c
2023-01-03 14:29:01 -08:00
Federico Baron c03bb43fa5 Improve restore icon treatment
This is the first of a few CL's that change the way pending/downloading/installing apps look to follow the new mocks. In this CL we:

-Fix a regression where the track path doesn't show up when downloading an app
-Change the sizes of icons to reflect the new design mock
-Add skeleton motion animation

In upcoming CL's we will add visual polish and make sure it matches the motion spec exactly

Bug: 254858049
Test: Download an app and check pending, downloading, and installing visuals
Change-Id: Ief1038ea52d77874b4031db76d51a2787615a14d
2022-12-20 12:58:40 -08:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Sebastian Franco 2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
Stefan Andonian 146701ca3e Move SharedPreferences code to its own class.
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
Sunny Goyal eb018d8004 Removing some unused code:
> intrinsicIconScaleFactor is no longer read
> We no longer generatepreview outline for drag

Bug: 245997823
Test: Presubmit
Change-Id: I17ed25239d0affe89482da3406d529d323a426d9
2022-09-09 16:02:13 -07:00
Sunny Goyal 211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Sihua Ma e04aa207f2 Resize preview for correct clipping
Before, the remote view for the widget in launcher is reused to generate a new preview. However, measuring the view without changing the scale would cause strange clippings. This CL sets the scale of the widget views by manually computing the size ratio.

Change ag/19572297 is necessary before a complete clean-up.

Test: Create a weather widget on first screen -> go to Wallpaper & style -> App grid -> tap on a different grid and verify that the clipping is correct
Fix: 228328759
Change-Id: I8242d3bcfcf30ec924552c1320e22f8a3592f1c1
2022-08-09 23:57:41 +00:00
Sunny Goyal ea6d59fbd4 Removing unused ShadowDrawable
Bug: 241152608
Test: Presubmit
Change-Id: Iae3b3799959dfe3457791cfac88a2cb4ac5770a4
2022-08-02 14:58:25 -07:00
Sunny Goyal c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Sihua Ma dfd8bfc7e0 Added functions to pass launcher widget span info to preview
To calculate the widget scales correctly for the launcher preview in different grids, the span info of the widgets in the launcher is necessary. Querying the launcher widget info in the database and passing it to the preview render.

Test: Verified that no exceptions were happening when changing preview grid layouts
Bug: 228328759
Change-Id: I681d21b176c8fe5208431a79009d9ba8279cda6a
2022-07-14 20:17:19 +00:00
Brian Isganitis cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
Alex Chau 1145722685 Add DisplayController in PreviewContext's allowed objects
Fix: 231526132
Test: switch grids
Change-Id: Ie43c54c5fbbea51ee3b795be6baa9c2eaf5e15e4
2022-05-06 20:17:57 +01:00
Shikha Malhotra 2e255ed0ac Merge "Refactor code to be used in LauncherLily features" into tm-dev 2022-04-21 07:50:32 +00:00