PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
75,536 Commits 1 Branch 0 Tags
e21525da4016c17a628d8fb2faeb47e5b2cd2cb9
Commit Graph
3748 Commits
Author SHA1 Message Date
Sebastián FrancoandAndroid (Google) Code Review 48d7c10a82 Merge "Make sure we keep the screen record even if the test succeeds" into main 2024-04-23 19:49:44 +00:00
Treehugger RobotandAndroid (Google) Code Review 62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Sunny GoyalandAndroid (Google) Code Review edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Sebastian Franco ad15dd719e Make sure we keep the screen record even if the test succeeds 
Bug: 322823478
Test: testEdu
Test: testDevicePressMenu
Flag: NA
Change-Id: Ia11d3cbc0a10e15d716b1845e3590bca2bd1ff76
 2024-04-23 10:37:22 -07:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache. 
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
 2024-04-23 15:28:01 +01:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject 
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
 2024-04-22 17:04:33 -07:00
dakinola 8771dfe3dd Force calculator to launch in fullscreen for taskbar tests 
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
 2024-04-22 21:42:09 +00:00
Treehugger RobotandAndroid (Google) Code Review 9960f43a5c Merge "Adds new log constant to track overview select tooltip misalignment" into main 2024-04-22 20:24:28 +00:00
Federico BaronandAndroid (Google) Code Review 9350e71447 Merge "Revert "Add screenrecord for simple reorder widgets test"" into main 2024-04-22 18:31:49 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
Treehugger RobotandAndroid (Google) Code Review 1acba69818 Merge "Add TestActivity without any label for testing" into main 2024-04-22 17:23:03 +00:00
Federico BaronandAndroid (Google) Code Review 0e9fce7046 Revert "Add screenrecord for simple reorder widgets test" 
This reverts commit 8248279894.

Reason for revert: test stopped failing

Change-Id: I7993e38124530bdb0bdbb3447a449bd727b56d0a
 2024-04-22 16:45:41 +00:00
Jordan Silva cbc8bf0443 Adds new log constant to track overview select tooltip misalignment 
Bug: 332485341
Flag: N/A
Test: atest OverviewSelectTooltipImageTest
Change-Id: Ic1a9ad4e1e9e9b95774a4a1edac92ea79c75cec6
 2024-04-22 17:39:31 +01:00
Treehugger RobotandAndroid (Google) Code Review 774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Schneider Victor-tulias abf9f308a5 Remove debug tracing for b/332386996 
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
 2024-04-22 16:16:42 +00:00
Schneider Victor-tulias 3f8eea99e3 Remove debug tracing for b/321775748 
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
 2024-04-22 09:55:49 -04:00
Jordan Silva cbd111483e Add TestActivity without any label for testing 
This change adds an unlabeled activity to test the overview select action. The test evaluates the overview modal task state to verify that the UI displays correctly.
Using an activity without a label prevents flakiness from AiAi, which sometimes shows the activity title as selected and sometimes does not.

Bug: 332750488
Flag: NA
Test: OverviewTaskSelectImageTest
Change-Id: I6b63f1410bc466ac6711b0ca3d609d8f7a31d8c1
 2024-04-22 12:39:06 +01:00
Charlie AndersonandAndroid (Google) Code Review 299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
Charlie Anderson ce255ff6fd Fix NPE for where intent.package is null but targetpkg is not. 
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
 2024-04-18 17:48:27 -04:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button 
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
 2024-04-18 14:32:33 -07:00
Federico BaronandAndroid (Google) Code Review 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
Brandon DayauonandAndroid (Google) Code Review 31e713ee4c Merge changes If93e3975,Ifed45f06 into main 
* changes:
  Fix views being visible after closing private space.
  Set attach consumer after animation finished
 2024-04-16 15:14:26 +00:00
fbaron e4b0b71faa Make hotseat column span responsive 
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
 2024-04-16 06:19:16 +00:00
Winson ChungandAndroid (Google) Code Review 240956e7d8 Merge "Use shared method for updating the runtime status flags for an item info" into main 2024-04-16 02:59:54 +00:00
Stefan AndonianandAndroid (Google) Code Review 0d2cc9e87c Merge "Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-04-16 02:42:04 +00:00
Priyanka AdvaniandAndroid (Google) Code Review 7d92102140 Merge "Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-16 00:46:24 +00:00
Priyanka AdvaniandAndroid (Google) Code Review 4e97c94559 Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized" 
This reverts commit 503ce966ef.

Reason for revert: Culprit for test breakages in b/334995023. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Id8707cb2074b4f00ec332ebb14deb7d143ff1bbb
 2024-04-15 22:18:31 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 9d4fb2b5be Merge "Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-15 19:30:38 +00:00
Stefan Andonian 1a626d2d05 Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency." 
This reverts commit a80997d9eb.

Bug: 324670265
Test: Locally tested this, as well as ran it through post-submit via go/abdt with the fix.
Flag: NA
Reason for revert: Root-caused the issue with this, and will push the fix along with this revert.

Change-Id: I4bda53d94dfdb865883fef6ceec9dacd0b87f015
 2024-04-15 18:28:25 +00:00
Anushree GanjamandAndroid (Google) Code Review 6642ea0d48 Merge "Add new class for SetPropRule and move outside ShellCommandRule." into main 2024-04-15 17:41:15 +00:00
Brandon Dayauon a271511240 Set attach consumer after animation finished 
Its possible after the animation that attached view's alpha can still be stuck at 0 and never change.
This only happens when the view isn't in range to animate and after onBind() is already called.

Also added flag guarding to the animation as it seems to be forgotten since the big CL change moving
everything to privateProfileManager.

bug: 333506236
Test locally: https://screenshot.googleplex.com/8Kk6rLaczMPwr49 and https://screenshot.googleplex.com/9wXHeNuiCVFEMp6
manually: before https://drive.google.com/file/d/15hSqaUVjwE-lLp6IIv_mqwYbn_ITzR7s/view?usp=sharing
after: https://drive.google.com/file/d/15m7Al5H3vldFgIaQfFyulm1h92_Mgd0H/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation trunkfood

Change-Id: Ifed45f065b536bca5e8878b1bb95d16caf136ed6
 2024-04-15 10:12:08 -07:00
Jagrut DesaiandAndroid (Google) Code Review 83fef2d60d Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test" into main 2024-04-15 16:41:46 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 503ce966ef Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized" 
This reverts commit b80c6c347a.

Reason for revert: The original change was not the cause for the test failures

Change-Id: Icfe0da43a96f5471076554c4dd25eae649bee81e
 2024-04-15 15:58:19 +00:00
Winson Chung 21cf4439d2 Use shared method for updating the runtime status flags for an item info 
- The method AppInfo#updateRuntimeFlagsForActivityTarget should also
  both add and remove runtime flags to match the current state

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: If87acf1e2324f98cf1d96d194eac13a93fa432c1
 2024-04-14 06:19:49 +00:00
Anushree Ganjam 8cac99a8dc Add new class for SetPropRule and move outside ShellCommandRule. 
Clean up the mEnableInputTransportPublisherRule from TaplWidgetPickerTest since b/325377690 is fixed now.

This is follow up for ag/26419353.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: Id55000ac3cb4b88097ad00b97773c39a725711b8
 2024-04-12 16:45:18 -07:00
Liana KazanovaandAndroid (Google) Code Review 1c0b61377d Merge "Revert "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-12 22:29:53 +00:00
Liana KazanovaandAndroid (Google) Code Review b80c6c347a Revert "Wait for LauncherModel loaded in waitForLauncherInitialized" 
This reverts commit f8f00f4233.

Reason for revert: DroidMonitor: Potential culprit for http://b/334162623.  verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Id165df41a87af4757abd3266b8643949ce012a08
 2024-04-12 21:30:50 +00:00
Sunny GoyalandAndroid (Google) Code Review 4396a935c2 Merge "Using resource overrides for PluginManager instead of code-swap" into main 2024-04-12 20:29:36 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review aec9ae92ea Merge "Wait for LauncherModel loaded in waitForLauncherInitialized" into main 2024-04-12 18:49:52 +00:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap 
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
 2024-04-12 11:38:32 -07:00
Jagrut Desai 49d4429881 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test 
Test: Presubmit
Bug: 319501259
Flag: NONE
Change-Id: I9566b947bc7d5d64953a8c637fefd4fa37cca87c
 2024-04-12 11:37:27 -07:00
Vadim TryshevandAndroid (Google) Code Review 2a6ce15290 Merge "Removing users synchronously" into main 2024-04-12 17:19:36 +00:00
Brandon DayauonandAndroid (Google) Code Review c1de065650 Merge "Fix stale header height being used in scroll to header calculation" into main 2024-04-12 17:00:40 +00:00
Schneider Victor-tulias f8f00f4233 Wait for LauncherModel loaded in waitForLauncherInitialized 
Flag: N/A
Fixes: 326737440
Test: Launcher TAPL tests
Change-Id: I631b370198c393ad84419930c026b6a0ce63ec2b
 2024-04-12 12:48:48 -04:00
Brandon Dayauon 5da04b231f Fix stale header height being used in scroll to header calculation 
- This fixes the inconsistency of how far down is needed to scroll to since
the values used to calculate the header during drawOnScrimWithScaleAndBottomOffset() is faulty.
- Tweaked the row to scroll to when there are tabs vs no tabs. When there are no tabs, its possible the
header gets cut off most of the time hence subtracting by 1 will help this problem.

bug:332543940
Test locally: https://screenshot.googleplex.com/5y4vYiQcnSMKcA6
manual - before: https://drive.google.com/file/d/14Zj_FyO-3bVfXwuxaqgG_DXMELYS5bQn/view?usp=sharing
after with tabs:
after 5x5: https://drive.google.com/file/d/16rjaut6VqBMxG6uLQSnVTLRhUQnAANZ5/view?usp=sharing
after 4x5: https://drive.google.com/file/d/16jCPN8BewwuIQobt0t6tdVouUKpp1CdI/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 3x3: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 2x2: https://drive.google.com/file/d/16N6Myuv9VtXgI1p4sIuV23iupea7jYLQ/view?usp=sharing

after no tabs:
after 5x5: https://drive.google.com/file/d/17H1oF_9fJnrtSqmJJqQyyn4upuM2CsoG/view?usp=sharing
after 4x5: https://drive.google.com/file/d/178Vu3SvnvSPODIfaR0oz6-jPVYDDNMaA/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16yt_5ePPR7kwSrZlo5Sj3x0DqHoQKqYP/view?usp=sharing
after 3x3: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing
after 2x2: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing

after tablet:
landscape: https://drive.google.com/file/d/16JQGs0A3ifKpgqrpQwIzssrXbH-OC0Ej/view?usp=sharing
portrait: https://drive.google.com/file/d/16LmLnOEB6XkuAkAcgvP2mKHe5QQqG1oh/view?usp=sharing

Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If8a70cc71e9cff4a7f8d3b648e3e59c414e40ee5
 2024-04-11 16:22:11 -07:00
Vadim Tryshev 2c72271915 Removing users synchronously 
Bug: 302400996
Test: presubmit
Flag: N/A
Change-Id: Iac1863039cbb9d612abe416b7aee135eec25f223
 2024-04-11 15:59:41 -07:00
Randy Pfohl c21b0000b5 Revert^2 "fixing tests to match new abstraction" 
8e4c0b7afb

Change-Id: I9875d6f9c16f1406d0818164a98e790c2b101650
 2024-04-11 08:58:22 -07:00
Priyanka AdvaniandAndroid (Google) Code Review 1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main 
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
 2024-04-10 23:58:09 +00:00
Sunny GoyalandAndroid (Google) Code Review 63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka AdvaniandAndroid (Google) Code Review 8e4c0b7afb Revert "fixing tests to match new abstraction" 
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
 2024-04-10 21:31:14 +00:00