Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
When apps are being installed in background, the widgets maybe rebound;
similarly, when app activity e.g. messaging happens, sometimes
recommendations are regenerated and bound again.
For the widget section that is expanded, when recycling the displayed
table, we reuse the rows that didn't change.
For recommendations, we already make sure we don't change them when
unless mRecommendedWidgetsMap is reset - so this change just ensures to
additionally re-render only when conditions such as available space or
uiMode are changed.
Bug: 393080128
Fix: 393080128
Flag: EXEMPT BUGFIX
Test: Manual - reproduced the scenario mentioned above.
Change-Id: I46a564c3f7b75145dd168f7fb0b59c130540df78
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().
This was found while updating android lint.
Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
Others e.g. folder etc. will need to handle it separately, so, didn't
update pagedView.
Bug: 383252838
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I43f3818afcdaa4d4805df2af0890b970d71db9a7
UX prefers full page view over low density categorized view in tablets.
Bug: 347288847
Test: Screenshot (see the tablet screenshots vs foldable)
Flag: EXEMPT BUGFIX
Change-Id: I6c8ad36dc6169c65aea4e655af0542958e555669
We always want to measure the pages based on the provided height.
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
Picker rebinds recommendations when size constraints change or
fold/unfold, but recommendations from popup provider may have changed.
This is an attempt at trying to maintain currently shown items
as much possible.
Also, align the pagination and title to the top in two pane picker
(confirmed with David that we prefer this version)
Additionally, we don't show the widgets count for suggestions.
Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: I60799f9ad38da913c3e084d758f5b82c79cd641c
- This makes the suggestion section non-overwhelming
- Currently it shows too many suggestions for user to find any value
- Limiting the height also allows pagination to feel smooth when showing
in categories
Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: Iab1f9a15bdd46ee1560734e30551bfb7c8a74a82
Ordering changes and some more UI changes in follow-up.
Bug: 318410881
Test: See screenshots
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I77e7f4dcdda32e2921ae56721cddbe261832f0d8
Sebastián Franco
Priyanka Advani (xWF)
Shamali Patwa
Cole Faust