Commit Graph

23 Commits

Author SHA1 Message Date
Sebastián Franco e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF) 7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Sebastian Franco e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Schneider Victor-Tulias 7850221bdb Clean up fully rolled out flag enable_additional_home_animations
Flag: EXEMPT flag being removed
Bug: 409610983
Test: None; flag is already fulled rolled out
Change-Id: Ib2b20bd43868275c4059a6a4bc3c9319d37bc5c3
2025-04-14 08:09:17 -07:00
Charlie Anderson 3cbdf78b4f remove shape-based icon scaling
Bug: 400774067
Test: trying different shapes
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I9535cdaa275abcda1d0fc73128f24fe89d473e4d
2025-03-28 17:23:58 -04:00
Charlie Anderson 2044dae70e Fix folder closing to different shapes
Bug: 403915526
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: opening and closing apps from shaped folders

Change-Id: I42f0f689151dcbbd5c8eb6bf424ec4ad7dbe435a
2025-03-24 10:07:44 -07:00
Sunny Goyal 91547eb4d2 Merge "Simplifying icon normalization for adaptive icons" into main 2025-02-19 10:36:30 -08:00
Charlie Anderson 43f4b55bdb Use selected shape during app launch animation
Bug: 372906633
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually launching apps

Change-Id: I86879e51df95b791266e9a5678042859a3fb27f0
2025-02-18 18:30:28 +00:00
Sunny Goyal fe5101d8de Simplifying icon normalization for adaptive icons
Bug: 366237794
Flag: EXEMPT refactor
Test: PResubmit and screenshot tests
Change-Id: Id21e57c9d4ba83983f27aa7988a08db3fd618ce3
2025-02-14 09:09:33 -08:00
Sunny Goyal 29f9c3d231 Merging IconShape with ThemeManager
The order of initialization for IconShape is closely tied to ThemeManager
which makes it difficult for change listeners to work. Merging these keeps
all the theming information at one place

Bug: 381897614
Test: Updated tests
Flag: EXEMPT refactor
Change-Id: Ie29efa20c3308a24be3e284c1c93ed7444b68d58
2025-02-13 22:38:01 -08:00
Schneider Victor-tulias 9fb1f80435 Fix icon flash on app launch
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 343051344
Test: temp logs, launched apps from home, quickly swiped home while quick switching
Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
2024-06-14 15:27:36 -04:00
Schneider Victor-tulias 65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
Sunny Goyal 638a687fc8 Converting IconShape to mainThreadInitializedObject instead of
keeping it a process static

Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: Id66100e0cb300659c6017c287eb38ab04290477b
2024-04-25 15:56:30 -07:00
Andy Wickham b922dccbf5 Cleanup API checks for P, Q, and R.
Test: Build with gradle
Flag: NA
Change-Id: I3ef17090741d14bebd76cf09cf3dc5ac4f11e686
2024-01-24 14:58:08 -08:00
fbaron 3b894e1f70 Fix IllegalArguemntException for ClipIconView#update
The scale was infinity sometimes which means that the view minSize is probably getting set to 0 due to lp height and width being 0, so we do not update the views as they are no longer laid out

Flag: NONE
Test: Opening apps should work fine, but i wasn't able to repro this exception before or after this fix
Fix: 318099222
Change-Id: I1c08346c7ee1d4e89d9c3ba23ee2aa51a451cb31
2024-01-03 12:44:10 -08:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Jon Miranda f23e2d1e16 Keep foreground drawable centered during app open/close animation.
For apps that use AdaptiveIcon, we used to animate the foreground
drawable independently from the background. This is sometimes
perceived as jank so we remove the animation since it is very subtle
in the best case scenario.

Bug: 268026344
Test: open/close apps/folders that use AdaptiveIcons
Change-Id: I500bf56e04823757d511d909a93d3b30703249a1
2023-03-20 16:13:02 +00:00
Jon Miranda 39334f4013 Allow icons to take up full width in all cases where width > height.
Previously we only let the icons take up the max width if the
device was in vertical bar layout. For tablets this meant
that the icons would be smaller than the actual window crop.

We want the full width in any cases where the profile width
is greater than the height, so created a new method to check for that.

Bug: 203157974
Test: phone/tablet in portrait/landscape
Change-Id: I467f142bac87ec7c3b369c01f8d9c96ddf74fc76
2022-03-07 18:17:50 -08:00
Jon Miranda c9ad2dd6c7 Add new app close implementation.
- We remove the fling completely
- We set damping to 1 for x/y springs so there is no
  bounciness, and updated the stiffness and bounds to tighten
  up the path to the final location.
- During the animation, we translate all launcher content
  down
- When the x/y springs, and rect animator all finish,
  we use a spring to bounce the launcher content back up

- Added AppCloseConfig so that the entire animation can
  be defined in one location, with getter methods so that
  all the involved parties of the animation can access the
  current value.
- The animations are all defined linearly, and then
  interpolated over using a 3 point curve.

Building behind feature flag as we tune the values.

Bug: 173107751
Test: manual, visual
Change-Id: I83ad0fa2c4234cf30004240d43e191354595adc8
2021-04-22 16:11:11 -04:00
Jon Miranda 8f09aa3438 Fix IllegalArgumentException for Float.NaN in ClipIconView.
Bug: 173703326
Test: not able to repo bug but this prevents the code from
      executing in bad case
Change-Id: I3701c040e72e6ce37a624b10bb82b2200935e283
2021-01-22 17:49:36 -05:00
Sunny Goyal 6fd105b69a Updating gesture tutorial home animation
> Using a separate View as icon, instead of the taskView
> Updating swipe animation logic to abstract out FloatingIconView dependency

Change-Id: Ib466262afead11ebe4ca035d589f0382c37e3e97
2020-07-09 07:51:34 -07:00
Jon Miranda b133a52e86 Fix app open/close animation in landscape.
When we refactored ClipIconView, we never init mIsVerticalBarLayout.
Instead we pass it in along with the rest of the info from FloatingIconView.

Bug: 155039118
Change-Id: Iff93105c512a8e6478dc49d8ab9100fd129af48c
2020-04-30 22:50:59 -07:00
Jon Miranda 4848604882 Polish badge animation on app open/close.
Create new ClipIconView so that the adaptive icon foreground/background can
get clipped properly, and the badge gets drawn separately on top of it.

Bug: 142105172

Change-Id: Ie5d65c20f845d9219fd01daa383f273dde0e096c
2020-03-23 12:24:04 -07:00