Commit Graph

7424 Commits

Author SHA1 Message Date
Vinit Nayak 868e6e38eb Merge "Reset floating split task view after remote animation finished" into sc-v2-dev am: e9fbcc4aeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15809021

Change-Id: I7596c805d44815084f888675308f99a5a0488c8f
2021-09-24 01:29:17 +00:00
Vinit Nayak e9fbcc4aeb Merge "Reset floating split task view after remote animation finished" into sc-v2-dev 2021-09-24 01:18:03 +00:00
Tracy Zhou 46c3f1e3f5 Merge "Hide task bar icons when notification shade is expanded" into sc-v2-dev am: ba086b8125
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15850809

Change-Id: I1e8617484ba8a241011d62d7ae2bcecf9813c7e9
2021-09-24 01:09:45 +00:00
Tracy Zhou ba086b8125 Merge "Hide task bar icons when notification shade is expanded" into sc-v2-dev 2021-09-24 00:57:26 +00:00
Vinit Nayak 8a1749f0d9 Merge "Allow tapping on app icon for second split app." into sc-v2-dev am: 03396d4fba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15900195

Change-Id: I61cbf3b9cd07c148019b85c6c7b070fd69bfa816
2021-09-24 00:27:02 +00:00
Vinit Nayak 03396d4fba Merge "Allow tapping on app icon for second split app." into sc-v2-dev 2021-09-24 00:17:57 +00:00
Jonathan Miranda 5940915502 Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev am: e2455aa1cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15898541

Change-Id: I99e6980287c57e2e308463037c4900e56577fe03
2021-09-23 23:23:50 +00:00
Andy Wickham 022c60fe05 Merge "Makes All Set layout more responsive." into sc-v2-dev am: 768e686466
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15890763

Change-Id: I80dd8dce0d591b971c963f14cbdba128033048be
2021-09-23 23:23:44 +00:00
Jonathan Miranda e2455aa1cf Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev 2021-09-23 23:14:50 +00:00
Andy Wickham 768e686466 Merge "Makes All Set layout more responsive." into sc-v2-dev 2021-09-23 23:12:44 +00:00
Andy Wickham 13c3f31a0d Makes All Set layout more responsive.
- No longer forced portrait mode
 - Bottom texts are aligned proportionally to the screen height
   to avoid overlapping in landscape folded
 - Subtitle text width is limited to force wrapping to avoid an
   awkward line of text on wider screens

Fix: 189896987
Bug: 187701213
Test: Manually went between portrait/landscape/folded/unfolded.
Change-Id: Ibb2bbe545cf7f154ad77e10d574e72f8d9110a72
2021-09-23 23:11:59 +00:00
Jerry Chang d3ceb3dc88 Reset floating split task view after remote animation finished
Move reseting floating task view for entering split after remote
animation finished to prevent the floating task view disappear before
opening split task view being visible and causing flicker.

Bug: 199377815
Test: Manual check the flicker disappear
Change-Id: I4a864335972842570c61291a7a0c423edeb74578
2021-09-23 16:01:18 -07:00
Vinit Nayak 9299a743af Allow tapping on app icon for second split app.
Fixes: 200851336
Test: Split with one app from overview,
tap on app icon for second app. Gets
selected as second app.

Change-Id: I312169fe7bc42007c2f1a0146a5fef5f8d5f46d6
2021-09-23 14:46:59 -07:00
Jon Miranda 13519e4402 Significantly reduce gesture feedback when swiping up to home screen.
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
  start, center, or bottom of the rect depending on where the item
  is on the workspace. This reduces the  amount of distance needed to
  travel between, which helps further reduce gesture feedback.

Bug: 173107751
Test: test closing app that is on:
      -  top row of home screen
      -  middle of home screen
      - in hotseat

Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
2021-09-23 20:13:40 +00:00
Vinit Nayak 870a105b79 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev am: 5dded93a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857414

Change-Id: Iab80cdbf68e75a16b64f4b8e9bae9a8602866cc6
2021-09-23 06:07:37 +00:00
Vinit Nayak 5dded93a72 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev 2021-09-23 05:55:17 +00:00
Tony Wickham 06743b6818 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev am: d523841ab4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889760

Change-Id: Iee408c6091ec44875387ba390d6f9478a0fb4ccd
2021-09-23 00:50:38 +00:00
Tony Wickham d523841ab4 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev 2021-09-23 00:39:01 +00:00
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Jonathan Miranda 739afa1bec Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I95b22ad6b05fb86707aff017eb11fca3af9f9c7d
2021-09-22 18:38:32 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 38935d3441 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Ie56e8d555cb0f803c30939633dc1533b6e11f17e
2021-09-22 17:38:54 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Alex Chau f6e67fb067 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Ied04deccc9e9ed6813831b7a25ad36380d38a783
2021-09-22 13:45:12 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
TreeHugger Robot 21f2b4cc91 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: I16bc98a32e7b12a871617b4fd622e180c0bb6bca
2021-09-21 22:02:15 +00:00
TreeHugger Robot c48f770a3d Merge "Adding screen record for a flake" into sc-v2-dev 2021-09-21 21:49:58 +00:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
Vinit Nayak 0ada7824c1 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I474126fe11984793006c8c07529c89d409621a58
2021-09-21 17:41:54 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 8bc27a7ee2 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I3ef3b561f2c76e5e4c069af751477ae83e11fcb7
2021-09-21 16:52:31 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
sfufa@google.com 5b38ff6d16 [Hotseat] Fix hotseat edu flicker
When edu view animation is not started in closed state, it results in a single frame showing right before the animation begins.

Bug: 184610272
Test: visual
Change-Id: I675dbe9927771f4b64d1d81c637f19621037b415
2021-09-21 01:50:41 -07:00
Samuel Fufa 8998a393b0 Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev am: e4057e628c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15864327

Change-Id: Ic5165aeabf619e649f3a9291bf64c689644c6c0b
2021-09-21 06:48:59 +00:00
Samuel Fufa fb0bd63b32 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev am: cf175820c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862162

Change-Id: I8649602454a097b553e94048027d772c68a14941
2021-09-21 06:48:53 +00:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
vadimt 99479a9925 Adding screen record for a flake
Test: presubmit
Bug: 195673272
Change-Id: I3ea99f68872554d688b30bf87f595fef1538a7cb
2021-09-20 20:09:07 -07:00
Evan Rosky 5684dffff6 Merge "Register remote transitions on activity start" into sc-v2-dev am: 26c596b813
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15847881

Change-Id: Idad928c2d632ed79a6065cc8f6ec4ebfdaaae70f
2021-09-20 22:46:45 +00:00
Evan Rosky 26c596b813 Merge "Register remote transitions on activity start" into sc-v2-dev 2021-09-20 22:29:57 +00:00
Samuel Fufa 700858930d Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev am: 7f693253c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862035

Change-Id: Iec7a78c53173b4b001c2ace6cd6b26a95cb17b19
2021-09-20 21:29:23 +00:00
Samuel Fufa de409fc30a Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev am: 091d91a84b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862161

Change-Id: Ia34a8eeb0672139521e1590fa6c93b36b4a20344
2021-09-20 21:29:18 +00:00
sfufa@google.com 0828fec3d2 [Hotseat] Show edu tip within screen bounds
Screenshot: https://screenshot.googleplex.com/8grkbkYQu5jQhU8
Bug: 163162675
Test: enable hotseat predictions while in landscape mode, dismiss hotseat edu dialog and verify toolTip is shown properly.
Change-Id: Ia6daa7412d728be702e30972136f4c849315793d
2021-09-20 14:22:25 -07:00
sfufa@google.com d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
sfufa@google.com ef5ee36e90 [Hotseat] Fix hotseat migration in landscape mode
Bug: 189860214
Test: performed migration in landspace and verified items are moved properly. change is persisted when device is rotated or launcher is restarted.
Change-Id: Ice088e5524a1405dbfa20c21b4edc597f23da07e
2021-09-20 14:22:24 -07:00
Samuel Fufa 7f693253c8 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev 2021-09-20 21:19:00 +00:00
Samuel Fufa 091d91a84b Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev 2021-09-20 21:16:49 +00:00