Commit Graph

13537 Commits

Author SHA1 Message Date
Abhilasha Chahal dfd154f18d Use numAllAppsColumns to calculate height of all apps icons
Additionally opens up access of some fields to allow them to be overridden.

Test: Manually verified that Launcher3 layout does not change

Launcher3 APKs: https://drive.google.com/drive/folders/1hBcZU9xou4tZJxbTmkya_LyBbD2oYuwV?resourcekey=0-R0I1IQ2rSUIEfPjW8S_ppA&usp=sharing

Bug: 216150572

Change-Id: I4b97a7e9e15973fc5aa70a4b98f0b73dd5bf3c17
2022-03-23 21:09:54 +00:00
Pat Manning 85eeb4e62e Merge "Add workspace page translations for edit state." into tm-dev 2022-03-23 11:35:20 +00:00
Luca Zuccarini 6f962f9357 Merge "[Toast] Flip the QSB motion flag to true by default." into tm-dev 2022-03-23 10:27:05 +00:00
Tracy Zhou 8d06bb8991 Merge "Update initial staged split UX." into tm-dev 2022-03-22 22:44:33 +00:00
Schneider Victor-tulias c741210bb1 Merge "Reset the home settings activity when launching it" into tm-dev 2022-03-22 18:23:41 +00:00
Pat Manning b04dd608bf Add workspace page translations for edit state.
Bug: 202971709
Test: manual
Change-Id: Ic807d380053b8cc5aaf521513c308854e1b14a43
2022-03-22 17:58:19 +00:00
Brian Isganitis 98214d072c Merge changes from topics "presubmit-am-08ca1fad1fe94bf3ace5a708c5584d55", "presubmit-am-3c6c58a0fa374b92b1a5f8d5f5788871", "presubmit-am-6939eac1469540108813bd4ed4c60a9b" into tm-dev
* changes:
  Have taskbar all apps extend ActivityAllAppsContainerView.
  Refactor ActivityAllAppsContainerView to depend on ActivityContext.
  Refactor allapps.search package to depend on ActivityContext.
2022-03-22 16:11:35 +00:00
Luca Zuccarini b21fd239a9 [Toast] Flip the QSB motion flag to true by default.
Bug:225749858
Test: manual with soong build as well as server build image with this
change

Change-Id: I5658bae753a7112a64fc89ae54c10c5af3a09654
2022-03-22 15:45:07 +00:00
Thales Lima 042482e94c Merge "Change size of All Apps bottom sheet" into tm-dev 2022-03-22 15:25:50 +00:00
Thales Lima b7ef569591 Change size of All Apps bottom sheet
This brings the size of the bottom sheet closer to the spec provided by UX. For that type of flexibility to be possible, more attributes are introduced and some calculations had to be changed.

This shouldn't affect phones.

Bug: 218638090
Test: visual, with dumpsys and HSV
Change-Id: Ieee7580d80d8e100837b1cdd7a1455c4d65612dc
2022-03-22 12:19:46 +00:00
Thales Lima 60dc19cb71 Merge "Fix height of hotseat" into tm-dev 2022-03-22 11:43:13 +00:00
Thales Lima f49dce6961 Merge "Reset the size of hotseat cells" into tm-dev 2022-03-22 10:06:22 +00:00
Tracy Zhou 4ff3615b23 Update initial staged split UX.
- Introduce inset to the staged split view
- Update width of the staged split view
- Introduce rounded corners to staged split view. It's tricky to animate it in with smooth transition considering the rounded corners. The best way to handle it is to draw content as if part of it is off the screen, so that when it's animated in, the rounded corners can slide in onto the screen correctly.

Fixes: 219085340
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/09a99b75-3614-4d20-b6d4-a78108f769d8

Change-Id: I24d90cc9e2695d822cb2de8b21e2d5519f2e344d
2022-03-21 21:21:42 -07:00
Becky Qiu fd6b0d5617 Merge "[OneSearch] Add a flag to guard QSB animations." into tm-dev 2022-03-22 00:58:07 +00:00
Jeremy Sim c0422b8a48 Merge "Fix issue with split thumbnails overflowing during rotation" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim 8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim cab1ef1a9d Merge "Fix small positioning bug with DWB banner in landscape" into tm-dev 2022-03-22 00:17:43 +00:00
TreeHugger Robot f8137e5ecb Merge "Fix overriden deep shortcut titles and icons" into tm-dev 2022-03-21 20:56:13 +00:00
Luca Zuccarini 24fab62d35 [OneSearch] Add a flag to guard QSB animations.
Bug: 225749858
Test: manual
Change-Id: Ib725b9bcec235d2e23cf93b2f86d0dc9cd0600cb
2022-03-21 19:00:23 +00:00
Thales Lima 7d14923195 Fix height of hotseat
Hotseat size was going behind workspace unnecessarily, causing some issues and also had the wrong hotseat height which was cutting the icons in folders.

Fixes: 224713923
Fixes: 221101290
Test: manual
Change-Id: I2646abc4a6aaa5bf2ea85e55e2f3618f8d7efd9b
2022-03-21 18:32:22 +00:00
Alex Chau c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
TreeHugger Robot 016dd3656d Merge "Adjust edit state drop targets, workspace scaling, and margins per device type and orientation." into tm-dev 2022-03-21 17:07:10 +00:00
Thales Lima c307cd137f Merge "Add more border space options" into tm-dev 2022-03-21 15:14:18 +00:00
Thales Lima 2017ee0208 Merge "Correct inline qsb for foldables" into tm-dev 2022-03-21 14:30:19 +00:00
kholoud mohamed af6641414c RESTRICT AUTOMERGE Fix newAPI lint error
Fixes: 225612636
Test: m -j out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-report.txt
Change-Id: Ib7f7df0010702b0f26d99bbd7b27ee38a6ed5e17
2022-03-21 10:50:29 +00:00
Kholoud Mohamed ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Jeremy Sim bf6f171f84 Fix issue with split thumbnails overflowing during rotation
Fixes a set of issues in Overview where you could cause split thumbnails to overflow their contents into each other by rotating the phone in certain ways.

The issue occurred because StagedSplitBounds objects have their height and width assigned differently depending on if they were created while the phone was in portrait or landscape.

Fixed by adding a conditional check in PortraitPagedViewHandler#setSplitTaskSwipeRect and LandscapePagedViewHandler#setSplitTaskSwipeRect.

Fixes: 218784856
Fixes: 218779313

Test: Manual on local devices
Change-Id: I04b4f4344250da34616ab1744af22fa41b9aba9b
(cherry picked from commit 1d6b7f2abf)
2022-03-19 00:10:54 +00:00
Jeremy Sim b42345273c Fix paired icon placement in landscape/seascape
In grouped task view, paired icons will now align better with task thumbnails.

Fixes: 218783211

Test: Extensive manual testing on local device(s).
Change-Id: I372d2ee90302a8d96ace048ff4f82126d9b2b363
(cherry picked from commit d6826c74a4)
2022-03-19 00:10:16 +00:00
Jeremy Sim 3b687a5092 Fix small positioning bug with DWB banner in landscape
The DWB banner is now positioned correctly when the task thumbnail is set as a secondary split view.

Fixes: 220637396
Test: Manual testing on local Pixel 6
Change-Id: I3bcb0eb09d2a607b2891bc9f63f3a0b03668f48e
(cherry picked from commit 87fad7b984)
2022-03-19 00:09:22 +00:00
Brian Isganitis d478f555cb Have taskbar all apps extend ActivityAllAppsContainerView.
This step is necessary to have taskbar support search in all apps.
Search is not ready yet, so a fallback search manager is included.

Test: Manual
Bug: 216683257
Change-Id: Id118388bc4baae4b63ef205295caf46cbd541bc8
2022-03-18 15:39:54 -07:00
Alex Chau d826f04b93 Merge "Use correct config.smallestScreenWidthDp when creating Resource in DeviceProfile" into tm-dev 2022-03-18 17:51:10 +00:00
Schneider Victor-tulias 90ba15622a Reset the home settings activity when launching it
Opening the home settings shouldn't open to a previous state. Updating home setting intents to clear previous tasks.

Bug: 187447602
Test: manual
Change-Id: I40fa408cdade5003c91136fe54f054e7f0ae07b2
2022-03-18 17:50:35 +00:00
Schneider Victor-tulias c8c761621b Fix overriden deep shortcut titles and icons
Bulk Icon loading causes all icons that share a component name to share a title and bitmap. This didn't work for deep shortcuts since they were already being loaded individually. Added a check to filter out deep shortcuts.

Note: If future traces show that individual deep shortcut loading is taking too long, then deep shortcut loading can be refactored into bulk icon loading.

Fixes: 224891898
Test: manual
Change-Id: I112fcd4a889071e5b523d56731bad8ecdee08abc
2022-03-18 17:50:22 +00:00
Pat Manning 1acf2b18af Adjust edit state drop targets, workspace scaling, and margins per device type and orientation.
Bug: 202971709
Test: manual
Change-Id: Id1817cd3c7e7bfa5b0aa8aa20565b791ad871f64
2022-03-18 17:43:28 +00:00
Brian Isganitis 5eb66d8abb Refactor ActivityAllAppsContainerView to depend on ActivityContext.
All of the all apps search support is in this class which is also being
refactored to depend on ActivityContext. At the end of this refactor,
this class can be merged with BaseAllAppsContainerView.

Test: Manual
Bug: 216683257
Change-Id: I8cbf21c8d9ce97cc60e9846cfe8c2a7bcb800a01
2022-03-18 10:36:15 -07:00
Brian Isganitis f477ec2032 Refactor allapps.search package to depend on ActivityContext.
Test: Manual
Bug: 216683257
Change-Id: I6230498b24380b37531f8a83db1dc768270e708a
2022-03-18 10:35:10 -07:00
Brian Isganitis 8198cb6f3f Merge "Move activity starting logic into new ActivityContext extension." into tm-dev 2022-03-18 16:43:48 +00:00
Alex Chau a6907dc8c9 Use correct config.smallestScreenWidthDp when creating Resource in DeviceProfile
- This is a regression from ag/17070486 when tested, likely because DeviceProfiles are no longer re-created when changing display sizes, so correct values need to be calculated on the starting state

Bug: 221961069
Test: verify smallestWidth specific resource on changing display sizes
Change-Id: I1539bad4b35b36f0056d59307ab5fbec23a71f49
2022-03-18 15:24:07 +00:00
Thales Lima 44cc3a2e21 Add more border space options
This give options to landscape layouts to have different border options

Bug: 222109350
Test: manual and HSV
Change-Id: If823dd09c945438f77e57ff80a8a0c4fc0b4c8a6
2022-03-18 14:28:24 +00:00
Thales Lima 2903a624ce Correct inline qsb for foldables
Fixes 223565967
Test: manual and HSV

Change-Id: I40ef17142f90a8b29cdec44a36249eb2b800734a
2022-03-17 13:52:19 +00:00
Alex Chau 2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
Becky Qiu 025bf08e2f Merge "[Avocado] Use device config for arm2 flags instead." into tm-dev 2022-03-17 06:39:54 +00:00
Brian Isganitis bde3c8b6bd Move activity starting logic into new ActivityContext extension.
This code branch is needed for taskbar, so needs to be moved from the
activity classes to an interface that both can share.

Test: Manual
Bug: 216683257
Change-Id: I042c0dcf08207d94847b9d7a1783acc14613ef5f
2022-03-16 13:59:03 -07:00
Alex Chau 3e40089771 Merge "Change grid migration to start from top to bottom" into tm-dev 2022-03-16 18:12:13 +00:00
Thales Lima 8cd020bb1d Reset the size of hotseat cells
When resetting the hotseat layout, the size of cells also can be changed based on changes in DeviceProfile. In this case, the border size changes when rotating the device.

Fixes 216071526
Test: manual and HSV

Change-Id: Idf7b7972e7be347a991cad1cb8ee8cf95cbc4a87
2022-03-16 17:49:40 +00:00
Becky Qiu 85025d248d [Avocado] Use device config for arm2 flags instead.
Bug: 224861508
Test: manual
Change-Id: Ib42ddb3808cf84ed1511754bf3f8bbcf5d100894
2022-03-15 17:13:56 -07:00
TreeHugger Robot 8dff7ca830 Merge "Close taskbar all apps on popup notification and app info shortcut tap." into tm-dev 2022-03-15 22:57:20 +00:00
TreeHugger Robot 2f06a23ed7 Merge "Fix NPE in BubbleTextView" into tm-dev 2022-03-15 22:18:02 +00:00
TreeHugger Robot e0380381b7 Merge "Add event tracking to the gesture navigation tutorial." into tm-dev 2022-03-15 22:12:29 +00:00
TreeHugger Robot b66fc8b145 Merge "Tune widget picker bottom sheet VisD for large screen" into tm-dev 2022-03-15 21:33:50 +00:00