Commit Graph

5973 Commits

Author SHA1 Message Date
Vinit Nayak 95ee358269 Show split options when overview actions hidden for grid
* We hide split option in task menu for focused task
if the user hasn't scrolled at all in overview
* We show option when user has scrolled because then
the split option from overview actions will be hidden
* Mostly uses the same logic as
RecentsView#updateActionsViewFocusedScroll()

Bug: 201380373
Test: Manual
Change-Id: Ia8769a67cfbb2e4414cd4d8e816e62245fc4bd2c
2021-10-05 14:28:07 -07:00
Alex Chau b78753a73f Adjust min/max scroll according to mSplitPlaceholderSize am: 516584e648 am: 60818c3de0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15982847

Change-Id: I8cbf7c400b06c19b5dd37a1fff66007d414e9d61
2021-10-05 18:27:44 +00:00
Pat Manning a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak 01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00
Alex Chau 516584e648 Adjust min/max scroll according to mSplitPlaceholderSize
- RTL is not handled yet due to split select broken

Bug: 200537659
Test: Split left and split right, check if min/max scroll is correct
Change-Id: I734d890bb955601da52cd806074014ed2e7eba55
2021-10-05 17:22:05 +01:00
Jerry Chang 93250cf918 Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev am: b001ce602f am: 6d6c9de783
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15903128

Change-Id: I82bbca3b2d5bbecdaff5ba6627c87d30f69b227d
2021-10-05 01:19:23 +00:00
Jerry Chang b001ce602f Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev 2021-10-05 00:46:36 +00:00
Prabir Pradhan 85f0cec3dc Remove workaround for unrotated gesture monitor (3/3)
There is currently a conflation between per-window-input-rotation and
unrotated gesture monitors. We would like to enable
per-widnow-input-rotation first without affecting gesture monitors so
that the old behavior is maintained for gesture monitors.

We can then add unrotated gesture monitors as a new feature later on.

Bug: 201982032
Bug: 179274888
Test: manual
Change-Id: I935165446e1a347129e9eb3cc816c62b24d4fc47
2021-10-04 06:06:18 -07:00
Jerry Chang d41c032afd Update side stage outline visibility with swipe gesture
Bug: 200850654
Test: enabled side stage outline, observed the outline updates its
      visibility with swipe gesture properly.
Change-Id: I59fcb1fdbb07f5ad5327036972ebbe20ebeb11b7
2021-10-02 10:04:32 +08:00
Schneider Victor-tulias a84672965e Make gesture nav tutorial skip button always visible.
Bug: 198285152
Test: started, completed and tried failing gesture nav tutorial.
Change-Id: Ic30a54e6592783abafcf1efe61ecedb9514d094d
2021-10-01 17:32:45 -07:00
TreeHugger Robot 889dfd07cd Merge "Don't snap to task when tapping task icon in overview grid" into sc-v2-dev am: f5942afeb5 am: a5a22a2970
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15960194

Change-Id: I3b1826f21c6f643f87ddfa5022385e36005f9558
2021-10-01 19:46:43 +00:00
Alex Chau d4864e5cbc Don't snap to task when tapping task icon in overview grid
- Open task menu directly instead of snapping to task, as there are spaces to do so unlike small screen

Fix: 201428316
Test: Tap task icon with clear all button shown in overview grid, no snapping
Test: Tap task icon with clear all button shown in non-grid overview, snapped to last task
Change-Id: Ief79f7c758c4109e5c7722b2f35647db98a9f05c
2021-10-01 18:23:25 +01:00
TreeHugger Robot 2e00cb8fee Merge "Overview - Remove Chips code" into sc-v2-dev am: d1ad84c6df am: 5587d7a493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15942463

Change-Id: I40a106e7ff4060c6c0459142defa418fad1d42b5
2021-09-30 22:43:30 +00:00
TreeHugger Robot d1ad84c6df Merge "Overview - Remove Chips code" into sc-v2-dev 2021-09-30 22:14:41 +00:00
Alex Chau 9ec321cbe9 Switch to rest state when display changes am: 90d24f4b9b am: f017e1bfcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15951262

Change-Id: If23c8dcd8a52c3293775a49b1e8e6b8efd336bc6
2021-09-30 19:40:29 +00:00
Alex Chau 90d24f4b9b Switch to rest state when display changes
Fix: 199463580
Test: Unfold device from overview (both from app and from home), overview should close
Change-Id: I7786f3ec46857075e123fa2a093c7b55ca616fc1
2021-09-30 17:26:05 +01:00
TreeHugger Robot 2e4a003f71 Merge "Remove the Share button option from Overview." into sc-v2-dev am: 70cc9ffe7c am: 8775a79741
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15935390

Change-Id: I27bfb9c63fb618abb0faaa116e44b9e95aa84b45
2021-09-30 04:38:22 +00:00
TreeHugger Robot 70cc9ffe7c Merge "Remove the Share button option from Overview." into sc-v2-dev 2021-09-30 04:11:47 +00:00
Tony Wickham ec7030a5e9 Merge "Aniamte stashed handle color changes" into sc-v2-dev am: 6db0cf1e22 am: 631a02507d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943405

Change-Id: I541418eadc98644d9b6f99a7a5a30dea519b1386
2021-09-30 02:39:20 +00:00
Tony Wickham f6af104676 Merge "Update stashed handle region to only include the handle" into sc-v2-dev am: ad3de8eab8 am: b3ade306da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943399

Change-Id: I06b1964118f83bc74678c8ea7a00341c24cf17dd
2021-09-30 02:39:10 +00:00
Tony Wickham 6db0cf1e22 Merge "Aniamte stashed handle color changes" into sc-v2-dev 2021-09-30 02:17:18 +00:00
Tony Wickham ad3de8eab8 Merge "Update stashed handle region to only include the handle" into sc-v2-dev 2021-09-30 02:17:03 +00:00
Tony Wickham 0ede0fa405 Aniamte stashed handle color changes
Test: Swipe from light background to dark background, ensure handle animates the color change
Bug: 193938970
Change-Id: I815c3a364019935bdf3d69309e695ac34b119c5e
2021-09-29 16:19:49 -07:00
Tony Wickham a93e158352 Update stashed handle region to only include the handle
Before it included the whole width/height of the view, rather than just the outline where the handle is drawn.

Test: Swipe up from a light app on dark wallpaper, ensure handle changes color as soon as the white app background is past halfway through the handle
Bug: 193938970
Change-Id: Ic8b83f60976f05b8ff56590422bd9b2fa6140e76
2021-09-29 15:47:58 -07:00
Samuel Fufa 7444c5185f Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev am: abb827b376 am: aab3edf950
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882894

Change-Id: I3f8df26bbc49772faf8b166750fa8cc5ddbc16b5
2021-09-29 22:32:01 +00:00
Samuel Fufa abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
Zak Cohen 71c527126b Overview - Remove Chips code
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.

Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
2021-09-29 14:43:27 -07:00
Zak Cohen 283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Pat Manning 05c2873979 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev am: 429b8df180 am: 148b8bd2eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15804385

Change-Id: I25bb02bde3dc3eeceb6a22d220a64da53b91ac96
2021-09-29 21:30:58 +00:00
Pat Manning 429b8df180 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev 2021-09-29 21:03:46 +00:00
Zak Cohen 018a761e17 Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev am: ba4b8e145d am: a3553ac013
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15936271

Change-Id: Ic3658840206e8a1ff6f8f9868209a219a82b47e2
2021-09-29 20:43:45 +00:00
Zak Cohen ba4b8e145d Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev 2021-09-29 20:15:14 +00:00
Schneider Victor-tulias 20ab96ab1b Merge "Update gesture navigation tutorial for foldable devices." into sc-v2-dev am: 5b563706e3 am: 70c43e7f13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15779642

Change-Id: Ib4102d0d3aa3b7b91a0d4e68c2ab4fecec6ab2d1
2021-09-29 20:09:21 +00:00
Schneider Victor-tulias 5b563706e3 Merge "Update gesture navigation tutorial for foldable devices." into sc-v2-dev 2021-09-29 19:42:43 +00:00
TreeHugger Robot e57bcd984f Merge "Remove check that system rotation must be allowed for recents rotation to be allowed." into sc-v2-dev am: 42b5b78bbf am: d60f4bf549
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15940373

Change-Id: I887750ba8b885e371d8268cb8e615cae4a17b403
2021-09-29 17:08:39 +00:00
TreeHugger Robot 42b5b78bbf Merge "Remove check that system rotation must be allowed for recents rotation to be allowed." into sc-v2-dev 2021-09-29 16:36:09 +00:00
Pat Manning da71f41263 Remove check that system rotation must be allowed for recents rotation
to be allowed.

This check existed before the user was able to rotate via the rotation
button while autorotate setting is off.

Test: manual
Fix: 201511975
Change-Id: I920886cb42ec5b8f4d3eb0bdd80b216cd7c3c849
2021-09-29 14:06:55 +00:00
Pat Manning 6e5cc70a58 Merge "Prevent repeated haptics on task dismissal." into sc-v2-dev am: 9fe8109b35 am: fa0df11f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15934464

Change-Id: I3a9778afddfd507a96a6119059bc80707b31652c
2021-09-29 13:36:45 +00:00
Pat Manning 9fe8109b35 Merge "Prevent repeated haptics on task dismissal." into sc-v2-dev 2021-09-29 13:28:37 +00:00
Pat Manning 35231f3041 Add TAPL tests for hiding the actions view when scrolling away from
focused task in overview.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ie44a5bd99d7c9ffbc5405973c0ba1950cd90665c
2021-09-29 10:30:18 +00:00
Vinit Nayak 9960098585 Merge "Add toast instructing user to select second split app" into sc-v2-dev am: 31e400d62e am: b1e429e011
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15925826

Change-Id: I6e3f4ee8f85ebbc19b6a9e2796215e1fa45408c6
2021-09-29 03:13:10 +00:00
Vinit Nayak 31e400d62e Merge "Add toast instructing user to select second split app" into sc-v2-dev 2021-09-29 02:48:58 +00:00
Zak Cohen 323b1e4f43 Remove RecentsExtraCard plugin hook.
This plugin hook never really worked properly. The touch handling was
always a bit off and it complicates the code.

Bug: 201460301
Test: Local
Change-Id: I19401be18f859b3bdf408a2e4aacd95ca95d35cc
2021-09-28 16:11:56 -07:00
Tony Wickham e0a486773d Merge "Use falllback animation when going back to no icon" into sc-v2-dev am: 1ad55e6ab5 am: c2a7481cd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15933204

Change-Id: I98653e32664f8e90c77af3654c62a34b771c6653
2021-09-28 21:44:32 +00:00
Tony Wickham 1ad55e6ab5 Merge "Use falllback animation when going back to no icon" into sc-v2-dev 2021-09-28 21:19:38 +00:00
Zak Cohen 7cb98961ce Merge "Remove Content Push prototype." into sc-v2-dev am: c1359c448d am: a163c68ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15922695

Change-Id: I30a08ef27bee0d2252ceaaac5acbf6f10879ad13
2021-09-28 20:44:52 +00:00
Zak Cohen c1359c448d Merge "Remove Content Push prototype." into sc-v2-dev 2021-09-28 20:16:23 +00:00
Pat Manning 0f5a1e3661 Prevent repeated haptics on task dismissal.
Test: manual
Fix: 200813011
Change-Id: I74ce053023935a037074db25552f730d30f8ef52
2021-09-28 17:35:58 +00:00
Vinit Nayak 8217054355 Add toast instructing user to select second split app
Fixes: 200131929
Change-Id: I1825fba64a42cef1d067bd5e085273d1eca68fce
2021-09-28 10:26:21 -07:00
Tony Wickham b43374e9f9 Use falllback animation when going back to no icon
Test: Open settings from the shade (not on home screen) and go back, ensure animates reasonably
Bug: 197656915
Change-Id: I78baa3ad03655f66b9e9727e62247ec8a15f3bf9
2021-09-28 09:19:47 -07:00