Commit Graph

5973 Commits

Author SHA1 Message Date
TreeHugger Robot 88dc380611 Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev am: ad890ac5af am: 4e36642c01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388226

Change-Id: I53adc3f81e4de6296d7c2f8e76696f33c01e2508
2021-12-03 21:01:09 +00:00
TreeHugger Robot ad890ac5af Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev 2021-12-03 20:23:58 +00:00
TreeHugger Robot 78b066d230 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev am: 79b56b0659 am: f3bcecf5c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388220

Change-Id: I306259c20ca095772e1ddb036a9c9edf7bfc05b2
2021-12-03 19:15:15 +00:00
TreeHugger Robot 79b56b0659 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-12-03 18:40:37 +00:00
TreeHugger Robot 739c56c117 Merge "Remove keepWindowOpaque and have the window always fade out." into sc-v2-dev am: dff64072ff am: 23fe70386d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365974

Change-Id: I2b5ee43ad1a173230f6c309c69cb7a3e9daebd41
2021-12-03 18:39:20 +00:00
Alex Chau 4bdf8c1754 Use getMeasuredWidth instead of getWidth in setSplitIconParams
Fix: 208647202
Test: Enter overview with app pairs, rotate and rotate back, check the task icon
Change-Id: I14914258a2508cf3f399312f4c88574b27a5e9fa
2021-12-03 18:28:38 +00:00
TreeHugger Robot dff64072ff Merge "Remove keepWindowOpaque and have the window always fade out." into sc-v2-dev 2021-12-03 18:06:24 +00:00
Alex Chau 149acef8d7 Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 6e906f3436.

Reason for revert: b/204891006
Bug: 189807374
Change-Id: I1b3f93d44b1691aa3d2cc90222ac93067a5cf6b4
2021-12-03 15:17:51 +00:00
Alex Chau eef3ed6628 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev am: 683b4cd824 am: f1c38718d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365768

Change-Id: I0144c29e4ca9e0ea04d831f4473b4fd6ccf21a8f
2021-12-03 12:57:05 +00:00
Alex Chau ef14a30767 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev am: 402252f4b6 am: f7360e8fe1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16185565

Change-Id: Ic0e11fc3d1d69a3e179791c5f6e59bb774c808ca
2021-12-03 12:57:03 +00:00
Alex Chau 1bf0fe1b70 Add back screenshot button to Launcher3
- Also make spacing between buttons always 36dp
- Updated screenshot button image for Launcher3

Fix: 208384949
Test: Start overview in Launcher3WithQuickStep, test screenshot button is working
Change-Id: Ieb60ce134813202c1d14137fff0a131e1f5f8c96
2021-12-03 12:32:29 +00:00
Alex Chau 683b4cd824 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Alex Chau 402252f4b6 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Winson Chung e4dc13ac72 Fix issue with Shell listeners being unbound if SysUI is restarted
- If SysUI is restarted (ie. during dev or a crash), the components
  registering the shell listeners may not be aware of this, and
  listener callbacks will not be re-registered.  Currently all the
  listeners are managed correctly (bound & later unbound) so we can
  just keep the active listener references to re-register if this
  happens.

Bug: 207142749
Test: Kill SysUI, start some apps and ensure Launcher still shows them
      in recents
Change-Id: I47665180bbff3a12b12686e2ca3063ecd188bb56
2021-12-03 04:38:26 +00:00
Wei Sheng Shih 3cc4bedd54 Merge "Fixes BinderTests when enable shell transition." 2021-12-03 02:56:24 +00:00
Sunny Goyal 331e6e94f9 Merge "Updating icon badging logic" 2021-12-03 02:14:42 +00:00
TreeHugger Robot 724ac3db2e Merge "Fix direction of matrix inversion" into sc-v2-dev am: 9c7baac12d am: f5a9714a63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16381637

Change-Id: If2a5d0528a1b6480e7591b36953f135d002e7bb7
2021-12-03 00:25:04 +00:00
Vinit Nayak 573fca80f6 Destroy activity/view references to avoid memory leak
Bug: 204891006
Change-Id: If60ac1716c30ebe68fb6e7457d71f542d3075422
2021-12-02 16:05:52 -08:00
TreeHugger Robot 9c7baac12d Merge "Fix direction of matrix inversion" into sc-v2-dev 2021-12-02 23:52:42 +00:00
TreeHugger Robot f30a999841 Merge "Add icons for staged split" into sc-v2-dev am: 7f54d5cde4 am: 0dc5a85eb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374164

Change-Id: I3103d1d423910686d049d72f399bfdf1eb0539ee
2021-12-02 23:36:33 +00:00
Alex Chau 2cbe70a386 Merge "Fix switch access for overview grid" into sc-v2-dev am: b31176c83b am: e5449f5468
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346361

Change-Id: I9488154c6e53fa0ba111e2041619b5e49d9c81c8
2021-12-02 23:06:26 +00:00
TreeHugger Robot 7f54d5cde4 Merge "Add icons for staged split" into sc-v2-dev 2021-12-02 23:00:48 +00:00
Alex Chau b31176c83b Merge "Fix switch access for overview grid" into sc-v2-dev 2021-12-02 22:32:01 +00:00
Sunny Goyal d872a97bd0 Updating icon badging logic
Bug: 201682172
Test: Manual
Change-Id: I57421b0c77e12f1cd464e532d2a1383c2cf93981
2021-12-02 22:14:25 +00:00
Vinit Nayak 20cbfa5427 Fix direction of matrix inversion
* "And I would have gotten away with it too
if it wasn't for you meddling [matrices]"

Fixes: 208360236
Change-Id: I1607a19c81830f6a037d2337ee1d9e944096e0ac
2021-12-02 22:08:06 +00:00
Tony Wickham e59a723af3 Fix taskbar jumping when going home
- Set resumed state immediately when finishing recents controller to launcher, otherwise there's a race where we start animating gesture state to 0 before animating resumed state to 1, which causes the jump in the bug

Test: Swipe from app to home 10 times, no jump
Fixes: 203725820
Change-Id: Ie8a1add29902a9961ba4d7861ba5424ab656f1c8
2021-12-02 12:19:32 -08:00
Winson Chung 4485125350 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev am: eb4b2d0147 am: 401558e396
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16333426

Change-Id: Ib2a7deeb645ab059c035e61ccceea30d0b22fbcc
2021-12-02 20:18:25 +00:00
Tony Wickham 34a5ec9f1c Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev am: 3d2a1a7368 am: a14fd14c65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374169

Change-Id: Id60002f4dc45aff2c6a721ae0c8a480d32a228e4
2021-12-02 19:02:43 +00:00
Winson Chung eb4b2d0147 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev 2021-12-02 19:01:40 +00:00
Tony Wickham 3d2a1a7368 Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev 2021-12-02 17:39:08 +00:00
Nick Chameyev 4283c6bc05 Do not animate QSB and hotseat when portrait am: c5d3a0d891 am: fc73f74271
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343607

Change-Id: I0efa62d2047a287bcc35c182f12361b8ce46dd91
2021-12-02 17:12:09 +00:00
Nick Chameyev c5d3a0d891 Do not animate QSB and hotseat when portrait
Disables fold/unfold animation for QSB and hotseat
icons when in portrait orientation. Launcher workspace
icons and widgets are still animated intentionally.
Reuses NaturalOrientationRotationProvider which is currently
used to disable fold/unfold animation in the status bar when
in non-natural orientation.

Bug: 201518277
Test: fold/unfold on launcher in landscape =>
 QSB and hotseat animated;
 rotate screen during fold/unfold animation =>
 translation reset after rotating to portrait,
 animated after returning to landscape;
 rotate after fold/unfold animation => no changes
Change-Id: I8ed405b09f445f554d7638ab44393c90773e0bb6
2021-12-02 14:39:08 +00:00
Tony Wickham 488bca7934 Remove TaskbarLauncherStateController#setIconAlpha()
Instead use setTaskbarViewVisible directly. Now that we stash when going to overview, we shouldn't have any launcher state where we need to fade out TaskbarView icons

Test: quick switch from home (follow up CL)
Bug: 194728611
Change-Id: I03e1fa4037b7e8a08494f6b7e065d144c4bc4e1b
2021-12-01 15:27:44 -08:00
Vinit Nayak 455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
TreeHugger Robot eba2a6aa8a Merge "Animate right icon of app pair" into sc-v2-dev am: 2bede2dbf2 am: 64b80cb75d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371722

Change-Id: I336948ccd6ada2c96a12d5deb9213e740595c6de
2021-12-01 20:47:12 +00:00
TreeHugger Robot b7323164bf Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev am: 87f010f3bd am: 8c427dd750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371720

Change-Id: Ia04b10a8fc9e55ca46bb80bdacd38b458b84b2e8
2021-12-01 20:41:24 +00:00
TreeHugger Robot 2bede2dbf2 Merge "Animate right icon of app pair" into sc-v2-dev 2021-12-01 20:06:56 +00:00
TreeHugger Robot 87f010f3bd Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev 2021-12-01 19:34:51 +00:00
Schneider Victor-tulias 63a061fff3 Merge "Implement AccessibilityDelegateImpl for the Taskbar" 2021-12-01 19:33:06 +00:00
TreeHugger Robot cdeb234b5b Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev am: e7e3d6ad31 am: 3c519248b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371718

Change-Id: Iebe599ce37b3d8f101fc14f284c4886d98d0ead7
2021-12-01 18:49:09 +00:00
TreeHugger Robot e7e3d6ad31 Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev 2021-12-01 18:21:05 +00:00
Alex Chau e81af3570b Animate right icon of app pair
Fix: 208647365
Test: Swipe up and observe right icon of app pair
Change-Id: I37a716c156d64c312d132bea80540ce922f3f709
2021-12-01 17:45:08 +00:00
Alex Chau 4536c2fc30 Apply/reset split scroll offset regardless of previous state
- Also do the same in setState without animation

Fix: 208605204
Test: Exit split screen and enter overview
Change-Id: I34dd102527dffa90925b6f0fd22465f1fe6e819c
2021-12-01 17:23:46 +00:00
Vinit Nayak 7834925992 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev am: b15d3cfe73 am: 298ebbef7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16368980

Change-Id: I128a586d65d5564bd066a705f395ee9f4624eaf8
2021-12-01 16:38:23 +00:00
Alex Chau a307492525 Removed onBackPressed handling in SplitSCreenSelectState
- So it'll have exact same behavior as OverviewState to exit overview when going back
- Also removed RecentsView.cancelSplitSelect as it's longer needed

Fix: 181707736
Test: manual
Change-Id: Ide4dfc64680ecc9adfe245ae2de1463735b0490e
2021-12-01 16:24:10 +00:00
Vinit Nayak b15d3cfe73 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev 2021-12-01 16:01:36 +00:00
Fedor Kudasov d6a28fe202 Merge "Separate getTaskViewAt usage" into sc-v2-dev 2021-12-01 10:08:06 +00:00
wilsonshih aa79e68759 Fixes BinderTests when enable shell transition.
Post startActivity to UI_HELPER_EXECUTOR
There will do Resumed the launcher's activity when goes to Overview,
skip the isStarted != isResumed check while shell transition is enabled

Bug: 207297486
Test: atest BinderTests
Change-Id: Id3220b89bfac212062f389879549627a88d93a04
2021-12-01 17:52:01 +08:00
TreeHugger Robot 8bc0314ab4 Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev am: f7518d42eb am: 89fe31ef0e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346762

Change-Id: I5e737afc44e1ae398b82f3dfb4799934b3fa5697
2021-12-01 07:03:08 +00:00
Schneider Victor-tulias a3fe68dcb1 Implement AccessibilityDelegateImpl for the Taskbar
- Added accessibility actions to open pop up menu
- Added accessibility actions to open an app/shortcut to the top/left or bottom/right

Fixes: 204453506
Bug: 198438631
Test: attempted all actions individually, attempted combinations of actions (eg. open pop up menu -> move to left/right)
Change-Id: I76a4237035a0ebfe88b8b5f147b574bb2629f20c
2021-11-30 23:02:55 -08:00