Commit Graph

18796 Commits

Author SHA1 Message Date
Sunny Goyal 1f2bb9d0b7 Updating the quickswitch direction in SEASCAPE
Change-Id: I9b4ff52971a70e2eae0567c2430916b0deaebd32
2019-05-02 12:11:40 -07:00
Kevin 990e7d4593 Fix bug where we left recents right after entering
There was an issue where tapping recents while there were no tasks and
we first launched would not actually go to recents. This was because we
had the leave recents call tightly coupled with showing the empty view.
When the user first goes to recents and no task is available, we animate
to the empty view. However, this also causes us to leave the view even
though nothing happened and it results in the user leaving right after
enterring.

Instead, we should couple the leaving logic with the actual action,
removing the task.

Bug: 131708240
Fix: 131708240
Test: Go to recents while empty, goes on first tap now
Test: Ensured swipe to remove => leave recents logic still works
Change-Id: Ifff6d051d957838c3cfae200a2a8ebb316b22965
2019-05-02 12:09:26 -07:00
Kevin e659758f17 Add scrim under status bar and above thumbnails.
For Recents Go, the thumbnails actually go directly under the status bar
text, so we should ensure that there is some scrim to ensure it's always
readable. We do this by adding a foreground drawable scrim to the
activity's root view.

Since this root view is used in other Launcher states, Launcher has to
toggle this on and off when going/leaving recents. When this view is
just being used for recents as a stand-alone, however, (i.e. when the
user has a different default launcher), it's fine to set this once at
the beginning since nothing else uses the root view.

Bug: 131834685
Fix: 131834685
Test: When quickstep is the default, go to recents and back. Status bar
is readable. Scrim does not animate when going to and from recents.
Test: When quickstep is not the default, scrim shows up fine
Change-Id: I5d88a1fd873860887b3141e1ec0ee999f59ccfad
2019-05-02 11:46:32 -07:00
TreeHugger Robot a51d6422c2 Merge "Anti-alias thumbnail corners to look smoother" into ub-launcher3-qt-dev 2019-05-02 18:35:10 +00:00
Tony Wickham da9cf0f66b Merge changes I705b7a65,I98a2e71a into ub-launcher3-qt-dev
* changes:
  Allow touches on launcher while animating to home
  End window animation to home when handler invalidated
2019-05-02 18:25:30 +00:00
Kevin 70aa79ffa1 Anti-alias thumbnail corners to look smoother
Thumbnail corners should be anti-aliased so that they look smoother and
less rough.

Bug: 131779031
Test: Manual, go to recents and see corners
Change-Id: I49a299671ec37f56b6eebe2dd2eb71790e8cb2b4
2019-05-02 11:14:01 -07:00
Sunny Goyal ae6e318711 Initial changes to creating a fake landscape Launcher UI
Workspace and hotseat are drawn in rotated UI giving the impression that the
device is in Portrait, even though it is in landscape

Bug: 131360075
Change-Id: I29c4068af25fd4dcf7039b9a45886e864a137977
2019-05-02 10:59:28 -07:00
TreeHugger Robot c2803ec5b2 Merge "Remove shortcuts/deepshortcuts as targets for swipe up to icon animation." into ub-launcher3-qt-dev 2019-05-02 17:02:03 +00:00
TreeHugger Robot 36abdcbc10 Merge "Exclude TaskViews from system gestures" into ub-launcher3-qt-dev 2019-05-02 16:35:27 +00:00
Tony f1d8260e2d Exclude TaskViews from system gestures
Test:
- Enter overview
- Swipe from right edge (no TaskView) goes back
- Swipe from left edge on top of TaskView scrolls to it
- Now swipe from either edge scrolls
- Swipe outside carousel goes back

Bug: 129297464
Change-Id: I0abd444a6e8d8daf79a824c94bdd05c01dfe19cb
2019-05-02 09:23:06 -07:00
Tony Wickham 1a468145ab Allow touches on launcher while animating to home
Previously we only proxied if the end target was recents (now we do it
for home as well) and only proxied to the controllers, not to all views.
We still only proxy to controllers for touches in the nav bar, but
otherwise we dispatch touches through normal view hierarchy.

Tests while animating home:
- Swipe down for notifications
- Swipe up for all apps
- Long press icon or wallpaper for shortcuts
- Tap a folder to open it
- Tap an icon to launch it (currently no animation plays, looking into
  it separately)

Bug: 131775822
Change-Id: I705b7a657b6d17bc0e24ed4fb44ecfb0f319e942
2019-05-02 09:21:47 -07:00
Tony Wickham a429fdbbe6 End window animation to home when handler invalidated
We did this already for mCurrentShift, which is used for all animations
except home animation. Now we do it for the home animation as well to
ensure we are properly cleaned up for the next interaction.

Test: Swipe up to home and double tap nav region before animation
finishes. Before, this would return to the app you swiped up from but
was in a broken state where subsequent swipes were ignored. Now we
jump to the home screen and remain there.

Bug: 130802487
Change-Id: I98a2e71a1791f5580451c94a35af98da193ff12f
2019-05-02 09:08:15 -07:00
Jon Miranda a9622f38cc Remove shortcuts/deepshortcuts as targets for swipe up to icon animation.
We'll add it back when b/129067201 is fixed.

Bug: 131809649
Change-Id: I6f009a84b86717f86394da6fb8540eb3f226419a
2019-05-02 08:55:38 -07:00
Jon Miranda 27530c99e2 Use original BubbleTextView icon for legacy stamped forced adaptive icons.
Bug: 129297366
Change-Id: Ic71c42e603cc361b716ba65067a772d19ef394f7
2019-05-02 08:45:27 -07:00
Alex Mang 35bda496f3 Merge "Clear should not show after Widget Configuration activity" into ub-launcher3-qt-dev 2019-05-01 23:59:09 +00:00
Vadim Tryshev f57c62c091 Merge "Remove tracing for fixed bugs" into ub-launcher3-qt-dev 2019-05-01 23:39:34 +00:00
Hyunyoung Song 497708c297 Clear should not show after Widget Configuration activity
Bug: 119847865

TL;DR;;
When configuration activity starts, simply make everything in drop
target bar invisible.

Change-Id: I37d067168368de4ee43b54e5dc95f958f5e94623
2019-05-01 16:33:31 -07:00
vadimt 8649cf29e4 Remove tracing for fixed bugs
Bug: 129434166
Bug: 131170582
Change-Id: Ia9b356594001d96c69ffbb7f8b767b2f54ed5feb
2019-05-01 16:10:56 -07:00
Sunny Goyal c7fefa6151 Disabling flaky test
Bug: 131772711
Change-Id: I98a20223845aa66c77e7a4b6fc1b9415ed046a86
2019-05-01 15:53:56 -07:00
Vadim Tryshev 0cad319633 Merge "Reenabling prediction tests" into ub-launcher3-qt-dev 2019-05-01 22:08:35 +00:00
vadimt 50af77bc46 Reenabling prediction tests
Bug: 131188880
Change-Id: Ie06a39a206a84cdf9384560c0d8498e51af957e5
2019-05-01 14:54:28 -07:00
vadimt bcf0d1e082 Reenabling switching between nav modes in tests
Bug: 130558787
Bug: 131419978
Bug: 131630813
Change-Id: I8d62c7f2b33ac94bd4f899f7c8ed00c8293841e7
2019-05-01 14:35:04 -07:00
Hyunyoung Song d960d4ec2b Merge "Move theme res logic to Themes static class. Bug: 131310726" into ub-launcher3-qt-dev 2019-05-01 21:27:37 +00:00
Hyunyoung Song fcd090da35 Move theme res logic to Themes static class.
Bug: 131310726

Change-Id: Ib46c26c2b44165a4441e109eed6d3ae7e19bcf02
2019-05-01 14:11:50 -07:00
Vadim Tryshev dffb214d0f Merge "Not using Contacts app" into ub-launcher3-qt-dev 2019-05-01 19:53:42 +00:00
TreeHugger Robot 428617ebe7 Merge "Setting predition enabled/disabled state based on callbacks from the service" into ub-launcher3-qt-dev 2019-05-01 19:51:21 +00:00
vadimt f1e0c90a3b Not using Contacts app
Bug: 131628231
Change-Id: If877cc95879263330b7bbd344ddd3a526a5e6fac
2019-05-01 12:21:56 -07:00
Winson Chung d16f87f52d Merge "Removing screen pinning flag check" into ub-launcher3-qt-dev 2019-05-01 04:07:05 +00:00
TreeHugger Robot 989f3747e2 Merge "TaskView controls currently drawn insets and radius" into ub-launcher3-qt-dev 2019-05-01 03:41:23 +00:00
Tony Wickham 737d67fa0f TaskView controls currently drawn insets and radius
Previously this was controlled by TaskThumbnailView. Having TaskView
handle it allows it to update its outline provider to match the
thumbnail when setting fullscreen progress.

Bug: 129883568
Change-Id: I067fcdd31676af4d4792d18eaaac031c2ac0b18a
2019-04-30 20:26:50 -07:00
Vadim Tryshev c9a2eb0809 Merge "Adding more activities for inproc tests" into ub-launcher3-qt-dev 2019-05-01 01:35:23 +00:00
vadimt db4afbba92 Adding more activities for inproc tests
So that virtual devices can scroll all apps

Change-Id: I7aeca9e73e4089431624ab88fc9216a60c575039
2019-04-30 18:19:50 -07:00
TreeHugger Robot 2fc528b833 Merge "Fix RTL bug when swiping up to home." into ub-launcher3-qt-dev 2019-04-30 21:50:47 +00:00
TreeHugger Robot 34659d2153 Merge "Fade task items when swiping out" into ub-launcher3-qt-dev 2019-04-30 21:27:23 +00:00
TreeHugger Robot 6380f51960 Merge "Fix recents order being reversed sometimes" into ub-launcher3-qt-dev 2019-04-30 21:23:54 +00:00
Jon Miranda 361ccf3490 Fix RTL bug when swiping up to home.
When you switch to RTL when an app is open, we try to use the BubbleTextView
that is no longer attached on the animation back to home. This causes the
item location to return the wrong values (since now the view doesn't have
valid padding/width we can use). In this case, we'll use the fallback
animation.

Bug: 131242470
Change-Id: I0ce27ee10bd6402cc6b2065813b034fc04592622
2019-04-30 14:04:16 -07:00
Kevin 72e8025f75 Fix recents order being reversed sometimes
Occasionally, the recents list items were reversed.  This is because
RecentsTaskList#getTasks returns the actual backing list which we were
reversing, so we solve this by making a new array list.

Bug: 131367388
Test: Do repro in bug, no longer gives reversed order
Change-Id: I825d284e4768c2b53fedf07480e99d195acfa6d6
2019-04-30 13:39:10 -07:00
TreeHugger Robot 943ce93bd5 Merge "Enabling quick-switch gesture in landscape mode (2 button UI)" into ub-launcher3-qt-dev 2019-04-30 19:29:14 +00:00
TreeHugger Robot 2e6f3c7324 Merge "Fix app open animation in landscape." into ub-launcher3-qt-dev 2019-04-30 19:16:34 +00:00
Sunny Goyal 27283f7ea8 Setting predition enabled/disabled state based on callbacks from the service
> If no callback is received within a timeout, it is set to disabled

Bug: 131188880
Change-Id: Ie6022b190a2504739f1569a500d6f5cc1566d373
2019-04-30 12:06:25 -07:00
Jon Miranda 063211f620 Fix app open animation in landscape.
Bug: 130828765
Change-Id: Ic447d05a8fe2097a6afd0bfec73039a62bbf5a4b
2019-04-30 12:03:39 -07:00
Winson Chung e6ef8dac28 Removing screen pinning flag check
- The flag may be inaccurate, revert to the activity manager check
  for now

Bug: 131552865
Test: Manual
Change-Id: If7c00ba7a1cbb726dcd65993451e82d76778fd4b
2019-04-30 18:19:24 +00:00
TreeHugger Robot d9c0fe130b Merge "Overlap insets with item margins" into ub-launcher3-qt-dev 2019-04-30 18:00:12 +00:00
Kevin d8144a6304 Overlap insets with item margins
The system insets already create visual space for us, so there is no
need to add additional margin if we already have the insets acting as a
buffer. So we can just overlap them, preventing scenarios where we have
too much scrollable white space.

As a bonus, we get a more robust way of determining the clear all
button's bottom margins as we now base it directly off whether the
insets cover the space as opposed to using the orientation (which is
an indirect way of knowing the insets).

Bug: 131636735
Test: Test on 320x569 mdpi. Matches UX spec.
Change-Id: I6a3a3a5475ed303ed21bca3ed3cc363276c6e745
2019-04-30 10:33:55 -07:00
TreeHugger Robot 287f5d5aef Merge "Fix some MW visual issues" into ub-launcher3-qt-dev 2019-04-30 16:48:43 +00:00
Winson Chung 8d86cf0bcc Fix some MW visual issues
- Ensure that we don't apply apply crop from device coordinates (reset to
  surface coordinates)
- Disable rounded window corners in MW

Bug: 128364741

Change-Id: Ia91500ca97b44537829983945cd3d3cc82747aeb
2019-04-30 09:35:22 -07:00
Kevin 8f6d41ee53 Fade task items when swiping out
As we have a fixed width for the task list now, we have to ensure that
we do not clip the task items when we swipe them out. In addition, we
should fade them out by the end of the swipe as the swipe end location
may still be on a visible part of the screen.

Bug: 131686863
Test: Go to landscape mode, swipe out tasks
Change-Id: If86136a9f9d47098a6dd5d355d3a99d540165c77
2019-04-30 09:13:51 -07:00
TreeHugger Robot 32d475bca4 Merge "Add null check before removing live tile overlay" into ub-launcher3-qt-dev 2019-04-30 01:22:32 +00:00
Vadim Tryshev 9736474072 Merge "Disabling fallback overview tests until the bug is fixed" into ub-launcher3-qt-dev 2019-04-30 01:10:51 +00:00
Vadim Tryshev b93786dca3 Merge "Slowing down gestures for virtual device" into ub-launcher3-qt-dev 2019-04-30 00:59:45 +00:00