Commit Graph

14797 Commits

Author SHA1 Message Date
Jeremy Sim 9ca8565a95 Merge "Allows splitscreen with work & personal version of the same app" into udc-dev am: ab9e66c260 am: cef431f675
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23200223

Change-Id: Ia53c6119b7b35d92199eed0dd3c5b8a4cc55ffd0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-13 00:46:53 +00:00
Jeremy Sim ab9e66c260 Merge "Allows splitscreen with work & personal version of the same app" into udc-dev 2023-05-13 00:23:23 +00:00
Schneider Victor-tulias 55d2f3f9ff Merge "Fix the overview tutorial step success animation" into udc-dev am: 8f23be7b6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122638

Change-Id: I282ccc693e96062dfa13abfa9c5b09b58510606f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 22:54:33 +00:00
Schneider Victor-tulias 8f23be7b6f Merge "Fix the overview tutorial step success animation" into udc-dev 2023-05-12 22:40:14 +00:00
Jeremy Sim b522fb3bb1 Merge "Force Taskbar to remain stashed when in 3p launcher or recents" into udc-dev am: d27b06f500
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22961525

Change-Id: I9354228dc397b49a48865ad46f85e73e660b10a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 22:14:34 +00:00
Saumya Prakash c1c285d999 Merge "Fix UI issues of fake task view in gesture nav tutorial." into udc-dev am: 24aec5e6b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23120959

Change-Id: Icdeaa1f1aa1e187ba78f4237a314efa58e922351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 22:12:11 +00:00
Jeremy Sim d27b06f500 Merge "Force Taskbar to remain stashed when in 3p launcher or recents" into udc-dev 2023-05-12 22:08:51 +00:00
Saumya Prakash 24aec5e6b0 Merge "Fix UI issues of fake task view in gesture nav tutorial." into udc-dev 2023-05-12 21:41:38 +00:00
Treehugger Robot d89d1e3282 Merge "Cleanup SettingsChangeLogger onClose()" into udc-dev am: 87abc0644b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159149

Change-Id: Id856bc3b19ea0d1aa8f3e0283b55cd9bf8d336d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 18:38:30 +00:00
Treehugger Robot 87abc0644b Merge "Cleanup SettingsChangeLogger onClose()" into udc-dev 2023-05-12 17:39:19 +00:00
Schneider Victor-tulias a8ccd542bc Fix the overview tutorial step success animation
- Tapping the screen after a successful overview gesture, but before the delayed success feedbck created a janky experience
- Immediately setting the gesture as successful

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281742006
Test: tapped the screen quickly after successfully completing the overview gesture
Change-Id: I166060191753d6b95bc223e2be08df2bb4b4ecfd
2023-05-12 10:24:39 -07:00
Brandon Dayauon fa8572145f Merge "Separate animations and add dragOffSet points in dragOptions" into udc-dev am: 125e121834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22862532

Change-Id: I6aa4717ff99212926b47a702dbbffda767052949
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 15:50:18 +00:00
Brandon Dayauon 125e121834 Merge "Separate animations and add dragOffSet points in dragOptions" into udc-dev 2023-05-12 15:22:48 +00:00
Jeremy Sim f4835a8884 Force Taskbar to remain stashed when in 3p launcher or recents
This patch makes it so that the transient Taskbar cannot unstash when in 3P launcher.

Previously, the user was able to unstash Taskbar when in 3P launcher, causing a janky-looking UI (3P launchers may implement their own version of Taskbar on the home screen. This also caused problems with certain Taskbar commands like split screen, which provide an entry portal to Pixel-specific implementations.

Fixed by forcing the Taskbar to stay stashed when a 3P Launcher is displayed. The Taskbar is still usable inside of other non-launcher apps. This was done by using TopTaskTracker to check for ACTIVITY_TYPE_HOME or ACTIVITY_TYPE_RECENTS, and disabling Taskbar when these activities are running.

Fixes: 277963491
Test: Manual
Change-Id: Ifc0f3c07e3b76eb610f93205978fbc596bab6253
2023-05-12 00:32:24 -07:00
Jeremy Sim 92e1eeb5f0 Allows splitscreen with work & personal version of the same app
This patch makes changes in various splitscreen controllers to pass userId to the new shell API, to allow same-app splitting with different users.

Fixes: 274973415
Test: Manual
Change-Id: I810b5353aad738c7c275856586b9c521f1554022
2023-05-11 22:10:51 -07:00
Jerry Chang 08e6fde4fe Merge "Fix not tracking splitting tasks correctly" into udc-dev am: 303d6101fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23149642

Change-Id: Ic5d0971b0d6444bea6d5191bbf710679ee652fe7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12 00:58:46 +00:00
Jerry Chang 303d6101fb Merge "Fix not tracking splitting tasks correctly" into udc-dev 2023-05-12 00:49:21 +00:00
Winson Chung ce1017e075 Merge "Only refresh the launcher resume state when the task launch fails" into udc-dev am: e04071e19c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23151004

Change-Id: If5bef04bd9e704371df3bf4568297be4f084ee50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 23:56:18 +00:00
Tony Wickham 9b83175350 Merge "Consistently multiply touch slop for InputConsumers" into udc-dev am: 8d402efac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23122637

Change-Id: I16f2310feec73c677ae603649205bdeb233388d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 23:55:29 +00:00
Vinit Nayak f68f1fa3cc Cleanup SettingsChangeLogger onClose()
* Correct name for San*d*box

Bug: 280463854
Flag: none
Test: v2/gnl-eng/unbundled/launcher/nexus_unit_test_multi_device_platform
Change-Id: I2446871c8ea0b146ccfa2ea7caa1727aec42dd42
2023-05-11 16:32:27 -07:00
Winson Chung e04071e19c Merge "Only refresh the launcher resume state when the task launch fails" into udc-dev 2023-05-11 23:31:21 +00:00
Winson Chung de1b42b957 Only refresh the launcher resume state when the task launch fails
- The previous call from TaskbarLauncherStateController caused a
  regression due to the inability for the code to distinguish
  Normal -> Background -> Normal when tapping on the bar area
  or from failing to launch a task, so both cases were triggering
  the resumed state to cycle and start an animation.  For now we can
  only handle the task-launch fail case.

Bug: 268448123
Fixes: 281966662
Test: Quickswitch to an activity that finishes when resumed
Change-Id: Ie4692dd85252540ff47633978c0e6e4adbb1bdd0
2023-05-11 23:31:14 +00:00
Tony Wickham 8d402efac2 Merge "Consistently multiply touch slop for InputConsumers" into udc-dev 2023-05-11 23:21:33 +00:00
Treehugger Robot 1e92350f86 Merge "Revert "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash"" into udc-dev am: 52d4764576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23177739

Change-Id: I2a447fc36ab12ce58df08bc53f6e9be3c95dee3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 21:46:40 +00:00
Treehugger Robot 52d4764576 Merge "Revert "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash"" into udc-dev 2023-05-11 20:58:02 +00:00
Mady Mellor 662787540c Revert "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash"
This reverts commit 7344766886.

Reason for revert: b/282035015

Change-Id: I38db287f730048d3e1e5041f1853bdae214e1a66
2023-05-11 18:50:35 +00:00
Brandon Dayauon e63401e711 Separate animations and add dragOffSet points in dragOptions
For 1, when animateShift() is called shiftAnimation() is the only thing needed.
2, by having point saved in preDragCondition, we can use that to update the drag layers and not have to
modify registrationX/Y later

Removed dragVisualizedOffset since it does not do anything.

There is an issue that also needs to be fixed if user decides to long click
on a search result and let go, the icon flashes at the touch point when you let go.. so we check when mContent can be shown in DragView
depending on if there is dragOffset.
If there is dragOffset, set mContent to invisible.
If there is no dragOffset, set mContent to visible because it doesn't matter as the original content is at the same spot.

bug: 245659929
test: manual: video: https://drive.google.com/file/d/1JQ0pud31HU0WlrqecX0v1cdPKQ37jQCf/view?usp=sharing
Change-Id: I4d2276b9c43e1e92c45d8538b8dde70baa84a5e8
2023-05-11 10:50:17 -07:00
Saumya Prakash 5c5472ff96 Fix UI issues of fake task view in gesture nav tutorial.
This change fixes the bug where the view for the fake task in the overview gesture was not being reset correctly. This was leading to UI issues such as lack of rounded corners and incorrect animations in the gesture navigation tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 281121451
Fix: 281121699
Fix: 281785378
Test: Manually went through the tutorial on handheld, foldable, and
tablet devices

Change-Id: I424a471013d2b8667724f790618d142ba7ae9a7b
2023-05-11 17:41:18 +00:00
Thales Lima be1131c137 Merge "Make taskbar touchable region smaller in Overview" into udc-dev am: fda9f3d430
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22995656

Change-Id: Id7f4594f69b01850915405574df45bd7d6e9fc6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 15:25:22 +00:00
Thales Lima fda9f3d430 Merge "Make taskbar touchable region smaller in Overview" into udc-dev 2023-05-11 14:48:18 +00:00
Thales Lima 3bc763f5a3 Make taskbar touchable region smaller in Overview
While in overview, makes the touchable region smaller so touches can go to the window below and trigger tapping on overview to go home.

Bug: 269985301
Test: Manual (TAPL in a following CL)
Flag: none
Change-Id: Ie8c7719090c387f951d78cf0fc47e6d9ed192f27
2023-05-11 14:45:41 +00:00
Jerry Chang 858a6e9c1e Defer intercepting touch events to actually start shifting tasks am: 2792271688
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23163166

Change-Id: Ie73cad69ffa904a00591d4f3e4293be6070b8388
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 09:07:33 +00:00
Jerry Chang 87ed2f1176 Fix not tracking splitting tasks correctly
When drag-to-repace one of the splitting tasks, it might reports to
TopTaskTracker the original task changed to undefined after repoting the
new task appeared in a split pair. Result to clear the split tasks
record unexpectedly in TopTaskTracker. This makes sure to clear the
correct stage and prevent override the correct split record.

Fix: 277982233
Test: manual check the behavior and verify the reocrd in TopTaskTracker
Change-Id: Ifce2efdde6d99508f1afa844b3ad424071e13a8f
2023-05-11 08:53:23 +00:00
Jerry Chang 2792271688 Defer intercepting touch events to actually start shifting tasks
Fix: 278740578
Test: http://recall/-/fLARJNt42LVxc3tt86SneW/d9A443iE2UQVktVc2YqwT2
Change-Id: I81efc87f19775dba96bab581a1c443d6070f6ebc
2023-05-11 05:44:16 +00:00
Tony Wickham 233ab99093 Consistently multiply touch slop for InputConsumers
Fixes: 268651129
Test: TaplTestsQuickstep; manually swipe up from various InputConsumers
Change-Id: I0a3baf654092a1a0bdafbfc734ec394668ba60f6
2023-05-11 03:33:57 +00:00
Jagrut Desai a66aa3a31d Merge "Fixing TaplTests" into udc-dev am: 4d559a6c92
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23139495

Change-Id: I043ff37f4ee2dc69b959641e1ff339b19ee3b840
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-11 00:20:55 +00:00
Mady Mellor 8ff2eec82c Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-dev am: 3291bfecf2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534248

Change-Id: Id30ee20f29b5a2ae1a53780d39b157bffafb87da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 23:39:31 +00:00
Jagrut Desai 4d559a6c92 Merge "Fixing TaplTests" into udc-dev 2023-05-10 23:19:39 +00:00
Mady Mellor 3291bfecf2 Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-dev 2023-05-10 23:11:42 +00:00
Treehugger Robot 91ce44e3b6 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev am: f3fdca59d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23143004

Change-Id: I1db198140b10b11fb79122d63ea830d47db24b96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 22:07:07 +00:00
Treehugger Robot 360b5a301a Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot f3fdca59d2 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev 2023-05-10 21:40:40 +00:00
Sunny Goyal 64809780ce Revert "Fix null-pointers in SurfaceTransactionApplier constructor."
This reverts commit d86c5657e0.

Reason for revert: b/281294745

Change-Id: Ib2680b60346a9bc5932057707d0ef105441f324d
2023-05-10 19:34:01 +00:00
Jagrut Desai 2e0770af08 Merge "Fixing NPE in TransfromParams.java" into udc-dev am: 4d17468f88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23120958

Change-Id: I33acacb6ffcbcb22801b2ae292e5aacce85e3b20
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 19:13:09 +00:00
Jagrut Desai 4d17468f88 Merge "Fixing NPE in TransfromParams.java" into udc-dev 2023-05-10 18:57:17 +00:00
Jagrut Desai c875f27912 Fixing TaplTests
Test: Pre-Submit
Fixes: 281772186
Flag: not needed
Change-Id: Ibe2987a69c9ca393ed267e755a3b99826164fee4
2023-05-10 10:47:45 -07:00
Treehugger Robot c6afe67f50 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev am: fb085e6393
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23117884

Change-Id: Ic653f205c2c3210f5af7e42cb9af66c6f54355a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 17:47:26 +00:00
Treehugger Robot fb085e6393 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev 2023-05-10 16:49:09 +00:00
Bill Yi cd5558fcd9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If7588e84680dbc8f4fcc616af06914ab7c57d1a7
2023-05-09 16:04:17 -07:00
Fengjiang Li 77f1806491 Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: Ie4234f9196ca701c78bf7393a0072d7a4147c3c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:57:19 +00:00