PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
53,078 Commits 1 Branch 0 Tags
deffe8f8df56eea613881934372ec0271fb90e28
Commit Graph
965 Commits
Author SHA1 Message Date
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext 
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
 2022-12-08 10:15:55 -08:00
Sebastian Franco 150e572e05 Ignore all launcher3 flaky test so that they come back online 
Test dashboard: https://android-build.googleplex.com/builds/tests/search?filter=mediumFailureRate&filter=highFailureRate&query=config%3Av2%2Fgnl-eng%2Funbundled%2Flauncher%2Flauncher3_test_platform+latest%3A4d&tab=tests

Test: dashboard should not show flaky tests
Bug: 256832045
Change-Id: I06e879dec2703455b7be728c7afd3500d2edd54a
 2022-12-06 17:08:45 -08:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change 
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
 2022-12-05 16:37:45 -08:00
TreeHugger RobotandAndroid (Google) Code Review 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users. 
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
 2022-12-02 13:33:04 -08:00
Sebastián FrancoandAndroid (Google) Code Review f9d418b9f2 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev 2022-12-02 19:34:11 +00:00
Sebastian Franco ac53846195 Ignore test while the solution for the flaky tests improve. 
Bug: 261178121
Test: atest ReorderWidgets
Change-Id: Id0c6594e00486695c63e2cda53b1a5ee39478a1f
 2022-12-02 11:33:00 -08:00
Sunny Goyal d25f79c48f Adding screenrecord to debug themeIconTest 
Bug: 260722220
Test: Updated
Change-Id: I20e590436e318f9a8914a8201d95584ab26de388
 2022-11-29 09:31:13 -08:00
Sunny Goyal ce4896cff5 Fixing shortcuts not getting theme icons 
Bug: 238650110
Test: Updated ThemeIconsTest
Change-Id: I803cd6eefa4e393bf19901a44712622adac7f4b1
 2022-11-28 09:48:50 -08:00
Pinyao TingandAndroid (Google) Code Review ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2 
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
 2022-11-21 15:24:38 -08:00
TreeHugger RobotandAndroid (Google) Code Review 81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Thales Lima ae0d7ef782 Increase icon size to be closer to spec 
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
 2022-11-18 12:38:14 +00:00
TreeHugger RobotandAndroid (Google) Code Review c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Sihua MaandAndroid (Google) Code Review c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev 
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
 2022-11-17 01:46:55 +00:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package 
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
 2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder 
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
 2022-11-16 14:30:08 -08:00
Holly Sun 0d69c8dde9 Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results. 
Also add simple prefix matching method.

Bug: 255355348
Test: manual
Change-Id: I35f2089924d774f3bcc1c05638a5d6b45ed7443f
 2022-11-15 16:55:29 -08:00
TreeHugger RobotandAndroid (Google) Code Review 8a03be1880 Merge "Added Tests for Secondary Display Launcher" into tm-qpr-dev 2022-11-15 22:41:51 +00:00
Alex ChauandAndroid (Google) Code Review 1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Thales Lima b35faed6e7 Improve spaces for folders 
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
 2022-11-07 18:23:48 +00:00
Sunny Goyal 679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it 
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
 2022-11-04 14:41:14 -07:00
TreeHugger RobotandAndroid (Google) Code Review 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test 
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
 2022-11-03 13:33:41 -07:00
Sebastián FrancoandAndroid (Google) Code Review 58502d0236 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev 2022-11-03 18:55:50 +00:00
TreeHugger RobotandAndroid (Google) Code Review 9e1f6002e5 Merge "Add delay after installing dummy app" into tm-qpr-dev 2022-11-03 17:17:09 +00:00
Winson Chung 38779f75da Add delay after installing dummy app 
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
 2022-11-03 03:47:01 +00:00
Sunny Goyal 39b07fd66c Fixing background jump when closing a widget 
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
 2022-11-02 19:17:18 +00:00
Sunny GoyalandAndroid (Google) Code Review c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal d6e9c601d8 Adding screenrecord for debug failing test 
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
 2022-10-31 13:25:17 -07:00
Sebastian Franco 285b749bcf Wait in ReorderWidgets test for the workapce to load after changing it. 
Fix: 252860608
Test: atest ReorderWidgets
Change-Id: Idf99188837a475d0327174e264ab1d23d646d75d
 2022-10-27 14:42:19 -07:00
Sihua MaandAndroid (Google) Code Review 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Sihua Ma 0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost 
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
 2022-10-26 10:57:13 -07:00
Sunny Goyal d859060860 Merging MultiValueAlpha with MultiPropertyFactory 
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
 2022-10-24 14:38:18 -07:00
Hui Kang 4b87b9e521 Fix AddWidgetTest flake 
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
 2022-10-24 18:09:15 +00:00
Sunny GoyalandHui Kang f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" 
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
 2022-10-22 15:37:47 +00:00
Sukesh RamandBrian Isganitis c6d4df87f0 Added Tests for Secondary Display Launcher 
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
 2022-10-20 22:58:46 +00:00
Hui KangandAndroid (Google) Code Review 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation" 
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
 2022-10-17 20:37:49 +00:00
Pat ManningandAndroid (Google) Code Review 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
Sebastián FrancoandAndroid (Google) Code Review 9eeeeacf30 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev 2022-10-07 20:33:41 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation 
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
 2022-10-05 11:37:37 +08:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets. 
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
 2022-09-29 11:12:31 +01:00
Sebastian Franco a44d255c8f Fix ReorderWidgets by removing faulty 4x4 cases 
Fix: 242323136
Test: atest ReorderWidgets (the device has to be cf_x86_64_phone-userdebug)
Change-Id: Ic545409ecc20420be6c7377513c704822dbaf75e
 2022-09-27 09:37:54 -05:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump 
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
 2022-09-21 10:56:04 -07:00
TreeHugger RobotandAndroid (Google) Code Review 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5) 
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
 2022-09-16 17:17:16 -07:00
TreeHugger RobotandAndroid (Google) Code Review 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sebastián FrancoandAndroid (Google) Code Review 09a98dfdbd Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev 2022-09-16 16:49:26 +00:00
Sebastián Franco a798be2ff5 Revert "Prevent dragging widgets to another page in tests when starting a drag." 
This reverts commit 749b2b8493.

Reason for revert: Causing tests to fail b/246972374

Change-Id: I9fc1f6d2e924f4ac5484c6674fd0adf49d04536f
 2022-09-15 21:19:12 +00:00