Commit Graph

6768 Commits

Author SHA1 Message Date
Sunny Goyal deffe8f8df Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev am: d31c8baef1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20676568

Change-Id: Ie215c1933dce65d87204e5969c470548452a7998
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 15:47:35 +00:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Ats Jenk 7868989e50 Merge "Check for both proto flags for common logic" into tm-qpr-dev am: e8c57e94e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20653403

Change-Id: I155bba8ce3621fcb235d3b5cc245e381f3c22947
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:54:23 +00:00
Ats Jenk e8c57e94e7 Merge "Check for both proto flags for common logic" into tm-qpr-dev 2022-12-09 00:43:04 +00:00
Brian Isganitis 2b5ba5eb5f Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev am: ddc7ef2eb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20672612

Change-Id: Ie302f00d1ba369210caf9910422a1df305a8a4ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:02:31 +00:00
Brian Isganitis ddc7ef2eb1 Merge "Add EDU lottie animations for persistent and transient." into tm-qpr-dev 2022-12-08 23:11:27 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Schneider Victor-tulias d132ad4393 Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: Icfdd29ce44e4ff73bfb79b3150addca41b7517cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:25:37 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00
Brian Isganitis 77de0d5a28 Add EDU lottie animations for persistent and transient.
This CL introduces separate lottie assets for light and dark themes, as
well as each step. Each asset contains all of the steps currently but is
constrained to a min and max frame. In future CLs, we will optimize the
storage these take up by using the global assets and controlling min and
max frames programmatically, or trimming each individual asset.
Additionally, we should only be importing one theme variant and then
converting to the opposite programmatically, but the color mappings are
not ready yet.

Future polish to the EDU sheet, such as better handling the stashed
taskbar, will be introduced in future CLs.

Test: Manual in transient and persistent modes.
Bug: 217261955
Change-Id: I5b219ea02e25de0c5c887b5b5640f909e1219287
2022-12-08 14:06:09 +00:00
Schneider Victor-tulias f0de6cc2ca Revert "Cancel gestures on launcher destroy"
Revert "Refactor SchedulerCallback implementation"

Revert submission 20555112-launcher-destroy-gestures

Reason for revert: causes test failures
Reverted Changes:
Ib43cdd597:Refactor SchedulerCallback implementation
Ia8e936e26:Cancel gestures on launcher destroy

Change-Id: I2199e39237b7c9fe25784b46e16960cd5f17c46c
2022-12-07 19:46:00 +00:00
TreeHugger Robot 602ef0772d Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev am: db8b97068b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20637474

Change-Id: I30d189b40676bdc62f4c5d8fa243eae9b10b23d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:24:07 +00:00
TreeHugger Robot db8b97068b Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev 2022-12-07 19:06:21 +00:00
Ats Jenk 8f5b9dd833 Check for both proto flags for common logic
Desktop mode has prototype 1 and prototype 2.
Check for both flags when logic is shared.

Bug: 260645044
Test: manual, check desktop mode 1 works
Change-Id: I40e84440222a9d5f007c2450606cd7c8f9628da2
2022-12-07 10:12:37 -08:00
Nicolo' Mazzucato 1ee66e943a Add logs to aid missing unfold animation on launcher investigation
Bug: 261320823
Test: Manual
Change-Id: If714750c85ee49e66e21462ab9d2675ab0be8b55
2022-12-06 13:06:01 +00:00
Tony Wickham c9740c89aa Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: Ia758acdad42c8f95b9ee52d37d0bf7a3f2c63e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 06:29:09 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
TreeHugger Robot f77ad4afd4 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: I5907940eac2de90c913e1d8ed965b35f013815f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:13:20 +00:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sebastián Franco e8786a176d Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev am: fba141a3dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20611319

Change-Id: Idb38e0a166a18455a2bed40822c0ed8547359b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 01:59:43 +00:00
Sebastián Franco fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00
Brian Isganitis 658905ee9f Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev am: a5953002d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20579485

Change-Id: I2b9f37784bf89d7249d239b1575c00124c838ac1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 21:53:45 +00:00
Sebastian Franco 2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Brian Isganitis a5953002d4 Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev 2022-12-02 21:10:55 +00:00
Jon Miranda 9c053594e9 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev am: 01e90b7787
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613321

Change-Id: Id47761c23154fe04e0cb1a5c1e7807ad02c22f1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 19:29:06 +00:00
Jon Miranda 01e90b7787 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev 2022-12-02 18:58:08 +00:00
TreeHugger Robot d48a078c78 Merge "Removing SearchActionItemInfo" into tm-qpr-dev am: cfa199537b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20537169

Change-Id: I8345c99ddf6fd22802f0c4ca0ed8ca56ee263f2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 17:45:52 +00:00
TreeHugger Robot cfa199537b Merge "Removing SearchActionItemInfo" into tm-qpr-dev 2022-12-02 17:31:25 +00:00
TreeHugger Robot 979fa6725c Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev am: c10a003aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411894

Change-Id: Idbed5a030b1e000a250c1a59446553ab7b4dc73d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 12:28:57 +00:00
TreeHugger Robot c10a003aa0 Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev 2022-12-02 11:40:25 +00:00
Jon Miranda a4aaf1aced Add transient taskbar sizing for twoPanel devices.
Bug: 259712417
Test: on two panel device, on tablet device
Change-Id: Iae273b6bbfb254288c234aa5882f39eb0b6a88b1
2022-12-01 16:28:29 -08:00
Jon Miranda fb6fe0ce82 Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev am: 12053e958f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590521

Change-Id: Ia8007f6d5d36d59292cf53233f20c244322099aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 20:21:15 +00:00
Jon Miranda 12053e958f Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev 2022-12-01 20:03:57 +00:00
Vinit Nayak a5bb63d39a Merge "Update for stashed taskbar animation" into tm-qpr-dev am: 18d5634176
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470413

Change-Id: I641cdf68d3e3b58e9ce77a12d16082d55297d4b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-01 19:47:32 +00:00
Vinit Nayak 18d5634176 Merge "Update for stashed taskbar animation" into tm-qpr-dev 2022-12-01 19:26:11 +00:00
Alex Chau cd76ac24b6 Fade in/out taskbar when launching apps from or back to AllApps/-1
- Added isHotseatIconTopWhenAligned to control both iconAlignment and stash animation to just fade in if hotseat icon isn't on top of the screen in the aligned state

Fix: 257355864
Fix: 213455090
Test: Launch apps from/back to home, taskbar animate from/to hotseat
Test: Launch apps from/back to AllApps/-1, taskbar fade in/out
Test: Repeat aboth with transient or persistent taskbar
Change-Id: I6bdae615ff9e199d23cbfe2d26c8d46a08fbc436
2022-12-01 18:56:30 +00:00
Brian Isganitis deac0d529a Reduce top padding of Taskbar's All Apps tray.
The top padding looks too high because the code is assuming we have a
search bar at the top of the bottom sheet. Until we implement search, we
should temporarily reduce padding for the taskbar implementation.

Before:
  - No tabs: https://screenshot.googleplex.com/AAPdR5nbwepWQ82.png
  - Tabs: https://screenshot.googleplex.com/3DnQp6PKhqXyRag.png

After:
  - No tabs: https://screenshot.googleplex.com/A8enwnSs8r78ccj.png
  - Tabs: https://screenshot.googleplex.com/A3fAy2bXgmSPrG9.png

Test: Manual
Bug: 216683257
Change-Id: Ie0837acc3aed162b9428a209962be2a102c515c8
2022-12-01 00:21:28 +00:00
Vinit Nayak 3b1f5849ce Update for stashed taskbar animation
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected

Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen

Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
2022-11-30 11:56:40 -08:00
Sunny Goyal 9a616213e1 Removing SearchActionItemInfo
> Instead introducing an interface for handling click events
> Linking this interface to other UI which handle clicks

Bug: 259733681
Test: Presubmit and verified manually
Change-Id: I9cbf2d009d64254f513deb909a151e46e860d039
2022-11-30 10:59:07 -08:00
Tracy Zhou e69081984b Animate split confirmation after second app selection from workspace am: c91ef50257
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20556280

Change-Id: Id2591ad19fe0164027d514417457ca4b2bda97b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 08:23:30 +00:00
Tracy Zhou c91ef50257 Animate split confirmation after second app selection from workspace
Fixes: 239824922
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/099acb31-1e05-4d00-a670-590c177a846e
Change-Id: Ifb769afcaf694a1157444f273da69331db15ab1a
2022-11-30 03:39:02 +00:00
Vinit Nayak 5d84ac3640 Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev am: 792a827309
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546386

Change-Id: Ifb13e200987d1a3475c1116589d87c57376c8179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 01:13:40 +00:00
Vinit Nayak 792a827309 Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev 2022-11-30 00:50:51 +00:00
Jon Miranda 1c96b6584c Merge "Allow touches on transient taskbar if ime is present." into tm-qpr-dev am: 912e6dd64d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544543

Change-Id: I783620f7e1644d344fc66f59cb78a88dfc9b3488
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 23:06:16 +00:00
Jon Miranda 912e6dd64d Merge "Allow touches on transient taskbar if ime is present." into tm-qpr-dev 2022-11-29 22:42:03 +00:00
Jon Miranda 6811fe8ab0 Fix window x-axis movement after gesture ends.
Previously we setClamp to false right after the gesture ends.
So when the page settle animation gets the page offset, it would
get the unclamped version which would cause the window to move
in the x-axis movement even if the window didn't actually move
during the gesture.

Now we ensure that we setClamp to false after the page transition
ends so that the scroll offset is consistent all the way until
the end of the animation.

Bug: 258851206
Test: 1. swipe a bit diagonally to bring up taskbar with
         no x-axis window movement
      2. release
      3. there should be no x-axis movement on window

Change-Id: Ic9949d11f2e8bc7ccbd737555a3d5551f09456da
2022-11-29 21:15:32 +00:00
Jon Miranda 106cc895e9 Allow touches on transient taskbar if ime is present.
Bug: 260101467
Test: open chrome, enter url to pull up ime, swipe up to show taskbar,
      tap on taskbar icon

Change-Id: Ic8be6c2bb82fc9b8ab83572cb8622ac157078ea9
2022-11-29 11:30:39 -08:00
TreeHugger Robot d813bddf99 Merge "Fixing shortcuts not getting theme icons" into tm-qpr-dev am: 1330244f0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546011

Change-Id: Iec0c682a4f1a81a4093a4971929603fc4dc32f21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 01:12:21 +00:00