Commit Graph

7914 Commits

Author SHA1 Message Date
Sunny Goyal de75321542 Fixing wrong accessibility focus when opening a floating view
> Using common logic for announcing a floating view for widgets and folders

Bug: 79091095
Bug: 79748886
Change-Id: Ibb3fe48e68e724f50d69f51a03d3b35ad0baf625
2018-05-16 13:11:00 -07:00
Sunny Goyal 9638caf6e4 Merge "Dumping the excoded view hierarchy instead of the default activity dump" into ub-launcher3-edmonton 2018-05-16 19:57:05 +00:00
TreeHugger Robot 0b1174ddbe Merge "Adding Clear All to accessibility chevron on Recents" into ub-launcher3-edmonton 2018-05-16 19:12:00 +00:00
Vadim Tryshev 3f51631b80 Adding Clear All to accessibility chevron on Recents
For motivation, see email thread "Tweaks to for the reverted order of
accessibility swiping"

This doesn't add the action to the fallback Recents, so it will require
more work.

Bug: 79165501
Test: Manual
Change-Id: I99d608ccc13cc1742dc4d427e763125788e8edd2
2018-05-16 12:00:33 -07:00
Hyunyoung Song 1241e61a45 Improve Task user event logging
Bug: 79539824
Bug: 79541772

(1) Added page index of the TASK that is being launched
(2) Covers all three cases of task launch (tap, swipe down, quick scrub)
UserEvent: action:FLING direction=DOWN
UserEvent:  Source child:TASK, packageHash=-1598699687, componentHash=1952702153, pageIdx=0

UserEvent: action:DRAGDROP
UserEvent:  Source child:TASK, packageHash=-744307622, componentHash=-515832044, pageIdx=4

(3) Avoid double logging (When onStop is called, it is not logged if
the cause of onStop is APP or TASK launch)

Change-Id: Ic5db7d6a640d43bfb5cd667b49e37dd0ed127d5c
2018-05-16 11:26:35 -07:00
Sunny Goyal 55eb556a4b Dumping the excoded view hierarchy instead of the default activity dump
> Encoded hierarchy is smaller is size and has a lot more information about the views

Bug: 79861035
Change-Id: I84316b1b0031282b0579f3aaac22d8d8f00d8bcb
2018-05-16 10:55:21 -07:00
Hyunyoung Song 61745e17c7 Merge "Add logging for Onboarding Bug: 73784423" into ub-launcher3-edmonton 2018-05-15 21:48:06 +00:00
Tony Wickham 46afdf5194 Merge "Tune quick scrub" into ub-launcher3-edmonton 2018-05-15 21:34:34 +00:00
Hyunyoung Song 018eec6899 Add logging for Onboarding
Bug: 73784423

* Discovery bounce, homescreen, hotseat
UserEvent: action:TIP
UserEvent:  Source child:HOTSEAT id=0 BOUNCE

* Discovery bounce, overview, prediction
UserEvent: action:TIP
UserEvent:  Source child:PREDICTION BOUNCE

* Swipe up from navbar text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP SWIPE_UP_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET SWIPE_UP_TEXT

* Quickscrub text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP QUICK_SCRUB_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET QUICK_SCRUB_TEXT

* Prediction apps text (visibility, cancel target)
UserEvent: action:TAP
UserEvent:  Source child:TIP PREDICTION_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET PREDICTION_TEXT

Change-Id: I94710b5ed3d00e3599985b154eb660af4a958288
2018-05-15 14:31:07 -07:00
Tony Wickham d58c2d5a48 Tune quick scrub
- Change durations/interpolators when starting from home vs an app
- Increase dim animation duration after quick scrub from an app
  - Also fixed contention between setting dim alpha for the animation
    and setting dim alpha for scrolling
Change-Id: I2c9ea52d4eafaad8954f3ff9d3c0c459a07953bc
2018-05-15 11:49:09 -07:00
Vadim Tryshev 3154cd16b0 Keep clear-all button revealed after dismiss
If it was visible before the dismiss, it will be visible after that.
As a nice side effect, it will preserve visibility on any layout, say,
after a rotation.

Bug: 79117932
Test: Manual
Change-Id: Ia8a544af1326458d4e2d7a07ae2b668f604bc0b3
2018-05-15 11:28:24 -07:00
TreeHugger Robot c14adabe99 Merge "Scrolling on the most recent task upon Overview start" into ub-launcher3-edmonton 2018-05-15 17:47:50 +00:00
Sunny Goyal ff102be52b Merge "Showing the caret/drag handle in transposed layout" into ub-launcher3-edmonton 2018-05-15 17:25:04 +00:00
Sunny Goyal 0076e67dc4 Showing the caret/drag handle in transposed layout
> Adding a simple touch-down effect, without capturing the motion event

Bug: 79526736
Change-Id: I50dcc76836765d158dfdcef2886b190a85707ff2
2018-05-15 09:47:32 -07:00
Vadim Tryshev eb701c6360 Scrolling on the most recent task upon Overview start
Fixes this problem:
1. Open a single task in Recents
2. Dismiss via Clear-all
3. Start a task
4. Press Home
5. Press square button
get Recents revealing Clear All button

Bug: 79117932
Test: Manual
Change-Id: I47bcc50cb72f1757025d2abac0196460e0bb3f36
2018-05-14 17:24:00 -07:00
Winson Chung a92961a639 Merge "Clear ref to animation after drag & drop animation completes" into ub-launcher3-edmonton 2018-05-14 22:49:57 +00:00
TreeHugger Robot d12033ab4a Merge "Adding some activity state information in dump" into ub-launcher3-edmonton 2018-05-14 21:37:28 +00:00
Sunny Goyal e43d00db40 Adding some activity state information in dump
Bug: 79216829
Change-Id: I3e1a5f5508f09b9ce2737c13d917fbab531c2572
2018-05-14 14:23:42 -07:00
Ng Zhi An cabc1ff276 Add click handler for qsb on boot to keep it responsive
Bug: None
Test: reboot device, qsb is responsive, and launches search,
after widgets initialized, qsb remote view takes over click

Change-Id: I30c01ce1ff3da63cc0324f822d21901eb6a49c2d
2018-05-14 13:06:09 -07:00
TreeHugger Robot 7c86a1ad42 Merge "Increasing thread priority while loading high res icons" into ub-launcher3-edmonton 2018-05-14 18:41:42 +00:00
Winson Chung 7dd3b521ff Clear ref to animation after drag & drop animation completes
- LauncherAppTransitionManagerImpl -> DragLayer -> mDropAnim -> mDragView
  (via the update listener) -> mBitmap

Bug: 76162466
Test: Take hprof after picking up an app or widget, ensure there are no
      references to the image created for drag and drop

Change-Id: Iffc92eed13775921567f9ac25fea8e356d6fe963
2018-05-14 10:12:50 -07:00
TreeHugger Robot 99dcc9fd83 Merge "Fixing crash on keyboard shortcuts popup" into ub-launcher3-edmonton 2018-05-14 05:21:31 +00:00
Vadim Tryshev 3455f8d0f6 Fixing crash on keyboard shortcuts popup
Bug: 76218025
Test: Manual
Change-Id: I11c9005764c7b0492138dc17716a0c6c4578798e
2018-05-11 20:02:20 -07:00
Winson Chung a7b42bbf91 Merge "Revert "Revert "Update sysui flags on swipe, skip task backgrounds on opaque apps""" into ub-launcher3-edmonton 2018-05-11 23:47:55 +00:00
Winson Chung a0f09f94b5 Revert "Revert "Update sysui flags on swipe, skip task backgrounds on opaque apps""
This reverts commit f5d5b6f00f.

Reason for revert: Can be submitted once a build with ag/4040557 is available for flashing

Change-Id: Id94440a1dc9b765bb9758af81b0567628befa283
2018-05-11 21:55:21 +00:00
TreeHugger Robot 7f71198dc8 Merge "Separating the draglayer alpha into multiple dimensions so that different animaitons can run without affecting the other." into ub-launcher3-edmonton 2018-05-11 19:26:51 +00:00
Sunny Goyal 6001ea2e2f Separating the draglayer alpha into multiple dimensions so that different animaitons
can run without affecting the other.

Bug: 79323355
Bug: 78880824
Change-Id: I11cb464ebdaad0a7f0a56d4bc4c3dff1d56da16b
2018-05-11 12:18:39 -07:00
Adam Cohen dfb509c580 Clear task when opening WallpaperPicker
-> Each session can reasonably be considered a fresh start
-> Also, works around b/79507056

Change-Id: Iac1ae59cd0c743d71c91a34ba32a0fef51548f74
2018-05-11 10:52:28 -07:00
Sunny Goyal 8201d97225 Increasing thread priority while loading high res icons
> On  local testing, average load time decreased to ~50%

Bug: 79227823
Bug: 78583301
Change-Id: Ib948a697ebad5c91322c74f4ab36b603f3525c61
2018-05-11 09:24:44 -07:00
Sunny Goyal 08cf36ea54 Merge "Tweak and fix bugs with new app close transition." into ub-launcher3-edmonton 2018-05-11 15:43:10 +00:00
Winson Chung 80a269b8ec Merge "Revert "Update sysui flags on swipe, skip task backgrounds on opaque apps"" into ub-launcher3-edmonton 2018-05-11 15:18:46 +00:00
Winson Chung f5d5b6f00f Revert "Update sysui flags on swipe, skip task backgrounds on opaque apps"
This reverts commit 5dd46d51ed.

Reason for revert: Temporary revert until ag/4040557 goes in

Change-Id: Iab2c747a99e1fb1cc5a91787dbf185df77f791b4
2018-05-11 06:50:21 +00:00
Sunny Goyal 81abe79619 Merge "Using dragHandle for workspace padding calculation instead of pageIndicator" into ub-launcher3-edmonton 2018-05-11 01:30:12 +00:00
Winson Chung 5dd46d51ed Update sysui flags on swipe, skip task backgrounds on opaque apps
Bug: 79228291
Bug: 77984778
Bug: 78659249
Bug: 73714156
Change-Id: I3bb9ce5b4d5d16bc229a1caba99891cb87775136
2018-05-10 15:36:44 -07:00
Jon Miranda 973622e8ec Tweak and fix bugs with new app close transition.
* Animates LauncherRootView instead of DragLayer to avoids the flashing that
  can occur when the overlay callback also changes the DragLayer alpha.
* To avoid the scrim's hard line: we hide it and then fade it in later.
* Launcher animation was wrong in landscape mode.

Change-Id: I7673228f5ed8bb72d7393f3d0769577b262f286f
2018-05-10 15:29:34 -07:00
Sunny Goyal 08ef66789b Using dragHandle for workspace padding calculation instead of pageIndicator
> PageIndicator is a 1dp indicator which does not contribute in any padding calculations

Bug: 79111591
Change-Id: I4d8be0149da2b3f14593ae71ca037ffe3885d9be
2018-05-10 11:33:11 -07:00
Sunny Goyal 5d1873a812 Removing scrim overdraw
> Moving all the scrims to draglayer to avoid creating multiple layers during
  various animations
> Removing sys-ui scrim in various states which alread have a background scrim

Bug: 74556464
Bug: 78585335
Change-Id: I8a3fd34ed440f3c7d2e19b3cdb4b72723c535602
2018-05-10 10:52:31 -07:00
Tony Wickham d4ece9a74c Don't reapply state when setting user controlled animation
Bug: 79525106
Change-Id: Ia41a51559196d4aa657fae47727c7366d9073295
2018-05-10 10:03:54 -07:00
Sunny Goyal cc0453c5e0 Merge "Fixing disabled filter is not applied to the foregound layer when dragging an icon" into ub-launcher3-edmonton 2018-05-10 06:52:02 +00:00
TreeHugger Robot 788003e4bf Merge "Tune discovery bounce to be more gentle when bouncing." into ub-launcher3-edmonton 2018-05-09 23:26:01 +00:00
Tracy Zhou 6c4fa1045b Tune discovery bounce to be more gentle when bouncing.
Change-Id: I6b1c094bbcd07bfda76bcc2c6b2a6fb249acd377
Fixes: 79491740
Test: Manual test
2018-05-09 23:18:44 +00:00
Sunny Goyal b6d292d788 Fixing disabled filter is not applied to the foregound layer when dragging an icon
Bug: 79475381
Change-Id: Ic489601f80a3180fe20a83988c2c3db7100e6946
2018-05-09 14:25:09 -07:00
TreeHugger Robot 5be4075727 Merge "Don't end atomic animation when passing through state" into ub-launcher3-edmonton 2018-05-09 20:26:46 +00:00
Tony Wickham 56b247da1d Merge "Add atomic recents animation while swiping up" into ub-launcher3-edmonton 2018-05-09 20:13:23 +00:00
android-build-team Robot f69f0c2bf0 Merge "Adding a carent in the scrim" into ub-launcher3-edmonton 2018-05-09 20:12:59 +00:00
android-build-team Robot 8473ddb7ee Merge "Tweaks to app closing animation." into ub-launcher3-edmonton 2018-05-09 20:11:23 +00:00
Jon Miranda d26d5aaa6d Tweaks to app closing animation.
Change-Id: Ia2cbc1401a57ad8dc3e3553110497eb35c19fe64
2018-05-09 12:51:34 -07:00
Sunny Goyal ef39540dde Adding a carent in the scrim
> Caret is only visible when the accessibility is enabled
> It is visible in NOTMAL and OVERVIEW state and moves out of the
  scrim along with the scrim.
> Acts as an accessible target for various options

Bug: 78172350
Bug: 79215734
Change-Id: I8a968b67e36901859649546295f6491d49cc9ce9
2018-05-09 12:39:30 -07:00
Tony Wickham fc564f1477 Don't end atomic animation when passing through state
Previously we were ending the atomic animation with the assumption
that it should be complete/almost complete by the time you drag to
the next state. However, it is very easy to drag quickly enough where
that assumption doesn't hold, and thus you just see the atomic
animation pop to the end (i.e. recents showing without animation).

Now instead of ending the atomic animation, we let it continue. But
because the new state animation will have an atomic component that
interferes with the still playing atomic animation, we have to
control the atomic component separately; we control the non-atomic
components until the atomic animation ends, at which point we create
a separate controller to control the atomic components.

Bug: 76449024
Change-Id: Ia4bf19e26d0838f952d9e500fbdd8aba19856a41
2018-05-09 12:36:02 -07:00
Tony Wickham 6becf7c07d Add atomic recents animation while swiping up
State handlers can now specify atomic and non-atomic components of
their animations to states, which can be specified when creating a
new animation. There is now one atomic animation, when going from
NORMAL to OVERVIEW (and in reverse):
- RecentsViewStateController's animation (scale/alpha) is all atomic
- WorkspaceStateTransitionAnimation has atomic and non-atomic:
  - Hotseat and workspace alpha is atomic, as is workspace scale
  - Everything else (scrim, translation, qsb and drag handle alpha) is
    non-atomic
- All apps progress is non-atomic

Also simplified dragging through overview; no longer pulls against you,
so we use an OvershootInterpolator when flinging instead of our custom
interpolator for the spring effect.

Bug: 76449024
Bug: 78089840
Change-Id: Iafac84d0c2b99ee9cf9dd5b30e2218286713b449
2018-05-09 12:33:46 -07:00