Commit Graph

7556 Commits

Author SHA1 Message Date
TreeHugger Robot dd336bbff6 Merge "Removing overscroll pluging support" into sc-v2-dev am: 27e294a973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15951928

Change-Id: Ia88f0c47785a2e8c7c2e24c06e00e9b54cee6a01
2021-10-15 19:45:32 +00:00
TreeHugger Robot 27e294a973 Merge "Removing overscroll pluging support" into sc-v2-dev 2021-10-15 19:27:25 +00:00
Vinit Nayak da87bc753d Merge "Align 3 button nav with hotseat" into sc-v2-dev am: 2a7c0c4ed8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16045012

Change-Id: I80e0ea7e4f363b20e43f2c11b16b8cc8fb853c81
2021-10-15 15:35:55 +00:00
Vinit Nayak 2a7c0c4ed8 Merge "Align 3 button nav with hotseat" into sc-v2-dev 2021-10-15 15:25:16 +00:00
Vinit Nayak 55c5ae2395 Merge "Suspend auto-hiding taskbar when folder is open" into sc-v2-dev am: 22762d91cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16010272

Change-Id: I3dd86dc6b32e65f87e3c1c37702a964afbdfb8b7
2021-10-15 09:25:39 +00:00
Vinit Nayak 74b25ca266 Align 3 button nav with hotseat
* Animate translationY alongside icons
* When device rotates on home, update
translationY
* Add padding to contextual buttons to center
it

Bug: 189807374
Change-Id: I149ef25df570fb1fd385f1da960c827105ff975d
2021-10-14 18:32:35 -07:00
Vinit Nayak 22762d91cd Merge "Suspend auto-hiding taskbar when folder is open" into sc-v2-dev 2021-10-14 19:11:53 +00:00
TreeHugger Robot 953476e27b Merge "Transform touch events in landscape mode now that app is on top" into sc-v2-dev am: 5ec8046f6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16008751

Change-Id: I67f6affe4e7b1894ad8993d6e15bb5a51f2e611d
2021-10-11 23:19:48 +00:00
TreeHugger Robot 5ec8046f6a Merge "Transform touch events in landscape mode now that app is on top" into sc-v2-dev 2021-10-11 23:01:31 +00:00
TreeHugger Robot 5e5bbff723 Merge "Sending Launcher resume event to app predictor" into sc-v2-dev am: 60c64adeed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16020107

Change-Id: Ia61fcb85321ec80da8a74fd2a7d2a08870a12463
2021-10-11 21:43:09 +00:00
TreeHugger Robot 60c64adeed Merge "Sending Launcher resume event to app predictor" into sc-v2-dev 2021-10-11 21:22:50 +00:00
Tracy Zhou a4a4002fa5 Transform touch events in landscape mode now that app is on top
Fixes: 193375232
Test: Swipe up from app in landscape mode, interact with Overview, and make sure it's interactive
Change-Id: Ib1838f02d537918b7a13d51a1fdcacbf3d02b99d
2021-10-11 14:04:51 -07:00
TreeHugger Robot 21192886c4 Merge "Fix split select scroll range when TaskView aren't shifting" into sc-v2-dev am: 11579eea19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16015203

Change-Id: Iafd71c95e0165a7ebc1ad84ca7660f1fcd2f9cc1
2021-10-11 20:04:38 +00:00
TreeHugger Robot 11579eea19 Merge "Fix split select scroll range when TaskView aren't shifting" into sc-v2-dev 2021-10-11 19:53:24 +00:00
TreeHugger Robot 98680d64f6 Merge "Add scroll logging to RecentsView behind DEBUG flag" into sc-v2-dev am: 1569754519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16015197

Change-Id: I845dbb5fe3c0d891413a5e8d46d58d502edd9485
2021-10-11 18:31:27 +00:00
TreeHugger Robot 1569754519 Merge "Add scroll logging to RecentsView behind DEBUG flag" into sc-v2-dev 2021-10-11 18:13:45 +00:00
Alex Chau 02150305f9 Fix split select scroll range when TaskView aren't shifting
- There is an edge case that when ClearAllButton is visible, no split translation is applied, the offset adjustment needs to be calculated differently in that case
- Also, apply the scrollOffset to the TaskViews / ClearAllButton instead of updating min/max scroll

Bug: 200537659
Test: Split right in grid, split left with clear all button, split left without clear all button
Change-Id: I869c448bbec6aec8fa070e47193a692be6f75e84
2021-10-11 19:02:28 +01:00
Sunny Goyal 1b6d43b13e Sending Launcher resume event to app predictor
Bug: 202535375
Test: Manual
Change-Id: I1618a5ed973b9d4f898442647e3e197ed4935aa4
2021-10-08 16:21:56 -07:00
TreeHugger Robot 3b4d624128 Merge changes I499c59bd,Ia7260c60,I90846e65 into sc-v2-dev am: 4e9a3d5bdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16012847

Change-Id: Ib26957e30803ea5a10ac182f4c182b480fe388ce
2021-10-08 17:29:32 +00:00
Alex Chau e95de31304 Add scroll logging to RecentsView behind DEBUG flag
Bug: 202514687
Test: manual
Change-Id: Iec022f2583baa794904242a44a2c8dca8ea4b1be
2021-10-08 16:26:08 +01:00
Tony Wickham 1bd4bf7ff1 When taskbar would be stashed in 3 button mode, hide icons instead
In 0 button mode, stashing morphs the icons into the home handle. In 3 button mode, that doesn't make sense, but we should still hide the icons (and just keep the 3 nav buttons). You still can't manually stash via long press in 3 button mode, but this will address other states where we automatically stash the taskbar when we want to hide the icons from users (e.g. when pinning an app).

Test: Pin an app from overview in 3 button mode, ensure the taskbar icons disappear until unpinning
Bug: 190192993
Change-Id: I499c59bd9d7871ff64696b67065cf9d4863222a5
2021-10-07 23:29:41 -07:00
Tony Wickham db0c2f1b79 Add flags to stash taskbar for app pinning and empty hotseat
Test: pin an app from overview, watch taskbar stash automatically until unpinning
Test: turn off suggestions for hotseat, remove all items and watch taskbar stash automatically when opening an app
Fixes: 190192993
Fixes: 193937948
Change-Id: Ia7260c60a820af1a48c9e4a400a52753baf34d41
2021-10-07 23:29:41 -07:00
Tony Wickham 772732de9e Migrate mStashedInApp to FLAGS_STASHED_IN_APP
This is to prepare for different flags that could cause taskbar to be stashed in an app without the user explicitly long pressing to stash.

Test: run wwdebug and wwlogcat, ensure still get logs for long press stash events; other interactions like clipping tasks to above unstashed taskbar still work as before
Bug: 190192993
Bug: 193937948
Change-Id: I90846e650a438e03bdcfdf9c4bf919e19cc5abb3
2021-10-07 23:29:34 -07:00
Vinit Nayak 2a77ff74bd Suspend auto-hiding taskbar when folder is open
* Notify SystemUi to suspend autoHide behavior
until launcher notifies otherwise
* There's no exclusive lock for AutoHideController
behavior, so down the road another component can
choose to resume auto-hide behavior even if launcher
has requested otherwise (and vice versa),
something to keep in mind.

Fixes: 193938507
Test: Opened folder while in immersive video,
taskbar stayed open.

Change-Id: I12f4055911822893551683466cfd532c8108a3a0
2021-10-07 13:46:26 -07:00
Alex Chau 5354bce2e1 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev am: fe69980f90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15992132

Change-Id: Ia9fa4abf3e2ce8f5284c31fb8a66daa236be1794
2021-10-07 15:05:38 +00:00
Vinit Nayak 34035ace74 Merge "Show split options when overview actions hidden for grid" into sc-v2-dev am: 7c2b52e5cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15971858

Change-Id: I654dacc74d748bd63478d0125fc1991d05c6bd8e
2021-10-07 15:05:32 +00:00
Vinit Nayak 08b57cd012 Merge "Move back to end of screen on keyguard" into sc-v2-dev am: c5ae15b481
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15986998

Change-Id: I8d6381fecfddfebfc5d7a3e9f67a3901b97f1180
2021-10-07 15:05:24 +00:00
Alex Chau fe69980f90 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev 2021-10-07 14:52:05 +00:00
Vinit Nayak 7c2b52e5cf Merge "Show split options when overview actions hidden for grid" into sc-v2-dev 2021-10-07 14:51:44 +00:00
Vinit Nayak c5ae15b481 Merge "Move back to end of screen on keyguard" into sc-v2-dev 2021-10-07 14:49:47 +00:00
TreeHugger Robot b01c390299 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-07 08:40:56 +00:00
Vinit Nayak a08e806e25 Move back to end of screen on keyguard
* Animate it back into position after user unlocks
* Re-create taskbar on layout direction change so
PropertyHolders are recreated to take into account
new values

Fixes: 199852418
Test: Tested w/ password + pin for gesture + 3 button
Change-Id: Ie7f16f737a8fc12328c05d7628d0e3ae09fc08ca
2021-10-06 18:09:15 -07:00
Bill Yi 3ec748654e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I86b517b1fa0abfc0f14c6ffc7edcd98c14552647
2021-10-06 21:31:18 +00:00
Sunny Goyal 0ecfb69596 Removing overscroll pluging support
Bug: 201677812
Test: Presubmit
Change-Id: Id8136e99746946ba840754ef8e71a4574f49938e
2021-10-06 11:23:46 -07:00
Tony Wickham cdb2df88bd Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev am: f9d2082cf3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15988588

Change-Id: I2a2f4c65e2cfc2649d5c590e7aa855b79f1f4b28
2021-10-06 17:48:39 +00:00
Tony Wickham f9d2082cf3 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev 2021-10-06 17:36:45 +00:00
Alex Chau aea42dc43e Only adjust min/max scroll for split screen in landscape
- Portrait's split placeholder is at top/bottom and does not affect scroll

Bug: 200537659
Test: Split left and split right in portrait / landscape, check if min/max scroll is correct
Change-Id: Ib7eb09d3cc44c8e0d962920ad094c73abc5f0dbd
2021-10-06 12:31:10 +01:00
Tony Wickham 66ed0ff23e Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
2021-10-05 18:14:51 -07:00
Vinit Nayak c8b7fef784 Merge "Reset state after split launch animation finishes" into sc-v2-dev am: 6ab0d1e7be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15986152

Change-Id: Iac00a062f0f3531fa1d59cb2e2ade6b17e7cb73c
2021-10-06 01:14:28 +00:00
Vinit Nayak 6ab0d1e7be Merge "Reset state after split launch animation finishes" into sc-v2-dev 2021-10-06 00:56:48 +00:00
TreeHugger Robot e77cae7f0d Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev am: 1bf753f7a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15947750

Change-Id: Id67d2342b0715896faa6832e59116b6ea42fcf05
2021-10-06 00:26:54 +00:00
TreeHugger Robot 1bf753f7a6 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev 2021-10-06 00:14:46 +00:00
Vinit Nayak 0516737146 Reset state after split launch animation finishes
Previously we were clearing SplitSelectStateController
state too soon for fake landscape case where
as soon as the tasks launch the device does a rotation
animation since the new split tasks are in landscape.
Move restting state after animation finishes.

Fixes: 201980666

Change-Id: I23efd59fad444c47ae6c2048888a8570f22610fd
2021-10-05 15:29:24 -07:00
Vinit Nayak 9b79688147 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev am: 0ff2ad6ff4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15956593

Change-Id: Ifc5c08374ce590e7c417be6355ae1abdfc36796b
2021-10-05 21:49:00 +00:00
Vinit Nayak 0ff2ad6ff4 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev 2021-10-05 21:44:34 +00:00
Vinit Nayak 95ee358269 Show split options when overview actions hidden for grid
* We hide split option in task menu for focused task
if the user hasn't scrolled at all in overview
* We show option when user has scrolled because then
the split option from overview actions will be hidden
* Mostly uses the same logic as
RecentsView#updateActionsViewFocusedScroll()

Bug: 201380373
Test: Manual
Change-Id: Ia8769a67cfbb2e4414cd4d8e816e62245fc4bd2c
2021-10-05 14:28:07 -07:00
Alex Chau 60818c3de0 Adjust min/max scroll according to mSplitPlaceholderSize am: 516584e648
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15982847

Change-Id: I8647b3135284dc504b3ac839f5191c26abf5d9b3
2021-10-05 18:13:46 +00:00
Pat Manning a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak 01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00
Alex Chau 516584e648 Adjust min/max scroll according to mSplitPlaceholderSize
- RTL is not handled yet due to split select broken

Bug: 200537659
Test: Split left and split right, check if min/max scroll is correct
Change-Id: I734d890bb955601da52cd806074014ed2e7eba55
2021-10-05 17:22:05 +01:00