Commit Graph

17450 Commits

Author SHA1 Message Date
Sebastian Franco dcf6bf2311 Moving the remainder of reorder logic to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I7203444df289cd3b67794fc570a2cd46e64549a2
2023-12-01 12:50:13 -06:00
Sebastián Franco f601447877 Merge "Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks" into main 2023-12-01 17:58:11 +00:00
Treehugger Robot 0cfbca60ab Merge "Move logic only used on the reorder from the cellLayout to ReorderAlgorithm" into main 2023-12-01 00:57:37 +00:00
Sunny Goyal 6f04a32b21 Merge "Revert "Removing unnecessary iconFactory class when generating b..."" into main 2023-11-30 23:55:59 +00:00
Stefan Andonian df7ea42299 Merge "Revert "Update launcher preview icons on themed icon update"" into main 2023-11-30 23:01:22 +00:00
Andy Wickham faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Stefan Andonian dd088daead Revert "Update launcher preview icons on themed icon update"
Revert submission 25242534-launcher-preview-update-themed-icon

Reason for revert: This change potentially breaks the launcher's database.

Reverted changes: /q/submissionid:25242534-launcher-preview-update-themed-icon

Change-Id: I90fd55695b24529752a82cb6bf001935204a53f7
2023-11-30 20:12:40 +00:00
Saumya Prakash 89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Jagrut Desai 7736ec8968 Merge "Decreasing the intensity of haptic feedback for taskbar invocation" into main 2023-11-30 19:29:45 +00:00
Tracy Zhou aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Sebastian Franco a7ff1558c9 Move logic only used on the reorder from the cellLayout to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I9909477274aadbbf928c9fdeb4157d697c4c7175
2023-11-30 11:14:57 -06:00
Sunny Goyal dad66f4188 Revert "Removing unnecessary iconFactory class when generating b..."
Revert submission 25483550-themed-badge

Reason for revert: b/314097390

Reverted changes: /q/submissionid:25483550-themed-badge

Change-Id: I7ad16d7c5d5457d350ac6cff86d512c2f57dbcbf
2023-11-30 17:09:41 +00:00
Jordan Silva 0734ef2d7c Merge "Revert "Make numFolderRows/numFolderColumns accept more values"" into main 2023-11-30 14:27:20 +00:00
Andreas Agvard 711f104409 Merge "Use NavHandleLongPressInputConsumer regardless of flags." into main 2023-11-30 13:32:00 +00:00
Thales Lima 09d42d5340 Revert "Make numFolderRows/numFolderColumns accept more values"
Revert submission 25438456-5x5_folder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25438456-5x5_folder

Revert "Use DeviceProfile numFolderRows and numFolderColumns"
Revert submission 25313018-numFolder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25313018-numFolder

Change-Id: I4890016e310c0a2122861f36fcdbf33e98e727c0
2023-11-30 11:47:37 +00:00
Anna Zhuravleva 94228b18db Merge "Add user_type field and log it in Launcher" into main 2023-11-30 10:28:45 +00:00
Tracy Zhou 6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Winson Chung abb4483f6f Merge "Add Launcher support for left-right splits on portrait foldables" into main 2023-11-30 05:52:57 +00:00
Jagrut Desai a5ad8bed64 Decreasing the intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ic8c28b8e84bf9f388a73c518c91840d958287546
2023-11-29 19:03:33 -08:00
Andy Wickham c0c420a3c2 Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag.
This controls whether a haptic is played when search invocation
starts. The assumption is that the search app will play this
haptic if the flag is disabled (default).

Test: Manual
Bug: 310659178
Bug: 314005577
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT DISABLED
Change-Id: I406c18cfaf27d004e19de26f00c997c0a03de996
2023-11-29 17:07:20 -08:00
Sebastián Franco 033a335801 Merge "Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-30 00:09:47 +00:00
Vadim Tryshev 54dbd42cae Merge "Waiting for Launcher activity to stop when starting a Launchable" into main 2023-11-29 21:57:45 +00:00
Vadim Tryshev 1b058fd467 Waiting for Launcher activity to stop when starting a Launchable
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I8bed0225617a225c2dc9587a75d004b98395fe1f
2023-11-29 13:55:46 -08:00
Sebastián Franco 61fbd18e5d Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 484a7ea4f3.

Reason for revert: Fixing build error 

Change-Id: I00dcbb831dc40a90d43ada7315969251413bb88b
2023-11-29 21:54:51 +00:00
Federico Baron f638d01063 Merge "Revert^2 "Update status bar scrim"" into main 2023-11-29 21:36:04 +00:00
Andy Wickham 3523154b07 Use NavHandleLongPressInputConsumer regardless of flags.
This way we can still log long press attempts even when the
feature flags or settings are disabled.

We always log LAUNCHER_LONG_PRESS_NAVBAR when a long press is
detected, even if nothing else happens.

Additionally, we log LAUNCHER_DEEP_PRESS_NAVBAR if the long
press was short-circuited by a deep press. In this case both
logs will appear.

If ENABLE_LPNH_DEEP_PRESS is false, it's possible that
LAUNCHER_DEEP_PRESS_NAVBAR will be logged without
LAUNCHER_LONG_PRESS_NAVBAR. This is because we log deep press
even if the feature is disabled, but it won't cause long press to
trigger immediately, so the user may release their finger before
the normal long press triggers.

Note: getLongPressRunnable will still return null if the flags or
other checks fail, so nothing will happen beyond logging.

Fix: 313477667
Fix: 310955078
Test: Manual with wwlogcat with flags in various states
Flag: NA
Change-Id: I40ceb5a22b364c2d5d6e4fdabb546b81c84354eb
2023-11-29 13:02:27 -08:00
Greg Kaiser 4144564af6 Merge "Revert "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-29 20:36:54 +00:00
Greg Kaiser 484a7ea4f3 Revert "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 6890893a24.

Reason for revert: Many build breaks, like https://android-build.corp.google.com/artifact/submitted/11157014/mokey_go32-trunk_staging-userdebug/latest/view/logs%2Fbuild_error.log , seem related to this.

Change-Id: I049c94fbd1e089c65fd4e0abb4ac2c165f228c92
2023-11-29 20:26:47 +00:00
Winson Chung 104a4c8b69 Add Launcher support for left-right splits on portrait foldables
Bug: 291018646
Test: Manual
Flag: enable_left_right_split_in_portrait

Change-Id: I92af7ffd83770f7e942c3892a12b1611ff5b50f4
Signed-off-by: Winson Chung <winsonc@google.com>
2023-11-29 20:20:14 +00:00
Sebastián Franco 1c1c18ca28 Merge "Moving rearrangementExists to ReorderLogic since it's only used there" into main 2023-11-29 19:18:18 +00:00
Sebastián Franco 1f04ea22b7 Merge "Enabling ENABLE_NO_LONG_PRESS_DRAG" into main 2023-11-29 19:17:14 +00:00
Sebastian Franco 7a08e54eed Enabling ENABLE_NO_LONG_PRESS_DRAG
This is a simple flag, I don't think it requires the new
flagging system, I mainly added the flag for ease of debugging
if it breaks test on postsubmit.

This flag was already tested using enabled but it was disabled
before trunk stable, I think we can set this to true without risk
and then remove the flag.

Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Fix: 299748096
Test: atest TaplDragTest
Change-Id: If99027d8cec7d75eee11012615da0e0d76951755
2023-11-29 10:09:57 -06:00
Anna Zhuravleva 9c20381231 Add user_type field and log it in Launcher
Add new field user_type to decouple
work_profile and private_space users.
Deprecate is_work boolean field.

Bug: 312200869
Test: statsd_testdrive 19, output: https://paste.googleplex.com/5912695996416000
Flag: NA
Change-Id: Idc25f341b4353a85b8a93eab97c88195895baedc
2023-11-29 10:26:53 +00:00
Sunny Goyal a481659e51 Merge "Merging widget item click listener to default click listener" into main 2023-11-28 21:36:15 +00:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Sunny Goyal 464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Jordan Silva 837fb91423 Merge "Validate responsive specs using more than 100% of remainder space" into main 2023-11-28 19:49:30 +00:00
Jordan Silva 2b5bac90b8 Merge "Update where responsive grid cell icon size is defined" into main 2023-11-28 19:48:43 +00:00
Sunny Goyal eb67c99e5f Merge "Removing unnecessary iconFactory class when generating badged icon" into main 2023-11-28 19:02:02 +00:00
Vinit Nayak 2349efe50d Merge "Revert "Add logs for workspace long press"" into main 2023-11-28 18:51:23 +00:00
Holly Jiuyu Sun b265cf8fdd Merge "[PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom." into main 2023-11-28 18:41:00 +00:00
Andy Wickham 9e6f276d41 Merge "Adds withPackageName to StatsLogger creation" into main 2023-11-28 17:15:55 +00:00
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Jordan Silva 4c09958671 Validate responsive specs using more than 100% of remainder space
Fix: 313463517
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveSpecsProviderTest
Change-Id: Ic80846d27dabd8d57f43b35581174bd2f2f3611b
2023-11-28 15:11:27 +00:00
Jordan Silva 15cacd54c6 Update where responsive grid cell icon size is defined
This CL changes where the cell icon size, text size and drawable padding is defined to prevent an issue with taskbar.
The transient taskbar updates the DeviceProfile icon size with a different value than used for responsive grids, and this update wasn't working anymore because responsive grid implementation wasn't reading the value from iconSize inside the updateIconSize function, but from the responsive grid spec.

Bug: 313463280
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: manual
Test: NexusLauncherImageTests
Change-Id: I835a90d724c2d1b2d32f483b758b789be7cbdcfe
2023-11-28 14:42:06 +00:00
Thales Lima 5fc47806f8 Merge "Make numFolderRows/numFolderColumns accept more values" into main 2023-11-28 11:22:27 +00:00
Holly Sun 454590d7ea [PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom.
UX spec: https://carbon.googleplex.com/google-material-3/pages/easing-and-duration/tokens-specs/bd8df608-11ee-48f9-b93d-90d74e3d35c8#5fa37127-0934-4c47-804e-cb2fbf47f73d. Use the first column "Emphasized" one.
Duration: 500ms

video: https://drive.google.com/file/d/1EYlkWVgiYFy0IB5WnQRVoQ9b_sbEkLj7/view?usp=sharing

Bug: 309522136
Test: manual
Flag: ACONFIG com.google.android.apps.nexuslauncher.inject_private_space_tile DEVELOPMENT
Change-Id: I178c075ebf5db8338f476d0607caabec7b8c7fde
2023-11-27 16:42:33 -08:00
Sebastián Franco 463131427d Merge "Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout" into main 2023-11-28 00:27:21 +00:00
Vinit Nayak fd66d09e94 Revert "Add logs for workspace long press"
This reverts commit 74fb544c27.

Reason for revert: b/311099513 is now no longer flaky. I suspect these logs may have improved a possibly existing race condition. Let's see if the flake returns w/o these logs.

Change-Id: Ib3a06b7d86f4eb5c3c95db9a68bc6eb15aead193
2023-11-28 00:22:02 +00:00