Commit Graph

49755 Commits

Author SHA1 Message Date
Xin Li 652b9b55d8 [automerger skipped] Merge SP2A.220305.012 am: 11a0454879 -s ours am: 2f4f77fdbc -s ours
am skip reason: Merged-In I51cb81718a489ad7568c5e05ace0b3dbc6ca5443 with SHA-1 0077caa15d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16872102

Change-Id: Ifb4f453ee15abcbd88169810dac11164a9cc8a20
2022-02-15 00:35:24 +00:00
Xin Li 2f4f77fdbc [automerger skipped] Merge SP2A.220305.012 am: 11a0454879 -s ours
am skip reason: Merged-In I51cb81718a489ad7568c5e05ace0b3dbc6ca5443 with SHA-1 0077caa15d is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16872102

Change-Id: Ife61a6188c19b497fda7df645caa549e4d90835a
2022-02-15 00:14:51 +00:00
Android Build Coastguard Worker 62d30d71f4 Merge cherrypicks of [16685428, 16688543, 16684091] into sc-v2-release.
Change-Id: If86b1acade6ad30900ecf35f9dc7b9afa223723e
2022-02-14 23:13:59 +00:00
Jon Miranda e44c403710 Fix bug where back swipe to icon in All Apps search result.
Issue is that All Apps is scaling during the animation, so when
FloatingIconView looks for it in the view hierarchy,
it's not in its final position.

This would be the cleanest approach for a scv2 fix

Bug: 213306709
Test: manual
Change-Id: Iaec77d15c9533edccd9c82164143af8fa522158f
Merged-In: Iaec77d15c9533edccd9c82164143af8fa522158f
(cherry picked from commit db767aa575)
Merged-In:Iaec77d15c9533edccd9c82164143af8fa522158f
2022-02-14 23:13:13 +00:00
Winson Chung 3db7cd137e Add fallback for missing remote animation callbacks
- In some cases WM won't callback the remote animation callbacks (neither
  start nor cancel) and Launcher never finishes executing the pending
  command (preventing the subsequent commands from running).  For the time
  being, just cancel the current state to allow the commands to be
  processed.

Bug: 194011186
Test: Mash on overview and home buttons with a 3p launcher

Signed-off-by: Winson Chung <winsonc@google.com>
Change-Id: I1b1296fab316b979f441ebb474d1475e3fa68f95
Merged-In: I1b1296fab316b979f441ebb474d1475e3fa68f95
(cherry picked from commit bb530e9058)
Merged-In:I1b1296fab316b979f441ebb474d1475e3fa68f95
2022-02-14 23:13:10 +00:00
Winson Chung ab5f39bdc0 Dispatch hover events through the input consumer proxy
- Touch explore uses hover events to focus views for accessibility, but
  we were dropping these events when handling them through the input
  consumer proxy.  The reason this changed is that in sc-v2 we moved the
  recents input consumer to the top of the task display area to ensure
  that it was always above any of the tasks in splitscreen, but by doing
  so, it was always above launcher even after settling in overview.  The
  existing path for handling motion events is heavily tied to touch
  handling (action down/move/up) so we just add a separate path for
  dispatching hover events through the normal mechanism to launcher via
  the consumer.

Bug: 197043796
Change-Id: I5f8cfd357ff13971fe172ce1d0179535479cd26c
(cherry picked from commit eff9a120c6)
Merged-In:I5f8cfd357ff13971fe172ce1d0179535479cd26c
2022-02-14 23:13:07 +00:00
Jon Miranda b2670d2051 Init FloatingIconView properties before fetching drawable.
& Make sure properties are reset when recycled.

This fixes the bug that causes BubbleTextView drawable not to get set.

Bug: 207389002
Test: locally disable loading AdaptiveIcons, ensure BubbleTextView
      drawable always gets drawn for closing animation

Change-Id: Ifdbf3e733e27918c57a5e9b23e5a11b65f8f338c
2022-02-14 14:43:32 -08:00
Xin Li 11a0454879 Merge SP2A.220305.012
Bug: 219523960
Merged-In: I51cb81718a489ad7568c5e05ace0b3dbc6ca5443
Change-Id: Icf0cc432ab3a97614b27efcf6fc9d18ea423a743
2022-02-14 20:06:39 +00:00
Brian Isganitis 099945b075 Add predictions row to taskbar all apps.
- We need to listen to DeviceProfile changes in case the number of
  columns changes in the grid. I made an interface/mixin separate from
  ActivityContext to avoid polutting the latter with too many things. I
  also applied this change to existing taskbar A-Z grid.
- Added all apps visited count to onboarding preferences for only
  showing "All Apps" label in place of divider 20 times. Label is also
  tracked on taskbar side and should be kept in sync.

Test: Manual
Fix: 216843395
Bug: 174174514
Change-Id: I97aa91397c334123626caf18251f19e17c7104fb
2022-02-14 11:24:16 -08:00
Alex Chau 8c3cb4e324 Merge "Fix restore not migrating to new grid" 2022-02-14 18:57:47 +00:00
TreeHugger Robot 4bbfcbd337 Merge "Not postponing expecting Pilfer when swiping to overview." 2022-02-14 18:35:20 +00:00
Xin Li 52bbb8d1ba [automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: bbd9e79bf2 -s ours am: 75cf4399c8 -s ours
am skip reason: Merged-In Iec90538bf8dd18fede035d7f548a71b757d2356c with SHA-1 88c671ee71 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16845246

Change-Id: I2b7748f05b6ef762d4b16a7646d610caaa01f607
2022-02-14 18:20:51 +00:00
Xin Li 75cf4399c8 [automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: bbd9e79bf2 -s ours
am skip reason: Merged-In Iec90538bf8dd18fede035d7f548a71b757d2356c with SHA-1 88c671ee71 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16845246

Change-Id: I37bb26275648a1835ef15bfb2b9175c60df6e504
2022-02-14 18:03:27 +00:00
TreeHugger Robot bf96683e46 Merge "Fix taskbar hotseat alignment" 2022-02-14 13:03:46 +00:00
Alex Chau bf63e9cf2b Merge "Add debug logs for testPromiseIcon_addedFromEligibleSession" 2022-02-14 11:38:57 +00:00
Tom Natan 7823e8b5b6 Merge "[11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING." 2022-02-13 12:20:57 +00:00
Tony Wickham 1c51edcef3 Merge "Only show unstash feedforward hint when long press will unstash" 2022-02-12 20:22:38 +00:00
Tony Wickham 9b2b607a09 Fix taskbar hotseat alignment
- Use hotseatBorderSpace instead of cellLayoutBorderSpace
- Also divide by 2f instead of 2 because AS was complaining. May or may not potentially address off by 1 pixel issues.

Test: locally set alignment = 1, ensure perfectly aligned
Fixes: 218880076
Change-Id: Ifec30e6727f62985427b65b6c0b0810e7f7cd695
2022-02-12 19:23:23 +00:00
vadimt 2dd23a0466 Not postponing expecting Pilfer when swiping to overview.
TAPL was expecting pilfer upon UP in the swipe-pause-to-overview gesture.
Actual Pilfer happens earlier, which resulted in wrong sequence-mismatch diags if the gesture fails before UP.
Now expecting Pilfer earlier.

Also fixing a problem that sneaked through earlier reviews when even down time was passed incorrectly.

Bug: 187761685
Test: presubmit
Change-Id: If4289a011247bf7801405ecaac8befa8461e8a37
2022-02-12 01:57:13 +00:00
Thiru Ramasamy 5ed87e4c96 Populate search attributes only if the atom's has DeviceSearchResultContainer.
Bug: 199495917, 218973952
Test: https://android-build.googleplex.com/builds/abtd/run/L37100000953023420
Change-Id: I355b4ec0806755f6c72d59b04555b970ca1578f5
2022-02-12 00:57:33 +00:00
Thiru Ramasamy 84a7fee8af Reverting the change that causes test breakage
Bug: 218973952
Test: wwdebug && wwlogcat
Change-Id: I494608ba3df31e9129dc47fc016a7e077e506165
2022-02-11 11:03:09 -08:00
Alex Chau 29a96adaab Fix restore not migrating to new grid
- In reinitializeAfterRestore, use db path instead of grid name to check if migration is necessary, so migration will still happen if grid names are renamed. Also, only remove the target db path instead of all non source db paths, which are not necessary to be removed.
- In LauncherBackupAgent, remove old files before restoring to avoid old files from overriding restored files e.g. grid name in shared preferences
- Make sure InvariantDeviceProfile is intialize before we set pending to false, so unsupported grids can still be initialized and then be migratead
- Renamed 6x5 grid so it no longer collides with 4x4

Fix: 218500583
Test: Restore backup from supported and unsupported grids
Change-Id: Ic78e0bc7dc44ad86bd217c736b88708ad488ac0b
2022-02-11 18:15:06 +00:00
Alex Chau bf57c15750 Merge "Avoid AllApps bottom sheet from being and add collapse handle" 2022-02-11 11:07:25 +00:00
tomnatan 9f12373bdd [11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING.
The setting is set to 1 if the taskbar education should be shown as soon as the animation for opening an app starts and is set back to 0 when the taskbar education window is detached from the window.

Bug: 214590804
Test: N/A
Change-Id: Id26e3051a6e0ef1f9c2dcbeef98710efbb4df54f
2022-02-11 10:28:51 +00:00
Xin Li bbd9e79bf2 Merge sc-v2-dev-plus-aosp-without-vendor@8084891
Bug: 214455710
Merged-In: Iec90538bf8dd18fede035d7f548a71b757d2356c
Change-Id: Icfcc0dcab0a30472a6faff67e67e364386b98d41
2022-02-11 07:28:32 +00:00
Riddle Hsu adfdfd8868 Merge "Set launch source info for shell recents animation" 2022-02-11 06:33:18 +00:00
Jeremy Sim b84462a6b4 Merge "Fix DWB placement in grouped task view" 2022-02-11 06:22:40 +00:00
TreeHugger Robot b82a517fee Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev am: 3ba95852f3 am: 5cf55827da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16359044

Change-Id: I043288685528d6430f38b93e19e468069071a503
2022-02-11 02:45:13 +00:00
TreeHugger Robot 5cf55827da Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev am: 3ba95852f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16359044

Change-Id: I01ee5a75a82798c002798d91538ecee0d455277b
2022-02-11 02:25:05 +00:00
TreeHugger Robot 3ba95852f3 Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev 2022-02-11 02:11:50 +00:00
Jon Miranda 701774d021 Add debug logs for testPromiseIcon_addedFromEligibleSession
Bug: 202985412
Test: PromiseIconUiTest
Change-Id: I160b9229bebe07015575f8184ac2d53bcbf2bad0
2022-02-10 17:26:11 -08:00
Tony Wickham 31a4c539d0 Only show unstash feedforward hint when long press will unstash
Test: Long press to unstash while in an app still works and shows feedforward; long pressing handle while in overview, all apps, or when IME is showing doesn't show anything.
Fixes: 218902248
Change-Id: I2c96570cab018c0e63c446793b84b210964bdb94
2022-02-11 00:29:56 +00:00
Evan Rosky 693f4e78bb Switch pip to fixed-rotation in shell transitions
Pip fixed-rotation should also be active when shell-transitions
is using fixed-rotation.

Bug: 217560545
Test: enter landscape pippable, enter pip (eg. via swipe-to-home)
Change-Id: I9bfbc1efc230a94dd9a480195e3a6ddf712ab353
2022-02-10 16:16:12 -08:00
Jeremy Sim c78ac6277c Fix DWB placement in grouped task view
In grouped task view, DWB banners will now rotate properly when phone is
in landscape or seascape orientation. Also fixes a couple of minor
existing issues with the bottom task not displaying correctly in the
first place.

Fixes: 208357326
Fixes: 216218406

Test: Tested locally on Pixel 6, using landscape, seascape, and
portrait. Double-checked with task proportions changed, RtL/LtR, and
split top/split left/split right initialization.

Change-Id: I945f9937d2d4d784c0c74a006c7d0680daf628c2
2022-02-11 00:13:13 +00:00
Thiru Ramasamy 70f3f86702 Merge "Populate LauncherUiChanged.search_attributes field." 2022-02-10 23:35:49 +00:00
Daniel Chapin 65fc27d5cb Merge "Work folder name is only fetched from activity, not ActivityContext" 2022-02-10 22:23:17 +00:00
Alex Chau fb54cf54e3 Avoid AllApps bottom sheet from being and add collapse handle
- Instead of using top margin, use top padding instead
- Add a separate LinearView for the bottom sheet background
- Added a handle to bottom sheet background that handle touches

Bug: 208599118
Test: phone, tablet and taskbar
Change-Id: Id8d3cb5ee6c58193926e2cf5ea7b0cb2280098be
2022-02-10 20:03:56 +00:00
Evan Rosky 19f7d988d1 Merge "Use fixed-rotation by default for shell transitions" 2022-02-10 19:51:45 +00:00
thiruram 103ccf1d87 Populate LauncherUiChanged.search_attributes field.
Test: Manual
Bug: 199495917
Change-Id: I9a7f9696d44b5b2af8d11e7f537b5c4ed78db060
2022-02-10 08:29:39 -08:00
Riddle Hsu 53e864d118 Set launch source info for shell recents animation
In legacy animation, it was set in RecentsAnimation
#startRecentsActivity. Now because shell transition use
startActivity, it can be set directly to the options.

Bug: 218847872
Test: adb shell setprop persist.debug.shell_transit 1; reboot
      Enable statsd log: "adb shell cmd stats print-logs"
      Swipe up gesture navigation bar from an app.
      adb logcat | grep statsd | grep "(48)"
      The line may contain 0x100000->4[I] 0x110000->20[I]
      that means 4=by recents and 20=latency 20ms.
Change-Id: Ia7bef23f8dc6cbf371cd1cdfb42f1f68d88d0787
2022-02-11 00:08:27 +08:00
Vinit Nayak 25e61b2606 [automerge] Add null check for null task in getItemInfo() 2p: 73c6288038
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828919

Change-Id: I205452840d664917ad1b61d3daec717f211a8ef2
2022-02-10 00:01:19 +00:00
Vinit Nayak 73c6288038 Add null check for null task in getItemInfo()
* Pass back an empty WorkspaceItemInfo with correct
itemType set on it so at least it can be identified
if remaining fields are missing.

Fixes: 218625473
Test: Wasn't able to repro crash
Change-Id: If20d8fa648edf6c210ad5398905bf78e173b23a1
2022-02-09 15:59:13 -08:00
Vinit Nayak 5c6173a8b9 [automerge] Add null check for mRemoteTargetHandles for side task launch 2p: 90e0fe3923
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: I8d41d76a5178c15beca5028291fc0a314a580de3
2022-02-09 23:31:57 +00:00
Vinit Nayak 90e0fe3923 Add null check for mRemoteTargetHandles for side task launch
* Other checks haven't changed, only pulled them out into
separate block

Fixes: 215699962
Test: Unable to repro the crash, I tried ending the
activity and starting via adb shell, but I was never
able to get into the original if-block that triggered the NPE

Change-Id: I83320634f1d059de610176f9031682ca287bd589
2022-02-09 15:30:19 -08:00
Winson Chung 6992855742 Merge "Add basic return animation when drag is canceled" 2022-02-09 19:32:22 +00:00
Winson Chung d937831791 Add basic return animation when drag is canceled
Bug: 179390870
Test: Drag, but don't drop to split an app from the taskbar and
      check that Launcher animates the surface back into place
Change-Id: I726855ff5bdffd1fc58d2839b3cc44b3fdb131e9
2022-02-09 06:44:21 +00:00
TreeHugger Robot e8b200eb6b Merge "Fix NPE when mRecentsView is null" 2022-02-09 05:04:57 +00:00
Jon Miranda 32319bf166 Merge "Move All Apps button to the left in RTL." 2022-02-09 01:55:36 +00:00
TreeHugger Robot fb1e592020 Merge "Prediction icons in Taskbar were updating when dragging icon in the same place" 2022-02-08 19:54:08 +00:00
Hyunyoung Song 57810aefa4 Work folder name is only fetched from activity, not ActivityContext
Bug: 217872881
Test: builds
Change-Id: I36bc9c386772c20fce2d10bf1bfaad565046d38f
2022-02-08 10:25:21 -08:00