PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
49,755 Commits 1 Branch 0 Tags
dcafe99d42ff8ae1e31fed8bbad996fce34c965f
Commit Graph

49755 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andy Wickham 73dfd548ca Merge "Adds Search Onboarding count and renames existing edu pref." into tm-dev am: 833b0a0b5b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17876281

Change-Id: I58f6fbef62ad446c4c0e9f0d923dc15f3a125b87
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-25 00:51:38 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast. 
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
 2022-04-24 17:36:48 -07:00
Andy Wickham 833b0a0b5b Merge "Adds Search Onboarding count and renames existing edu pref." into tm-dev 2022-04-25 00:26:51 +00:00
TreeHugger Robot 4ebc61e76a Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I5a02a4c0d0d22655559100c95998ceec0f7a752b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 03:56:23 +00:00
TreeHugger Robot 9c3bd94b48 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I3083e1b4d5e9556b0152b8229658575e403ca76a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 03:24:58 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham 96c5c67dca Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I0471cb6feb14e517dea2ca0a07445335ecee45a5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 01:47:33 +00:00
Tony Wickham cc10db044f Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Id798f042e7cc39d76fb3e4ce8c7ffbf2a54184fd
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 01:18:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized 
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
 2022-04-22 17:28:35 -07:00
Tony Wickham b0b89c7f00 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: 9de10ff889 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I56e8a873e333b1470eddddb73157ace4eb531bb7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 23:43:01 +00:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial. 
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
 2022-04-22 16:37:49 -07:00
Tony Wickham 9de10ff889 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I6c01f58f282234ce2e85a582a25a442ba7c7d9d2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 23:19:24 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere eef266fe39 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: 78194ca6ad 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I2d68fd2a3348c2ca7bede5a189e93c14b34b8826
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:20:47 +00:00
Sunny Goyal 8fbfd8ecf8 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: d99aee90ef 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I7ca9e432376e4533a1643187c51ab3545f25c465
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:20:32 +00:00
Santiago Etchebehere 78194ca6ad Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I7e56d7a2f10052f9cb0a3ef6e83e33aa4024f493
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:11:04 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal d99aee90ef Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Id8a4e2f0a5b45267b8386f22b15639f232e93460
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:03:22 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview" 
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
 2022-04-22 21:02:22 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim fb8907517c Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: cca5e510fd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: Ie12e347f3d58730d4a0ae5ed9c4c92fbfcace800
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:21:14 +00:00
TreeHugger Robot f06f6e7f1d Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: e17589f4b8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: Ib73e94fdb7f113ba0838b857817648520d91bb02
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:20:50 +00:00
Sunny Goyal 45df9454a8 Merge "Revert "Removing some unused code from All-Apps"" into tm-dev am: b1f6a3fe97 am: fdda22953d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17917348

Change-Id: I298e1d6103c1445e1778e51a82045572309fc422
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:20:32 +00:00
Tony Wickham cf6b7e2dd9 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 44e65099c2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: If17f49f0227f14bdbbd72a8c7480b7a27eacc73a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:20:01 +00:00
Sunny Goyal 9bab249078 Merge "Removing some unused code from All-Apps" into tm-dev am: a938cc27a2 am: 094aba941b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17867143

Change-Id: I9b6968446fa89da8b3bbf198e18c5daebb302664
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:19:51 +00:00
Jeremy Sim cca5e510fd Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I18ac8925b7cf520d4d123c6648dc0e7cbaf2a862
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:10:47 +00:00
TreeHugger Robot e17589f4b8 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: If978a1789f76f0edbc8259031c42f9fe94438dc9
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:10:37 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Sunny Goyal fdda22953d Merge "Revert "Removing some unused code from All-Apps"" into tm-dev am: b1f6a3fe97 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17917348

Change-Id: I100804cf91d0fd450557c6e6f8cbd02a777778c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:02:59 +00:00
Tony Wickham 44e65099c2 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I437518bf5b439cf7918ffe42d4bfdf9971207e3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:02:21 +00:00
Sunny Goyal 094aba941b Merge "Removing some unused code from All-Apps" into tm-dev am: a938cc27a2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17867143

Change-Id: Id83118884e84bbdea0f938942d077d410d7364ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:02:02 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled 
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
 2022-04-22 19:58:40 +00:00
Sunny Goyal b1f6a3fe97 Merge "Revert "Removing some unused code from All-Apps"" into tm-dev 2022-04-22 19:55:42 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
Sunny Goyal 13ae6784b5 Revert "Removing some unused code from All-Apps" 
Revert submission 17866780-cancel-request

Reason for revert: wrong icons

Reverted Changes:
Iedc98e5ef:Cancelling previous request and clearing UI when a...
I72394fb42:Removing some unused code from All-Apps

Change-Id: I2ecefcaf07e6105a10f86b8dc19f75089e45a3e0
 2022-04-22 19:53:37 +00:00
Sunny Goyal a938cc27a2 Merge "Removing some unused code from All-Apps" into tm-dev 2022-04-22 19:40:06 +00:00
TreeHugger Robot 3c2956abcc Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: 0e46bac72f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I0303221c25206ae054099019d0426b40794cfd73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 18:19:35 +00:00
Alex Chau a053005db5 Update pull back animation for tablet AllApps am: e3b806366a am: a6f8f85436 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I79e4523321a3ac8a5d6f806bc075f02bebf29230
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 18:18:57 +00:00
TreeHugger Robot 0e46bac72f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: Ie2e30df6666338626d6d4575ac68572dba305c43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 17:53:48 +00:00
Alex Chau a6f8f85436 Update pull back animation for tablet AllApps am: e3b806366a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If9173888b7e3a0680001eed885aa88bd7d93a69a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 17:53:25 +00:00
TreeHugger Robot 37fa1392ec Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev 2022-04-22 17:33:06 +00:00
Sunny Goyal 7b8d63fcf8 Removing fade in logic during load. 
Launcher already blocks the draw during load, which ensures
that system draws the loading screen. Additional fade animation
is not visible since the Launcher window is already getting fade in

Bug: 199120420
Bug: 199120420
Test: Verified on device

Change-Id: I7089cea4c5f97f6ef92eabcba56451de407c98b8
 2022-04-22 16:35:40 +00:00
Alex Chau e3b806366a Update pull back animation for tablet AllApps 
- This is a follow-up of http://ag/17636490
- Introduced animation property specifically for pullback translation and alpha, which will invoke getRecyclerViewContainer directly on tablet, and invoke aggregate setter of appsView on phones
- Delay reset of pullback animation to after dismiss animation to avoid jump in value during state transition animation
- Introduced property factory for addictive properties similar to MultiScalePropertyFactory

Fix: 220345008
Test: manual on small and large screen
Change-Id: I7b5c0019c1d4d36c3c7ca4ec79e38e4eb09c32ca
 2022-04-22 16:27:25 +01:00
Pablo Gamito a9e9c667b4 Use shared background color animation for settings activity 
Test: check that the launcher home settings activity transitions use the clear color activity animation with the correct background color

Bug: 229898866
Change-Id: Ic96ceb0fdbd6c4f10b411492dc5be18e979796c8
 2022-04-22 11:39:53 +00:00
TreeHugger Robot 76a1a392b4 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev am: f2889ed9c8 -s ours am: 3a16087bab -s ours am: 4db516ef71 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17880720

Change-Id: Ibc21d7736606bdb52e47150b8380dd3d6668fa45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 08:57:02 +00:00
Bill Yi 0a702fb73f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e7af40c247 -s ours am: 7fd03c663a -s ours am: 71ebfd65fa -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17880720

Change-Id: I1905ea7fd6813543fae067f4d4dfa4d52d71191d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 08:56:44 +00:00
TreeHugger Robot 4db516ef71 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev am: f2889ed9c8 -s ours am: 3a16087bab -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17880720

Change-Id: Ibe5ab30204aad331e19a6556872c6a4557dae80c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 08:19:45 +00:00
Bill Yi 71ebfd65fa [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e7af40c247 -s ours am: 7fd03c663a -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17880720

Change-Id: I7113eeeb917aa3f3b9d3cb4d8fd8e41a2281b5ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 08:19:24 +00:00
TreeHugger Robot 3a16087bab [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev am: f2889ed9c8 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17880720

Change-Id: I7a88a6287a2f906d42277ede533b944e3970441a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 07:52:22 +00:00