Commit Graph

49755 Commits

Author SHA1 Message Date
Alex Chau 4ffebaa68c Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev am: a2ecf75082 am: 9899c3f028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580266

Change-Id: Ib8da8d3fa08aad0335b9d5cfcf50e2a5c2f12dbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:01 +00:00
Alex Chau 7ca1b38d7e Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: Ib3aa90d2bf6cf8f2d563d02047f47e304245ea1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:05:04 +00:00
Alex Chau 9899c3f028 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev am: a2ecf75082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580266

Change-Id: I827fe7997db6451a188a17db32e601672d2badb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:05:03 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau 158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Alex Chau e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
wilsonshih 2b06fa518b Cancel the recents animation for locked gesture[2/2]
When device is locked and going to finish the recents animation,
instead of start home activity, calling
finishRunningRecentsAnimation directly so core and shell does not need
to handle another transition.

Bug: 230582311
Test: enable shell transition. Start showWhenLocked activity while
keyguard showing. Scroll up to dismiss the activity and verify the
activity and home shall be stopped and only keyguard remains on the
screen.
Also verify entering recents works fine when device is unlocked.

Change-Id: Ic76f81efcaa8ed00d5af1475259ec16659f6b568
2022-05-25 12:57:32 +08:00
Brian Isganitis 5b8e3dd34e Check if event is over All Apps correctly on large screens.
Test: Manual
Fix: 232826650
Change-Id: Ia6a0aefe1a2886ba21150c7d65be5c5d95f18141
2022-05-25 00:19:11 +00:00
Sunny Goyal cdc111a158 Creating the transaction on the UI thread
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error

Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Stefan Andonian ed2340ac0b Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev am: 748195421c am: 6213c103eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579642

Change-Id: Ic79998268e0194dc2cd723ba66d8d9d819343e62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 23:48:27 +00:00
Stefan Andonian 6213c103eb Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev am: 748195421c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579642

Change-Id: Iccd16094411f92dadcb0290ba0b2d7eab8f73609
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 23:11:22 +00:00
Stefan Andonian 748195421c Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev 2022-05-24 22:47:50 +00:00
Sunny Goyal 51cbd323e2 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316 am: 57a956911c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212

Change-Id: I63c8780cd914488282f1159037e3d6e31bbd87da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 22:15:02 +00:00
Bill Yi 16026ae9f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1d33db6f290ae068d29aea6a405cd0436c3d5341
2022-05-24 14:51:03 -07:00
Bill Yi dbaeaa5c05 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8dab647a81e5f333a8c4d9ad5dbe13247429f7c1
2022-05-24 14:49:54 -07:00
Sunny Goyal 57a956911c Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212

Change-Id: I93b35cc939115511c4a8e17736ddd4029d5cd350
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 21:39:52 +00:00
Nicolò Mazzucato dff1a938e1 Merge "Fix flakiness in getIconPosition test" into tm-qpr-dev 2022-05-24 21:33:01 +00:00
Sunny Goyal 689b000316 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev 2022-05-24 21:13:00 +00:00
TreeHugger Robot 03b821a8f2 Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev am: 69149d07ff am: 0210441e55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580078

Change-Id: Ia134caf82253fa4d00e5dba1d7a6ff4488c5f467
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 20:56:35 +00:00
TreeHugger Robot 0210441e55 Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev am: 69149d07ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580078

Change-Id: I23aea31514feac769609ae1b1093421accab94d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 20:27:22 +00:00
TreeHugger Robot 69149d07ff Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev 2022-05-24 19:52:32 +00:00
Schneider Victor-tulias aa5ae621c5 Add screen recording to drag to splitscreen taskbar tests to help with debugging.
Test: presubmit and local
Bug: 231615831
Change-Id: I87ea5eb30eaf9ec1f4f96572c78bc9daf976a589
2022-05-24 11:46:31 -07:00
Vinit Nayak 7608cfd628 Hide taskviews when animating to split
* Move FloatingTaskView to drag layer to
keep it from showing up on top of the
TaskMenuView that is animating to a close

Bug: 232804154
Change-Id: Ifaa3286c48509d1f60a559bb4d318988a1d30679
2022-05-24 18:41:42 +00:00
Sunny Goyal 1fa184c778 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev am: f7a48aae65 am: 6bea7c51d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18493941

Change-Id: I7274fde74b9c37b997546fc00f38cc85c8bd74f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:35 +00:00
Stefan Andonian 058c88bfce Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I30e4c6c0884721519ecf5167f0b8c6aa68c18911
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:30 +00:00
Brandon Dayauon ded505e5d5 Merge "Fixes scroll bar issues." into tm-dev am: 6bb327888e am: 6c5ad138d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18566198

Change-Id: I95f22eda8f30537002b2f5b001eedae6876cf4d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:24 +00:00
Anushree Ganjam 1b5a2333fb Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev am: 223bfe0908 am: 5b39a7db99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18570019

Change-Id: I7562458f5f5e47d13bb016f0a4fe6e9034c3e77e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:15 +00:00
TreeHugger Robot 913831282f Merge "Fix widget span" into tm-dev am: ec3723beb1 am: 97e2f47199
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579283

Change-Id: I632a9104fd8e22312b40f51b7dd572fe16acccad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:06 +00:00
Schneider Victor-tulias 2edbe23513 Update vibrations in the All set page to match the SUW welcome page.
Fixes: 211844049
Test: opened the all set page on different devices, tested with different supported vibration effects
Change-Id: I0b86dae3bec28ff56a3a23f9bb65dcbdb1b27325
2022-05-24 18:30:11 +00:00
Sunny Goyal 6bea7c51d8 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev am: f7a48aae65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18493941

Change-Id: I97f1d3980c1c5856ba628e8429fa3d5b24420e1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:25:26 +00:00
Stefan Andonian 2e8f2e192b Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I44d1b4d98035645e7046a1d8846ef288ad4b6a4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:25:18 +00:00
Stefan Andonian 45fc301b0e Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
(cherry picked from commit 83bc5f5050)
2022-05-24 18:21:33 +00:00
Sunny Goyal f7a48aae65 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev 2022-05-24 18:21:24 +00:00
Stefan Andonian af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Brandon Dayauon 6c5ad138d4 Merge "Fixes scroll bar issues." into tm-dev am: 6bb327888e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18566198

Change-Id: Ia403e2c65047bc421a54e42b3ef51f48748e61de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:17:37 +00:00
Brandon Dayauon 6bb327888e Merge "Fixes scroll bar issues." into tm-dev 2022-05-24 18:10:42 +00:00
Anushree Ganjam 5b39a7db99 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev am: 223bfe0908
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18570019

Change-Id: I00bf6a41aa597dfe371603a5119359bb37b8f28d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:08:29 +00:00
TreeHugger Robot 97e2f47199 Merge "Fix widget span" into tm-dev am: ec3723beb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579283

Change-Id: I4d8be05de0358c94d2f401db6bd7b579d4a2aca2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:08:11 +00:00
Anushree Ganjam 223bfe0908 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev 2022-05-24 17:38:08 +00:00
Alex Chau 5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot ec3723beb1 Merge "Fix widget span" into tm-dev 2022-05-24 17:31:13 +00:00
Sunny Goyal 425bfa320f Fixing ConcurrentModificationException in FirstScreenBroadcast
Bug: 232333237
Test: Not sure, unable to reproduce
Change-Id: I3eeabf76c14651d2fb64c82955851efa883760ce
2022-05-24 09:17:39 -07:00
Brandon Dayauon c472da1e5e Fixes scroll bar issues.
Fix issue where the letter bubble stays showing. Now it is able to disappear.
Fix fast scroll so its smoother and able to grab

Bug: 233607012
Bug: 233076260
Test: Manual
Change-Id: Ieccc72079602f4606da6ded7ee48d82440882ef7
2022-05-24 08:50:07 -07:00
Thales Lima 4f3cf5d05f Fix widget span
Need to take the horizontal margin of the view into consideration.

Fix: 233302799
Test: manual
Change-Id: I5f584977db85d5436b22c3701f586a5b079099ae
2022-05-24 14:49:26 +01:00
Nicolo' Mazzucato 25b36f7716 Fix flakiness in getIconPosition test
After uninstalling the app, it was disappearing after some time. For this reason, tryGetWorkspaceAppIcon was still returning it after the uninstall.

Fixes: 232009313
Test: atest TaplTestsLauncher3
Change-Id: I62e3a8f9a481e9786a136b6c00051c1025ab5b32
2022-05-24 09:42:24 +00:00
Cherry Ng d89f704671 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev am: 6a4ea4c849 am: f05363a7d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18568158

Change-Id: I2c64a8cb9bd2397b74b2d99aee65838a2b70df3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 02:50:04 +00:00
Cherry Ng f05363a7d4 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev am: 6a4ea4c849
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18568158

Change-Id: I9492ed07aacb0a31eb64bd9f2dbaf6cbd7ae69be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 02:34:59 +00:00
Anushree Ganjam 13b3922af9 Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."
Revert submission 18568158-revert-18500283-dismissEduCard-SCFTOPONPS

Reason for revert: b/233680944 , This is a build merger issue. 
Reverted Changes:
Ia39781c78:Revert "Add "incrementEventCountBy" function to On...
Ibba14f7c2:Revert "Save the value to sharedPreference When ed...

Change-Id: I1c0e4be10cf7e9b21623a056604618cbea2639d4
2022-05-24 02:19:57 +00:00