Commit Graph

49755 Commits

Author SHA1 Message Date
Jeremy Sim 1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Tony Wickham 06e5728c7e Merge "Set FLAG_RESUMED = false when expanding PiP" into tm-qpr-dev 2022-07-28 18:57:22 +00:00
Sunny Goyal 42b640404a Removing tabWidth calculation and using DeviceProfile directly
This removes some dependency on FloatingHeaderView, making it
easier to replace

Bug: 234008165
Test: Verified that the UI does not change
Change-Id: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
2022-07-28 18:10:19 +00:00
Sunny Goyal 524f4c4fba Fixing tab width and panner not aligned with the all-apps icons
Bug: 234008165
Test: Verified on device
Change-Id: Ibec3eed4aef730439d79b086d6ae23b63b66361e
Merged-in: Ibec3eed4aef730439d79b086d6ae23b63b66361e
2022-07-28 18:06:16 +00:00
Merissa Tan 5dbd289f18 Add running apps icons to taskbar for desktop environment.
This CL adds app icons for launched/running apps to the Launcher
taskbar hotseat. When the activity is closed, the app icon is
removed. The apps that are added to the taskbar on boot are never
removed.

Recall: http://recall/clips/ad6d3cfc-7358-4b37-846e-de843ad3000d

Bug: 183906774
Test: Launch an app and verify the app icon is added on the taskbar.
Close the app and verify the icon is removed from the taskbar.
Test: Switch navigation modes on the emulator and ensure that running
app icons are added to the taskbar after it is reinitialized.
Test: atest NexusLauncherTests:com.android.quickstep.RecentTasksListTest RecentTasksControllerTest

Change-Id: Ieaaf001530b5778871fb7a8d18cdcaa1ccbf0e31
Merged-In: Ieaaf001530b5778871fb7a8d18cdcaa1ccbf0e31
2022-07-28 17:50:12 +00:00
Tracy Zhou f1a523a790 Merge "Add testSplitFromOverview test (for phones)" into tm-qpr-dev 2022-07-28 05:06:40 +00:00
Iris Yang 282cf0867f Keep the default display's top running task in the top of running list
While we move a task to virtual display, we will receive
onTaskMovedToFront() callback to add the task(on virtual display) into
the running list. It cause the first item of Recents is virtual
display's task but the thumbnail view is showing default display's
task snapshot.
This change is to keep default display's top task in the first while
adding a virtual display's task into the running task list.

Fix: 235797788
Test: 1.Launch app1 on default display,
        launch app2 on virtual display,
        enter Recents,
        observed the recent animation and overview is showing app1.
      2.Launch app1 on default display,
        swipe app1 to home,
        launch app2 on virtual display,
        enter Recents,
        observed the overview is showing app2.
https://drive.google.com/file/d/1XkGNupJknmFKqjE3c97s6ieCKN5v-n_z/view?resourcekey=0-NLDIaK2EV2tG2ItccUdxDw
Change-Id: Ibb740986782eadf02672081cbd716fed04be6468
2022-07-28 02:43:39 +00:00
Andy Wickham f61e7bb4a2 Merge "Only bind fast scrollbar when attached if not already bound." into tm-qpr-dev 2022-07-27 22:27:25 +00:00
TreeHugger Robot 778f8c1833 Merge "Fix issue where System UI crashing resulted in no unlock animation." into tm-qpr-dev 2022-07-27 21:34:05 +00:00
Andy Wickham 87a9bf7c15 Only bind fast scrollbar when attached if not already bound.
This was overriding the previously bound RecyclerView if multiple
were attached simultaneously. Instead, the appropriate container
(All Apps / Widgets) should bind the active RecyclerView whenever
it changes, with the onAttach serving as a fallback to ensure
the scrollbar has an initial RV to avoid NPEs.

Fix: 234591523
Bug: 235476489
Test: Manually checked All Apps from Launcher and Taskbar, as well
as Widget bottom sheet. Also ran relevant Tapl tests.

Change-Id: I06e27d2f66f9778087711a566817b6806ec7218b
2022-07-27 21:02:34 +00:00
Shikha Malhotra bc9b08fdd1 [Cherry pick merge conflict] Updating visibility of some members for easier extensibility
This change is causing a merge conflict with ag/19441591. Hopefully only a cherrypick is needed.

Bug: b/218186980
Test: Manual Testing that Launcher3 compiles and works
Change-Id: Id85486ef763ce9a04b83fef44542b2eb3e0e599d
(cherry picked from commit c487e1b4c5)
2022-07-27 20:33:29 +00:00
Vadim Tryshev 45633e5aa1 Merge "Moving all sources that are shared between Launcher and TAPL in one directory" into tm-qpr-dev 2022-07-27 20:24:35 +00:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Tony Wickham eeb66e41e5 Cleanup taskbar+assistant interactions
- Always move the taskbar layer when voice interaction window visibility
  changes, to ensure we remove the temporary taskbar background in all
  cases (e.g. swipe to home)
- Move check to not draw taskbar background to the temporary view
  itself, so that it's at the proper layer when shown (e.g. during
  fulfillment on the home screen)
- Don't add view to window if it's already added (we already have this
  check for the removal case)

Test: Open an app, invoke Assistant, swipe home; Taskbar background is
removed; invoke and fulfill assistant from home screen, in app, in 3
button mode, and in gesture mode (all permutations)
Fixes: 236924161
Fixes: 240101132
Fixes: 235895444

Change-Id: I5958f1dbe14a6d190d3808014429f7f8146c9f96
2022-07-27 12:52:59 -07:00
Josh Tsuji 28fa196090 Fix issue where System UI crashing resulted in no unlock animation.
Fixes: 235254892
Test: adb shell am crash com.android.systemui
Test: adb shell am crash com.google.android.apps.nexuslauncher
Change-Id: Ia9644f8d1d5ffc9b162ce1608f8dd9ea9e1e3622
2022-07-27 14:38:31 -04:00
Evan Rosky d14f4c5181 Merge "Make shell-transit flag public" into tm-qpr-dev 2022-07-27 16:11:50 +00:00
Tony Wickham f3636d09e7 Set FLAG_RESUMED = false when expanding PiP
This allows us to play the icon alignment animation immediately, rather
than waiting for the expand to finish and launcher to be paused.

Test: Open Maps in PiP on home screen, expand it and watch taskbar
Fixes: 239506421
Change-Id: I5c04f778c4c39c2895db0a1ea1fca4d48d1f3093
2022-07-27 08:52:09 -07:00
Tony Wickham 592d80dc29 Merge "Add @ScreenRecord to testSwitchToOverview" into tm-qpr-dev 2022-07-27 14:59:12 +00:00
Tracy Zhou 1780cee0fe Add testSplitFromOverview test (for phones)
Design doc: go/split_tapl

Bug: 238553914
Fixes: 239082974
Test: run this test
Change-Id: I6b67ede6d62a9fb48222aa4d15fe29ccd1d0fa06
2022-07-27 04:18:50 +00:00
Jeremy Sim caacd73cfa Merge "Add comment regarding Overview TaskViews" into tm-qpr-dev 2022-07-26 23:00:20 +00:00
Evan Rosky 13a86c43ac Make shell-transit flag public
So it can be accessed by tests in other packages

Bug: 238328090
Test: N/A just increasing visibility
Change-Id: I5c270e1bdd315010c169d4cfcd82e3cce6d12442
2022-07-26 12:49:11 -07:00
Tony Wickham bb76b99c56 Have All Set aniamted background extend edge-to-edge am: 96431570d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19429240

Change-Id: Ideffeaa3d083feaa0a3d8e110d25c0b1eb5c3153
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 19:19:24 +00:00
Schneider Victor-tulias f6003ff070 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev 2022-07-26 17:29:33 +00:00
TreeHugger Robot 5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Winson Chung c6fb382132 Merge "Prevent setting max layer above the input consumer" into tm-qpr-dev 2022-07-26 16:28:21 +00:00
Tony Wickham 96431570d4 Have All Set aniamted background extend edge-to-edge
There's already a separate ConstraintLayout for the content that needs
to have fitsSystemWindows="true", but the drawing can extend past system
insets.

Test: Run AllSetActivity, manually inspect layout/drawing
Fixes: 237052706
Change-Id: I8ff1e3a036fb5c6bfa8586b041c9e5eae55c321d
2022-07-26 16:03:04 +00:00
Alex Chau 66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00
Tony Wickham bbfbe60f72 Merge "Hide the task icon during quick switch from home" into tm-qpr-dev 2022-07-26 00:43:55 +00:00
Tony Wickham a397f3784f Add @ScreenRecord to testSwitchToOverview
Test: N/A
Bug: 238461765
Change-Id: I0ff65e2ca7c5026d46e0e218a94a11cafe3f9648
2022-07-25 17:11:55 -07:00
Sunny Goyal 7b131c7c50 Fixing icon label not updated during bulk load am: bc3fb936e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19419027

Change-Id: I75c5949e541afef084cd4f078c86565e09d77b54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-25 23:08:18 +00:00
Jeremy Sim 74f7789f8b Add comment regarding Overview TaskViews
Just adds a comment explaining the elevation of Overview TaskViews. No code changes.

Bug: 208650434
Test: None needed.
Change-Id: I19c434f8473237a4a0f6fe36deecc9c80e7b8a49
2022-07-25 22:04:37 +00:00
Sunny Goyal bc3fb936e1 Fixing icon label not updated during bulk load
The label was being updated to default in Loader cursor
which prevented eventual final update of the label

Bug: 220645719
Test: Verified on device
Change-Id: I2559804eb885663387bd1f5afe9e3337130a9fe3
(cherry picked from commit 412f0d26fa)
2022-07-25 20:52:13 +00:00
Vinit Nayak c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
TreeHugger Robot 9fb9ae1a9e Merge "Fixing icon label not updated during bulk load" into tm-qpr-dev 2022-07-25 19:17:51 +00:00
Alex Chau 62572c04e2 Revert "Move BaseActivityInterface task size methods to DevicePr..."
Revert "Move BaseActivityInterface task size methods to DevicePr..."

Revert submission 19279487-baseactivityinterface

Reason for revert: As per discussion in ag/19341332, make sure DeviceProfile can properly react to inset changes before moving task size calculations there
Reverted Changes:
I30324d34c:Move BaseActivityInterface task size methods to De...
Ia9c1d0387:Move BaseActivityInterface task size methods to De...

Bug: 238593212
Change-Id: I0d40fdd4a5d4468494e30cef32a284479ddd2feb
2022-07-25 18:38:03 +00:00
Winson Chung d59a6e053d Merge "Quick change to unblock launching freeform from overview" into tm-qpr-dev 2022-07-25 17:30:14 +00:00
Sunny Goyal 412f0d26fa Fixing icon label not updated during bulk load
The label was being updated to default in Loader cursor
which prevented eventual final update of the label

Bug: 220645719
Test: Verified on device
Change-Id: I2559804eb885663387bd1f5afe9e3337130a9fe3
2022-07-25 17:24:34 +00:00
Hyunyoung Song 026ddc4460 Merge "Fix testSearchDeadzoneForTablets failure" into tm-qpr-dev 2022-07-25 16:59:00 +00:00
Winson Chung 8b0793f9ef Prevent setting max layer above the input consumer
- The leash is being set to max layer above the specified
  layer of the recents input consumer set by WM (in
  InputMonitor), revert this for legacy transitions

Bug: 239042246
Test: Swipe up to overview and quickly swipe again
Change-Id: I92ab2ae0917857b6b1154f6250e7fac6565a58f1
2022-07-25 16:21:49 +00:00
hyunyoungs 4ba188aa5f Fix testSearchDeadzoneForTablets failure
Bug: 239868630
Bug: 240116666
Test: testSearchDeadzoneForTablets passes

Change-Id: I8b20cf56191058b6033ae929be6726a2c88825c8
2022-07-25 09:53:25 +00:00
TreeHugger Robot 627f839a34 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev am: 3b042d6139 -s ours am: 5998b30d80 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19390325

Change-Id: I4772085ddbbece1db8511a0fbb39f0d6c69b84da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-23 07:06:42 +00:00
Bill Yi abe242645d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d74259083c -s ours am: 12a50bcae7 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19390325

Change-Id: I6d62ad14b58f1e808bbe37670f5968076ac5e9fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-23 07:06:23 +00:00
TreeHugger Robot 5998b30d80 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev am: 3b042d6139 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19390325

Change-Id: Idcd2eceb59d335a6e0fa63532e20a3366ebd4472
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-23 06:35:09 +00:00
Bill Yi 12a50bcae7 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: d74259083c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19390325

Change-Id: I8452904f55b28dd53dbd0a2b06efee5a586f6d02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-23 06:34:52 +00:00
TreeHugger Robot 3b042d6139 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-07-23 05:57:25 +00:00
TreeHugger Robot f6a6c1bcdf Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-07-23 05:32:43 +00:00
TreeHugger Robot 4b232d529f Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-07-23 05:32:43 +00:00
TreeHugger Robot 66eff5b891 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-07-23 05:32:43 +00:00
Winson Chung a44c6b53c0 Quick change to unblock launching freeform from overview
- Finish the recents animation before starting the freeform task
- Remove MultiWindowFactory abstraction now that freeform is the only
  implementation that uses that

Bug: 239429564
Test: Enable freeform in developer options, launch task into freeform
      from overview

Change-Id: I48069aee322f6a275d2cdae5345b196f8d682bac
Signed-off-by: Winson Chung <winsonc@google.com>
2022-07-23 05:29:14 +00:00
TreeHugger Robot 7b73b8bd59 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev am: eb47e42077 -s ours am: a5a8125cd4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19391616

Change-Id: Ie8b2324aebac856d1d3bbd496392f9507bf4edd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-23 02:37:47 +00:00