Commit Graph

11392 Commits

Author SHA1 Message Date
Jerry Chang 3d39bfcda7 Support starts a pair of intent/shortcut and task to split
Add startIntentAndTask and startShortcutAndTask APIs to support starts a
pair of intent/shortcut and task to split with shell-transition.

Fix: 250875492
Test: atest WMShellFlickerTests
Test: manual check start tasks or start intent/shortcut with task flow
      with shell-transition enabled
Change-Id: Ibce60f3a10e2bbc99ef17185f45680dc23ef5f48
2022-10-05 06:44:25 +00:00
Ming-Shin Lu 8ff85dc733 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev 2022-10-05 06:43:42 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Jerry Chang e3f95693ef Remove stage concept from split screen APIs
Since split screen has transferred from stage-based model to app-pair
model. Update to remove the stage concept from split screen APIs, so the
caller won't need to deal with stage concept.

Bug: 250875492
Test: atest WMShellFlickerTests
Test: manual check start tasks or start intent/shortcut with task flow
Change-Id: I36bfb54f3f690cfafd18ba31ab23f5745ead6d97
2022-10-05 03:27:02 +00:00
Tracy Zhou d7a7bfc304 Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev 2022-10-04 20:02:30 +00:00
TreeHugger Robot 6a84ebc7ab Merge "Reset TaskView transformations on orientationHandler change" into tm-qpr-dev 2022-10-04 19:05:43 +00:00
Vinit Nayak 188c8916ee Merge "Hide back button if IME shows in SUW" into tm-qpr-dev 2022-10-04 19:01:42 +00:00
Pat Manning e7fc4b1f63 Use wm shell splash screen animation to reveal app after tasks have appeared.
Bug: 202826469
Test: manual
Change-Id: I6a9e8a932849c30f7b572119a7f607178b5a6437
2022-10-04 19:08:54 +01:00
Winson Chung a5846c9868 Merge "Updating launcher for pip interface cleanup" into tm-qpr-dev 2022-10-04 16:54:48 +00:00
Pat Manning 0fa114ecc0 Merge "Refresh taskbar apps show on DeviceProfile change." into tm-qpr-dev 2022-10-04 11:46:48 +00:00
Alex Chau 2f7fd17dc1 Merge "Refactor TaskbarLauncherStateController to use a single AnimatedFLoat" into tm-qpr-dev 2022-10-04 10:32:54 +00:00
Thales Lima e8efdc1185 Merge "Check for view measurement before animating" into tm-qpr-dev 2022-10-04 10:09:10 +00:00
Vinit Nayak 64510b48b0 Merge "Add margin to SUW back button" into tm-qpr-dev 2022-10-04 03:10:21 +00:00
Winson Chung 1c3f817f89 Updating launcher for pip interface cleanup
Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: I375e67eeb07ffe50bf15eafb65c1e9d215118c73
2022-10-03 23:56:39 +00:00
Jeremy Sim 33e57ebc1a Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev 2022-10-03 23:31:59 +00:00
Vinit Nayak 66160e9dd8 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev 2022-10-03 22:45:42 +00:00
Jeremy Sim 86065b81e0 Fix animation slowdown when splitting from All Apps
This patch fixes a tablet bug related to splitting from All Apps. Splitting from AllApps was playing a very slow animation.

The bug occurred because there was no case set in QuickstepAtomicAnimationFactory for animating from the ALL_APPS state.

Fixed by setting the appropriate case in QuickstepAtomicAnimationFactory.

Fixes: 247053528
Test: Manual
Change-Id: I7391dc7049a6ff5a7f8c7e1ae8b69e29899248fa
2022-10-03 12:49:31 -07:00
Alex Chau d67ddc4920 Taskbar in overview
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
2022-10-03 20:15:12 +01:00
Stefan Andonian b759de4769 Fix ViewCapture NPE.
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.

Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.

Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
2022-10-03 15:25:04 +00:00
Alex Chau 58bc281142 Refactor TaskbarLauncherStateController to use a single AnimatedFLoat
- Use a single iconAlignment animation
- Introduced isInLauncher/goingToLauncher/FLAGS_LAUNCHER as combined FLAG_RESUMED|FLAG_RECENTS_ANIMATION_RUNNING
- iconAlignment is now centralized in onStateChangeApplied with single source of truth

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ie51b602394c155aca060a84585eb0e677e23425c
2022-10-03 11:24:00 +01:00
Jeremy Sim 978b0021a9 Fix 2 bugs involving split staging task translation
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.

Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().

Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
Thales Lima 517cafff18 Check for view measurement before animating
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.

Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
2022-09-30 16:04:42 +01:00
Vinit Nayak 7523b94105 Hide back button if IME shows in SUW
Fixes: 230830643
Test: Visually see no back button when IME
shows up on enter pin screen

Change-Id: Icdde92d39962c3891a56bb07de5b16a22635729e
2022-09-29 15:47:15 -07:00
Vinit Nayak c7295ee37a Add margin to SUW back button
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.

Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity

Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
Brian Isganitis f733a716fd Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev 2022-09-29 21:13:59 +00:00
Tracy Zhou c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Vinit Nayak 888f745490 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-28 18:30:16 +00:00
Brian Isganitis c7c2e8d7e6 Avoid syncing voice interaction background window for skipAnim=true.
Test: Manual
Fix: 236924161
Change-Id: Iaf95221678d36f9b5782fd8c4bda626b946565a9
2022-09-27 23:36:24 +00:00
Saumya Prakash 96bed75d9f Updated overview exit animation for 3 button navigation
Changed overview exit animation so that tiles don't slide off and only fade/scale in place for 3 button navigation. Previously, tiles would slide off when exiting for both gesture navigation and 3 button navigation. Now 3 button navigation exits with tiles staying in place.

Test: Manual
Fix: 245745939
Change-Id: I4144ed7e3ff29419df7fb13b6417ccc0a1f9dd45
2022-09-27 15:46:05 +00:00
Jeremy Sim ba7324e2b8 Update animations for phones: Overview > OverviewSplitSelect transition
This change updates the animation for initiating a split from the Overview screen on phones. Includes new timings and interpolators, and extends timing data classes related to SplitAnimationTimings.

Fixes a noticeable issue where the split animation appeared slow on phones.

Outstanding issues (fixes in progress):
- Repeated invocations of split on phones cause an erroneous animation to play. (b/249154347)
- Thumbnail corners do not match placeholder corners; the transition between the two is slightly janky. (b/236761794)
- Placeholder icons should be 72dp. (b/236761794)

Bug: 236761794
Test: Manual
Change-Id: Ibb97ef54498b0aa9556df531d8084799259c06e2
2022-09-27 11:45:02 -04:00
Ats Jenk aeea6768e6 Merge "Set up a place holder tile for desktop" into tm-qpr-dev 2022-09-26 23:43:19 +00:00
Brian Isganitis 815018be9a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev 2022-09-26 22:56:06 +00:00
Brian Isganitis 731ef0c301 Properly color taskbar nav buttons when slide-in view is shown.
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.

Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A

Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789

Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Tony Wickham 34461ba303 Merge "Don't moveToRestState from onTaskAppeared" into tm-qpr-dev 2022-09-24 06:44:17 +00:00
Ats Jenk 919ddf19f3 Set up a place holder tile for desktop
Create a placeholder tile in recents for desktop.
It is based on launcher task information. With extra flag indicating it
is for desktop.
When it is clicked, it will call sysui to show apps on desktop.

Test: manually verify that desktop tasks do not show up separately in
recents
Bug: 244348395

Change-Id: I8535a54e1545841cd988d4770e6fc5e857277cda
2022-09-23 16:28:48 -07:00
Tony Wickham 017bbc098a Don't moveToRestState from onTaskAppeared
There's a possible race here where we call moveToRestState before
Launcher is actually stopped, so it starts to animate the state
change, causing a visual jump before it gets stopped. We already call
moveToRestState in StatefulActivity#onStop, so this one shouldn't be
necessary anyway.

Test: Enable Winscope tracing, quick switch from app A to app B; before
this change, 9/10 times it would repro the jump in the bug, 0/10 times
after this fix. (Also verified through debug logging.)
Fixes: 244583136

Change-Id: I656b028f26a64f872960cb3fe87c39b097431511
2022-09-23 14:14:52 -07:00
Mady Mellor dea0a2466b Merge "Set package name on the floating intent" into tm-qpr-dev 2022-09-23 17:50:53 +00:00
Sebastián Franco 8c158770d7 Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev 2022-09-23 15:19:43 +00:00
Johannes Gallmann d79a87bf16 Disable split button instead of hiding it
The split button remains visible when there is only a single task present, but in a disabled state.

Test: Manual
Bug: 227600027
Change-Id: I36e8904bf342021db210cea7355a3806c783f235
2022-09-23 08:05:26 +00:00
Winson Chung d859a20086 Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev 2022-09-23 04:33:22 +00:00
Vinit Nayak 26fee57f37 Null out mSplitHiddenTaskView when resetting split selection state
* May have accidentally been removed in ag/19984439

Fixes: 248153819
Test: Repro in bug doesn't occur
Change-Id: Icdc04de84c28963d36368f9672baf5993cd87d8a
2022-09-22 16:27:47 -07:00
Winson Chung 8ae6b852d7 Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"
This reverts commit 240b064cdb.

Reason for revert: b/248344141

Change-Id: I559e583ddea4a68b4291ceb8ba119500d051ed36
2022-09-22 22:10:20 +00:00
Vinit Nayak 061e6f5dd5 Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev 2022-09-22 21:56:55 +00:00
Mady Mellor ceff6537ee Set package name on the floating intent
Test: treehugger
Bug: 237678727
Change-Id: I70923e62893cd6578fa3fa21e025cd5cf5e15edf
2022-09-22 12:08:41 -07:00
Thales Lima c9a317c7a2 Change taskbar edu size to wrap around icons
Bug: 217262479
Test: manual
Change-Id: I766394f4f64d5ba76c1bf50de9d06526376e6662
2022-09-22 14:36:10 -04:00
Sebastian Franco e7c222cdb5 Check for null when calling getCreatedActivity which is marked as Nullable
Fix: 243508135
Test: compiles
Change-Id: Id1ff2cf68fa10690a1bbec60a0c17cceab9db8d1
2022-09-22 13:03:15 -05:00
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Mady Mellor 13b7e00fff Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev 2022-09-22 14:58:13 +00:00
Nicolò Mazzucato 98e4e461fe Merge "Fix taskbar instrumentation crash" into tm-qpr-dev 2022-09-22 08:28:41 +00:00
Vinit Nayak 5144be3903 Prevent taps on initial TaskView animated into split select
Fixes: 247843657
Test: Tapping on animating taskView as soon as
split top is selected from app menu doesn't result
in starting split prematurely.

Change-Id: I94455d9bab381e5223f70cab981830d51a8fad6b
2022-09-21 16:57:53 -07:00