Commit Graph

11392 Commits

Author SHA1 Message Date
Sunny Goyal ebd8b75a9e Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037

Change-Id: I33bdf5f8dbacef076c6441a2309c308252143370
2021-07-01 18:31:07 +00:00
Sunny Goyal 08fa7008b0 Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037

Change-Id: I8f187fe98130bc8c35864a97b21fc31fb1161e30
2021-07-01 18:31:02 +00:00
Sunny Goyal f3d3dcf4a1 Merge "Fixing some dimentions in AllSet activity" into sc-dev 2021-07-01 18:16:45 +00:00
Winson Chung d9cff07959 Merge "Remove unused logs" into sc-v2-dev am: efa5e9f5ea am: a717b7b45a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15167125

Change-Id: I36a13d6621db04060c6d26c9bbc86a907b35f50f
2021-07-01 18:05:23 +00:00
Tracy Zhou 4986376828 Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev am: d25ee3294c am: 89f8d0763d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158868

Change-Id: I09acf90f0b002e801c9706d8cd88bf9dbf9d853d
2021-07-01 18:02:45 +00:00
Tracy Zhou 99adef95b3 Do not switch to screenshot and finish recents animation for menu options that already do so
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.

Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau e0fcee01b3 Restore previous currentPage in applyLoadPlan in case task is re-ordered
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham 5fac02bc5e Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.

- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung a12450e7dd Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2 am: bc5819ad4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: Ie3e85c1f419e9faecc3a9bc73db1626001978be7
2021-07-01 17:28:10 +00:00
Winson Chung 927059c8be Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2 am: 2ae6a3e3c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I717210002017b6ed71bfa49a90171f4e32a7532f
2021-07-01 17:16:24 +00:00
Winson Chung 2ae6a3e3c9 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I4183018dbe6ad644824f842cae259ab0786c9657
2021-07-01 17:15:48 +00:00
Winson Chung a717b7b45a Merge "Remove unused logs" into sc-v2-dev am: efa5e9f5ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15167125

Change-Id: I12a6c3dd689fdeda918809b6848772b97bd9b376
2021-07-01 17:15:29 +00:00
Winson Chung bc5819ad4c Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: Ic27229e49360d62d6fcd6bda498bfbb601b5e7ee
2021-07-01 17:14:55 +00:00
Winson Chung 277e9c83c7 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I4ed3c6d9009dcff282b08e6597fecd9dcfdecd0e
2021-07-01 17:14:51 +00:00
Winson Chung eb0a38c5f2 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev 2021-07-01 17:11:35 +00:00
Winson Chung 6a777d84b8 Remove unused logs
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
Merged-In: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 17:09:40 +00:00
Hongwei Wang dcfe1eab2f Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220 am: b4a1448ae2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: I8853abffe95a33dec942a69e92be5bc9579776d0
2021-07-01 13:43:35 +00:00
Yogisha Dixit c0425b05c6 Merge "Log widgets source." into sc-dev am: f9acf1d5d4 am: 0f8e5a8a3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: If1ec9ea5acee39e6b83b5beb51a3cb109aaf219b
2021-07-01 13:43:21 +00:00
Vinit Nayak 80edc3a54c Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae am: e8ea68582f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: I86391bfa2d276c15b72ea6511b2d5b536467309d
2021-07-01 13:43:15 +00:00
Yogisha Dixit e79c6ae8a8 Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9 am: 0d36d3d9bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: I211c9d19c46c772e48ec2c1a6e09bc9155cf6547
2021-07-01 13:43:06 +00:00
Cyrus Boadway f3bd6d81c7 resolve merge conflicts of 239e0b5408 to master
Bug: 192467834
Change-Id: Iaa856c8606561980be3d41251a68ca87eb419def
2021-07-01 11:42:00 +00:00
Hongwei Wang b4a1448ae2 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: Icf00b2bb3cac793a144081a42b817960a72745c0
2021-07-01 07:24:40 +00:00
Yogisha Dixit 0f8e5a8a3f Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I8c76625ff6a2a6c42b88518e7332119000e3eda4
2021-07-01 07:24:22 +00:00
Vinit Nayak e8ea68582f Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: I279f00bd76bbf78c40c0cd71c541586edf060d7d
2021-07-01 07:02:54 +00:00
Yogisha Dixit 0d36d3d9bb Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: Ifae5dbc4fe7f64d8c921a9e13c34cdd0b5d1cfc2
2021-07-01 06:52:22 +00:00
Winson Chung 8185663b6e Remove unused logs
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 04:44:04 +00:00
Vinit Nayak 837359b1ea Set correct divider dimension for task menu options
Previously divider drawable dimension was set on height,
which only works when things are divided vertically.
For horizontal layouts, we need to set divider width.

Bug: 192398954
Test: Tested portrait + fake/real landscape
+ tablet

Change-Id: I5a63df9749bf37c3a563e923a1b4724aa17d9409
2021-07-01 02:05:42 +00:00
Tracy Zhou 89f8d0763d Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev am: d25ee3294c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158868

Change-Id: Ic6dfce00e0b80adaa26da23b05363578ada8689a
2021-07-01 01:22:10 +00:00
Tracy Zhou d25ee3294c Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev 2021-07-01 01:11:11 +00:00
Jon Miranda 17cc821c28 Fix bug where app icon is gone for first frame on cold start.
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).

Bug: 192366079
Test: slow down window animations
      check no empty frame on cold start app launch
      check no empty frame on warm start app launch

Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Hongwei Wang 4b38eb6f95 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220 am: c3a9f0e75b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: Id3d94c0000cd8738475213b21435dfe306b13feb
2021-06-30 20:52:44 +00:00
Hongwei Wang 52df9c8580 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: I0fa466ab04f93a9d6f1f6ab15658a1d10f968fa4
2021-06-30 20:41:42 +00:00
Hongwei Wang c3a9f0e75b Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: Id256786bd820ea5f01174c136fc992fc2cd82999
2021-06-30 20:35:28 +00:00
Hongwei Wang 005e269220 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev 2021-06-30 20:23:23 +00:00
Sunny Goyal 25f386edc8 Fixing some dimentions in AllSet activity
Bug: 192412172
Test: Manual
Change-Id: I599c858fc21d45dd41eaa01ff3d91863d52f6ae8
2021-06-30 12:19:30 -07:00
Winson Chung a7d7f78c08 Defer cleaning up screenshot until after we actually switch to screenshot
- In the case where we get a screenshot on cancel, we should wait to
  finish the recents animation until the view gets a chance to update

Bug: 185643608
Test: Swipe up to overview in 2 button, hit home
Change-Id: I2ac3567006f6fa7e6f473499f6862e5e408dfc3d
2021-06-30 12:03:33 -07:00
Yogisha Dixit 8235d49e74 Merge "Log widgets source." into sc-dev am: f9acf1d5d4 am: 669bac8bd6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I5b2fe5baebd5f38e897412523f3920ff22054247
2021-06-30 18:47:29 +00:00
Yogisha Dixit ba28286260 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit 669bac8bd6 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: Ib47b6d3aaacaa30c723dafeeb65492510a150eb2
2021-06-30 18:32:53 +00:00
Yogisha Dixit f9acf1d5d4 Merge "Log widgets source." into sc-dev 2021-06-30 18:18:12 +00:00
Yogisha Dixit 658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Vinit Nayak 0a708332b8 Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae am: 0a740a074a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: If8a9fc5ddb10538c008181e71e78cd990c1cb644
2021-06-30 17:34:42 +00:00
Yogisha Dixit 9d096bb34c Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9 am: 1e143f2c6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: Ib396bb1b4afc661f0df417107c3da6344cc5268c
2021-06-30 17:34:34 +00:00
Tracy Zhou e9e5e51d73 [Live Tile] App surface is above launcher even after reaching Overview
Currently we place app surface below launcher and punch a hole through task view to display live tile in overview. In this change the order will be flipped, with a few benefits not limited to the following. For example, we have a surface view lifecycle bug where the surface view in a live tile app can go blank during app launch transition. This change will significantly mitigate the issue visually as the background wallpaper will not be revealed.

In order to make sure visually everything still looks the same, we will need to finish the recents animation when the user taps on the task view icon, since the menu overlaps with the task snapshort view.

This change also addresses fading out the task view when it's getting dismissed.

Test: manual
Fixes: 186531762
Fixes: 189265196

Change-Id: Ieae67fb89b60136fd81ceb8abde1a0cab8718b27
2021-06-30 17:34:13 +00:00
Vinit Nayak 0a740a074a Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: Ib3639aeb91dabbb4283d21e3e6cb6da69af08d23
2021-06-30 17:34:03 +00:00
Cyrus Boadway 8cf91e4bcc Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790 am: f5f23ba119
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896

Change-Id: Ibea99f93bd4047de977566282d3fe567e62cfdc3
2021-06-30 17:33:22 +00:00
Vinit Nayak 7f5fa6d1e6 Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173

Change-Id: Ic1ce3fbd0e68848a7095f3408d877117b0678adb
2021-06-30 17:32:59 +00:00
Vinit Nayak 0f3053ceae Merge "Take margin insets into account when setting position" into sc-dev 2021-06-30 17:29:44 +00:00
Yogisha Dixit 1e143f2c6b Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: Ib0e8d40b2b09d1b090f7968cce73fbafde5534c2
2021-06-30 17:28:34 +00:00
Yogisha Dixit aacc518984 Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002

Change-Id: Ia2f5626249f63f7d6aa28b7646e0cbb230bb7ce8
2021-06-30 17:26:59 +00:00