Commit Graph

11392 Commits

Author SHA1 Message Date
Pat Manning 30c28a0a22 Reenable tablet tests for OOP TAPL tests.
Bug: 210158657
Test: TaplTestsQuickstep.java
Change-Id: Ib604642be6819065cde4167f3705d43ced3b2fda
2022-01-31 18:49:20 +00:00
Winson Chung 458e842bca Merge "Revert "Temporarily disable SUW specific insets logic"" 2022-01-29 22:05:14 +00:00
Brian Isganitis c13700b61e Merge changes I2ede15d8,I86a0ffc0,I7c5fdbc7
* changes:
  Do not scale down taskbar all apps icons.
  Inflate taskbar all apps in abstract slide-in view.
  Introduce initial A-Z app drawer to taskbar.
2022-01-29 03:00:45 +00:00
TreeHugger Robot 5f0dbb6828 Merge "Include A11y timeout for taskbar icon dimming in kids mode." 2022-01-29 02:42:55 +00:00
Jon Miranda b2e30bd4e9 Merge "Fix bug where back swipe to icon in All Apps search result." into sc-v2-dev 2022-01-29 00:07:23 +00:00
Jon Miranda ce048f07cc Merge changes from topic "presubmit-am-afa98d56a10a42f4b953a23b9b07db3b" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Fix bug where back swipe to icon in All Apps search result. 2p: db767aa575
  Fix bug where back swipe to icon in All Apps search result.
2022-01-29 00:07:23 +00:00
Alex Chau 65dd83817c Merge "Remove ENABLE_OVERVIEW_GRID feature flag" 2022-01-28 23:14:23 +00:00
Lucas Dupin b9f7e269a9 Be forgiving with accidental horizontal scroll
An accidental horizontal touch, due to vertical fling on the -1 screen
could lead to imperceptible change in zoom, and send a frame to client
composition. This CL adds extra padding to overlay scroll amount, to
avoid these accidental gestures.

Bug: 211245940
Test: https://ui.perfetto.dev/#!/viewer?trace_id=3260c116-c578-6dad-e047-0a327b7d346c
Change-Id: Id05e482c79c1dcc2e1ba73baf8a4a4101797bbd2
2022-01-28 14:58:02 -08:00
Brian Isganitis 25b2ac8527 Do not scale down taskbar all apps icons.
Test: Manual
Bug: 204696617
Change-Id: I2ede15d8beaef65661984fe63bd99d0e7e726774
2022-01-28 16:43:24 -05:00
Brian Isganitis 9e80fb355c Inflate taskbar all apps in abstract slide-in view.
All apps can now be dismissed via the scrim or swiping down. To properly
behave as an AFW, the apps view can no longer be within the taskbar's
layout, and will instead add and remove itself from the drag layer.

Test: Manual
Bug: 204696617
Change-Id: I86a0ffc06faa653c65b3797a57ba6512c6874221
2022-01-28 15:21:11 -05:00
Brian Isganitis 4edf1da6e2 Introduce initial A-Z app drawer to taskbar.
Invoking the drawer is currently hooked up to tapping empty space on the
taskbar. Apps can be launched, and drag-n-drop split screen works. The
drawer can only be dismissed by acting on an app icon or tapping the
taskbar again.

Test: Manual
Bug: 204696617
Change-Id: I7c5fdbc7d54d8209f6f15ef80bfeb5e9b80cf647
2022-01-28 15:20:00 -05:00
TreeHugger Robot 65ffe19260 Merge "Allow overriding enterprise related strings in Launcher" 2022-01-28 18:52:43 +00:00
kholoud mohamed c76b2035aa Allow overriding enterprise related strings in Launcher
Test: manual
Bug: 188414133
Bug: 211422509
Bug: 188410712
Change-Id: I75858cdcf2057e7c270da5893cd9a90c6753f182
2022-01-28 16:33:03 +00:00
TreeHugger Robot 790146d1d8 Merge "Do not translate taskbar icons in kids mode when IME present." 2022-01-28 15:05:15 +00:00
TreeHugger Robot 0cc131ffe7 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-01-28 14:49:21 +00:00
Pat Manning 05ff09c52c Do not translate taskbar icons in kids mode when IME present.
Test: manual
Bug: 203749295
Change-Id: I6958ed95f1199c1178487134b92ff3ef0f15da2e
2022-01-28 12:22:17 +00:00
Pat Manning 2a0d1bed1a Include A11y timeout for taskbar icon dimming in kids mode.
Test: manual
Bug: 203748818
Change-Id: I3d3f325aa667a033bb32ab3b3cd2d0b794f6ea4b
2022-01-28 11:42:21 +00:00
Pat Manning e9a36099db Merge "Animate icon dimming in taskbar when force showing in immersive mode." 2022-01-28 10:24:07 +00:00
Tony Wickham f6e98fdc9c Don't add IME back and switcher buttons if IME renders them
- Also cache InputMethodService.canImeRenderGesturalNavButtons() since it doesn't change at runtime

Test: Enable persist.sys.ime.can_render_gestural_nav_buttons setprop, then ensure we don't draw IME back button or switcher button when gesture nav is enabled
Test: We still show back button in setup, regardless of nav mode
Bug: 205803355
Change-Id: Iab8c47521ab9e561881e4ffb45142888e4c427e4
2022-01-27 20:15:19 +00:00
Pat Manning 900ef936ad Animate icon dimming in taskbar when force showing in immersive mode.
Test: manual
Bug: 203748818
Change-Id: Iab3c65db502e7dbde3141429e9ae70eec1fabde1
2022-01-27 17:59:35 +00:00
Winson Chung 41e2824bfa Revert "Temporarily disable SUW specific insets logic"
This reverts commit 361f82b237.

Reason for revert: Latest SUW update ensures AOSP layout is same as Pixel

Bug: 204384193
Change-Id: I4eaa8e6045232c2897d97e49d532939c838dbce0
2022-01-27 17:21:48 +00:00
Pat Manning 2718fd6767 Merge "Adjust margins for kids mode back button." 2022-01-27 13:00:00 +00:00
TreeHugger Robot fea22ae7e9 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2022-01-27 12:07:13 +00:00
Alex Chau 635b3abcf1 Remove ENABLE_OVERVIEW_GRID feature flag
- Use isTablet directly instead of overviewShowAsGrid
- Tablet/landscape resoruces can now be overriden via xml
- Use Landscape resources in tablet in additional to vertical bar layout
  - For resources overwritten in values-land that was intended for vertical bar layout, override them in sw600dp for tablet landscape

Bug: 210597891
Test: manual
Change-Id: I19eac935a5fb1a420485408aa8b4774632726af1
2022-01-27 11:28:35 +00:00
Pat Manning a46ba689f3 Adjust margins for kids mode back button.
Test: manual
Bug: 203749295
Change-Id: I3374fad84de0e6d39bec26761a9ea70a5a3d6375
2022-01-26 16:45:07 +00:00
Tracy Zhou 3007a91b5e Merge "Delay showing task bar until the user releases their finger dragging from all apps to normal" 2022-01-25 21:44:48 +00:00
Tony Wickham c4f2560b0f Merge "Don't create new nav bar layer when IME is rendering nav buttons" 2022-01-25 20:17:43 +00:00
Schneider Victor-tulias bce63e06ed Merge "Fix taskbar icon dragging issues" 2022-01-25 19:03:06 +00:00
Brian Isganitis c19b51e1f3 Merge "Refactor all apps to depend on activity context." 2022-01-25 18:34:30 +00:00
TreeHugger Robot a9a7d9b5d9 Merge "Update taskbar resume alignment anim if launcher state changes in the middle" into sc-v2-dev 2022-01-25 18:31:32 +00:00
TreeHugger Robot 1d3b256eff Merge changes from topic "presubmit-am-7ba50c92d19c455d8266daf2c96ec31b" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Update taskbar resume alignment anim if launcher state changes in the middle 2p: cd6abc19a8
  Update taskbar resume alignment anim if launcher state changes in the middle
2022-01-25 18:31:32 +00:00
Bill Yi 4e18c410bf Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I54fc1393608a503daf9e549fb61e92e7a58e7867
2022-01-25 18:13:32 +00:00
Bill Yi d97da07a54 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9829ed62bfe1ab6f6cdaf011e8b1c75d43b68625
2022-01-25 18:09:35 +00:00
TreeHugger Robot 78cac51636 Merge "Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag." 2022-01-25 14:21:24 +00:00
TreeHugger Robot 5d534c807a Merge "Cleanup dead code from old all close prototype." 2022-01-25 13:15:01 +00:00
Jon Miranda 78d0d4f832 Remove ADAPTIVE_ICON_WINDOW_ANIM feature flag.
Has been enabled for past few releases, no longer needed
as a debug flag.

Bug: 209856611
Test: manual
Change-Id: Id25e36522636e5c5d8ee60cdec49b3ee3f4d4251
2022-01-24 18:00:04 -08:00
Jon Miranda 3ad2e4e350 Cleanup dead code from old all close prototype.
Bug: 209856611
Test: compiled
Change-Id: Ie94587467442ea00f949241fec41d10fb8c5a527
2022-01-24 17:56:44 -08:00
Brian Isganitis 1664c9f418 Refactor all apps to depend on activity context.
The current AllAppsContainerView has been split into a base class and a
subclass for activities. The base class allows using all apps with an
activity context. A-Z and work profile tabs are supported, but search
and the hotseat still require an Activity.

Test: Manual. All apps should work the same.
Bug: 204696617
Change-Id: I3b146714bc11b3b3555d97623aab5d78ac836482
2022-01-24 20:24:20 -05:00
Presubmit Automerger Backend 714c0bf1d6 [automerge] Update taskbar resume alignment anim if launcher state changes in the middle 2p: cd6abc19a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16693156

Change-Id: I5fe6e2e1492df3467ae3bc6880ff308e03a401dd
Merged-In: Ie0c6140e14186e41c7e4748dc745f87349b084fe
2022-01-24 23:25:36 +00:00
Presubmit Automerger Backend acbd4852b9 [automerge] Add fallback for missing remote animation callbacks 2p: bb530e9058
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16688543

Bug: 194011186
Change-Id: I975ca18ca54c2ee061b0e8259e4091dc5b999e21
Merged-In: I1b1296fab316b979f441ebb474d1475e3fa68f95
2022-01-24 22:25:30 +00:00
Josh Tsuji 46728f6481 Merge "Adds Launcher in-window animations, and reworks how the unlock flow works." 2022-01-24 20:34:44 +00:00
Winson Chung bb530e9058 Add fallback for missing remote animation callbacks
- In some cases WM won't callback the remote animation callbacks (neither
  start nor cancel) and Launcher never finishes executing the pending
  command (preventing the subsequent commands from running).  For the time
  being, just cancel the current state to allow the commands to be
  processed.

Bug: 194011186
Test: Mash on overview and home buttons with a 3p launcher

Signed-off-by: Winson Chung <winsonc@google.com>
Change-Id: I1b1296fab316b979f441ebb474d1475e3fa68f95
Merged-In: I1b1296fab316b979f441ebb474d1475e3fa68f95
2022-01-24 20:11:04 +00:00
Winson Chung a0c451008a Merge "Add fallback for missing remote animation callbacks" 2022-01-24 18:13:47 +00:00
Tony Wickham cd6abc19a8 Update taskbar resume alignment anim if launcher state changes in the middle
One way to reproduce this issue is to run `adb shell input keyevent KEYCODE_HOME`, which happens to pause and immediately resume launcher. For example, let's say we run this while in All Apps. Because the isResumed=true comes before the state transition to Normal, we behave as if we are still going to All Apps, specifically goingToUnstashedState = false (since we stash in All Apps). To fix this, we now listen to state changes while the resume alignment animation is playing, and update it if necessary.

Also did the same correction for the gesture alignment animation, though I don't have a specific repo for that.

Finally, because there are now more triggers for alignment animations to play, we add a check to only play them if it's not animating to the same value it's already animating towards. One notable experience this improves is swiping down from All Apps to home; if you do it quick enough, the state animation ends before the taskbar unstash animation, and thus the unstash animation would cancel and start again with the full duration, making it look laggy/disjointed (this behavior existed before this change as well).

Test: TaplTestsQuickstep
Test: Go to All Apps, run `adb shell input keyevent KEYCODE_HOME`, open an app and ensure taskbar icons are visible
Test: Quick switch from home when taskbar is present in apps, but instead go to overview; ensure no jump when taskbar stashes
Test: Swipe down quickly from All Apps, ensure taskbar unstashing doesn't slow down when reaching the end of the state transition
Fixes: 214562370
Change-Id: Ie0c6140e14186e41c7e4748dc745f87349b084fe
Merged-In: Ie0c6140e14186e41c7e4748dc745f87349b084fe
(cherry picked from commit 5fa2ed27bf)
2022-01-24 16:56:12 +00:00
Sunny Goyal fcb9182336 Merge "Updating logic to check if icon needs badging" 2022-01-24 16:20:34 +00:00
Wei Sheng Shih 1234813d1c Merge "Fix NPE crash when merge transition to remote transition." 2022-01-24 01:38:58 +00:00
Winson Chung efb80ec588 Merge changes from topic "presubmit-am-cf03cdfdc7444d7faac91b866c05eae8" into sc-v2-dev-plus-aosp am: b7225856ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16685428

Change-Id: I5595a2cf4bdc179c74d20a01e9249de7c14199ce
2022-01-21 22:48:54 +00:00
Winson Chung a84f86f254 Merge "Dispatch hover events through the input consumer proxy" into sc-v2-dev 2022-01-21 22:29:43 +00:00
Winson Chung b7225856ad Merge changes from topic "presubmit-am-cf03cdfdc7444d7faac91b866c05eae8" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Dispatch hover events through the input consumer proxy 2p: eff9a120c6
  Dispatch hover events through the input consumer proxy
2022-01-21 22:29:43 +00:00
Winson Chung 92d66a4d2a Merge changes from topic "presubmit-am-eb42a70960e740e988dfbddc552edcae" into sc-v2-dev-plus-aosp am: 4f9711c182
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16683595

Change-Id: Iaa54adbb00484f99272212781bdedd84a1d8ecfc
2022-01-21 20:33:38 +00:00