This reverts commit a66dafe617.
Reason for revert: b/159183864 introduce com.android.launcher3.memory.MemoryTests failed after this CL merged.
Due to I need more time to investigate the root cause and do not block MemoryTests, revert this CL temporary.
Change-Id: I0408123e36c55a262ee0f1080cd6612785b3f527
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.
The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.
Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.
Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.
Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
This "fixes" the bug where wallpaper zoom does not reset to 0 when
screen turns off since we no longer require a valid surface to set the depth
when blur is disabled.
Note that the bug still exists when blur is enabled, which will need to be
fixed in a follow up CL.
Bug: 157946272
Change-Id: I43179435885c95eb2ecf406fa5c291badf5a1ed3
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).
Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.
Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
(cherry picked from commit 80303ac4b9)
Merged-In: I33a71698411d9bc2416b6660f8dbd53233628917
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).
Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.
Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
(cherry picked from commit 80303ac4b9)
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI
Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.
Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
Doc: go/hybrid-hotseat-tips
Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.
Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
Notify to expand notification panel through SystemUiProxy when
one-handed mode disabled and one-handed gesture detected.
Bug: 154080211
Test: make and install
Test: manual disable one handed mode and swipe down to trigger
Test: verified the gesture works even outside of home page
Change-Id: Iacc0e506ccd04dd81f6182759c8af7d686a7b77b
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.
Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.
Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
Previously we did this for the last task that appeared, but didn't
take into account cases where multiple tasks had appeared during
the same gesture state. We handle that now.
Test:
- Quick switch to delayed task A, start new gesture, return to the
first app after onTaskAppeared(A)
- Quick switch to delayed task A, start new gesture, wait for
onTaskAppeared(A), then switch to delayed task B, start new
gesture, wait for onTaskAppeared(B), and switch back to A
- Quick switch to delayed task A, start new gesture, wait for
onTaskAppeared(A), then switch to delayed task B, start new
gesture, wait for onTaskAppeared(B), and switch back to A and
quickly back to original app (before settling on A)
Ensure task starts/resumes and is interactable in all cases.
Bug: 158588954
Change-Id: I647a6d015baa1d9b6d613e6c0e584589f35da54a
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.
Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.
Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
This reverts commit 4dfcbec512.
Reason for revert: Fix the margin issue by handling the bottom
insets ourselves.
Change-Id: Ic01cadbbe847e419af8bb444ad57764e719152c3
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).
Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.
Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
3 Button overview orientation wasn't
getting set, but working because of the sensor.
Now we set orientation when entering overview,
and reset to rotation 0 when exiting overview.
Also fix related bug in RecentsOriented state
where we weren't updating the current sensor
rotation with foreground app orientation.
Fixes: 157069195
Change-Id: Ide1b7dbeb68aeaf6a3c45f7260595f69f4813d94
This reverts commit 160ca4b8a2.
Reason for revert: Got issues like b/158318606 when switch nav modes, also the margin seems not set properly. And this doesn't work for 3 button mode too. Would switch to just use task menu for all.
Change-Id: I645f2a2a9032ae99799c75bcc6c983c1bbfd8df8
Bill Lin
Vinit Nayak
Miranda Kephart
TreeHugger Robot
Samuel Fufa
Sunny Goyal
thiruram
Jon Miranda
Hyunyoung Song
Pinyao Ting
Jerry Chang
Tony Wickham
Becky Qiu