Commit Graph

7102 Commits

Author SHA1 Message Date
Vinit Nayak dc8d558947 Merge "Set StateManager to BackgroundAppState if end gesture is LAST_TASK" into tm-qpr-dev am: c1799a8221
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21233604

Change-Id: If78e768276933ec8d72420508b8ff6b1bd8b4410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 06:36:08 +00:00
Vinit Nayak c1799a8221 Merge "Set StateManager to BackgroundAppState if end gesture is LAST_TASK" into tm-qpr-dev 2023-02-03 06:05:22 +00:00
Jon Miranda 195e0c9e75 Merge "Iterative improvement to the taskbar stash animation." into tm-qpr-dev am: 554c431d40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21226020

Change-Id: I77cdf5512378cb5ba481a6eaedf6aaa10973154a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 02:50:26 +00:00
Jon Miranda 554c431d40 Merge "Iterative improvement to the taskbar stash animation." into tm-qpr-dev 2023-02-03 02:39:10 +00:00
Jon Miranda 82382fc784 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev am: 5903751ee3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21225224

Change-Id: If372917ea9fa959faf913fa831b533ec8681e27d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 02:00:06 +00:00
Jon Miranda 5903751ee3 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev 2023-02-03 01:34:05 +00:00
Stefan Andonian 424c469513 Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev am: 6a4e9a34ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21061164

Change-Id: I9c33c9c4e1532a07ea00772e210e221cd9661cd8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 00:53:00 +00:00
Stefan Andonian 6a4e9a34ab Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev 2023-02-03 00:27:14 +00:00
Jon Miranda b1e85e9b70 Iterative improvement to the taskbar stash animation.
Test: manual
Bug: 246632728
Change-Id: I4e4051faaf699a462c90acf87afcee11a0b4165b
2023-02-02 23:52:23 +00:00
Jon Miranda 2b25ded506 Update notification dot renderer when we update the taskbar icon size.
Test: swipe to home with an app that has a notification dot
      observe no jump in dot size
Bug: 264709741

Change-Id: I5d56fe57e74ed7b094477ecd8727152f3f522042
2023-02-02 23:10:42 +00:00
Vinit Nayak 576592575b Set StateManager to BackgroundAppState if end gesture is LAST_TASK
* Setting stateManager to QUICK_SWITCH results in calling
launchTasks() in the current TaskView in recycler view, however
if the end is LAST_TASK, there's no need to launch anything.
* Currently this isn't an issue with fullscreen tasks because
Launcher's onStop() cancels the animation, but that isn't the
case in the specific step of locking/unlocking the device AND
in splitscreen. Tracked at (b/267674372)

Test: Bug no longer repros. Did other quickswitch gestures and
also going to overview with split and fullscreen apps
Fixes: 265734073

Change-Id: Ie553c7b5db7e59e0cd8aba1723c25ad923690d5c
2023-02-02 14:16:31 -08:00
Saumya Prakash 2dc342ab7b Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev am: 334094da9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150239

Change-Id: Ic9945132bfd6c048136dea36abbfcb846750d954
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 22:12:23 +00:00
Saumya Prakash 334094da9e Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev 2023-02-02 21:54:10 +00:00
Nicolò Mazzucato b46a7dde3a Merge "Improve launcher tracing around unfold animation" into tm-qpr-dev am: b70a68a6d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150249

Change-Id: I64655c297122a8505ed47a1c60c2661538e479ba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 21:22:11 +00:00
Saumya Prakash b1291e6ae2 Redesign the tutorial for the go home gesture
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.

Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
2023-02-02 18:14:14 +00:00
Nicolò Mazzucato b70a68a6d7 Merge "Improve launcher tracing around unfold animation" into tm-qpr-dev 2023-02-02 10:14:47 +00:00
TreeHugger Robot f114ad9fa4 Merge "Force persistent taskbar all apps icon to light version." into tm-qpr-dev am: 858092151c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21164239

Change-Id: If868dcfa656fcba965f5bd0e9e8fbd30f3c7e951
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 03:45:08 +00:00
TreeHugger Robot 858092151c Merge "Force persistent taskbar all apps icon to light version." into tm-qpr-dev 2023-02-02 03:14:23 +00:00
Vinit Nayak 98fb659aec Merge "Fix bug with selecting a secondary task as second splitscreen app via Taskbar" into tm-qpr-dev am: 5be7cde8fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21168146

Change-Id: I2254294f59428f7b8e46f143f9d9778af7accd33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-02 00:01:03 +00:00
Vinit Nayak 5be7cde8fa Merge "Fix bug with selecting a secondary task as second splitscreen app via Taskbar" into tm-qpr-dev 2023-02-01 22:47:51 +00:00
TreeHugger Robot be539a692d Merge "Dispatch onAnimationStart and End to maintain proper state" into tm-qpr-dev am: 8baae80cdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150244

Change-Id: I463f969d05b6e26e8d69cd906674a9c6a92be611
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 20:47:39 +00:00
Stefan Andonian 1d7f703514 Migrate "isRotationAllowed" setting to LauncherPrefs.
This semi-complicated case requires use of a context in order to get the
default value. That is why it was migrated by itself.

Bug: 261635315
Test: Manually tested all the base functionality of the launcher.
Change-Id: I40d8ccd414402b55921a0a224264414d3245871b
2023-02-01 20:26:41 +00:00
Brian Isganitis 748094b185 Force persistent taskbar all apps icon to light version.
Persistent taskbar background is always dark regardless of device theme,
so we should make the icon always light for now.

Test: Manual
Fix: 262837720
Change-Id: I8f66af874e07f68e1943245e9cd49c3b3107915f
2023-02-01 12:07:58 -08:00
TreeHugger Robot 8baae80cdf Merge "Dispatch onAnimationStart and End to maintain proper state" into tm-qpr-dev 2023-02-01 18:58:56 +00:00
Nicolo' Mazzucato 06578ff8b1 Improve launcher tracing around unfold animation
This will make it explicit in a trace when we're waiting for one additional frame after onResume to start processing unfold animation related progresses

Bug: 267287854
Test: recorded trace locally after unfolding
Change-Id: I3b13842f018c6f23cbb5bc1c1cfd77e5c38dad98
2023-02-01 17:46:56 +00:00
Tony Wickham 4edce0100a Dispatch onAnimationStart and End to maintain proper state
The AnimatorPlaybackController from createLauncherStateFromSuwAnimation
does not ever get started (it's all user-driven) and thus some internal
state is not updated properly, namely mIsStashed is never set to false
even though the animation unstashes visually. This will break the first
"real" unstash animation after SUW. Thus, when the animation from SUW is
completed, we now dispatch onAnimationStart() and End() to ensure the
proper state is updated.

Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
  Then, skip to the end and swipe to home; ensure first app launch
  properly stashes taskbar
Fixes: 263533070
Change-Id: I9553b8a884fb84303e2e97f14b9a7051e9de4709
2023-02-01 16:18:18 +00:00
Jeremy Sim 0b4b89bdcf Fix bug with selecting a secondary task as second splitscreen app via Taskbar
This patch makes it so that the correct task will be chosen when selecting a second splitscreen app via Taskbar.

Prior to this patch, the Taskbar app selection function -- which attempts to match the tapped icon to a running TaskView -- assumed that the TaskView in question was always a solo (non-grouped) Task. This resulted in the wrong app being selected for split when the desired Task happened to be the secondary app in a pair.

Fixed by checking to see if the desired app is primary or secondary, and returning the correct Task, IconView, and ThumbnailView for the split operation.

Fixes: 265244769
Test: Manual
Change-Id: Ie1122d1b49151d70dec9711fe558fba7752b7d8e
2023-02-01 15:40:06 +08:00
Tony Huang 8d3e1dbed9 Merge "Fix divider hidden delay if quick swipe to home" into tm-qpr-dev am: c3cb117b01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21152801

Change-Id: Ifcb574e76cad43d8163a0d602f711c21f8a0a3b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 04:03:13 +00:00
Tony Huang c3cb117b01 Merge "Fix divider hidden delay if quick swipe to home" into tm-qpr-dev 2023-02-01 03:31:00 +00:00
Brian Isganitis 69fcae1207 Merge changes Iaf02a42a,I8daf3c08 into tm-qpr-dev am: 1a4eb297ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21161656

Change-Id: Ifa1ade1b50a767bdb4385c283848f6269b51d71b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 02:10:03 +00:00
Brian Isganitis 1a4eb297ee Merge changes Iaf02a42a,I8daf3c08 into tm-qpr-dev
* changes:
  Enable taskbar EDU tooltip flag.
  Add settings asset to persistent Taskbar tooltip.
2023-02-01 01:34:59 +00:00
TreeHugger Robot a2edf995e1 Merge "Fix bug with trying to split an app with itself" into tm-qpr-dev am: 5107dff0eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21152798

Change-Id: I8f102c0c6a0bc14ba9a4cd47f966a656acca194a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 00:10:55 +00:00
TreeHugger Robot 5107dff0eb Merge "Fix bug with trying to split an app with itself" into tm-qpr-dev 2023-01-31 23:42:29 +00:00
Alex Chau 09ee64d7ec Merge "Clear PredictorState targets when it's re-registered" into tm-qpr-dev am: 2eacb5c601
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150242

Change-Id: Ic043045cfc8e72e542e790f44cbb746b5f3c000b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 22:29:24 +00:00
Brian Isganitis 7881b81aa7 Add settings asset to persistent Taskbar tooltip.
Test: Manual (3 button)
Bug: 263157739
Change-Id: I8daf3c08e48ef1f9ec190af301333d279878aa59
2023-01-31 14:07:34 -08:00
Alex Chau 2eacb5c601 Merge "Clear PredictorState targets when it's re-registered" into tm-qpr-dev 2023-01-31 21:59:14 +00:00
Pat Manning 23aa4f8022 Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev am: f667823a8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136526

Change-Id: I116f965bdd77c65e7a82abb55e7aa0ce6dadcf19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 21:21:15 +00:00
Pat Manning f667823a8e Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev 2023-01-31 21:13:46 +00:00
Alex Chau e5c1edb31b Clear PredictorState targets when it's re-registered
- After SUW, registerPredictor is called for hotseat, and then BaseLauncherBinder will call bindExtraContainerItems with empty items. A subsequent registerPredictor will then be triggered by LoadTask, but handleUpdate will skip the update due to no diff in PredictorState targets. As a result, HotseatPredictionController always have no items after SUW
- Clearing PredictorState when it's re-registerted will allow the respective prediction controller to receive new prediction items that comes with the registration.

Fix: 265340241
Test: Factory reset, pass SUW, prediction items are in hotseat
Test: Reboot, prediction items are in hotseat
Change-Id: Ie6e219028e7fde42854459d34806a04052dc41ba
2023-01-31 19:24:31 +00:00
Sunny Goyal a19f661961 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Ia74b38af165fa317c4d562730652f960026912a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 18:47:36 +00:00
Sunny Goyal 126ac14112 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev 2023-01-31 18:20:35 +00:00
TreeHugger Robot 21c3aab5b3 Merge changes I865871e5,Ie655de7a into tm-qpr-dev am: 6e21d310c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074655

Change-Id: I3253ef6d326b7b0dc2c20ee9f3679ca969bd39b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 18:04:58 +00:00
Stefan Andonian ba7ed6c66c Move ViewCapture On/Off controls to QuickSettings Tile. am: 526e168906
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20946024

Change-Id: I49c50822242162c940a6bbe7ac9a6487b500823b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 18:02:19 +00:00
TreeHugger Robot 6e21d310c1 Merge changes I865871e5,Ie655de7a into tm-qpr-dev
* changes:
  Fixes to VoiceInteractionWindowController
  Fix TaskbarBackgroundRenderer not being applied correctly in 2 cases
2023-01-31 17:52:55 +00:00
Pat Manning 7462c2ab62 Make showing back for bouncer only rely on back disable status, not home and recents as well.
Fix: 260655218
Test: manual. Create second user, switch to three button nav, set lockscreen password, lock and show IME on lockscreen.
Change-Id: I1d874196afc24d5bae86d525a81ae199152fc750
2023-01-31 14:57:26 +00:00
Jeremy Sim c779ae54ce Fix bug with trying to split an app with itself
This patch fixes the following user flow:
1) App is already running
2) User initiates splitscreen from Home with that app
3) User selects the same app from Taskbar or AllApps

Previously, this caused a crash because the split-from-home initiation removed the corresponding app tile, causing a null pointer exception when the same task ID was used as a split target.

Fixed by adding a null check: if the target TaskView can't be found for any reason, fall back to launching the second app via Intent instead. If the app doesn't support multi-instance, the UI will now show an attempted split, followed by the message "This app can only be opened in 1 window."

Fixes: 263041522
Fixes: 266218404
Test: Manual
Change-Id: I39ed60c9ac758ac215391f0618f44f7fcee4f32c
2023-01-31 17:58:12 +08:00
Tony Huang 36baf82028 Fix divider hidden delay if quick swipe to home
We didn't handle such case if transient bar enable and divider is
hidden by split side so it will have a delay.
Catch up it on handleNormalGestureEnd if end target is home.

Fix: 265755388
Test: manual
Test: pass existing tests
Change-Id: I09ac2a3a57c51473daf2b6887cd23bca505378f7
2023-01-31 09:03:09 +00:00
Tony Wickham c3963a7ff4 Fixes to VoiceInteractionWindowController
- Make temporary taskbar background behind assistant non-touchable
  (fail-safe in case the window isn't removed for some reason)
- Give temporary taskbar background a different window title and
  add a couple more dump statements to help debugging
- Only show the taskbar background for persistent taskbar; transient
  taskbar can skip most of the special casing and just hide it
- Fix bug where we weren't drawing the separate taskbar background in 3
  button mode
- Fix bug where we weren't actually synchronizing
  separateWindowForTaskbarBackground with TaskbarDragLayer, since the
  former wasn't attached to the window yet; now we wait until it is
  attached before calling synchronizeNextDraw()
- Also added dump logs for TaskbarDragLayerController alpha channels

Test: manual in 3 button and gesture nav (with and without
FORCE_PERSISTENT_TASKBAR enabled)
Fixes: 243652789
Bug: 262664266

Change-Id: I865871e57dd4cb255a916317a7e5d35cfde97df5
2023-01-31 00:58:22 +00:00
TreeHugger Robot ac906553d9 Merge "Revert "Revert "Add debug logs for hotseat disapperaed bug""" into tm-qpr-dev am: ba73400fe1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21147358

Change-Id: Ideccac6c81d2021b4b8fd4f5672c3e2bbe5ac191
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-30 23:16:40 +00:00
Stefan Andonian 526e168906 Move ViewCapture On/Off controls to QuickSettings Tile.
Rather than use a feature flag for this feature, the on/off state will
be stored as a system setting and will be changed via a QuickSettings
tile.

Bug: b/264452057
Test: Verified that the new QuickSettings tile doesn't crash via normal
interactions (pressing, long-pressing, etc.). Also verified that
ViewCapture is turned on when the QuickSettings tile is in the enabled
state and is turned off when it is in the disabled state.

Change-Id: I90551511ac2766dc30c51a25aec2c96e3e552ce9
2023-01-30 22:51:26 +00:00