0e668e1b1d
Update accessibility hint for widget cell that shows add button.
...
With tap to add feature, tapping widget cell reveals add button.
So, clarify the intent with ACTION_CLICK
Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
d1cd8c2ea6
Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
9f1b9d1b13
Fix close button in workEDU card not 48dp.
...
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.
- since there's no rtl catering for insets insets must have equal left and right values.
* this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
* reduce end margin of the linearlayout to be given to the right inset of the drawable.
bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix
Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
c4a90de0e9
Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main
2024-11-27 21:17:43 +00:00
8b63ee3420
Merge "Migrate materialColor* attributes into colors" into main
2024-11-27 14:55:47 +00:00
493583435b
Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
f9884f20f3
Avoid drawing the launcher pill outside the view bounds
...
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds. Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.
Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
bc02103a6a
Migrate materialColor* attributes into colors
...
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
d406bd8f2a
Update the a11y announcement for the deep shortcut menu to "Shortcut Menu"
...
Bug: 378062790
Change-Id: Iebbf922d95be5a9f726d993ac9fb7a41fb2bcbc3
Test: manual
Flag: EXEMPT bugfix
2024-11-20 19:15:38 +00:00
74842f0c16
Merge "Fix work tab accessbility issues." into main
2024-11-19 18:44:14 +00:00
3448777679
Merge "Changing name of RowCount to GridDimension to be more general" into main
2024-11-19 05:36:43 +00:00
df5e51ce34
Fix work tab accessbility issues.
...
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.
bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp
Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
fede690863
Merge "Aligning Android color tokens with Material" into main
2024-11-15 14:50:53 +00:00
52866fc596
Merge "Add Manage Windows option to Taskbar long press menu" into main
2024-11-15 08:57:49 +00:00
dbaf1028db
Add Manage Windows option to Taskbar long press menu
...
This change adds an option to the long press menu on Taskbar apps to
view open instances of the calling apps. It will only show on apps that
support multi instance (ex. Chrome).
Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie1e001c4cec831c751bcbf448aaa68bb90fb24ca
2024-11-15 06:34:28 +00:00
394a7e64f8
Changing name of RowCount to GridDimension to be more general
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I7ca46babf0c4ce647a4c98a7dd0326b35450479f
2024-11-14 18:58:16 -08:00
27fc554d2e
Merge "Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on" into main
2024-11-13 21:16:43 +00:00
6c91ef9191
Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: NexusLauncherImageTests, DeviceProfileDumpTest
Change-Id: I8e3ff70d2f3008d1de7c8419290ff44c18c72e70
2024-11-13 11:31:50 -08:00
7ddef8f82d
Aligning Android color tokens with Material
...
Original change was reverted because of a flag misplacement. Fixed now.
Script also updated to generate update resource files.
Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Ieefa4a675a1cd140e6e86a51cbca85faa52870c7
2024-11-13 13:58:33 +00:00
df14fffa54
Add elevation to workFAB to create a shadow
...
Unable to use md.sys.elevation.level3 but codesearched and
looked it up that this is equivalent to 6dp.
bug: 375597648
Test:
before: https://drive.google.com/file/d/1fp2l5p4wW2Gf3duC2qQ_brQ-xY0bTnOF/view?usp=sharing
after: https://drive.google.com/file/d/19xSAnWJURuwrjhMiywfjNT2vD0G2GoFP/view?usp=sharing
Flag: NONE adding elevation
Change-Id: I484609b4dc817b6d76701f60da51c3ec89bc8755
2024-11-12 15:33:10 -08:00
a438f7be54
Merge "Revert "Aligning Android color tokens with Material"" into main
2024-11-12 16:35:18 +00:00
866b7e3cee
Revert "Aligning Android color tokens with Material"
...
Revert submission 30126328-material-token-sync
Reason for revert: <Potential culprit for b/378661448 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>
Reverted changes: /q/submissionid:30126328-material-token-sync
Change-Id: Ifd0490a876081f3e50f674abc504bf5ba9be2df9
2024-11-12 15:12:01 +00:00
76eadb7c5c
Merge "Aligning Android color tokens with Material" into main
2024-11-12 12:40:17 +00:00
0c5177c817
Merge "Add mounted mode image tests and remove some image tests for OneGrid" into main
2024-11-11 19:17:42 +00:00
e2a68036b7
Aligning Android color tokens with Material
...
Script also updated to generate update resource files.
Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: I7f0fc8db36d8400559c3d5817e8331b973343dc3
2024-11-11 15:35:24 +00:00
c1b68f4f6d
Add mounted mode image tests and remove some image tests for OneGrid
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest, AllAppsImageTest, FolderImageTest
Change-Id: I1d51596d50d63b00614a2efd342cce72d9a4af8e
2024-11-09 01:21:40 -08:00
ba81c0f345
Merge "Add focus ring to widgets header" into main
2024-11-08 21:44:05 +00:00
9e4c99befd
Adding Launcher Mode settings to Launcher settings
...
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
7820eab80c
Add focus ring to widgets header
...
Change the widgets header drawable to be a selector with the
state_focused property in addition to the state_expanded property. The
focused items are drawn with a focus ring with no ripple, while the
unfocused items have a ripple.
Bug: 365120324
Test: focus traversal through left widget picker pane
Flag: EXEMPT bug fix
Change-Id: I710cb9e2d727a061e0c19df15526e8c832f6366b
2024-11-07 12:56:16 -08:00
1c173e96be
Define the list entry and view holder for the view all button
...
Child cl updates the adapter & picker to use this list entry type.
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
270e1c3dc4
Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
...
* changes:
Make sure work button is collapsed when keyboard is up upon going to app drawer
Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
bfd02bb36a
Implement the work scheduler view and update colors of FAB
...
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.
bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
230b2f50a7
Merge "Fix flag guarding for oneGridRotationHandling" into main
2024-11-06 17:04:05 +00:00
49f7df0444
Fix flag guarding for oneGridRotationHandling
...
Bug: 364711064
Flag: com.android.launcher3.one_grid_rotation_handling
Test: n/a
Change-Id: Ic0027bf82912bf56470a8abc29880599820b3352
2024-11-05 16:29:26 -08:00
2d55010135
Make ContextualEduStatsManager injected by Dagger (13/n)
...
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I0150ad8edeac1746e27b7d919891d02e648413be
2024-11-05 14:53:01 -08:00
ea078cb647
Add a resource override for providing default widgets filter.
...
The implementation in this CL is no-op i.e. all widgets will be shown
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
9486f5b455
Merge "OneGrid Grid Option Updates" into main
2024-10-30 22:06:11 +00:00
eac269ac81
Add custom talkback action for unarchiving apps
...
Bug: 373746865
Test: manually with Talkback
Flag: EXEMPT bugfix
Change-Id: I8c9efc029c2172e0dacd644b34f4930f50a7f8aa
2024-10-30 14:44:08 -04:00
ebc10c9ecc
OneGrid Grid Option Updates
...
Bug: 330900048
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I919195dbc7ac78c3be42f0f9d7620193a24d7e99
2024-10-30 11:38:09 -07:00
0b2acd6516
Merge changes from topic "AddWorkSchedulerInWorkProfileFlag" into main
...
* changes:
Add work_scheduler_in_work_profile flag.
Remove layoutTransitions for current FAB and use custom animation.
2024-10-29 20:17:02 +00:00
a7123472ce
Remove layoutTransitions for current FAB and use custom animation.
...
Have background contain left and right padding of 16dp.
That way upon collapse, its easier to animate so that every other view's space but the icon is removed.
Spec when expanded/collapsed: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2839-365095&node-type=text&m=dev
bug: 361589193
Test: manually - video:https://drive.google.com/file/d/1K7HCpayZBa_oo9p3XV10QQX4miTy_d3q/view?usp=sharing
withRTL: https://drive.google.com/file/d/1NfUEyEvzjfQamujv4EqLNBqB47mPNG1Y/view?usp=sharing
Flag: NONE just changing expandedFAB to use custom animations from layoutTransition
Change-Id: I7948633850a1010175eb4f0248daff22cf2f2c87
2024-10-29 09:50:13 -07:00
ba8c0a8fbd
Merge "Make ApiWrapper to be injected by dagger (12/n)" into main
2024-10-25 19:27:50 +00:00
ef2c5c0e49
Make ApiWrapper to be injected by dagger (12/n)
...
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
27e05992f6
Update recent indicators to match spec.
...
Does not implement any animations.
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Fix: 356394053
Test: go/testedequals
Change-Id: If8e319b605beedd0e9b14dc37da1b5ffa12f3c9f
2024-10-21 15:04:03 -04:00
9cd3154952
Moving PluginManager to dagger
...
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread
Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
d4488bfd72
Implement focus state on personal/work tab button
...
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208
Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
4cf02b8538
Merge "Add "New Window" option to Taskbar menu." into main
2024-09-20 18:20:36 +00:00
8e0ed4b01b
Add "New Window" option to Taskbar menu.
...
This change adds a new menu option to Taskbar that is invoked when long
pressing an icon. It createds a new instance for an app if the app
supports multi instance in Desktop Mode.
Bug: 315344726
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ibc42fbb1ad485496cd938af730b86e051cea559a
2024-09-19 21:30:43 +00:00
2a359916ca
Moving some utility class to IconCache to make it easier to use outside Launcher
...
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I7583ae162b652e73a33f1aee76714e292b707e39
2024-09-18 10:05:05 -07:00
13d9588f88
Merge "Updates many launcher color to new dynamic tokens" into main
2024-09-04 11:27:16 +00:00
Shamali P
fbaron
Brandon Dayauon
Treehugger Robot
Marcelo Arteiro
Ana Salazar Maldonado
Pinyao Ting
Sebastián Franco
Saumya Prakash
ELIYAZ MOMIN (xWF)
Matthew Mourgos
Anushree Ganjam
Charlie Anderson
Brian Isganitis
Sunny Goyal
Liam, Lee Pong Lam