TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
We did it in past for app-specific picker. Updating the same for the
pin sheet - verified change with Jane Park.
Bug: 379675391
Flag: EXEMPT BUGFIX
Test: Verified with pin sheet and wallpaper colors
Change-Id: I37e7ac93757e95e1940567e800a376256e0b8ed8
Previously, it stretched the parent container, which on close
observation looked odd.
Bug: 360061549
Flag: EXEMPT BUGFIX
Test: Opened picker and tested that stretch doesn't overflow.
Change-Id: I531b91131f7f86f37df21ab0f67a778c4ae7843f
Right now, with 24dp bottom padding, the last item is partially visible
behind that padding. And makes the touch target for last item small.
This is more visible when show all button ends up there.
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: If2743f73bec0ea244fef7eb1fa3efc903876914b
Child cl updates the adapter & picker to use this list entry type.
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
With the sticky header removed from two pane, the search results list
should to be aligned similar to the work / personal lists relative
to the search bar container.
Bug: N/A
Test: Manual
Flag: EXEMPT cleanup
Change-Id: I5cca57ca1861d3135d3b72fe84f75607555ea5ed
WidgetPagedView seems to rely on padding to position it such that
talkback doesn't focus on it before sticky header.
Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix
Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
Centralize the folder name within folder footer using gravity property
instead of adding padding to the folder name view. Padding as calculated
was cropping the folder name to the text line height, which was
insuficient in some cases, as eveidenced by the linked bug.
Bug: b/358006967
Test: Open a folder on home screen with arabic system language.
Verify that the folder name displays correctly.
Flag: EXEMPT bugfix
Change-Id: I4436c224f7f6541f447e3a5354ff870cf4d50698
SpringRelativeLayout views in widgets sheets UI are non-actionable
containers, and as such they would ideally not receive focus. They were
made focusable as a workaround for an issue where back action was no-op
when widget search text box was focused, and there were no other
focusable elements in the UI b/197129170.
WidgetSearchBarController handles back action by clearing
focus, which ends up refocusing the search text box. This CL, removes
this back action override, and let's back action through - it will end
up being handled by `WidgetsFullSheet.onBackInvoked` which resets the
search.
Bug: 365120544
Test: Manual - verified back action with widget search active (and in
case with no results) in emulator
Flag: EXEMPT bugfix
Change-Id: I1fed37372521947b7d4644047807dc451b0119a4
- The function used is a raised cosine function to determine the sections to animate.
Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary
bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.
Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
* changes:
Consider the widget option menu choice in search results
Show only filtered / default widgets in standalone activity by default
Add a 3 dot vertical menu and styles (child cl makes it functional)
Set default widgets and all widgets separately from standalone activity
Update the widget picker activity theme for popup menus styling
This allows the overflow to be tested properly in end-to-end tests.
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest OverflowBubbleTest (with other CL)
Bug: 347312208
Change-Id: Ice969434f9c40602c4b2d1a5baf6ba0509534a56
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class
bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
Reset the work edu card bit so the edu card shows if the managed profile is removed
Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG
Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation
bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING
Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
Set android:stateListAnimator to @null to remove default shadow on Add
button.
Bug: 333736273
Test: manual, check shadow on device
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ifa66801963e69582935806eb8a39dcfe624ffdc7
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.
Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.
Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.
Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
This Cl contains:
1. Alt text for Lock/Unlock button as per state.
2. Alt text for Header when Locked.
3. Removing Header from accessibility target when unlocked.
Bug: 328024119
Test: Manual
Flag: NA
Change-Id: I791176afdae4fc6eb9387080aa036c1aed2a03a9
* changes:
Align the margins between handle, text, and container with main picker.
Update the app-specific picker to have a container like the main picker
Brandon Dayauon
Marcelo Arteiro
Shamali Patwa
Treehugger Robot
Liam Lee Pong Lam
Toni Barzic
Sunny Goyal
Mady Mellor
Oli Thompson
Willie Koomson
Himanshu Gupta