Commit Graph

6567 Commits

Author SHA1 Message Date
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Brandon Dayauon 345901fdb0 Merge "Fix close button in workEDU card not 48dp." into main 2024-12-02 20:39:20 +00:00
Treehugger Robot fedf7fa5e2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Bill Yi 5e7bda3b84 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1688b8e845f0eb1185950e16c6ab11d686edc873
2024-11-27 17:35:47 -08:00
Brandon Dayauon 9f1b9d1b13 Fix close button in workEDU card not 48dp.
Can use insets to make it appear the same small visual but have a 48dp tap target. Since delegating the touch to the 48dp,
we can make the imageButton clickable to false as it's instead being used by the 48dp frame.

- since there's no rtl catering for insets insets must have equal left and right values.
   * this means to reduce the end margin of the text to be given to the LEFT inset of the inset_rounded_action_button
   * reduce end margin of the linearlayout to be given to the right inset of the drawable.

bug:379794419
Test manually photos:
beforeRTL:https://drive.google.com/file/d/1-DzcjOTywgk6SFjfCX7AVnmfqsIfa1lh/view?usp=sharing
afterRTL:https://drive.google.com/file/d/1UERlZ7XdoF0NhFuQE-oMulqgW9sDq9cy/view?usp=sharing
before:https://drive.google.com/file/d/1h5_Ljsx1rLyKum1PK7IRwD14ps2SPKC3/view?usp=sharing
after:https://drive.google.com/file/d/1b_8rgrC8WlDIdQuO7gOXS0MDNCISfxWr/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I017d4d34ef6e42fa49543c5f787063b061c382dc
2024-11-27 14:02:31 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
fbaron 493583435b Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I391e001ddee454baccbc0a8f1e002cc815722239
2024-11-26 00:38:19 +00:00
Bill Yi 040aad2cb2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-25 18:54:47 +00:00
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Bill Yi 0018279493 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4a880f6ed65b4053f7b58562757b9c3a70ed2d5e
2024-11-21 21:18:29 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Pinyao Ting d406bd8f2a Update the a11y announcement for the deep shortcut menu to "Shortcut Menu"
Bug: 378062790
Change-Id: Iebbf922d95be5a9f726d993ac9fb7a41fb2bcbc3
Test: manual
Flag: EXEMPT bugfix
2024-11-20 19:15:38 +00:00
Treehugger Robot 33a9c4936b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-19 21:49:29 +00:00
Brandon Dayauon 74842f0c16 Merge "Fix work tab accessbility issues." into main 2024-11-19 18:44:14 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Bill Yi 54d198b191 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5fbd48cc57813d4982e2f1c72f879bd442608b94
2024-11-18 20:01:02 -08:00
Shamali Patwa 797b636491 Merge "Add container around the previews in the pin widget sheet." into main 2024-11-19 00:02:47 +00:00
Brandon Dayauon df5e51ce34 Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
2024-11-18 15:16:41 -08:00
Shamali P 9f80ecfc83 Add container around the previews in the pin widget sheet.
We did it in past for app-specific picker. Updating the same for the
pin sheet - verified change with Jane Park.

Bug: 379675391
Flag: EXEMPT BUGFIX
Test: Verified with pin sheet and wallpaper colors
Change-Id: I37e7ac93757e95e1940567e800a376256e0b8ed8
2024-11-18 20:41:12 +00:00
Shamali P 1ce33c8537 Make overscroll in recommendation section limit within its bounds.
Previously, it stretched the parent container, which on close
 observation looked odd.

Bug: 360061549
Flag: EXEMPT BUGFIX
Test: Opened picker and tested that stretch doesn't overflow.
Change-Id: I531b91131f7f86f37df21ab0f67a778c4ae7843f
2024-11-15 23:34:34 +00:00
Marcelo Arteiro fede690863 Merge "Aligning Android color tokens with Material" into main 2024-11-15 14:50:53 +00:00
Saumya Prakash 52866fc596 Merge "Add Manage Windows option to Taskbar long press menu" into main 2024-11-15 08:57:49 +00:00
Saumya Prakash dbaf1028db Add Manage Windows option to Taskbar long press menu
This change adds an option to the long press menu on Taskbar apps to
view open instances of the calling apps. It will only show on apps that
support multi instance (ex. Chrome).

Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie1e001c4cec831c751bcbf448aaa68bb90fb24ca
2024-11-15 06:34:28 +00:00
Sebastian Franco 394a7e64f8 Changing name of RowCount to GridDimension to be more general
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I7ca46babf0c4ce647a4c98a7dd0326b35450479f
2024-11-14 18:58:16 -08:00
Treehugger Robot 27fc554d2e Merge "Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on" into main 2024-11-13 21:16:43 +00:00
fbaron 6c91ef9191 Add OldGrid field for GridOption so we can properly filter out the old grids when the flag is on
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: NexusLauncherImageTests, DeviceProfileDumpTest
Change-Id: I8e3ff70d2f3008d1de7c8419290ff44c18c72e70
2024-11-13 11:31:50 -08:00
Brandon Dayauon 7a609d8f1b Merge "Add elevation to workFAB to create a shadow" into main 2024-11-13 17:50:28 +00:00
Marcelo Arteiro 7ddef8f82d Aligning Android color tokens with Material
Original change was reverted because of a flag misplacement. Fixed now.

Script also updated to generate update resource files.

Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Ieefa4a675a1cd140e6e86a51cbca85faa52870c7
2024-11-13 13:58:33 +00:00
Brandon Dayauon df14fffa54 Add elevation to workFAB to create a shadow
Unable to use md.sys.elevation.level3 but codesearched and
looked it up that this is equivalent to 6dp.

bug: 375597648
Test:
before: https://drive.google.com/file/d/1fp2l5p4wW2Gf3duC2qQ_brQ-xY0bTnOF/view?usp=sharing
after: https://drive.google.com/file/d/19xSAnWJURuwrjhMiywfjNT2vD0G2GoFP/view?usp=sharing
Flag: NONE adding elevation
Change-Id: I484609b4dc817b6d76701f60da51c3ec89bc8755
2024-11-12 15:33:10 -08:00
Shamali P 697dcf44ac Maintain selected or last header on clicking "Show all" button
Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I762695f9999e5ea4c722dbedde6d7efabd3ab0cb
2024-11-12 22:31:14 +00:00
ELIYAZ MOMIN (xWF) a438f7be54 Merge "Revert "Aligning Android color tokens with Material"" into main 2024-11-12 16:35:18 +00:00
ELIYAZ MOMIN (xWF) 866b7e3cee Revert "Aligning Android color tokens with Material"
Revert submission 30126328-material-token-sync

Reason for revert: <Potential culprit for b/378661448  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Reverted changes: /q/submissionid:30126328-material-token-sync

Change-Id: Ifd0490a876081f3e50f674abc504bf5ba9be2df9
2024-11-12 15:12:01 +00:00
Treehugger Robot 76eadb7c5c Merge "Aligning Android color tokens with Material" into main 2024-11-12 12:40:17 +00:00
Bill Yi b52ce463ee Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-11 21:52:23 +00:00
Federico Baron 0c5177c817 Merge "Add mounted mode image tests and remove some image tests for OneGrid" into main 2024-11-11 19:17:42 +00:00
Marcelo Arteiro e2a68036b7 Aligning Android color tokens with Material
Script also updated to generate update resource files.

Bug: 376195115
Test: presubmit
Flag: EXEMPT bugfix

Change-Id: I7f0fc8db36d8400559c3d5817e8331b973343dc3
2024-11-11 15:35:24 +00:00
Bill Yi 9ba43ab5c8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib70ed0083cac05ffae400838449358addea27589
2024-11-10 16:24:11 -08:00
fbaron c1b68f4f6d Add mounted mode image tests and remove some image tests for OneGrid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest, AllAppsImageTest, FolderImageTest
Change-Id: I1d51596d50d63b00614a2efd342cce72d9a4af8e
2024-11-09 01:21:40 -08:00
Matthew Mourgos ba81c0f345 Merge "Add focus ring to widgets header" into main 2024-11-08 21:44:05 +00:00
Sebastian Franco 9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Matthew Mourgos 7820eab80c Add focus ring to widgets header
Change the widgets header drawable to be a selector with the
state_focused property in addition to the state_expanded property. The
focused items are drawn with a focus ring with no ripple, while the
unfocused items have a ripple.

Bug: 365120324
Test: focus traversal through left widget picker pane
Flag: EXEMPT bug fix
Change-Id: I710cb9e2d727a061e0c19df15526e8c832f6366b
2024-11-07 12:56:16 -08:00
Shamali P d39c31da74 Adjust the bottom padding padding on the left pane in picker
Right now, with 24dp bottom padding, the last item is partially visible
behind that padding. And makes the touch target for last item small.
This is more visible when show all button ends up there.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: If2743f73bec0ea244fef7eb1fa3efc903876914b
2024-11-07 14:02:02 +00:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Shamali P 8694df5f59 Move search widgets list view besides the personal/work lists
With the sticky header removed from two pane, the search results list
should to be aligned similar to the work / personal lists relative
to the search bar container.

Bug: N/A
Test: Manual
Flag: EXEMPT cleanup
Change-Id: I5cca57ca1861d3135d3b72fe84f75607555ea5ed
2024-11-07 14:01:17 +00:00
Bill Yi b7666bd2f0 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-06 22:52:30 +00:00
Brandon Dayauon 270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00