Commit Graph

12631 Commits

Author SHA1 Message Date
Alex Chau de68b73d16 Merge "Avoid unnecessarily add stub task for Desktop task" into main 2024-04-24 13:28:27 +00:00
Jordan Silva d889ee37c9 Merge "Add a refactored TaskThumbnailView" into main 2024-04-24 11:53:17 +00:00
Alex Chau 576d6ba60e Avoid unnecessarily add stub task for Desktop task
- ag/27016210 caused a regression for DesktopTaskView, where shouldAddStubTaskView returns false whenever DesktopTaskView have multiple tasks
- This is because for an unknown reason, runningTasks for Desktop task is always a single element array. This will be further investigated in b/249371338
- For now, shouldAddStubTaskView will still match DesktopTaskView if any runningTasks matches any of the tasks

Bug: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Test: Swipe up from desktop
Flag: NONE
Change-Id: I40cff473595a21ad1619bcdbde30bb8bfd600e15
2024-04-24 12:25:03 +01:00
Treehugger Robot f87a1ec91e Merge "Add permanent TaskView logs to track taskIds being launched" into main 2024-04-24 10:14:44 +00:00
Alex Chau aa10f54ace Add permanent TaskView logs to track taskIds being launched
Sample logs:
```
04-24 09:26:08.713 12608 12608 D TaskView: launchTaskInternal - launchExistingSplitPair: [1078, 925]
04-24 09:26:11.092 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [1078, 925]
04-24 09:26:13.940 12608 12608 D TaskView: launchTaskAnimated - startActivityFromRecents: [933, -1]
04-24 09:26:16.254 12608 12608 D TaskView: launchTasks - composeRecentsLaunchAnimator: [933, -1]
```

Bug: 310064698
Test: manual
Flag: None
Change-Id: Ic190bc9ea749ba4c8324832be8bc86112947b9ba
2024-04-24 09:26:20 +01:00
Alex Chau f7555925c1 Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:492965326e7391c8427b6fca7875508e7a957b49)
Merged-In: I2f33f91956d485957cedf43ccd684f16d42803be
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-24 07:08:50 +00:00
Alex Chau 0e5a4bb4bd Merge "Add stub task when matching TaskView is grouped while runningTasks is not grouped" into main 2024-04-24 07:07:50 +00:00
Brian Isganitis 5247849454 Make IME force stash the Taskbar.
This change moves the IME flag to be part of FORCE_STASHED rather than
STASHED_IN_APP, since there are cases where we are not in an app but
still want to stash the IME.

You can still bring up transient taskbar over IME since we do not set
the IME flag for transient mode (see TaskbarStashController#shouldStashForIme() first guardrail).

Test: Manual
Flag: N/A
Fix: 336592511
Change-Id: Iafa32b1a52f4bfbc0d3a4e77b19c82149dc42d0a
2024-04-23 18:30:24 -04:00
Brian Isganitis 0db4a1aac5 Merge "Support toggling Taskbar All Apps with 3P Launcher." into 24D1-dev 2024-04-23 22:13:11 +00:00
Uwais Ashraf e21525da40 Add a refactored TaskThumbnailView
- Live Tile, swipe (left+right) and dismiss working
- Tests of ViewModel state transitions
- Deprecate the old TaskThumbnailView
- Renaming TaskThumbnailView to TaskThumbnailViewDeprecated

Fix: 335440878
Fix: 331754672
Bug: 331753115
Test: TaskThumbnailViewModelTest
Test: Attached video on bug
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: I063b957fe6e56960970dcaadc641848fbd73251c
2024-04-23 23:05:14 +01:00
Saumya Prakash 17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Alex Chau 492965326e Add stub task when matching TaskView is grouped while runningTasks is not grouped
- Completely rewrote shouldAddStubTaskView to simplify the logic

Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
2024-04-23 20:37:44 +01:00
Winson Chung a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Treehugger Robot 8114a7ffb5 Merge "Reland slow gesture callback handling" into 24D1-dev 2024-04-23 17:47:37 +00:00
Fengjiang Li 02ff0add09 Merge "[Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread" into main 2024-04-23 17:46:26 +00:00
Sukesh Ram 36ce5c8840 Fix Taskbar Background Visibility After Entering IME then Overview.
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
(cherry picked from commit 5c34cf2d06)
2024-04-23 17:41:25 +00:00
Schneider Victor-tulias c30642b97f Reland slow gesture callback handling
Now that b/329324086 has been fixed, we can be more certain that launcher always gets a signal to clean up from WM.

- Relanding original fix for b/285636175 with some additional error checking
- We will now check whether the recents animation start is pending on ACTION_UP
- We will now block entire swipes to prevent sending additional inputs an input consumer while the recents animation start is pending
- We will now only stop blocking inputs on ACTION_DOWN

Flag: LEGACY ENABLE_HANDLE_DELAYED_GESTURE_CALLBACKS TEAMFOOD
Bug: 329324927
Fixes: 285636175
Test: added a delay in RecentsAnimationCallbacks.onAnimationStart and attempted several rapid gestures
Change-Id: I9805114da34bf44e6b28c2a8a665e4cca88904c2
(cherry picked from commit f3f0e28762)
Merged-In: I9805114da34bf44e6b28c2a8a665e4cca88904c2
2024-04-23 15:36:01 +00:00
Gustav Sennton 568e0bff90 Merge "Show running apps in Taskbar when in Desktop Mode" into main 2024-04-23 14:02:11 +00:00
Alex Chau 0e64dbe149 Make TaskMenuViewWithArrow width wrap content with a minimum width
- Also add a end padding for the text
- http://screen/3yTa8tmJfJuVf2t

Fix: 331555315
Test: OverviewMenuImageTest
Flag: NONE
Change-Id: Ic9bc2799cd25f87d2ec6c7ce83d50d060513a292
2024-04-23 11:53:48 +01:00
Gustav Sennton 0b33b172fb Show running apps in Taskbar when in Desktop Mode
In Desktop Mode: show currently running (Desktop) apps in Taskbar

Bug: 332504528
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT

Change-Id: I10dec022f4b16562e81d7cbd5f9ce835474e9d20
2024-04-23 10:43:27 +00:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
Brian Isganitis 86b5755178 Reset allAppsVisible if folding to phone upon recreateTaskbar.
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.

Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
(cherry picked from commit 6d63e7796d)
Merged-In: I53c38c8b4df477191be3c21b7750c55a71c7336f
2024-04-22 22:31:17 +00:00
Brian Isganitis c383204356 Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
(cherry picked from commit c113b277e6)

Change-Id: Ib4d029617442ebf0f637f7e146aa5d001a065515
Merged-In: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
2024-04-22 22:16:28 +00:00
Liran Binyamin 5905d55a9d Merge "Only animate bubbles when in app" into main 2024-04-22 21:38:39 +00:00
Jagrut Desai 147aa374c1 Adjusting Taskbar Icons for larger display size
Bug: 323948193
Test: Manual
Flag: NONE

Change-Id: I0bdfcaebf3de050ac850fe42c061c82ffebdb7c2
(cherry picked from commit e6f349b3dd)
2024-04-22 20:35:22 +00:00
Liran Binyamin 3232d8a5e7 Only animate bubbles when in app
We currently animate bubbles on home but the animation hasn't been implemented properly yet, so ensure we don't play the animation on home.

This also deflakes some tests that fail because we're not yet handling interruptions while animations are playing.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Fixes: 333796110
Fixes: 333910495
Fixes: 336086185
Test: https://android-build.corp.google.com/builds/tests/view?invocationId=I78600010269170812&testResultId=TR95029270629703599&redirect=http://fusion2/ac10ec72-4e02-4573-86be-59ecb823ecd1
Change-Id: I99de02cbaebeb6c930a1368ea65562aa178f6762
2024-04-22 19:11:25 +00:00
Fengjiang Li 7686997079 [Launcher Jank] Schedule LauncherApps#getAppUsageLimit on single bg thread
b/336326937 shows that getAppUsageLimit is being called a lot and it's scheduled on a thread pool, which is causing quite a lot of contention and should be scheduled on a single thread

Fix: 336326937
Flag: NONE
Test: presubmit
Change-Id: Ie041e72f2bff9f5d2dbfa4ce3c63a4bb2e5b08d4
2024-04-22 11:24:04 -07:00
Saumya Prakash 1e8961c3f8 Increase the delay in between gesture tutorials
The time in between each gesture's finish page and the start of the next
gesture tutorial was too short. We increased the time we spend on the
finish page by 1000 ms based on this feedback.

Fix: 293967263
Test: Run through the gesture tutorial and note the longer pause in
between each gesture
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:959dff122049349e25cfec82e78c6ae6db9fa7d6)
Merged-In: I2c22e19dff91ac720877e596df90efe7f3cfcd80
Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80
2024-04-22 18:05:57 +00:00
Schneider Victor-tulias 77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
Schneider Victor-tulias abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Mykola Podolian 1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Winson Chung bb32b7e0de Migrate PackageManagerHelper to MainThreadInitializedObject
- This is in preparation for other things that can be loaded with
  PMH initialization and prevents duplicate temporary helpers from
  loading this many times.
- Most calls in PMH can use the app context, but one call requires
  starting activities/showing toasts so that one needs to take the
  context and can be made static instead.

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
2024-04-22 12:35:03 +00:00
Schneider Victor-tulias 1ebeb1d1ae Merge "Update KQS to better support desktop tasks" into main 2024-04-22 01:37:39 +00:00
Eghosa Ewansiha-Vlachavas 0c338f3055 Merge "Check RecentsView is not null before use in AbsSwipeUpHandler" into main 2024-04-19 20:25:21 +00:00
Schneider Victor-tulias ec39107105 Update KQS to better support desktop tasks
While we wait for a way to display a sreenshot of the desktop statically, using a placeholder solution.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 335632286
Test: TaplTestKeyboardQuickSwitch
Change-Id: I2525ab89eb3a5a902e7ab55367187d87aada1f10
2024-04-19 14:53:20 -04:00
Eghosa Ewansiha-Vlachavas 47e0a61f29 Check RecentsView is not null before use in AbsSwipeUpHandler
Prevents NullPointerException

Flag: NONE
Test: Presubmit
Fixes: 335485976
Change-Id: Ia91f95dc4839c9d4c00c7aeed6cc9cebdafa33ee
2024-04-19 18:18:51 +00:00
Vinit Nayak c0a1fbe872 Merge "Revert^2 "Launch split tasks at beginning of animation instead of the end"" into main 2024-04-19 17:00:37 +00:00
mpodolian 73b07e2024 Updated pointer to match visual specification.
Updated bubble bar view pointer to have rounded tip.

Test: BubbleBarViewAnimatorTest
Fixes: 333546362
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I7875426b06a330bc355a833c51849335f831317e
2024-04-19 15:32:26 +01:00
Brandon Dayauon 715059a1e3 Merge "Make settings cog animate back to original button" into main 2024-04-19 10:07:36 +00:00
Luca Zuccarini 62535f1fab Merge "Settle without jumping at the end of the home transition." into main 2024-04-19 09:50:38 +00:00
Vinit Nayak a6bf5a0014 Revert^2 "Launch split tasks at beginning of animation instead of the end"
This reverts commit fb092a9a6c.

Reason for revert: b/333937249

Change-Id: I77bd6c0d2fbe2f2dad074e8e0e741b50d4d7c204
2024-04-19 00:18:16 +00:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
2024-04-18 14:32:33 -07:00
Liran Binyamin 4d91e16589 Merge "Give bubble team owners on launcher bubble dirs" into main 2024-04-18 18:45:54 +00:00
Liran Binyamin a87abece5a Handle taps on the animating bubble
Make the animating bubble touchable and expand the bubble bar when tapping on it.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/c4wBVtrT5YIgxL5kVuuoDU

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I09281c2ebc9921750ada42dfc27e95d1ad0bd83b
2024-04-18 13:52:22 -04:00
Liran Binyamin b8ae441c10 Give bubble team owners on launcher bubble dirs
Flag: N/A
Test: treehugger
Bug: none
Change-Id: Ic5f69f34a1561ffb5a879a88b1532754e4b38f42
2024-04-18 12:18:21 -04:00
Liran Binyamin a7d2658d96 Merge "Update new bubble animation" into main 2024-04-18 15:51:39 +00:00
Mykola Podolian 3291b85e5e Merge "Update bubble bar to match visual spec" into main 2024-04-18 15:09:34 +00:00
Eghosa Ewansiha-Vlachavas f6ea0a3a2b Merge "Gate new desktop task menu button with device config check" into main 2024-04-18 15:02:52 +00:00
Eghosa Ewansiha-Vlachavas e885e54d90 Gate new desktop task menu button with device config check
Desktop windowing is enabled only when the desktop windowing flag is
enabled and the device is supported through setting a device config
flag. Add this device config check to the desktop task menu button so it
does not appear if the device is not compatible.

Flag: NONE
Fixes: 335178869
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: Ia2559c1ff57bb7921867e69a47d868c03eae57e7
2024-04-18 11:47:55 +00:00