Commit Graph

12235 Commits

Author SHA1 Message Date
Andy Wickham da5a89b130 Doesn't scale PagedView snap speed during tests.
Settings.Global.getFloat causes a Binder
transaction which breaks BinderTests.java
when running it from Android Studio.

Test: BinderTests.java
Bug: 187428578
Change-Id: I07ce2fe256dba0bfa98a5dade538d68e7ce357ff
2021-07-23 23:08:46 +00:00
Alex Chau 0686931b68 Use DeviceProfile.isTwoPanels for two panels expectation in tests
Fix: 193810767
Test: TaplTestsLauncher3.testWorkspace
Change-Id: Ifec5506415b79f3effa84fe0163eb1bb2bc7cc8d
2021-07-16 15:14:34 +00:00
András Klöczl f52f6206dc Merge "Fix two panel accessibility issues" into sc-v2-dev 2021-07-16 12:05:47 +00:00
Steven Ng 4083ae30db Merge "Scale RemoteViews from requestPinAppWidget shown in AddItemActivity" into sc-v2-dev 2021-07-16 09:24:02 +00:00
Andras Kloczl 77b3eb0acb Fix two panel accessibility issues
When two panel home was enabled in Launcher the items on
the left panel weren't able to get selected while on Talkback
because of an incorrect calculation in getScrollProgress.
Also the user was unable to jump to other workspaces by doing
simple one finger swipes because the page jump count was
only 1.

Test: manual
Bug: 174464170
Change-Id: I6cfe39b5059e8e7e7a32c9b0d372c658e796c3e8
2021-07-16 10:39:51 +02:00
Steven Ng 02c75d9897 Fix class cast issue in AddItemActivity am: 671ffb88ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: I393d4540df0b32e644e3d1a963db14564281c03c
2021-07-16 02:04:23 +00:00
TreeHugger Robot f877edb8fc Merge "Fix work profile disable button falsing" into sc-dev am: 753c8b7016
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15286021

Change-Id: I20ea01059f339d8a3dbe1186b7d838fd17faf539
2021-07-16 02:02:54 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Alex Chau 0eaf4e86a2 Merge "Enable logs on swipe detection in tests" into sc-v2-dev 2021-07-16 00:28:42 +00:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Alex Chau 46b9a41686 Enable logs on swipe detection in tests
- Enable BaseSwipeDetector log in tests
- Add log for scroll finish and motion pause event

Bug: 193440212
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: Idab566bc615050f73d898459897b66f8b95951b3
2021-07-15 20:45:51 +01:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Steven Ng 2b123833ad Scale RemoteViews from requestPinAppWidget shown in AddItemActivity
Test: manual
Bug: 193144010

Change-Id: Ia2b64c32f92a43a8d71ee82f164543e1e624814a
2021-07-15 17:59:45 +01:00
TreeHugger Robot eba399c130 Merge "Reland "Snap to relative position to snappd task when dismissing"" into sc-v2-dev 2021-07-15 16:27:11 +00:00
Steven Ng b3880636c4 Merge "Scale widget previews" into sc-v2-dev 2021-07-15 15:58:08 +00:00
Steven Ng 671ffb88ca Fix class cast issue in AddItemActivity
AddItemActivity is a standalone activity. There is no Launcher activity
instance. Avoid using LauncherAppWidgetHostView in WidgetCell by
replacing it NavigableAppWidgetHostView instead

Test: Check preview layouts are correctly rendered in widgets picker
      and pin widget dialog. Also test drag and drop to verify the
      local color extraction still works when dragging a preview layout
      from widgets picker to home screen.
Fix: 193765783
Change-Id: I3a734a54941257cebcd7b7f6a4c2c9cc764c5c12
2021-07-15 16:06:51 +01:00
Alex Chau 031373daa3 Reland "Snap to relative position to snappd task when dismissing"
This reland commit ba61b98fca accidentally reverted by http://ag/15162411

Bug: 188793333
Test: manual
Change-Id: Iae07a67d528aa80e8f87d37758244d0c46b61cf7
2021-07-15 15:12:34 +01:00
Steven Ng f3d23f67bd Scale widget previews
This CL covers drag requests initiated from Launcher.java but not from
other activities.

Test: Manual
Bug: 193144010
Change-Id: Ieb862d689afe81a5b35aedeb9a277de08c775230
2021-07-15 12:22:37 +01:00
TreeHugger Robot 753c8b7016 Merge "Fix work profile disable button falsing" into sc-dev 2021-07-15 00:27:59 +00:00
Hyunyoung Song 44424572b4 Fix work profile disable button falsing
Bug: 191996677

Test: before this CL: when tapping on immediately above keyboard when
keyboard is translating or when onApplyWindowInset is called, the
hidden (GONE) view handles touch and triggers work profile to be disabled.

After the CL, the button view is not attached to the parent container
when on personal tab. Also, the onApplyWindowInsets method translations
can only be called when work tab is selected.

Change-Id: Ib3e9a5c4b3280052f9ccb62a199ed256ae4e094f
2021-07-14 15:09:26 -07:00
András Klöczl 7609cc4e58 Merge "Fix launcher preview for two panel home" into sc-v2-dev 2021-07-14 15:16:07 +00:00
TreeHugger Robot 6224eaea29 Merge "Notify System UI about taskbar state" into sc-v2-dev 2021-07-14 10:59:26 +00:00
Schneider Victor-tulias 38a6d462a2 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: Icb5e7cdca02fab3c6c165ab3c612ee943d97d947
2021-07-13 23:41:14 +00:00
Schneider Victor-tulias ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00
Andras Kloczl ac3f08558c Fix launcher preview for two panel home
Test: manual
Bug: 185508060
Gif: http://shortn/_oOgKLjg5QC
Change-Id: I216b3761b3bd15c7069b92aa4a1bff8ad655b767
2021-07-13 23:13:17 +02:00
TreeHugger Robot a4821a0bb8 Merge "Fix hole in recycler view" into sc-dev am: 3d6d2e38b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15270060

Change-Id: I7bf9cd8b3ed98c086b0496ce84f5f41d312d68dc
2021-07-13 19:16:02 +00:00
TreeHugger Robot 3d6d2e38b0 Merge "Fix hole in recycler view" into sc-dev 2021-07-13 19:05:22 +00:00
Hyunyoung Song b6acd14d0f Fix hole in recycler view
Bug: 153780395
Test: manual

Without this change, typing single character and then
backspace, and then scrolling down and up will result in
hole in recycler view.

Change-Id: Iff6fa3f147d8bfdb8a7e84847b96e5390941dd4e
2021-07-13 09:51:42 -07:00
Steven Ng 16c9ebabbf Merge "Fix shortcut size calcuation" into sc-dev am: 372e85106d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15259646

Change-Id: I5b37dc1971d67afbc3923774db2256459e389ae6
2021-07-13 14:10:25 +00:00
Steven Ng 372e85106d Merge "Fix shortcut size calcuation" into sc-dev 2021-07-13 13:59:41 +00:00
Steven Ng 6fe115b2ae Fix shortcut size calcuation
Shortcut size should be the size of all apps icon + padding

Test: Check shortcuts and widgets are shown without crash in the
      following surfaces with display & font set to largest and
      display cutout enabled. Repeat the same test with normal
      display setting and no cutout.
      1. Full widgets picker
      2. Bottom widgets picker
      3. Pin widget dialog
Fix: 193422438
Change-Id: Ibfebf94e92eed5e9cd1dd4196d98823b0e4dda6b
2021-07-13 12:46:31 +01:00
TreeHugger Robot fc98f27759 Merge "Add accessibility announcement when user clicks on 'Add automatically to home screen' button" into sc-dev am: 972ab9327c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15242979

Change-Id: Ie8a852ed4ac0d2856a1afc2a33aca3b6905dc9da
2021-07-13 05:20:29 +00:00
TreeHugger Robot 972ab9327c Merge "Add accessibility announcement when user clicks on 'Add automatically to home screen' button" into sc-dev 2021-07-13 05:06:10 +00:00
Alina Zaidi dfa2752d28 Add accessibility announcement when user clicks on 'Add automatically to
home screen' button

Test: Tested manually with talkback on
Bug: 192808036
Bug: 192811245
Change-Id: I1c02738e0e4755b3bbdde12dad96ac2ed1996e6c
2021-07-12 15:37:13 +01:00
Steven Ng fbb82586a7 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
(cherry picked from commit 3d27207ff6)
2021-07-12 10:29:56 +00:00
Steven Ng ac21df2246 Merge "Clear WidgetCell#mItem before recylcing a WidgetCell" into sc-v2-dev 2021-07-09 22:16:03 +00:00
Schneider Victor-tulias bfe33b057a Update Gesture navigation tutorial to match new specs
- Updated strings
- Updated removed 'next' button when there are followign steps
- Added timeout to automatically continue the tutorial
- Combined back left and right into one step

Bug: 192009114
Bug: 177005427
Test: manual
Change-Id: I58b9017c4d69b5d097326c7d5be156a63951fb1a
2021-07-09 19:38:16 +00:00
Steven Ng 3d27207ff6 Clear WidgetCell#mItem before recylcing a WidgetCell
This fixes a bug which reuses a previous widget item spans to
compute the preview size.

Fix: 193133048
Test: manual
Change-Id: I5459882e258dc010898854dbbe52a6fa8d84796c
2021-07-09 17:45:19 +01:00
Steven Ng 12b2742780 Merge "Restricts the width of pin widget dialog to 89% on large screen devices" into sc-v2-dev 2021-07-09 09:38:33 +00:00
Steven Ng 3572c9100a Merge "Wrap the widget preview of the add item sheet with a scroll view" into sc-v2-dev 2021-07-09 09:00:31 +00:00
Steven Ng 1afca4dce5 Wrap the widget preview of the add item sheet with a scroll view
Test: manual
Fix: 192622015
Change-Id: I1eb676a92201970962c71194682ea70ce42b3d1b
2021-07-08 22:22:17 +01:00
Steven Ng 452e8b8512 Correct # of cells estimation that can fit horizontally in widgets
picker

Fix: 192661517
Test: check widgets are fit correctly in both full & bottom widgets
      picker in portrait and landscape in different grid settings.
Change-Id: Ic1b0589b7ccf62ff1ec1fd5713b4249ba58246a5
2021-07-08 16:23:38 +01:00
Steven Ng a37de9e141 Restricts the width of pin widget dialog to 89% on large screen devices
Test: manual
Fix: 193116981
Change-Id: I6ff8920a3698e6c11729b01a140a6942268f67cc
2021-07-08 16:06:50 +01:00
Vinit Nayak 9241fe62d1 Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: Ia48a1e6b2ebab8f94f374d0c4369bf4b62d13bea
2021-07-07 20:13:15 +00:00
Vinit Nayak 7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Andras Kloczl 88716645cd Fix icon adding issue on two panel home
Test: manual & PromiseIconUITest & RequestPinItemTest
Bug: 192431856
Change-Id: I4a6319fa33c9359057f87d9c008eb139410593b5
2021-07-06 17:41:26 +02:00
Hyunyoung Song 6700b07b95 Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev am: 933d2536da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184812

Change-Id: I11f7a50edec21c2ed2adca381f7841a4844b2580
2021-07-02 21:36:55 +00:00
Hyunyoung Song 933d2536da Merge "Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"" into sc-dev 2021-07-02 21:18:18 +00:00
Hyunyoung Song 5881b910e9 Revert "Don't use ProxyActivity when launching from SearchActionItemInfo intent"
This reverts commit 878dedfb84.

Reason for revert: b/192558017
Bug: 192558017

Change-Id: I41e64ab74c00d7b255be6f3ef1b783c01571d641
2021-07-02 21:18:10 +00:00
Hyunyoung Song 40729fbdd6 Merge "Remove flicker when dismissing snackbar" into sc-dev am: 2d8856537e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15190712

Change-Id: I96da9d1380c2131849080e7835ed30b2b17f16a2
2021-07-02 20:42:24 +00:00