Commit Graph

1252 Commits

Author SHA1 Message Date
Jon Miranda 0fe7e089ca Merge "Align taskbar to the left/right in 3 button nav for certain devices." into tm-qpr-dev 2023-03-09 22:33:28 +00:00
Jon Miranda e17a949950 Align taskbar to the left/right in 3 button nav for certain devices.
Otherwise we position the taskbar in the center.

Bug: 259712417
Fixes: 267997547
Test: transient taskbar unaffected
      persistent taskbar
      - test on small tablet
      - test on large tablet
      - test LTR and RTL

Change-Id: Ieb0a304d9963ebf583bc4ef2deaab747019e8d6d
2023-03-09 22:33:18 +00:00
Ats Jenk bac6d4946a Merge "Remove empty desktop tile" into tm-qpr-dev 2023-03-09 00:31:50 +00:00
Jagrut Desai d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
Ats Jenk 4d01acf44e Remove empty desktop tile
Do not show the desktop tile in overview when there are no apps on the
desktop.

Bug: 270399069
Test: have desktop mode proto 2 enabled, launch an app in fullscreen,
  open overview, observe no desktop tile
Test: move an app to desktop, be on desktop, open overview, observe
  overview is opened with desktop tile focused
Test: have an app on desktop, go home and launch an app in fullscreen,
  open overview, observe fullscreen app is focused, desktop is peeking
  in from right
Test: have an app on desktop and a fullscreen app in overview, open
  desktop from overview, close the desktop app, open overview, observe
  desktop tile is not shown
Change-Id: Ia8657d5b260043a630f32b35f2560ea93273d421
2023-03-08 11:49:48 -08:00
Ats Jenk 8efad6b111 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev 2023-03-08 19:10:09 +00:00
Jagrut Desai 1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Ats Jenk 80f4c20f6c Set desktop icon to always use black for the icon
Desktop icon in overview was using a themed color for the icon. But the
background is always a white circle. When using a dark theme, the themed
primary text color is too light. Fixing the color of the icon to be
black always.

Bug: 267326722
Test: enable dark mode, open overview and check the desktop tile icon
Change-Id: Ibcfdfd92ffe2db41cf6ed75c3da8f6457773c2bf
2023-03-07 14:24:37 -08:00
Schneider Victor-tulias f1a0bd61f4 Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev 2023-03-07 20:49:22 +00:00
Schneider Victor-tulias ec76d6e4b9 Translate the navigation setting text to prevent overlapping with home gesture hint
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.

Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
2023-03-06 19:14:40 +00:00
Brandon Dayauon ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Brian Isganitis 5248b02080 Merge "Treat setup wizard default home as null." into tm-qpr-dev 2023-03-03 21:11:18 +00:00
Brian Isganitis 589cb3480a Treat setup wizard default home as null.
During setup, default home progresses setup -> null -> launcher, which
can lead us to unintentionally preload the fallback overview.

Fix: 258022658
Test: Manual
Change-Id: I952b7923b06f2d4b058f42834d1f840719c73fd0
2023-03-01 18:05:51 -08:00
Bill Yi 3f4d577e24 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I945470f393b326f16958e50d928972d159a3bda6
2023-02-27 06:57:17 -08:00
Jagrut Desai 3addf0b66d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev 2023-02-25 01:49:59 +00:00
Jagrut Desai 560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
TreeHugger Robot c1883668f4 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-02-22 20:59:46 +00:00
Ats Jenk 431c0c05fd Merge "Add empty view to desktop tile in overview" into tm-qpr-dev 2023-02-22 19:30:55 +00:00
Bill Yi f37947d879 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia3af5fda1c89d7a29ca6579059d87e3043b87610
2023-02-21 09:25:45 -08:00
Ats Jenk 4d397e2ebb Add empty view to desktop tile in overview
Show an empty view when there are no tasks on the desktop.

Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
  desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
  is shown in overview and empty view is hidden

Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
2023-02-17 16:48:47 -08:00
Sunny Goyal 239d6e9b8d Adding support for customizing shortcut pinning logic
> Allowing support for overring shortcut badge
> Updating pendingShortcutInfo so that the
  handler can be easily overridden

Bug: 268253894
Test: Verified on device
Change-Id: I3184cb6494bc98c7eed33798b35b4e6e6a1e7ddc
2023-02-17 18:07:23 +00:00
Jagrut Desai 202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Bill Yi 5839ffa71b Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-02-15 19:21:36 +00:00
Ats Jenk 4ec2d1296f Merge "Add support for showing border for desktop tile" into tm-qpr-dev 2023-02-15 17:48:53 +00:00
Bill Yi 22f97f02bd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I262d0ca873322a1bcd7c79201b0c98883a7e4b94
2023-02-14 21:09:19 -08:00
Ats Jenk ae7e03440c Add support for showing border for desktop tile
When a external keyboard is connected and ENABLE_KEYBOARD_QUICK_SWITCH
feature flag is enabled, we highlight the selected tile in overview.
Add support to the new desktop tile to show the highlight.

Bug: 269342116
Test: connect an external keyboard, use alt+tab to open overview and
  switch between the tiles
Change-Id: I29ac5864776a9a251ecdb0cb4b741b12747de564
2023-02-14 14:40:07 -08:00
Schneider Victor-tulias de7ceba80b Add the KeyboardQuickSwitchView (2/2)
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
Schneider Victor-tulias f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Jagrut Desai ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
TreeHugger Robot af092ea846 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-02-11 07:43:22 +00:00
Ats Jenk 90d0019447 Merge "Add icon to desktop tile in overview" into tm-qpr-dev 2023-02-10 21:47:31 +00:00
Ats Jenk 78b614f555 Add icon to desktop tile in overview
Copied over icon from caption desktop button in WMShell. Temporary icon
for now.
Refactored some logic in TaskView to better support for custom
orientation handling in subclasses. Subclasses can override setting
orientation for icon or thumbnail.

Bug: 267326722
Test: manual, enable desktop windowing proto 2 and go to overview
Change-Id: Id66d48fa52a418a07b954a384b2c3ea22f091b1f
2023-02-10 10:16:31 -08:00
Bill Yi fd8d21179a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibdaf9a8936e17246f19955354e41828ed660f568
2023-02-10 01:44:30 -08:00
Saumya Prakash 65a0ee776e Merge "Update strings on "All set" screen." into tm-qpr-dev 2023-02-09 23:03:18 +00:00
Saumya Prakash 0c72529fae Update strings on "All set" screen.
Change the string to "Swipe up to go home" to match new UI changes.
Screenshot: https://screenshot.googleplex.com/5SqP2fQFPKdybcr.png

Fix: 263561675
Test: Manual
Change-Id: Iffc81fa8ea532729096a106e0182200d897375e7
2023-02-08 23:41:56 +00:00
Saumya Prakash a184e0def7 Merge "Migrate from using CardViews to Views in gesture nav tutorial layouts." into tm-qpr-dev 2023-02-08 23:02:04 +00:00
Saumya Prakash c65f37e7c6 Migrate from using CardViews to Views in gesture nav tutorial layouts.
Use Views in layouts for the gesture navigation tutorial instead of CardViews. We only migrate the classes that will end up being used in the redesigned gesture tutorial.

Fix: 268259319
Test: Manual
Change-Id: I510c8b3f840d0267dd6dfca573cc69c4996d525c
2023-02-08 19:28:05 +00:00
TreeHugger Robot 96328e98d1 Merge "Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag." into tm-qpr-dev 2023-02-07 21:03:18 +00:00
Jon Miranda 24bd17f23d Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag.
Test: manual
Fixes: 268056334
Change-Id: Iab0eb1ca76b49f0acb96f50274cb2c81d9f213a5
2023-02-07 09:09:52 -08:00
TreeHugger Robot f28599a960 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-02-06 20:37:31 +00:00
Ats Jenk b759d55a50 Merge "Pin desktop tile to the right in overview" into tm-qpr-dev 2023-02-06 20:01:24 +00:00
Bill Yi ed5f8430e2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I02296771fa891195c29548f9a75f6e36b5bf943b
2023-02-05 17:28:16 -08:00
Ats Jenk 6f50ca34c4 Pin desktop tile to the right in overview
When desktop windowing prototype is enabled, pin desktop tile to the
right of the focused tile.
Also making desktop tile persistent so it will always show up,
regardless whether there are tasks added to the desktop or not.
Fixing some nullpointer issues that stem from that.

Bug: 261234155
Test: no recent tasks, go to overview, shows empty view
Test: only desktop tasks, go to overview from home, desktop tile focused
Test: only desktop tasks, desktop open, go to overview, desktop tile
  focused
Test: 1 fullscreen task and some desktop tasks, go to overview from home
  screen, fullscreen tile focused
Test: fullscreen task open and no desktop tasks, go to overview,
  fullscreen task focused and empty desktop tile on the right
Test: fullscreen task open and some desktop tasks in background, go to
  overview, fullscreen tile focused, desktop tile on the right
Test: some desktop tasks focused, some fullscreen tasks in background,
  go to overview, desktop tile focused, fullscreen tasks on the left

Change-Id: Ib28185b40f639d36b82b6d0e3c61026ec84e245c
2023-02-03 17:29:43 -08:00
Brian Isganitis d98de99af8 Merge "Support persistent/transient asset variants in EDU tooltip." into tm-qpr-dev 2023-02-03 23:24:58 +00:00
Vinit Nayak 6fa1ab9441 Merge "Unify split options into single option" into tm-qpr-dev 2023-02-03 06:07:41 +00:00
Brian Isganitis 720dcd2d3b Support persistent/transient asset variants in EDU tooltip.
Test: Manual
Fix: 267384293
Change-Id: Ia4aefb7d0e9bf675355ea52f657f78b7533eeb98
2023-02-02 14:15:47 -08:00
Saumya Prakash 334094da9e Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev 2023-02-02 21:54:10 +00:00
Saumya Prakash b1291e6ae2 Redesign the tutorial for the go home gesture
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.

Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
2023-02-02 18:14:14 +00:00
Vinit Nayak 5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Jon Miranda 9443403104 Merge "New taskbar threhsolds 30/100/180/300" into tm-qpr-dev 2023-02-01 23:46:40 +00:00