PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
47,193 Commits 1 Branch 0 Tags
da10ae3330524a5a5e95ec3e643d0141bfa780df
Commit Graph

10229 Commits

Author SHA1 Message Date
Thales Lima 14527d5f6d Fix hotseat width to span a number of columns am: 828875cd12 am: ab5faf06a8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983445

Change-Id: I8b8ca39109683ce38653e5da3be32842868e73d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-29 18:44:25 +00:00
Shan Huang e622186f70 Merge "Fix screen rounded corner flicker." into tm-dev am: 8073fc8daf am: 276a31bbf8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17948370

Change-Id: If92b4c6527c173fe621b264b17d66eea1c01fef2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-29 18:44:17 +00:00
Mateusz Cicheński 4ffccee112 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev am: f312acc081 am: cc3cc0428e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17969666

Change-Id: I8a4d56baeef9ca5a5d5b5128a971e041f908e4d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-29 18:44:11 +00:00
Thales Lima ab5faf06a8 Fix hotseat width to span a number of columns am: 828875cd12 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983445

Change-Id: Ia462205bfb1ea81a8a83d7f6b522d196ccf8bc45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-29 18:00:56 +00:00
Thales Lima 828875cd12 Fix hotseat width to span a number of columns 
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
 2022-04-29 14:56:30 +00:00
Shan Huang 276a31bbf8 Merge "Fix screen rounded corner flicker." into tm-dev am: 8073fc8daf 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17948370

Change-Id: I15a3ccac2d38046ee4bef5d3a19a8cac6fe67f63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-28 20:47:39 +00:00
Mateusz Cicheński cc3cc0428e Merge "Make Hotseat report shelf height on large screen devices." into tm-dev am: f312acc081 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17969666

Change-Id: Ifa0e62550691414636c9cb97fc5d32d0940f8dd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-28 20:46:22 +00:00
Shan Huang 8073fc8daf Merge "Fix screen rounded corner flicker." into tm-dev 2022-04-28 19:34:37 +00:00
Mateusz Cicheński f312acc081 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev 2022-04-28 18:48:11 +00:00
Anushree Ganjam 34fc3c4aee Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev am: fa693be19f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18011182

Change-Id: I8ae06fc716589295d47b5fe4101ea26b3dd217de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-28 05:29:50 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam 5cc7ff0990 Revert "Refactors Search results into separate RV for Toast." 
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
 2022-04-28 01:37:49 +00:00
TreeHugger Robot 6d7db81e74 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I03703262518cf2fd060bf4d3b0a89337e9a92b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-27 16:43:22 +00:00
Alex Chau 2a6e364e91 Remove unnecessary updatePivots 
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
 2022-04-27 13:57:39 +01:00
Alex Chau c7fee694e7 Merge "Update overview actions alignment" into tm-dev am: a80efcee9f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: Ie7496af60cde34345324140511a7b2f7b255f10f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-27 12:47:17 +00:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Jerry Chang 448ae578f9 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I523efffd571c815efe94836f3560d3b1c60788b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-27 03:50:22 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Mateusz Cicheński 76fb120994 Make Hotseat report shelf height on large screen devices. 
Test: http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ckTLvEEiaCugieedwOU6tj
Bug: 198311114
Change-Id: I9d5bc6ab031fb6d07d5205581c33aa5ab9b45a8c
 2022-04-26 23:34:22 +00:00
Tracy Zhou 7148e74f1e Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: Ic6378b71451cafcf02ece812c93a240123cd2c03
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-26 17:53:25 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
Shan Huang 3e952539a1 Fix screen rounded corner flicker. 
We've previously always played transitions with a fixed start corner
radius. This should however be an interpolated value based on gesture
progress.

Bug: 230115505
Test: Turn on predictive animations. Try completing a back swipe as well
as canceling a back swipe. Observe corner radius to make sure there's no
flicker.

Change-Id: Iae2517d969ed1b779bced866407b939b3a011b68
 2022-04-26 17:16:22 +00:00
TreeHugger Robot 14615df286 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I86545cb56dac22db803cacfdc893f82efcecefd5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-26 15:36:46 +00:00
Alex Chau a2fc764405 Update overview actions alignment 
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
 2022-04-25 19:20:21 +01:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks 
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
 2022-04-25 15:41:28 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast. 
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
 2022-04-24 17:36:48 -07:00
TreeHugger Robot 9c3bd94b48 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I3083e1b4d5e9556b0152b8229658575e403ca76a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 03:24:58 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham cc10db044f Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Id798f042e7cc39d76fb3e4ce8c7ffbf2a54184fd
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-23 01:18:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized 
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
 2022-04-22 17:28:35 -07:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial. 
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
 2022-04-22 16:37:49 -07:00
Tony Wickham 9de10ff889 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I6c01f58f282234ce2e85a582a25a442ba7c7d9d2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 23:19:24 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere 78194ca6ad Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I7e56d7a2f10052f9cb0a3ef6e83e33aa4024f493
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:11:04 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal d99aee90ef Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Id8a4e2f0a5b45267b8386f22b15639f232e93460
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 21:03:22 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview" 
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
 2022-04-22 21:02:22 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim cca5e510fd Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I18ac8925b7cf520d4d123c6648dc0e7cbaf2a862
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:10:47 +00:00
TreeHugger Robot e17589f4b8 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: If978a1789f76f0edbc8259031c42f9fe94438dc9
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:10:37 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Tony Wickham 44e65099c2 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I437518bf5b439cf7918ffe42d4bfdf9971207e3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 20:02:21 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled 
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
 2022-04-22 19:58:40 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot 0e46bac72f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: Ie2e30df6666338626d6d4575ac68572dba305c43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 17:53:48 +00:00
Alex Chau a6f8f85436 Update pull back animation for tablet AllApps am: e3b806366a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If9173888b7e3a0680001eed885aa88bd7d93a69a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-04-22 17:53:25 +00:00
TreeHugger Robot 37fa1392ec Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev 2022-04-22 17:33:06 +00:00
Sunny Goyal 7b8d63fcf8 Removing fade in logic during load. 
Launcher already blocks the draw during load, which ensures
that system draws the loading screen. Additional fade animation
is not visible since the Launcher window is already getting fade in

Bug: 199120420
Bug: 199120420
Test: Verified on device

Change-Id: I7089cea4c5f97f6ef92eabcba56451de407c98b8
 2022-04-22 16:35:40 +00:00
Alex Chau e3b806366a Update pull back animation for tablet AllApps 
- This is a follow-up of http://ag/17636490
- Introduced animation property specifically for pullback translation and alpha, which will invoke getRecyclerViewContainer directly on tablet, and invoke aggregate setter of appsView on phones
- Delay reset of pullback animation to after dismiss animation to avoid jump in value during state transition animation
- Introduced property factory for addictive properties similar to MultiScalePropertyFactory

Fix: 220345008
Test: manual on small and large screen
Change-Id: I7b5c0019c1d4d36c3c7ca4ec79e38e4eb09c32ca
 2022-04-22 16:27:25 +01:00