Commit Graph

3652 Commits

Author SHA1 Message Date
Winson Chung 5b50e92a65 Merge "Don't finish to home when launching a task from recents" into sc-dev am: d27f127b3a am: 87c7e0d963
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15057896

Change-Id: If53c0028ef6e15afca447df349ec0fab4cc4ebc8
2021-06-22 19:32:50 +00:00
Winson Chung d27f127b3a Merge "Don't finish to home when launching a task from recents" into sc-dev 2021-06-22 18:54:14 +00:00
Winson Chung 856cd1bd4d Don't finish to home when launching a task from recents
- When launching without a task view, we should also not be finishing
  to home (similar to composeRecentsLaunchAnimator) since it will
  clobber the newly launched task

Fixes: 191182965
Test: Open overview with live tile, try to open usb debugging settings
      page
Change-Id: If7464ebf155cee33e81205fbf4899e9ab49a52d0
2021-06-22 18:54:03 +00:00
Cyrus Boadway 05461df6c0 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev am: 9dd0351ed1 am: e995155f7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062776

Change-Id: I3826fc194a75d3afc20cef9474d19b25f078f00f
2021-06-22 18:37:45 +00:00
Sunny Goyal 1bf8b7e9d0 Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev am: eb3367796a am: ed0d2c40f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032513

Change-Id: I30ba9bdbec9cd20e1b5691d40b183dbf274ced44
2021-06-22 18:37:40 +00:00
Cyrus Boadway 9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou 04f866bf1b Merge "Null check on target set before rendering task open animation" into sc-dev am: 578b45f919 am: af60e8e5b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14698046

Change-Id: I3ea98b76e73a047f831079a9e5f1ad03c7dcf2c5
2021-06-22 18:00:30 +00:00
Zak Cohen 3ab08fd258 Merge "Fade overview action buttons faster in overview -> home" into sc-dev am: 049c2f578b am: 7663208d0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054721

Change-Id: I366a9998531c8e478ecfe048200d86dca2bda655
2021-06-22 17:29:00 +00:00
Matt Casey 37567c24f8 Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298 am: d85152e484
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: I0327d3932072b5e3829f9139f822defc17b50964
2021-06-22 17:28:36 +00:00
Tracy Zhou 578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen 049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey 3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou 8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Lucas Dupin 9a6bde9234 Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794 am: 07b3fc2d2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: Ib7e69cdf0a320697510c87dd321de4390e05445c
2021-06-22 01:52:16 +00:00
Lucas Dupin 818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal 6cc492941b Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb am: b6cdee307b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I250b79241b12f23c0f53d1710887bf7327071cfb
2021-06-21 23:11:44 +00:00
Tony Wickham 10018d2191 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5 am: 4de1650940
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I3943bc9286ae242dca9e9256ea34e65937463a10
2021-06-21 23:11:35 +00:00
Sunny Goyal 696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal 871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen 061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham 82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky 08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham 9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Tony Wickham 29d762fb82 Merge "Initial commit of taskbar stashing" into sc-v2-dev am: 0ac023196d am: a2be8926bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14941111

Change-Id: I3da658073e4ad181c872021f3b4faa8d6a2d1160
2021-06-21 19:56:54 +00:00
Tony Wickham 0ac023196d Merge "Initial commit of taskbar stashing" into sc-v2-dev 2021-06-21 15:56:12 +00:00
Jonathan Miranda db2f0df330 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682 am: 24ae397544
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: Icc2e06db004672614609b009ffbdb37d092bc7ae
2021-06-20 23:10:13 +00:00
Jonathan Miranda 94df55bada Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I9ab72caa407fd3e6a2e6130bcf9e924ba2c7726c
2021-06-20 22:59:04 +00:00
Vinit Nayak 0e4375e3b7 Merge "Add IDs to buttons in 3 button nav for Taskbar" into sc-v2-dev am: 3fcc02b8dc am: 7107268df9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027506

Change-Id: I7fc65aa447ab6ca63b3e5b0ff1802ad056ab4b56
2021-06-19 06:20:53 +00:00
Vinit Nayak b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Sunny Goyal 63f52f8308 Merge "Fixing out of order taskbar callbacks" into sc-v2-dev am: d7e17a860f am: a5422c8902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023048

Change-Id: I99bffa51e5d30143acd2805f4c9d4a841967fb99
2021-06-19 01:12:26 +00:00
Tony Wickham 3fd22847ac Initial commit of taskbar stashing
- Added StashedHandleViewController to provide properties such as ViewOutlineProvider to animate the handle that's shown in place of taskbar while it's stashed
- Added TaskbarStashController to coordinate the stashed state, including orchestrating the animation across taskbar controllers
- Added TaskbarStashInput consumer to detect long press in the nav region when taskbar is stashed

Behavior:
- Long pressing taskbar background animates to the stashed state by morphing the TaskbarView into the stashed handle view and offsetting the background offscreen
- We persist the stashed state across app launches and reboot; to unstash, long press the stashed handle
- We also visually unstash when going back home

Test: long press tasbkar background when in an app to stash it, long press the resulting stashed handle to unstash; while stashed, swipe up to home to also unstash until launching another app
Bug: 189503603
Change-Id: I698eff785388dff1ef717c76879719d6af236c2d
2021-06-18 17:51:39 -07:00
Sunny Goyal d7e17a860f Merge "Fixing out of order taskbar callbacks" into sc-v2-dev 2021-06-19 00:40:46 +00:00
Vinit Nayak dcd9a0cdd6 Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev am: 70565c5e7d am: 0d50bfacb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017522

Change-Id: I3e010dd812b4b8cc2a3d23081f2fc5328401ef88
2021-06-18 23:20:17 +00:00
Vinit Nayak 70565c5e7d Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev 2021-06-18 22:56:24 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Sunny Goyal 6e1ce8ccb8 Fixing out of order taskbar callbacks
OnCreate can come before onDestroy for a previous activity which can
cause the callbacks for taskbar to get cleared

Bug: 190170303
Test: Presubmit
Change-Id: I48334605384d4604043a50ffc3d137f84575148a
2021-06-18 12:44:38 -07:00
Vinit Nayak 4d276961be Merge "Enable 3 button nav for taskbar" into sc-v2-dev am: ae7c8cacd5 am: fe043eafee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985475

Change-Id: I409cf319365ee2554236f5113dd8cc464f874367
2021-06-18 05:56:22 +00:00
Vinit Nayak ae7c8cacd5 Merge "Enable 3 button nav for taskbar" into sc-v2-dev 2021-06-18 05:43:41 +00:00
TreeHugger Robot 06292bf289 Merge "Fixing Taskbar not initialized properly on recreate" into sc-v2-dev am: cb207ef236 am: fcd4a6b131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019036

Change-Id: I56454821c074a01871452072f22c2c5e852c1f8d
2021-06-18 01:57:12 +00:00
Sunny Goyal deec62378c Fixing Taskbar not initialized properly on recreate
Bug: 187353581
Test: Manual
Change-Id: I6e675937a033a4edcb4fa4e8151c210e14e8f896
2021-06-17 15:19:12 -07:00
Vinit Nayak e91e4f0328 Default to requesting command type TOGGLE for OverviewCommandHelper
Parity with how sysui switches between apps for double
tapping recents button.

Fixes: 190660016
Test: Double tap to switch works, tapping fast also works
Change-Id: If6dda377d8accf564f3385e78c6721c677310361
2021-06-17 12:37:02 -07:00
Alex Chau 4d4dd93e75 Merge "Send TaskBar touch events to tests" into sc-v2-dev am: f77d45cce8 am: 1ffc292ed5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14736370

Change-Id: I01d6bd1faf3c6169a1f45e35458ec699a1d7dfda
2021-06-17 18:35:25 +00:00
Alex Chau f77d45cce8 Merge "Send TaskBar touch events to tests" into sc-v2-dev 2021-06-17 17:52:44 +00:00
Winson Chung 84f273878f Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519 am: 3df79133f2 am: 1294809bbc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I53529a2f0a90f4c4a71bd36c63b4793c8a683bfd
2021-06-17 17:31:44 +00:00