Commit Graph

11652 Commits

Author SHA1 Message Date
TreeHugger Robot d98a784d0e Merge "Overview - Remove the space withheld for proactive chips" into sc-dev 2021-05-26 00:11:18 +00:00
Vinit Nayak b74b9d2966 Merge "TaskMenu in overview UI polish" into sc-dev 2021-05-25 23:56:00 +00:00
zakcohen dad8a80d19 Overview - Remove the space withheld for proactive chips
Remove the space in the ui that was being used for chips.
Centralize some of the logic around calculating the action margins to aid
that.

Bug: 179922117
Test: Local build and flash and run
Change-Id: Icd2f894c858fab475c5411f3f7c412b899d5b220
2021-05-25 15:29:08 -07:00
Steven Ng 530f644788 Merge "Fix tabs abruptly reset during swipe" into sc-dev 2021-05-25 22:21:25 +00:00
TreeHugger Robot 17385ce33e Merge "Fix full widgets picker fast scroller height." into sc-dev 2021-05-25 21:43:40 +00:00
Vinit Nayak 063cb2d892 TaskMenu in overview UI polish
Bug: 188168717
Test: TaskMenuLooks closer to mocks.
Change-Id: I1560b66a48c4c70c7c79f7307b2b76f22e30c653
2021-05-25 14:42:35 -07:00
Sunny Goyal 47da5d628c Merge "Using icon color for dot and halo" into sc-dev 2021-05-25 18:24:56 +00:00
Sunny Goyal a71269e372 Merge "Updating method for getting themed icon" into sc-dev 2021-05-25 18:24:38 +00:00
Alina Zaidi e6521ad542 Merge "Add more education tips for widgets. (1/3)" into sc-dev 2021-05-25 17:35:27 +00:00
Alina Zaidi 9d24de1353 Add more education tips for widgets. (1/3)
Show Arrow education tip on WidgetsBottomSheet. This tip is shown only
once either in widgets full sheet or bottom sheet.

Test: Tested manually
Bug: 185354491
Change-Id: I6d770ed0906a5cb0f5bcfe6ae0cd327b790cf164
2021-05-25 10:50:02 +01:00
Steven Ng 21979aca50 Fix tabs abruptly reset during swipe
The indicator position has already been updated by
PersonalWorkPagedView#onScrollChanged. The updateIndicatorPosition
call in setActiveMarker has abruptly reset the mScrollOffset to a page
index rather than a [0f, 1f] offset.

Test: On a work profile device, swipe left & right in the all apps.
      Then, swipe left & right in the full widgets picker. In both
      cases, I no longer observe an abruptly reset of the tabs
      transition animation.
Bug: 187704466
Change-Id: I53c4ed3a98219093f3d61dfa4de2fe21ec88851c
2021-05-24 23:57:28 +01:00
Steven Ng e90dddaaa0 Fix full widgets picker fast scroller height.
1. Fix the app title to one line.
2. Use the measured height of a header view to estimate the available
   fast scroll bar height.

Test: Open full widgets picker. Scroll to the bottom by scroll gesture.
      Observe the fast scroll bar indicator is correctly shown.
      Scroll back to top and then use the fast scroll bar to scroll to
      the end of the page. Observe the last app row is aligned to the
      bottom of the page.
Bug: 188914448
Change-Id: I57a2419d1fbfc8f946a932eebfefb67ae0c07eb6
2021-05-24 18:05:56 +01:00
Steven Ng ede641bd77 Adjust padding, margin of tabs in the WidgetsFullSheet
Also remove elevation set to tab to remove unwanted shadow.

Test: Set up a work profile. Then, open the full widgets picker.
      Observe padding & margin of the work / personal tabs.
Bug: 188221455
Change-Id: I761cb1c1410f87c80a5fdca3803fb8b099d499d6
2021-05-24 11:40:16 +01:00
TreeHugger Robot eb0a14ad79 Merge "Fixing missing unlinktoDeath" into sc-dev 2021-05-22 01:05:05 +00:00
Sunny Goyal b5596f72e4 Fixing missing unlinktoDeath
Bug: 186712316
Test: Manual
Change-Id: If06737403c346c5ccca533dec647e3a0691f1bfa
2021-05-21 15:29:33 -07:00
Sunny Goyal 6755587219 Using icon color for dot and halo
Bug: 188839628
Test: Manual
Change-Id: I8a393cc7073d5a249619b4033ec860c55f17167a
2021-05-21 12:57:38 -07:00
Sunny Goyal e9d27f137f Updating method for getting themed icon
Bug: 183641907
Test: Manual
Change-Id: I417886acea1b518c184d8e7c649367cae841a7e4
2021-05-21 12:29:15 -07:00
TreeHugger Robot 576722164a Merge "Apply the current system window insets to launcher preview" into sc-dev 2021-05-21 18:00:07 +00:00
TreeHugger Robot 3350508bb6 Merge "Avoid drawing tall header when scrolling search results" into sc-dev 2021-05-21 17:34:42 +00:00
Songchun Fan 6a69ff55b7 Merge "Reapply All Apps icons on download complete." into sc-dev 2021-05-21 15:59:58 +00:00
Sunny Goyal 67914aff50 Merge changes from topic "revert-14664190-JGHJCCJYPM" into sc-dev
* changes:
  Initiate taskbar only after the user is unlocked
  Revert "Revert "Renaming TaskbarController to LauncherTaskbarUIC..."
  Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
2021-05-21 15:45:11 +00:00
Alina Zaidi 260c38c4a0 Align 'No widgets available' text box properly in Widget picker.
Bug: 186209657
Test: Tested manually
Change-Id: I85fa43cd745a8c9f9601d25ed3a35f512506234d
2021-05-21 10:49:03 +01:00
Steven Ng 9f194ee290 Merge "Clear widgets search bar focus when the user taps outside the search bar" into sc-dev 2021-05-21 08:52:50 +00:00
Sunny Goyal d5500548dc Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
430465a3d5
Bug: 187353581
Change-Id: I7b2280d16adfafd3e85ffc1d22e32d0c00d12b67
2021-05-21 07:05:02 +00:00
Chihhang Chuang ccb71776c6 Apply the current system window insets to launcher preview
For wallpaper picker, the position of app icon on the wallpaper preview would match to the launcher after applying the wallpaper.

Wallpaper picker: https://screenshot.googleplex.com/JZazpgZLgzacZMZ.png
Launcher: https://screenshot.googleplex.com/9uTTQwdmcnFZ7Vi.png
Gesture mode: https://screenshot.googleplex.com/3YaKbBerYgtHBFb.png
3-button mode: https://screenshot.googleplex.com/7sA5nE3GmbuKf62.png

Fixes: 188539072
Test: Manually
Change-Id: I553000e6ae646207eb94fa33e97d00a3990043c8
2021-05-21 14:41:37 +08:00
Pierre Barbier de Reuille fd3ad5d769 Merge "Correct size of AppWidget for color extraction." into sc-dev 2021-05-21 06:06:30 +00:00
TreeHugger Robot 50308f3750 Merge "Fixing Launcher preview leaking surface and memory" into sc-dev 2021-05-21 05:51:08 +00:00
Winson Chung 07414d5cd5 Merge "Tweak ordering of first match search" into sc-dev 2021-05-21 03:15:55 +00:00
TreeHugger Robot 45f7360432 Merge "Animate recommended widgets vertical transition when reset widgets picker scroll position" into sc-dev 2021-05-21 02:02:47 +00:00
Steven Ng 36f9aa7530 Merge "Apply android:attr/dialogCornerRadius to widgets picker dialog top corners" into sc-dev 2021-05-20 23:46:53 +00:00
Steven Ng b46428fcd9 Merge "Remove work profile badge from widget previews" into sc-dev 2021-05-20 23:42:50 +00:00
Steven Ng 444b2489a5 Merge "Reset visible entries when the app tile of the same app no longer match" into sc-dev 2021-05-20 23:42:24 +00:00
Steven Ng f357dc4f3e Merge "Widgets: Only reset expanded item & scroll to top if the user switch tab" into sc-dev 2021-05-20 23:24:35 +00:00
Lucas Dupin c2bcdcee9b Merge "Make launcher opaque when scrim becomes opaque" into sc-dev 2021-05-20 23:11:46 +00:00
Winson Chung bd2fa26bda Tweak ordering of first match search
- Tweak iteration for finding first match, go by operator priority and
  check each cell layout by order to return the first view that matches
- Also reset the launch cookie in cases where we're launching a task
  that doesn't support cookies (ie. via prediction), otherwise we may
  still try to associate it with the last launched cookie later

Fixes: 187720286
Test: Swipe up from various icon types across hotseat/workspace
Change-Id: I71c4c13c442b0884b2247589685f976eaaeb30a4
Signed-off-by: Winson Chung <winsonc@google.com>
2021-05-20 14:50:33 -07:00
Sunny Goyal df4241ca4e Fixing Launcher preview leaking surface and memory
> Closing existing preview if a new request comes for same host token
> Closing in-memory icon db when closing preview
> Removing unnecessary wait blocks on UI thread and rendering
  view asynchronously
> Fixing preview loading failing on LauncherAppState access

Bug: 186712316
Bug: 187140897
Test: Manual
Change-Id: I045930b007e5dc015320224a197eee20a8354d17
2021-05-20 21:37:28 +00:00
Lucas Dupin 0c6341af99 Make launcher opaque when scrim becomes opaque
This will help with overdraw, because we don't need to draw the
wallpaper.

Test: manual
Test: adb shell dumpsys SurfaceFlinger --timestats -dump
Bug: 187703092
Change-Id: I2ebae94725578e5f4d640cd6b45da3f4d1f21a20
2021-05-20 14:33:39 -07:00
Steven Ng 400493c70c Apply android:attr/dialogCornerRadius to widgets picker dialog top corners
Test: Open full & bottom widgets picker and observe the top corners.
Bug: 188651333
Change-Id: If091e2d760042582bb98cbd3e44663542098ecd9
2021-05-20 22:05:29 +01:00
Pierre Barbier de Reuille 1b8bbb6c40 Correct size of AppWidget for color extraction.
Correct the size of the App Widget: first, compute the size when the
widget is positioned (it wasn't done), then do not apply the
transformation when computing the size of the widget when drawn.

Note: Somehow, there is a shift by 1 on the position on the x axis, both
in landscape and portrait. So I added a +1 to get the exact same values.
If not, we have a risk of getting different colors.

Fix: 188759989
Bug: 187907544
Test: Added logs and moved a widget by hand, check the actual
coordinates with hsv.

Change-Id: Ia3bd5b3e3ea9a3ef75f8cdf466a9800786646a94
2021-05-20 21:02:30 +01:00
Samuel Fufa d312651f79 Avoid drawing tall header when scrolling search results
Bug: 184946772
Test: manual
Change-Id: I1bedec89fb9eb5dc51b8b34511a02868cec91efe
2021-05-20 09:15:20 -05:00
Kholoud Mohamed 430465a3d5 Revert "Moving taskbar lifecycle to TouchInteractionService"
This reverts commit e215fb730b.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/tests/view?invocationId=I13700009003387451&testResultId=TR89423459137251402, bug https://buganizer.corp.google.com/issues/188755902

Bug: 188755902
Change-Id: I4650136975b60f311499ee6ff5b27ab9a32d23d6
2021-05-20 13:32:05 +01:00
Steven Ng 73d44f63b4 Animate recommended widgets vertical transition when reset widgets picker scroll position
Test: Set up work profile. Then open the widgets picker, scroll down from
      the personal tab, then switch tab. Observes a vertical transition
      animation of the search and recommendation container view.
Bug: 188538428
Change-Id: I2b8523d1682a6312de3b5393c0bff782ae110b3c
2021-05-19 23:58:54 +01:00
Steven Ng f735c738ea Remove work profile badge from widget previews
Test: Check work profile badge no longer shown on work widget in the
      full and bottom widgets pickers.
Bug: 177675123
Change-Id: I0e5e32e18df832c1919749404094d68805c30556
2021-05-19 21:45:10 +01:00
Samuel Fufa b1114a9834 Merge "[Search] Update all apps header protection" into sc-dev 2021-05-19 19:00:33 +00:00
TreeHugger Robot 1e558a2f4c Merge "Folder polish" into sc-dev 2021-05-19 18:00:18 +00:00
Steven Ng 2f2cbce818 Reset visible entries when the app tile of the same app no longer match
Test: Switch language and then go to full widgets picker. Expand apps.
      Expanded entry is shown underneath the expanded app.
Bug: 187529983
Change-Id: Ib438cf01656d3a177309e7f22796d0fa0c11881f
2021-05-19 15:40:02 +01:00
Steven Ng 1a55d1ff37 Widgets: Only reset expanded item & scroll to top if the user switch tab
Test: Open widgets picker, then adb install an app that has widget.
      Observe the newly installed app widget is shown and the widgets
      picker doesn't scroll itself back to top.
Bug: 188425375
Change-Id: I7ac29f08b06d528ef64e902e678a67e56971c681
2021-05-19 15:32:54 +01:00
Jon Miranda e3104682fb Folder polish
- Update folder hint text to ensure enough contrast.
- Clamp down on alpha when animating to local color extraction
- Update colors to new spec.

Bug: 179209484
Bug: 175329686
Test: manual
Change-Id: I9471504e10f02630ae13b2c478ced1ee05bd5220
2021-05-19 14:03:09 +00:00
Steven Ng 66034efaae Clear widgets search bar focus when the user taps outside the search bar
Test: Focus widgets search bar. Then tap outside the search bar and
      observe the keyboard is being dismissed.
Bug: 188540267
Change-Id: Ica1b5b804ed97dd0b1cd8d41351eddcf5249ded0
2021-05-19 11:31:09 +01:00
Sunny Goyal 194dcc0fd3 Merge "Removing number of threads used in background execution to prevent system thrashing" into sc-dev 2021-05-19 06:23:10 +00:00