Commit Graph

19022 Commits

Author SHA1 Message Date
Alex Chau 74804ae560 Merge "Remove unused @ScreenRecord and @Stability for closed bug" into main 2024-05-13 18:03:27 +00:00
Liran Binyamin 3fcdc0a39f Merge "Handle touch on bubble bar while animating" into main 2024-05-13 17:30:40 +00:00
Treehugger Robot b28f611163 Merge "Removing old workaround" into main 2024-05-13 15:53:22 +00:00
Liran Binyamin 6097a29158 Handle touch on bubble bar while animating
This change handles touches on the bubble bar while the bubble bar is animating.
We now update the taskbar touch region during the animation to make the bubble bar touchable.
When the bubble bar is touched during the animation, we now cancel the animation and allow dragging or clicking to expand.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gtGS6FCrygN5RKueFtPs5E

BubbleBarTest 100x run: https://android-build.corp.google.com/abtd/run/L42600030003675041
Note that in the abtd run above there's a flake but that's for a different test which I'll look into separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Bug: 280605846
Bug: 339066271
Fixes: 339244038
Test: See demo
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icb8f4fa46ae4bb8c94ca931193d4a3cc49c5b718
2024-05-13 09:41:23 -04:00
Luca Zuccarini 50a7190efa Merge "Update alpha animation for All Apps / Divider icon." into main 2024-05-13 13:32:23 +00:00
Pat Manning f0bff25b1e Merge "Unstash taskbar after timeout when cursor hovers bottom edge." into main 2024-05-13 12:44:21 +00:00
Alex Chau f1c402ad89 Remove unused @ScreenRecord and @Stability for closed bug
Fix: 309820115
Test: None
Flag: None
Change-Id: I7739c3eccb72e8c20e71ed85f5464e1619f8ea3f
2024-05-13 12:22:28 +01:00
Saumya Prakash 9352374c08 Merge "Move the Done button in gesture navigation tutorial" into main 2024-05-11 00:41:54 +00:00
Treehugger Robot 4423758449 Merge "Revert "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent"" into main 2024-05-10 22:51:13 +00:00
Alex Chau 42af1f0725 Merge "Convert DesktopTaskView to Kotlin" into main 2024-05-10 21:32:52 +00:00
Saumya Prakash b8782e7341 Move the Done button in gesture navigation tutorial
To align with updated UX specs, this change moves the Done button in
each gesture's tutorial from the middle of the screen to the bottom
right.

Fix: 293285057
Test: Run through the gesture tutorial in all font/display sizes for
different form factors and check that the Done button after each step is
in the new location.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2f2a7be0bf365727cff030f827e539add8533c18
2024-05-10 21:18:36 +00:00
Federico Baron 6619568efd Revert "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent"
This reverts commit 4f836430a7.

Reason for revert: issue resolved

Change-Id: I7174e50c166358634626aa308edbd5987e5cc2fb
2024-05-10 20:43:32 +00:00
Vadim Tryshev 306fa566f9 Removing old workaround
Bug: 165029151
Test: presubmit
Flag: N/A
Change-Id: Id54344f0b0423caa4c23eb574f0764648f49e41a
2024-05-10 13:40:37 -07:00
Vadim Tryshev 575d15f231 Cleaning up TestProtocol
Bug: 262282528, 279059025, 322823209
Test: presubmit
Flag: N/A
Change-Id: I9af6e3f1fc49b2ebf0d99df8c4514de0bddee8f2
2024-05-10 11:03:24 -07:00
Michał Brzeziński b839430047 Merge "Rename gesture_blocking_activities to back_gesture_blocking_activities" into main 2024-05-10 16:32:51 +00:00
Alex Chau a88d3beed7 Convert DesktopTaskView to Kotlin
Bug: 339787593
Test: Manual
Flag: None
Change-Id: I94ee4675c11ef64c12b0e3278d4af367b764375e
2024-05-10 16:11:52 +01:00
Treehugger Robot a8c1628d6e Merge "Fix bug where hotseat disappears" into main 2024-05-10 08:47:33 +00:00
Jordan Demeulenaere 3af63d8504 Merge "Delay TransitionAnimator.onAnimationEnd by one frame (2/4)" into main 2024-05-10 07:36:34 +00:00
Winson Chung 36f38cb028 Merge "Add multi-instance state to item infos" into main 2024-05-10 04:16:38 +00:00
Ats Jenk 8ed5d288d2 Merge "Get display size from DisplayController instance" into main 2024-05-09 22:58:38 +00:00
fbaron cf10603ed3 Fix bug where hotseat disappears
Fix: 336096469
Bug: 339700174
Flag: NONE
Test: n/a
Change-Id: Ie567c08445d7743281f501c782a8fd51a75ad9bc
2024-05-09 15:44:57 -07:00
Jon Miranda c7e5813d97 Update alpha animation for All Apps / Divider icon.
This prevents the icons from lingering as the spring settles for the scaling reveal
home animation.

Bug: 298089923
Test: go from app to home, from overview to home, vice versa
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Change-Id: I6bc3f0fcbdc63f0c064d425c8ebaf62a20451ac1
2024-05-09 13:34:46 -07:00
Anushree Ganjam 798340dc6d Merge "Hardcode the className instead of class.getSimpleName()." into main 2024-05-09 20:13:13 +00:00
Ats Jenk 5b650d0796 Merge "Update expanded view drop target size based on value from shell" into main 2024-05-09 20:06:10 +00:00
Winson Chung 94e8ad0731 Add multi-instance state to item infos
- Add legacy resource for supported multi-instance apps that
  matches the current SystemUI resource of the same name, and will
  be removed as apps migrate to the V manifest property to declare
  multi-instance support
- Load the multi-instance state from PackageManager when the db is
  first loaded or when packages are updated
- The multi-instance check is then used to determine if an app pair
  can be saved (ie. whether the action can be shown)

Bug: 323112914
Test: atest NexusLauncherTests

Change-Id: I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c
2024-05-09 18:43:38 +00:00
Sukesh Ram e514bac5e3 Merge "Remove Logs for TaplOverviewIconTest#testOverviewActionsMenu" into main 2024-05-09 18:26:31 +00:00
Pat Manning 5f838c45c2 Unstash taskbar after timeout when cursor hovers bottom edge.
This prevents accidental triggering of Taskbar unstash with cursor when the user wants to click the handle to go home.

Fix: 338357087
Test: TaplTestsTransientTaskbar
Flag: com.android.launcher3.enable_cursor_hover_states
Change-Id: I76f3e31cb2588a0fae302278c847227e9548be8f
2024-05-09 16:10:30 +01:00
Michał Brzeziński 13025d7aca Rename gesture_blocking_activities to back_gesture_blocking_activities
This is to make it more clear that this is only for the back gesture.

Bug: 309928033
Flag: None, just renaming resource
Test: just renaming resource
Change-Id: Id48fada3bc3b6bc91b80337def3bddcdd40dde3c
2024-05-09 14:37:18 +00:00
Uwais Ashraf 2a2be5dfee Merge "Add corner rounding to TaskThumbnailView" into main 2024-05-09 09:44:30 +00:00
Tracy Zhou bfdd7d27c0 Merge "Fix back button sometimes not showing up in the initial setup screen" into main 2024-05-09 05:50:46 +00:00
Ats Jenk 5a4836b64f Get display size from DisplayController instance
DeviceProfile is not updated after rotation. Which led to drag to
reposition using landscape display size in portrait.

Bug: 330585402
Test: have device in landscape, drag bubbles and the bar itself
  left/right, observe that the drop target is shown when passing half
  the screen
  rotate device to portrait, start dragging again, observe that drop
  target is shown on the other side when passing half the screen
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I5c0e2e4ab47a669b6e178b45ab132989029f5913
2024-05-08 15:59:54 -07:00
Sukesh Ram 60cab37a23 Remove Logs for TaplOverviewIconTest#testOverviewActionsMenu
Remove logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: Ie19cdb10234fd50fc64f259b5dafe9881162e23d
2024-05-08 22:29:48 +00:00
Alex Chau ec547e0c32 Merge "Recycle thumbnailViews in DesktopTaskView" into main 2024-05-08 22:20:22 +00:00
Alex Chau 4205013b0a Recycle thumbnailViews in DesktopTaskView
- Changed mTaskContainers to a List
- Added an XML for TaskThumbnailView to make it compatible with ViewPool
- Removed mSnapshotViews variable, and streamlined DesktopTaskView binding logic to re-use thumbnailvIew from mTaskContainers or ViewPool

Bug: 249371338
Fix: 251586230
Test: manual
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Iab7575e9c36b8ebf3eb62f19f13d75ba671f9f4f
2024-05-08 22:19:27 +00:00
Ats Jenk f3224cf847 Update expanded view drop target size based on value from shell
When a bubble drag starts, shell sends the current expanded view size
over as part of BubbleBarData. Update the size stored in
BubblePinController based on latest value.
Update drop target visual to match the spec. It should have 24dp insets
compared to expanded view and 28dp corner radius.

Bug: 330585402
Test: drag bubble in landscape, check that drop target for expanded view
  matches with what is shown when expanded view is dragged
Test: drag bubble in portrait, check that the drop target for expanded
  view, matches with what is shown when expanded view is dragged
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: Ic11c4c5c675107543ba08f24a4138cda422d24c1
2024-05-08 14:05:03 -07:00
Treehugger Robot 05f201e8ac Merge "Marking testPrivateSpaceLockingBehaviour as disabled." into main 2024-05-08 20:59:02 +00:00
Jeremy Sim 7d69804e4e Merge "Fix bug with double-relayout of Overview Actions View" into main 2024-05-08 20:24:21 +00:00
Anushree Ganjam c9eda41c31 Hardcode the className instead of class.getSimpleName().
class.getSimpleName() causes issues with obfuscation.

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I5119a7ba0e4e27d8745c94df67881934fed282a4
2024-05-08 12:31:24 -07:00
Holly Jiuyu Sun e498d6ea55 Merge "allKeys in DeviceConfigHelper should be populated with keys." into main 2024-05-08 19:30:09 +00:00
Treehugger Robot b4e46e1e03 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-08 19:07:16 +00:00
Himanshu Gupta a3da6fc6bd Marking testPrivateSpaceLockingBehaviour as disabled.
Temporarily disabling the test as there are failures
seen.
Will be renabled, once the RCA of errors is found.

Bug: 339179262
Test: NA
Flag: NA
Change-Id: I4e4a0b9f8b7290e5be27770a4ded2355a2cc74de
2024-05-08 16:30:07 +01:00
Uwais Ashraf 9533b0fb27 Add corner rounding to TaskThumbnailView
Fix: 334826840
Test: TaskThumbnailViewModelTest
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: Iba4d49d43abc09363f61186c3fcc07f2281b7006
2024-05-08 14:45:44 +00:00
Jordan Demeulenaere 5512003c0d Delay TransitionAnimator.onAnimationEnd by one frame (2/4)
Bug: 330672236
Test: atest ActivityTransitionAnimatorTest
Test: atest DialogTransitionAnimatorTest
Flag: N/A
Change-Id: I81e85df79256d013f6c3ef5cb58a5d96c0c7deec
2024-05-08 16:28:53 +02:00
Orhan Uysal 906df388ef Merge "Add quick switch flag for desktop windowing cases." into main 2024-05-08 11:17:56 +00:00
Anna Zhuravleva 9f3bca37e6 Merge "Log animation jank" into main 2024-05-08 08:22:57 +00:00
Tracy Zhou 9d602e684c Fix back button sometimes not showing up in the initial setup screen
A few things to note
- We use gesture nav layoutter because it's the mode in which we show back button rendered by IME. There might be other historical reasons but it is what it is.
- The back button isn't necessarily laid out correctly with this layoutter (currently we don't adjust anything in layoutButtons.

Fixes: 338876161
Test: Repeatedly get in setup mode, and make sure the back button is visible
Change-Id: I402273c2868f3f46a12b00918dab3f36fbe82204
2024-05-07 18:15:51 -07:00
Bill Yi 92ae2bde65 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3a7919f2fb54f7921e2e3ae5854a57e2bcbdbca2
2024-05-07 16:59:34 -07:00
Jeremy Sim 41eadd1a91 Fix bug with double-relayout of Overview Actions View
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).

This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.

Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-07 11:18:24 -07:00
Vinit Nayak cc7107d82e Merge "Disable gestures when split apps are animating in from shell" into main 2024-05-07 18:12:00 +00:00
Ats Jenk 31e9455718 Merge "Use translation to move bubble bar during bubble drag" into main 2024-05-07 18:04:31 +00:00