Commit Graph

15895 Commits

Author SHA1 Message Date
Hongwei Wang 247a2cfe03 Merge "Cleanup ENABLE_PIP_APP_ICON_OVERLAY" into udc-qpr-dev am: 3ca497b646
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24435526

Change-Id: I59f4e0f1051b5f96c7a5e4d3834ccb497cb31711
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-16 17:22:07 +00:00
Hongwei Wang 3ca497b646 Merge "Cleanup ENABLE_PIP_APP_ICON_OVERLAY" into udc-qpr-dev 2023-08-16 16:45:33 +00:00
Hongwei Wang 7aded94e94 Cleanup ENABLE_PIP_APP_ICON_OVERLAY
Bug: 296125301
Test: manual, enter PiP from Google Maps
Change-Id: I571fd5450ccf00232c450d82d32783beb99cfecf
2023-08-15 15:44:39 -07:00
Treehugger Robot 3f87c59922 Merge "Adding TaplTestsSplitscreen to OOP tests" into udc-qpr-dev am: 173cf33ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24409976

Change-Id: Ifbc3e47e0ba04cf8d379b6446da52ab836985400
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-15 07:04:07 +00:00
Treehugger Robot 173cf33ac1 Merge "Adding TaplTestsSplitscreen to OOP tests" into udc-qpr-dev 2023-08-15 06:17:05 +00:00
Sunny Goyal 0ae8f5c91d Merge "Removing some unused overrides in Launcher" into udc-qpr-dev am: 12bf58feb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24407042

Change-Id: I113cc9bb779a3d09d1e2914c85d249695ffba931
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 21:02:39 +00:00
Sunny Goyal 12bf58feb9 Merge "Removing some unused overrides in Launcher" into udc-qpr-dev 2023-08-14 20:40:28 +00:00
Colin Cross efada45adf Merge "Fix kotlin nullable errors in Launcher3" into udc-qpr-dev-plus-aosp 2023-08-14 17:55:18 +00:00
Treehugger Robot 8da7427ba5 Merge "Add relayout debug support in Launcher" into udc-qpr-dev am: 1c4cb11662
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24403823

Change-Id: I8459cb1d828d1f27454f25cebc0c90f1a8165ce5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 10:40:59 +00:00
Treehugger Robot 1c4cb11662 Merge "Add relayout debug support in Launcher" into udc-qpr-dev 2023-08-14 09:43:51 +00:00
Nicolo' Mazzucato 93e7e4b1c0 Add relayout debug support in Launcher
This adds support for measure/layout tracing in Launcher (in sysui it has already been enabled in T)

When enabled, traces for each class measure and layout are output in
a perfetto trace. This adds some overhead, so it's disabled by default, but extremely useful for testing and debugging long doFrames.

To enable request layout tracing for a specific class X, the following helper can be used:

trace_class_layouts() {
        adb shell setprop persist.debug.trace_request_layout  1
        adb shell setprop persist.debug.trace_request_layout_class $1

        adb shell am force-stop com.google.android.apps.nexuslauncher
        adb shell am force-stop com.android.systemui
}

Then, use `trace_class_layouts X` and record a perfetto trace
e.g. `trace_class_layout BubbleTextView`

To just see class breakdown of measure/layout setting `persist.debug.trace_request_layout` is sufficient.

Test: record a trace after enabling options
Bug: 266090955
Change-Id: I4f621ebaaec6a07cd7c0693aa8876158cc60e208
2023-08-14 08:18:27 +00:00
Vadim Tryshev 95c9e86b34 Moving stress tests to postsubmit am: 053f476376
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24409978

Change-Id: I79790bd4e3f62794f6dca9bf583d6c4c100b4934
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 04:54:49 +00:00
Vadim Tryshev e598bc71bc Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev am: 8c764a0870
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23681107

Change-Id: I7636d8cd9bad4beed904f9d0f85125680d06b318
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-12 02:29:51 +00:00
Vadim Tryshev 053f476376 Moving stress tests to postsubmit
They don't consistently fail, but have flakes.

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I07db69259d86093d81ab65a52a8e839269a3dd80
2023-08-12 02:14:55 +00:00
Vadim Tryshev 8c764a0870 Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev 2023-08-12 01:51:46 +00:00
Vadim Tryshev 401cde8d99 Adding TaplTestsSplitscreen to OOP tests
It's a nice addition to our OOP tests, which serve as a kind-of ssmoke check for the system, as well a a test for a proguarded Launcher.

Bug: 187761685
Flag: N/A
Test: presubmit

Change-Id: I196cf0047f0df6cf843615e48252035f216597a0
2023-08-11 18:34:01 -07:00
Vinit Nayak 050cfbeb10 Merge "Animate Split invocation with shell transitions" into udc-qpr-dev am: 8488a7e757
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24392742

Change-Id: I2834012cb573bfc031d02be80c382916c583362b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-11 23:32:23 +00:00
Vinit Nayak 8488a7e757 Merge "Animate Split invocation with shell transitions" into udc-qpr-dev 2023-08-11 22:29:59 +00:00
Vinit Nayak 6458c11699 Animate Split invocation with shell transitions
* SplitRoot1/2 and the split left/right roots, but
they also have a parent that's the top-most split root.
* We have to explicitly set the alpha on top most parent
for animations on children to be visible
* This path wasn't being used even w/ shell transitions
enabled but became active after ag/24346391

Test: Launch split from overview and workspace
Flag: None
Bug: 276361926
Change-Id: I267dccbf3402af9b0972371b856a79b7785f986c
2023-08-11 12:59:18 -07:00
Sunny Goyal c1d1e68a82 Removing some unused overrides in Launcher
> Changing AddItemActivity to use RemoteAnimation directly
  to avoidTransitionManager override

Bug: 273828110
Test: Manual
Flag: N/A
Change-Id: I49777e7eeba00319476b0a239bc1cdac37833457
2023-08-11 12:31:49 -07:00
Vinit Nayak 9304143cd1 Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev am: f49367cd96
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24374676

Change-Id: I5fa6f41a3f0fc16fa104706aa5591a0872f5bbcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-11 19:19:36 +00:00
Vinit Nayak f49367cd96 Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev 2023-08-11 18:32:43 +00:00
Colin Cross abf18e9c03 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:28:54 -07:00
Sam Dubey 1b481e1973 Revert "Fix kotlin nullable errors in Launcher3"
This reverts commit 7943b35a71.

Reason for revert: Seems to be breaking flicker tests b/295447665, will verify before submitting. This change could be WAI (or surfacing issues)

Change-Id: Ic240c29539f41490cf7232bd6a7a944a868f3870
2023-08-11 11:52:38 +00:00
Colin Cross 7943b35a71 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
2023-08-10 11:11:42 -07:00
Brian Isganitis b7eb932dd5 Merge changes from topic "taskbar-search-ime" into udc-qpr-dev am: c4247d85b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24247103

Change-Id: Ib4c1aa6932ec5d76b84079e20cf38ec50f6367b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-10 16:28:14 +00:00
Brian Isganitis 74dfcccf73 Animate AbstractSlideInView translation shift with PendingAnimation. am: 0a036e9c15
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24344079

Change-Id: I124d7eafa47e130cef684f41982b43a5c6ab2eee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-10 16:28:10 +00:00
Brian Isganitis c4247d85b4 Merge changes from topic "taskbar-search-ime" into udc-qpr-dev
* changes:
  Support customizing open-close PendingAnimation for Taskbar search.
  Animate AbstractSlideInView translation shift with PendingAnimation.
2023-08-10 16:10:39 +00:00
Schneider Victor-tulias 6f0cafc738 Merge "Update All Set page vibrations on large screens" into udc-qpr-dev am: 087990668b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24299295

Change-Id: I24e4f42dc8232307b19c0050e973445f88251c43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-10 14:44:16 +00:00
Schneider Victor-tulias 087990668b Merge "Update All Set page vibrations on large screens" into udc-qpr-dev 2023-08-10 13:49:17 +00:00
Brian Isganitis a7ee532d47 Support customizing open-close PendingAnimation for Taskbar search.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I9f076875c4bd13c98a3ace8c02d512defa013fdf
2023-08-09 22:23:43 +00:00
Brian Isganitis 0a036e9c15 Animate AbstractSlideInView translation shift with PendingAnimation.
The PendingAnimation gives us more flexibility than the AnimatorSet.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I3156a659098c44ce9e6b20e5e79e88742add629a
2023-08-09 22:23:41 +00:00
Vinit Nayak 51a210d787 Prevent setting mIsStashed in TaskbarStashController
* Partial revert of ag/24139629
* Taskbar showing up where it shouldn't in gesturenav,
this change isn't behind the flag

Bug: 295047555
Change-Id: Ib36b1fed5e25c667e396291a30a68730e1daa517
2023-08-09 12:28:44 -07:00
Tracy Zhou f691c79141 Merge "Fix nav buttons in task bar disppearing when unfolding from landscape small screen" into udc-qpr-dev am: 59aa5e696b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24367252

Change-Id: I84f03144f15282c9361384057c77d4faf3cca847
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 17:48:12 +00:00
Matt Sziklay 628997c45c Merge "Allow split select transition from desktop mode." into udc-qpr-dev am: aad3a8e34f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23922245

Change-Id: Id221e4a600c38e1a62b009c507d7a588573eb9c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 17:47:22 +00:00
Brian Isganitis 34c2a0a2e3 Merge "Launch Taskbar All Apps with Meta key when it's available." into udc-qpr-dev am: 18dd200832
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24358834

Change-Id: Ida410d146b045113bb54a497f4027a14bc8ce992
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 17:47:05 +00:00
Tracy Zhou 59aa5e696b Merge "Fix nav buttons in task bar disppearing when unfolding from landscape small screen" into udc-qpr-dev 2023-08-09 17:46:27 +00:00
Tracy Zhou a7e48fa6d7 Fix nav buttons in task bar disppearing when unfolding from landscape small screen
Previously we reuse layout params when we switch to a new layout, but not all of the fields we reuse are reset. Due to the variety of fields we update in different layouts and the fact that it's relatively cheap to instantiate a new layout params object, let's start fresh every time.

Fixes: 295057715
Bug: 288311605
Test: put the device to landscape in small screen and then unfold, make sure that the nav buttons show in the task bar
Change-Id: I8e600c2553436f563dd4509a83cc46ce47c0114d
2023-08-09 17:37:38 +00:00
Matt Sziklay aad3a8e34f Merge "Allow split select transition from desktop mode." into udc-qpr-dev 2023-08-09 17:26:48 +00:00
mattsziklay 95c85034ea Allow split select transition from desktop mode.
Introduces a new controller to manage an app entering split select mode
from desktop mode.

Video: http://recall/-/gjymLwjdDT07aWqaK6101a/gU56zTDcWov6ukbKuH8tFx
Flag: ENABLE_SPLIT_FROM_DESKTOP_TO_WORKSPACE
Bug: 286550932
Bug: 279586624
Test: Manual

Change-Id: Ib94402553c88286894d94c95c38cac125be23a0d
2023-08-09 17:23:03 +00:00
Brian Isganitis 18dd200832 Merge "Launch Taskbar All Apps with Meta key when it's available." into udc-qpr-dev 2023-08-09 17:15:12 +00:00
Randy Pfohl 267dd7e038 Merge "Adding minimal logs to investigate overview floating bug" into udc-qpr-dev am: 6ff6c00b26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24027420

Change-Id: I77d225473b319acfe03721e4ca18451f5b3b522a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-08 22:42:35 +00:00
Randy Pfohl 6ff6c00b26 Merge "Adding minimal logs to investigate overview floating bug" into udc-qpr-dev 2023-08-08 22:11:19 +00:00
Andy Wickham 5d95ba7c00 Merge "Revert^3 "Change Overview Actions to round buttons."" into udc-qpr-dev am: c15fd5c248
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24344529

Change-Id: Ic9142b717463e838e4c0d131018fed3379253fa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-08 21:14:05 +00:00
Vinit Nayak 3a9cf4dc84 Merge "Move splitInstructionsView reference out of RecentsView" into udc-qpr-dev am: 6682d58d0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24330913

Change-Id: I53a4fa0fba79737ebf3c5adac4a01b8815306976
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-08 21:13:18 +00:00
Andy Wickham c15fd5c248 Merge "Revert^3 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-08-08 20:58:04 +00:00
Vinit Nayak 6682d58d0a Merge "Move splitInstructionsView reference out of RecentsView" into udc-qpr-dev 2023-08-08 20:40:57 +00:00
Brian Isganitis a8ad7e448c Launch Taskbar All Apps with Meta key when it's available.
Taskbar All Apps will be chosen over Launcher's when we are in an app or
in overview. Otherwise, we fallback to toggling Launcher All Apps.

Test: Manual, adb shell input keyevent 117
Fix: 282111244
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I68e4cb3a80d42e233f7d9ad33fc3791b5c75d219
2023-08-08 19:32:02 +00:00
Andy Wickham bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Jeremy Sim 3ec81aedbd Merge "App Pairs: Implement save, inflate, launch, and delete" into udc-qpr-dev am: 6390654526
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23502665

Change-Id: Ib2f094b1bb1331745ea5ccf3a90788fb9c5b0ef3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-08 01:18:29 +00:00