Commit Graph

5641 Commits

Author SHA1 Message Date
TreeHugger Robot d880a4fa63 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev 2022-04-21 17:54:03 +00:00
TreeHugger Robot 8e0177813a Merge "Disallow long press below taskbar icons" into tm-dev 2022-04-21 17:16:42 +00:00
Tony Huang 8edc0dfcf1 Merge "Add jank instrument support for split screen" into tm-dev 2022-04-21 11:31:22 +00:00
Tony Wickham 74641da5b8 Merge "Move taskbar insets logic to TaskbarInsetsController" into tm-dev 2022-04-20 23:43:50 +00:00
Tony Wickham 81bff9becd Disallow long press below taskbar icons
Test: long press below icons, doesn't stash; can still swipe up
Fixes: 201239461
Change-Id: Ifdf355138d7958c0442814d968f0722f54e12ae1
2022-04-20 13:58:53 -07:00
Vinit Nayak bf33e85cb7 Merge "Check for auto-rotation when initializing RecentsOrientedState" into tm-dev 2022-04-20 20:58:30 +00:00
Tony Wickham 36c9d888d8 Move taskbar insets logic to TaskbarInsetsController
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME
Bug: 215411414
Change-Id: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
Merged-In: I73622dc020c4f8c8b3d317fcb1dd072bcfc3d274
2022-04-20 19:27:48 +00:00
Brian Isganitis 7bd3e02e2f Merge "Decrease overview degree threshold from 45 to 15 degrees." into tm-dev 2022-04-20 17:14:42 +00:00
Brian Isganitis 6d780af405 Merge "Log taskbar all apps entrypoint, launches, and drags" into tm-dev 2022-04-20 17:13:52 +00:00
Brian Isganitis 95cad640c7 Decrease overview degree threshold from 45 to 15 degrees.
Met with arifhuda@ to confirm the benefit of lowering to 15 degrees.

This change also updates AbsSwipeHandler to differentiate between X and
Y flings in calculateEndTarget.

Test: Manual
Fix: 222117127
Change-Id: I416986145a4306d1babe23735e0563e87660c417
2022-04-19 23:14:36 +00:00
Tony Huang 8f994ea76f Add jank instrument support for split screen
Add jank instrument support for split screen of anter animation.

Bug: 203439850
Test: build passed
Test: verified with systrace dump
Change-Id: I128fe829b36198e1a437d27427b54ebdc67e5f52
2022-04-19 15:49:32 +08:00
Sunny Goyal df472f8db7 Merge "Updating target SDK for Launcher" into tm-dev 2022-04-19 03:32:27 +00:00
Sunny Goyal 25137534a1 Fixing potential NullPointer exceptions when Launcher is
created before TouchInteractionService is initialized

SystemUiProxy is a wrapper opject which holds the state information
until the actual proxy is initialized. It is safe to be initialized
lazily.

Bug: 221961069
Test: Verified on device
Change-Id: I1a621cad52e5b8384439ef02de6b95c6452bcb06
2022-04-18 15:42:07 -07:00
Sunny Goyal cd2ac0f3e9 Updating target SDK for Launcher
Bug: 229173942
Bug: 226461147
Test: Presubmit
Change-Id: Id9e303f113cba87adf26442f1417ed2814555c54
2022-04-18 13:55:01 -07:00
Sunny Goyal 7ee087f53f Revert "Revert "Removing AM.getTasks call on UI thread during touch down""
This reverts commit f9042d32ae.

Reason for revert: build breakage fixed

Change-Id: I5dac8826e1dc6064e7961ebbf3bc249b5fb307c7
2022-04-18 10:15:08 -07:00
Sam Dubey 1e0648475b Merge "Revert "Removing AM.getTasks call on UI thread during touch down"" into tm-dev 2022-04-18 17:11:50 +00:00
Sam Dubey f9042d32ae Revert "Removing AM.getTasks call on UI thread during touch down"
This reverts commit 013a8a75ab.

Reason for revert: Broke builds

Bug: 229619753
Change-Id: Idb1aecf1d43db50aa4f11dbb88079c37e401d694
2022-04-18 16:47:24 +00:00
Sunny Goyal 2207b577d0 Merge "Removing AM.getTasks call on UI thread during touch down" into tm-dev 2022-04-18 16:19:41 +00:00
TreeHugger Robot cf80645111 Merge "Polish the back to home gesture animation to match the spec." into tm-dev 2022-04-16 01:51:10 +00:00
Tony Wickham 8bb0bdc42b Merge "Move Taskbar background drawing to TaskbarBackgroundRenderer" into tm-dev 2022-04-15 23:06:40 +00:00
Vinit Nayak e28dbba7b4 Check for auto-rotation when initializing RecentsOrientedState
* When folding/unfolding we destroy listeners because
the view gets torn down but the auto-rotate setting gets
updated before launcher has a chance to re-init the listeners
* Force update once when initializing (hopefully this doesn't
cause test issues by creating an additional binder call..)

Fixes: 228765701
Test: Bug no longer repros
Change-Id: Ide0e8907f97d6985813257b299104ac7cfdf959a
2022-04-15 15:26:32 -07:00
Mady Mellor 729eb8458b Fix crash/flicker with taskbar when canceling drag and drop
The surfaceControl transaction is performed more than once so close
the transaction at the end of the animation.

Test: manual - start a drag from taskbar into split and then pull it
               back so that it doesn't complete
             => ensure taskbar doesn't flicker / no crash in logs
Bug: 228006271
Change-Id: I38c8efe310596bbbbf09f361c266a7fefc1b2eea
2022-04-15 20:25:35 +00:00
Shan Huang 4ce2b40f91 Polish the back to home gesture animation to match the spec.
Bug:228533817
Test: Enable back animation from FlagFlipper (Predicitve Back Animation)
and swipe back on Flag Flipper. Try in both portrait and landscape mode.

Change-Id: I7792dc5079698c1b5a7dd3cd06344ba46c4a2da6
2022-04-15 19:26:11 +00:00
Hongwei Wang 778b5e6bd0 Merge "Fix flicker when entering PiP from split-screen / overview" into tm-dev 2022-04-15 02:48:08 +00:00
TreeHugger Robot 8c65675382 Merge "Add flag that disables depth on overlay scroll" into tm-dev 2022-04-14 23:16:20 +00:00
Tony Wickham 2604dd348c Move Taskbar background drawing to TaskbarBackgroundRenderer
Currently used by both TaskbarDragLayer and TaskbarScrimView

Test: stash and unstash taskbar, background drawn as before; open a
Bubble and ensure taskbar is still scrimmed
Bug: 225200928

Change-Id: I3f7f4c1b1232b53c3eacb0e000d1c3aec25bb49d
2022-04-14 14:18:35 -07:00
Lucas Dupin 4d90868075 Add flag that disables depth on overlay scroll
Test: manual
Fixes: 229261804
Change-Id: I132d9b5ca78255447ca72655b0a1fb1a4f86c3a1
2022-04-14 14:06:11 -07:00
Sunny Goyal 013a8a75ab Removing AM.getTasks call on UI thread during touch down
We maintain a cached task queue using TaskStackChangeListener.
It keeps the top RunningTaskInfo partially in sync with platfrom:
   taskInfo is only initialized when the top task changes
   but not when there are changes within the task itself.

Bug: 214581894
Bug: 220742398
Test: Manual and presubmit
Change-Id: Ifafde574040c03435b78f044350c45f3b49c4bcb
2022-04-14 14:02:28 -07:00
TreeHugger Robot 998c47e594 Merge "Prevent double selection of second split app" into tm-dev 2022-04-14 20:13:59 +00:00
Sunny Goyal bc25ec02a2 Merge "Updating code due to TaskStackChangeListener changes" into tm-dev 2022-04-14 20:11:58 +00:00
Vinit Nayak a4e5a9eebe Prevent double selection of second split app
* Also fix small other bug where we were
checking only for LauncherState
OVERVIEW_SPLIT_SELECT and not for equivalent
3P RecentsState

Fixes: 227419997
Test: Repro steps don't cause bug. Yay.
Change-Id: Ibb8238185b959d22d8455b6812d29b2e268d9739
2022-04-14 11:06:47 -07:00
Hongwei Wang 5f5bd84d99 Fix flicker when entering PiP from split-screen / overview
This is a follow-up of ag/16418447 where we hide the Tasks in
split-screen mode on swipe-home-to-pip and here we use the same
mechanism when we are entering PiP from the overview and the pip-able
task is in split-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bNtg3ZOhuTBKm9nU9CPeNQ
Bug: 228289777
Test: follow the reproduce steps in bug, see video
Change-Id: Icab11d52cedaf94af0ee72023cebca8ec51d8851
2022-04-14 10:49:29 -07:00
TreeHugger Robot 7ea312db9b Merge "Creaet separate pull back animation for AllApps" into tm-dev 2022-04-14 14:07:58 +00:00
TreeHugger Robot bf5a0d5fe3 Merge "Use bottomMargin to align OverviewActions with 3 button" into tm-dev 2022-04-14 10:56:43 +00:00
Alex Chau a74a8595fb Creaet separate pull back animation for AllApps
- In tablet, only animate recyclerView on pullback to be consistent with widget bottom sheet, and avoid showing a gap below mAppsView

Fix: 220345008
Test: manual on small and large screen
Change-Id: I1f7d03b6bd16af7a91a51a0985ef163d9e365261
2022-04-14 11:01:25 +01:00
Vinit Nayak 37ce441089 Merge "Listen for density changes through DisplayController callbacks" into tm-dev 2022-04-13 22:57:00 +00:00
Alex Chau b1508b8023 Use bottomMargin to align OverviewActions with 3 button
- This ensure the updated OverviewActions position is considered when calculating modal task size

Fix: 228976149
Test: manual
Change-Id: I635e00096fdb26c164bc76fc94f6bf203f5c9c71
2022-04-13 18:51:40 +01:00
Hongwei Wang d34d3b4834 Merge "Pass sourceRectHint to auto-enter-pip transition" into tm-dev 2022-04-13 17:38:34 +00:00
Sunny Goyal afb6e23500 Updating code due to TaskStackChangeListener changes
Bug: 221961069
Test: Presubmit
Change-Id: I40b2e5a12c4cd6faa53ee788939c31b25bf5c37b
2022-04-13 10:31:18 -07:00
András Klöczl fed1182660 Merge "Change page snapping logic for large screen devices" into tm-dev 2022-04-13 11:18:39 +00:00
Shikha Malhotra 80a315e50f Merge "Review comments followup" into tm-dev 2022-04-13 08:00:31 +00:00
TreeHugger Robot d9939d8174 Merge "Adjust the insets frame providing method per API change" into tm-dev 2022-04-13 01:53:04 +00:00
Andras Kloczl 07111f25f4 Change page snapping logic for large screen devices
Use 15% of the screen width instead of 40% of the page
width currently used for phones.

Test: try page snapping on Launcher home
Bug: 213305066
Change-Id: I6a525100bf942c5089f580a27250c425ca95cf00
2022-04-12 20:23:23 +01:00
Shikha Malhotra f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Pat Manning 29fbab4ddd Animate clear all button's alpha after last task has scrolled beyond its edge.
Test: manual
Fix: 208879377
Change-Id: Iad43abbe36d11317869a0c5aa6a8d59fd1fddb67
2022-04-12 15:32:06 +01:00
Brian Isganitis 4ad53f1268 Defer unstashing taskbar on all apps close if gesture in progress.
This behavior is more consistent with how we update taskbar stashing when IME is dismissed.

Test: Verified stashing behavior with gestures, 3-button, and bottom sheet dismiss.
Fix: 223837786
Change-Id: Ib85ebe629f33f0bddc36bbc8d99136711105b279
2022-04-11 19:54:53 -07:00
Tracy Zhou b5d7744c1b Merge "Play icon alignment animation in live tile mode" into tm-dev 2022-04-12 00:05:34 +00:00
Tracy Zhou abc2288399 Merge "Update task bar icon alignment logic when launcher is paused and resumed in Overview" into tm-dev 2022-04-12 00:03:15 +00:00
Tracy Zhou d4ed2f7717 Update task bar icon alignment logic when launcher is paused and resumed in Overview
If launcher is paused and resumed in overview, goingToUnstashedLauncherStateChanged doesn't change, so we should not use goingToUnstashedLauncherState as a signal for the end value of mIconAlignmentForResumedState anim

Bug: 223109070
Test: go to overview, use the share functionality, share to drive, and make sure task bar ends up in stashed state. Making sure that it never unstashes is out of scope for this change
Change-Id: I5684be6b58279a9b41e257dd72591f7d692c2fbc
2022-04-11 23:12:49 +00:00
Tracy Zhou 42e30963c3 Play icon alignment animation in live tile mode
aka launcher is not resumed but recents animation is running

Fixes: 210047102
Test: Go to overview in live tile mode, tap on somewhere outside any task in overview, and make sure icon alignment animation is played.
Change-Id: Ic300ee296049b6fdcdf6d2595916cc84c09d95fa
2022-04-11 16:11:28 -07:00