Commit Graph

6211 Commits

Author SHA1 Message Date
Matt Casey d85152e484 Merge "Send a zero for assist invocation on animation end" into sc-dev am: 3a65795298
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065435

Change-Id: Ib265dddfe60bd2f62cae8a461bebe04dd85f4d9d
2021-06-22 17:02:35 +00:00
Matt Casey 3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Lucas Dupin 07b3fc2d2c Merge "Apply depth even when surface is null" into sc-dev am: 818ed4b794
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15055654

Change-Id: I66b092af5dc6ca580672865f65aaffe7eb98de33
2021-06-22 01:21:14 +00:00
Lucas Dupin 818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal b7bd28692a Merge "Finish wrapped launcher animations if impl is gone" into sc-dev am: 871d435be2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15054029

Change-Id: I13ee44bada34c3906591de8b619ce236100f1af7
2021-06-21 23:19:45 +00:00
Sunny Goyal 871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal b6cdee307b Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: Ia84604f9126b2dc142c1d99ae54c71f36accaa0f
2021-06-21 22:40:28 +00:00
Tony Wickham 4de1650940 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I0842941791cddd5c8c33c73f7feb68edee78b69b
2021-06-21 22:40:20 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
Tony Wickham 82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky 08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham 9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Schneider Victor-tulias ebc85f672d Merge "Update All set screen icon" into sc-dev am: 689d69572b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: Ia29d12a91ae58ee0d01118406c1fa82e5aa9d0e6
2021-06-21 19:56:38 +00:00
Schneider Victor-tulias 689d69572b Merge "Update All set screen icon" into sc-dev 2021-06-21 17:35:15 +00:00
Jonathan Miranda 24ae397544 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I21f9366f93afe6eaf2d9e96927a6a2eef7d5427a
2021-06-20 22:58:15 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Schneider Victor-tulias 4ef6bd5a7a Update All set screen icon
Fixes: 191463446
Test: Manual
Change-Id: I746bfb2eab950a01041493bd72d7dda30ac66d7b
2021-06-18 15:36:23 -07:00
Zak Cohen 360d81e308 Merge "Suppress ViewInflationDuringSwipeUp test." into sc-dev am: 1d5debd60d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15013549

Change-Id: Idac925cf7f1957a44a1817c7048d798b8773af80
2021-06-17 18:49:01 +00:00
Zak Cohen 1d5debd60d Merge "Suppress ViewInflationDuringSwipeUp test." into sc-dev 2021-06-17 18:34:29 +00:00
Winson Chung 4280926c7a Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I6da674f1eec758bb5e2b8f1857a2fca57a92f6ea
2021-06-17 17:01:06 +00:00
Winson Chung caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
zakcohen 360489ff51 Suppress ViewInflationDuringSwipeUp test.
Test is failing on a subset of devices with a memory leak in an activity.
This is not repoing on other devices so could be a problem with the setup
rather than the code.

Bug: 190618549
Test: Local
Change-Id: I9c6a56432d1b1f59c337bf34e7b8c26befeb2d7d
2021-06-17 09:46:56 -07:00
Jonathan Miranda 95168f389e Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: I3a15b70a7299c1ed27b23ac7c906321b4ec35e04
2021-06-16 20:38:19 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Jonathan Miranda 5473ae0c18 Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: I1f820134d767abd5774e0d752786e9e174c06fed
2021-06-16 18:18:15 +00:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
Jon Miranda 229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Hongwei Wang c4b1a50a70 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev am: e3bfeddd04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14984847

Change-Id: I0e2976b5f41baed1729fd9c64e65ab489e7a4a16
2021-06-15 21:16:43 +00:00
Thiru Ramasamy 47224bc3a3 Merge "Enable logging for 'Themed icons' setting." into sc-dev am: 640fc8b84d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14983277

Change-Id: I06a98f6434e448dad971319fcf6d9ec4bb7b8743
2021-06-15 21:16:22 +00:00
Winson Chung d14190d547 Do some additional cleanup when switching handlers
Bug: 183962705
Test: Presubmit

Change-Id: Ia9295d2cf89fa6b6fe77c5e4861a704c4a82ab12
2021-06-15 13:57:06 -07:00
Hongwei Wang e3bfeddd04 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev 2021-06-15 20:50:45 +00:00
Thiru Ramasamy 640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00
Hongwei Wang 9d3e31e67c Use RectFSpringAnim for auto-enter-pip
Make SwipePipToHomeAnimator a subclass of RectFSpringAnim and use the
bounds calculated from latter for auto-enter-pip transition.

Note that the landscape to portrait case may not fully comply to
RectFSpringAnim as we calculate the position separately in
SwipePipToHomeAnimator.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/CWBPU2A6vB8CeTFRanQLx
Bug: 184789411
Test: manual, see video
Change-Id: I67dae09e682b7d8f1a1f08995eb3bcf76bdf7417
2021-06-15 12:04:17 -07:00
TreeHugger Robot 20422f7030 Merge "Update all apps divider to pill shape" into sc-dev am: 4ff2682787
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14966493

Change-Id: I588f35969f14d1e44727cf69e9a3711ca86eb5ef
2021-06-15 18:52:30 +00:00
TreeHugger Robot 1560f401ae Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-15 18:52:15 +00:00
TreeHugger Robot 4ff2682787 Merge "Update all apps divider to pill shape" into sc-dev 2021-06-15 18:33:22 +00:00
Winson Chung cb4a74617b Merge "Don't rely on intent to call back from activity tracker" into sc-dev am: 1b369c4763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14909197

Change-Id: I2259802dfb1de1260e2cddb7b5ad59ad7f60d47f
2021-06-15 18:15:11 +00:00
TreeHugger Robot 75af17a011 Merge "Fix foreground position during widget home animation" into sc-dev am: 3e366d6529
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14948450

Change-Id: I348560eb961e3313142140006e60df7caabe61b5
2021-06-15 18:15:01 +00:00
Winson Chung 1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
TreeHugger Robot 3e366d6529 Merge "Fix foreground position during widget home animation" into sc-dev 2021-06-15 17:59:48 +00:00
Thiru Ramasamy 74a6d2ea55 Enable logging for 'Themed icons' setting.
Eldar: http://eldar/510864786
Bug: 191161241
Test: local - http://gpaste/5934701681311744 & http://gpaste/6715297709948928
Change-Id: I18ad97f68b372997e222f06dabf8bbe83f15d92f
2021-06-15 10:48:43 -07:00
Bill Yi 579b51a4d2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I01c5129b1c842e461860f3f08701a3f897546503
2021-06-15 16:40:31 +00:00
Winson Chung 1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
Jonathan Miranda 0fb09b4a1b Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev am: bea8267854
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14949954

Change-Id: I3887c48c363405be60dae9210b15b620e07ad3a1
2021-06-15 00:49:47 +00:00
Jonathan Miranda bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda 0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00