Commit Graph

16807 Commits

Author SHA1 Message Date
Anushree Ganjam 3c2a696391 Merge "Post the mSearchUiManager.resetSearch() to next frame." into udc-qpr-dev 2023-07-27 20:59:47 +00:00
Brandon Dayauon d6c00c7114 Merge "enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH" into udc-qpr-dev 2023-07-26 22:51:55 +00:00
Schneider Victor-tulias 06ca4d9c6e Merge "Fix flaky RuntimeException in CellLayout." into udc-qpr-dev 2023-07-26 20:35:15 +00:00
Schneider Victor-tulias 750c5af2da Fix flaky RuntimeException in CellLayout.
Changing the grid while a previous loader is running (more likely to happen in test) can cause a saved item info to have a cell position outside the bounds of the new grid. This should just be handled the same way as other item infos being loaded in an occupied space.

Flag: not needed
Fixes: 233989158
Test: changed grid sizes multiple times
Change-Id: Ibba337c224e7a08533331a87b1369ebf96e3c9a3
2023-07-26 10:20:24 -07:00
Vinit Nayak dc53fdc717 Merge "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD" into udc-qpr-dev 2023-07-26 00:50:33 +00:00
Anushree Ganjam 135eee0410 Post the mSearchUiManager.resetSearch() to next frame.
SearchBox gets cleared in the current frame even before we read the
input entered by the user. So clear the searchbox in next frame after
onAllAppsTransitionEnd is completed.

See ag/22266746 where this change was introduced and I want to move the resetSearch() call to next frame.

Bug: 287693114
Test: Manual . Tested with both Floating search box on and off.
Flag: NA

Change-Id: I11509cf652f96847ad3c54f20a76f2a728775fe3
2023-07-25 22:34:54 +00:00
Schneider Victor-tulias c73b653e1d Merge "Fix home animation jank when quickly pressing home button" into udc-qpr-dev 2023-07-25 21:01:47 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Thales Lima d9f4d93cbf Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev 2023-07-24 21:24:00 +00:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Schneider Victor-tulias 3913e297e9 Fix home animation jank when quickly pressing home button
Pressing the home button a second time while the app icon is animating cancels the animation. The listener view's AFV doesn't need to be explicitly closed since it will be cleaned up.

Flag: not needed
Fixes: 291807246
Test: manually pressed the home button twice quickly
Change-Id: Ia963e06da78742eade91a6174c3d5f5328368bc5
2023-07-24 10:44:41 -07:00
Brandon Dayauon 19a380095e enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH
PM said we can enable ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH flags.

bug:287307252
Flag: turning to true
test: presubmit (updated tests in previous CL ag/23835677)

Change-Id: I89ede9807205a72108f25ca3b962f8d67384f7ae
2023-07-24 07:38:38 -07:00
Andy Wickham f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Charlie Anderson 673a81be1e When unpausing work profile after reboot, we should do a single reload of the workspace.
Prevents greyed out work items from persisting that are not actually paused.

Bug: 290870690
Test: manually tested pausing work profile, rebooting, unpausing work profile. Also tested just pausing/unpausing work profile.
Change-Id: Iab6d51c9bf47b1732b9cc4278bec5119e7c6afbf
2023-07-22 02:29:50 +00:00
Jordan Silva 575c3bddec Add twoPanelId attribute for responsive grid in device profile
Three new attributes were created to be used in device profile. These attributes will provide the responsive specs for two panel devices.

Fix: 292204121
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: I35c93e16dde043b0fd611b81bf2de74e3621818e
2023-07-21 12:00:43 +01:00
Brian Isganitis 5cc62b13ee Merge changes from topics "taskbar-search-back", "taskbar-search-transition" into udc-qpr-dev
* changes:
  Support system back in Taskbar search session.
  Notify Taskbar search session of All Apps transitions.
2023-07-21 00:14:04 +00:00
Vinit Nayak d49239be89 Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD
Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I55c8e8293eeadeca623ae879ca62d8d7c405f486
2023-07-20 16:32:51 -07:00
Fengjiang Li bebcaaae19 Merge "Log appear animation's scale factor" into udc-qpr-dev 2023-07-20 21:02:42 +00:00
Fengjiang Li da718e9749 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-07-20 11:08:14 -07:00
Brian Isganitis c90df24e1c Notify Taskbar search session of All Apps transitions.
Test: Manual
Bug: 290819902
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9ff5ec7d55c33f9987aec79ebae31c38c710a920
2023-07-20 13:41:14 -04:00
Jordan Silva c118fb5dea Implement responsive grid for foldables 4x4 grid
Bug: 277064862
Fix: 289888732
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: ResponsiveFolderImageTest
Change-Id: Idf21fc0dc71f9cea474dc9515a4695ccaf6bc094
2023-07-20 11:37:00 +01:00
Anushree Ganjam 4cd4ed090e Merge "Implement ImpressionLogging v2." into udc-qpr-dev 2023-07-19 23:17:10 +00:00
Brian Isganitis 62b59f9a81 Merge "Start drag from current translation shift during animation." into udc-qpr-dev 2023-07-19 23:06:32 +00:00
Brandon Dayauon cff52a4db6 Merge "Make mDisplay DISPLAY_SEARCH_RESULT visible for test" into udc-qpr-dev 2023-07-19 22:02:22 +00:00
Thales Lima 6382afd657 Merge "Improving responsive grid xml parser" into udc-qpr-dev 2023-07-19 20:56:04 +00:00
Fengjiang Li 82ddd8ac97 Merge "Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled" into udc-qpr-dev 2023-07-19 20:03:48 +00:00
Brian Isganitis f3ebdd4819 Start drag from current translation shift during animation.
Test: Manual
Fix: 291950331
Flag: No
Change-Id: I67fe6a474fc1b10d8e34fb047f98af2c1e6e085c
2023-07-19 14:15:31 -04:00
Anushree Ganjam 55405157e2 Merge "Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate." into udc-qpr-dev 2023-07-19 18:02:41 +00:00
Pat Manning 933f2b9f27 Merge "Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y." into udc-qpr-dev 2023-07-19 17:20:39 +00:00
Pat Manning 75708262fc Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y.
Fix: 290211274
Test: manual.

Change-Id: Ieddce683d76c696b5ac3eae4fb9f73a5827a50ad
2023-07-19 14:47:32 +00:00
Anushree Ganjam a9645535b8 Implement ImpressionLogging v2.
Deprecate V1 implementation and keep only V2.

Bug: 285964742
Test: Manual
Flag: NA

Change-Id: If27f02f7142abf7960f74252d1e46bcd8c5b5e2a
2023-07-18 21:56:28 +00:00
Fengjiang Li bafbdfbfd6 Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled
When work profile is disabled, we should also let main RV use AllAppsStore's recycler view pool.

Test: Turn off work profile, kill launcher process, swipe up all apps, start record perfetto trace, scroll down all apps, then stop record, verify no BubbleTextView inflation after change
Bug: 287523421
Flags: ENABLE_ALL_APPS_RV_PREINFLATION
Change-Id: Idd5f8193e85fc2a250877affc3b2e4ab4a704797
2023-07-18 14:05:36 -07:00
Jordan Silva 8bd7af2b3f Improving responsive grid xml parser
Refactors AllAppsSpecs, FolderSpecs and WorkspaceSpecs initialization to use the same code to parse the xml with different map function. This CL improves the readability of the code and remove code duplication.

Fix: 286538013
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: AllAppsSpecsTes
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: FolderSpecsTest
Test: WorkspaceSpecsTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iec5863619399efd2e80f3db46b75c4d785e1656f
2023-07-18 18:03:16 +01:00
Anushree Ganjam 660679f91f Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate.
This will be called when transition animation to search is completed.

Bug: 285166099
Flag: NA
Test: Manual
Change-Id: I69e594cbf3564a866d258654fc23a00410e7deab
2023-07-18 02:16:42 +00:00
Brian Isganitis 40c96b4049 Have OptionsPopupView depend on ActivityContext.
Only certain static methods in this class require Launcher at this
point.

Test: Manual
Bug: 291615281
Flag: No
Change-Id: I27bda70bd4f9da75e112d4f68a383447bcc3c32c
2023-07-17 14:40:59 -04:00
Brian Isganitis 3f0e7e7c5d Merge "Initial Taskbar drag-n-drop support for search results." into udc-qpr-dev 2023-07-17 17:08:15 +00:00
Sunny Goyal cd5d3d0c31 Merge "Removing LauncherActivityRule as it can be flaky based on when the rule was initialized" into udc-qpr-dev 2023-07-17 16:58:20 +00:00
Pat Manning f351e515f7 Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev 2023-07-17 10:15:46 +00:00
Fengjiang Li ccd49005c9 Merge "Handle nullable CellLayout when removing app icon from folder" into udc-qpr-dev 2023-07-15 02:44:31 +00:00
TreeHugger Robot 61c2bbe5b8 Merge "Clean up SplitData refactor flag" into udc-qpr-dev 2023-07-14 23:25:27 +00:00
TreeHugger Robot ef52e37e5f Merge "Exposing the layout URI builder method, so that it can be used in tests" into udc-qpr-dev 2023-07-14 22:11:29 +00:00
Sunny Goyal 0d149e6f93 Exposing the layout URI builder method, so that it can be used in tests
Bug: 286558846
Test: N/A
Flag: N/A
Change-Id: Ib39c0477bb977ac2eb3e484463bc3ea770dc4069
2023-07-14 13:03:12 -07:00
Vinit Nayak 1db3292029 Clean up SplitData refactor flag
Bug: 279494325
Test: Invoking split works from home, overview.
Opening split to fullscreen also works

Change-Id: Ie1f26f833d5c10bb114b9e8eb1bd9f3b6b913b3d
2023-07-14 10:54:59 -07:00
Sunny Goyal f6b79f7caf Removing LauncherActivityRule as it can be flaky based on when
the rule was initialized

Bug: 289161193
Test: Presubmit and PostSubmit
Flag: N/A
Change-Id: I0e1e9c6f932d2a98a2f1e47bd1665e26f2db9eb4
2023-07-14 10:29:55 -07:00
Pat Manning da69661add Show tooltips on cursor hover of taskbar icons.
Fix: 250092437
Test: TaskbarHoverToolTipControllerTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia0463518d13b313b354328078685930215fb7636
2023-07-14 13:42:30 +01:00
Treehugger Robot 3396b5c338 Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-qpr-dev 2023-07-13 20:31:37 +00:00
Becky Qiu 5bcd1ca3d6 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 am: 64746f8a29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I9f00b40302eba3683f2260f5efa5e5dbc3566f38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 20:09:01 +00:00
Becky Qiu 64746f8a29 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I513daa1fdeb8d5582bd0cec9b8b2eb4d043f2543
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 19:02:27 +00:00
Fengjiang Li 080f9326ab Handle nullable CellLayout when removing app icon from folder
If CellLayout is null, instead of early return that will lead app icon not clickable, we should fallback to use Launcher as activity

Fix: 290973455
Test: attached to video
Change-Id: I10b03f3f41dd672116133af83ae8a5b066824d71
2023-07-13 10:30:19 -07:00