Commit Graph

10810 Commits

Author SHA1 Message Date
Alex Chau d6bc129231 Ensure setRequestedOrientation is called when unfolding the device
- In RotationHelper, mLastActivityFlags defaults to -1, which is the same value as SCREEN_ORIENTATION_UNSPECIFIED. When the screen is folded, a new instance of RotationHelper is created, which attempts to reset setRequestedOrientation to SCREEN_ORIENTATION_UNSPECIFIED. But SCREEN_ORIENTATION_UNSPECIFIED is equal to mLastActivityFlags, and the call is skipped.
- The simpel fix is to default mLastActivityFlags to something else that is not a a valid value of setRequestedOrientation

Bug: 177320461
Change-Id: I1ca284149598745bfa612ee12e4da3b940b60288
(cherry picked from commit 8aa592f44620a8f57fa104819f8bba57c4360f95)
2021-01-18 12:17:09 +00:00
Sunny Goyal b18501402c Merge "Fixing preview rendering in device search mode" 2021-01-15 19:20:26 +00:00
Sunny Goyal e733e79946 Fixing preview rendering in device search mode
When the flag is disabled, search box may not show in preview

Bug: 177500166
Test: Presubmit
Change-Id: I064ba6ca22e71030056a4ceafea27e6ef0517d01
2021-01-14 14:17:13 -08:00
Schneider Victor-tulias 7cb41c3584 Merge "Add UI updates for incremental app installs." 2021-01-13 23:51:53 +00:00
Schneider Victor-tulias 36ea68360b Merge "Revert "Revert "Add UI updates for incremental app installs.""" 2021-01-13 23:51:37 +00:00
Samuel Fufa d78e90d163 Merge "Migrate from Plugin SearchTarget to API search Target [2/3]" 2021-01-13 23:46:16 +00:00
Samuel Fufa af83e714ac Merge "Remove Second consumer from AllAppsSearchBarController" 2021-01-13 18:57:07 +00:00
Samuel Fufa a60d1f9be7 Migrate from Plugin SearchTarget to API search Target [2/3]
- Adds support for android.app.search.SearchTarget in plugin while maintaining plugin SearchTarget support
- Introduces SEARCH_TARGET_LEGACY temporary to switch between plugin and sdk variants.
- Maps resultType and layoutType pairs to the appropriate view

Bug: 177223401
Test: Manual
Change-Id: If8d4bb7c21c47a12447dcb0c56eed8781bd21e54
2021-01-13 12:35:51 -06:00
Samuel Fufa fd58d23cdf Migrate from Plugin SearchTarget to API search Target [1/3]
Setup architecture for separation between aosp and quickstep search as setup for switch to android.app.SearchTarget

Bug: 177223401
Test: manual
Change-Id: Iefd069a34d5e5551bf731e9171958e93377774aa
2021-01-12 19:46:25 -06:00
Schneider Victor-tulias b803f7e2cb Add UI updates for incremental app installs.
1. Changed Preload Icon UI to be grayscale while the app is not startable.
2. Added progress bar for when app is installed but still ownloading.
3. Updated Preload Icon progress and click handling to use new incremental api.

Progress bar color updates will follow in a separate CL.

Demo: https://drive.google.com/file/d/1H1EvtTorLeJwC1eiq10tm-TT81YZ6osk/view?usp=sharing

Fixes: 176901235,176992421,176884453

Test: manual
Change-Id: Ie0575dc56c33c5d6ecd6c5cbf00666b96d6dcb16
2021-01-12 16:04:01 -08:00
Schneider Victor-tulias 6a5f431a7b Revert "Revert "Add UI updates for incremental app installs.""
This reverts commit 229497d182.

Reason for revert: Patching bugs

Fixes: 176901235, 176992421, 176884453

Test: manual

Change-Id: I57e13a15e72284564a10761966732ee31d15fd08
2021-01-12 12:22:33 -08:00
TreeHugger Robot 67b612bb85 Merge "Disable default IME in all apps if DISABLE_INITIAL_IME_IN_ALLAPPS is on" 2021-01-11 19:07:18 +00:00
Hyunyoung Song f19c579706 Disable default IME in all apps if DISABLE_INITIAL_IME_IN_ALLAPPS is on
Bug: 173447266
Test: manual
Change-Id: Ib5c03b20cc7f09fdc2d066dd20fb7ccbb1e154f5
2021-01-10 21:09:19 -08:00
Jason Chang cfbfea9172 Merge "Fix triggering One-handed mode introduces gesture conflict issues (2/n)" 2021-01-10 03:38:37 +00:00
TreeHugger Robot cdfed2320a Merge "Revert "Add UI updates for incremental app installs."" 2021-01-08 00:31:06 +00:00
Schneider Victor-tulias 229497d182 Revert "Add UI updates for incremental app installs."
This reverts commit 84269d349d.

Reason for revert: causes b/176884453 and b/176992421

Change-Id: I3398674a0acbad8329df5d341ae074ac073a6bf9
2021-01-07 19:44:44 +00:00
Jason Chang be5af2de6b Fix triggering One-handed mode introduces gesture conflict issues
(2/n)

Define a new larger gesture height instead of replacing
existing navigation_bar_gesture_height with RRO.

Bug: 159580663

Test: manual
Change-Id: Icdd70b28d9b2629171fb60a0c9d603f6a69f076a
2021-01-07 15:20:10 +08:00
Schneider Victor-tulias b76e4dbc51 Merge "Temporarily disable visibility-gated hotseat and prediction row updates." 2021-01-06 15:20:27 +00:00
Becky Qiu 5a7d6d682a [Overview Sharing] Add a feature flag for overview sharing.
Bug: 169772466, 169799864
Test: local
Change-Id: Ie386f660d24feb8d0f3ed15ccf946c005d436986
2021-01-05 14:37:29 -08:00
Schneider Victor-tulias f5e0f1122c Merge "Add UI updates for incremental app installs." 2021-01-05 21:53:44 +00:00
Schneider Victor-tulias 84269d349d Add UI updates for incremental app installs.
1. Changed Preload Icon UI to be grayscale while the app is not startable.
2. Added progress bar for when app is installed but still ownloading.
3. Updated Preload Icon progress and click handling to use new incremental api.

Progress bar color updates will follow in a separate CL.

Demo: https://drive.google.com/file/d/1H1EvtTorLeJwC1eiq10tm-TT81YZ6osk/view?usp=sharing

Bug: 171008815

Test: manual

Change-Id: I5874a5146d79a8c91d7d90ff0b9c1c427a3c95dd
2021-01-05 15:17:26 -05:00
Sunny Goyal 9b1e77377b Removing shelf from 2-button gesture mode
Test: Manual
Bug: 175137718
Change-Id: Ifb64b4dcac53252aefa8ee0bd6434f90f1d868b7
2021-01-05 19:07:21 +00:00
Samuel Fufa 6e0b00d15c Remove Second consumer from AllAppsSearchBarController
Bug: 175125073
Test: Manual
Change-Id: I34abf0b999e58e034705a1c0696e8fcd88020b28
2020-12-27 16:13:06 -06:00
TreeHugger Robot 618ba37e04 Merge "Add additional fake task views on overview gesture completion." 2020-12-23 01:34:00 +00:00
Schneider Victor-tulias 20bbaa3390 Add additional fake task views on overview gesture completion.
Added motion pause listening to animate an additional fake task view on overview gestures in the sandbox.

Test: manual

Demo: https://drive.google.com/file/d/1EpewbIAxiMUEz0Fqdfbok5q9xpWS6NWz/view?usp=sharing
Change-Id: Ifd0aed0a2bbb3204ae32c833b8466952679700e3
2020-12-22 16:10:09 -08:00
Jason Chang aa934170de Merge "Fix swipe for notification default should be on instead of off" 2020-12-18 09:29:06 +00:00
TreeHugger Robot ad8d9454d4 Merge "Fix some task view fling calculations" 2020-12-17 00:34:47 +00:00
TreeHugger Robot a15b5a6760 Merge "Don't crash Launcher when attempting to endTransaction on an already-closed DB." 2020-12-16 22:35:06 +00:00
Tony Wickham b956a03067 Fix some task view fling calculations
- Map to progress 1 instead of dividing by 0 if expectedDuration == 0
- Map to starting progress one frame ahead based on velocity
- Change direction of velocity so it's in the same direction as the
  task progress (0 is down and 1 is up).

Change-Id: I5ac3f8a0d6c616bd303ac1a902242964bb33d3c7
2020-12-16 09:31:26 -08:00
Jason Chang 6025dfe1ab Fix swipe for notification default should be on instead of off
Set newOneHandedSettingsObserver() defaut value 0 to prevent
blocking swipe-down notification's OneHandedModeInputConsumer
.onStartGestureDetected() when device first booting.

Bug: 175084985

Test: rebuild ROM image and manual
Change-Id: I5fe7d4036ac74682ae72cf210e8b40c63ceb53e1
2020-12-16 19:58:15 +08:00
TreeHugger Robot 2df0ef38a0 Merge "Synchronizing model data access" 2020-12-16 09:59:19 +00:00
Schneider Victor-tulias 5aad9d87d7 Temporarily disable visibility-gated hotseat and prediction row updates.
Pending a resolution in b/174174514, disabling the visibility-gating of hotseat and all app prediction row updates. Updates will be allowed regardless of visibility.

Test: manual
Change-Id: I10e4dae9aad9af7b799fdad3b231c734e383b493
2020-12-15 16:00:59 -05:00
Tony Wickham 79ec120b3f Merge "Fix TaskViewTouchController crash in seascape" 2020-12-15 18:45:15 +00:00
Sunny Goyal fee1b25fee Fixing PendingArgs not cleared when going home
Bug: 174781600
Test: manual
Change-Id: I2f192b0f60d843b49b290fa70b76f562fca81e36
2020-12-14 12:30:47 -08:00
TreeHugger Robot e1358149fc Merge "Removing unused tracing" 2020-12-14 18:21:37 +00:00
TreeHugger Robot 04099cdabe Merge "Add FeatureFlag for ENABLE_FOUR_COLUMNS." 2020-12-12 10:31:41 +00:00
vadimt c610f26404 Removing unused tracing
Test: presubmit
Bug: 139891609
Change-Id: I30b432d329d6606b3d955409c167bddbacce8a37
2020-12-11 19:43:49 -08:00
Tony Wickham e3386502cf Fix TaskViewTouchController crash in seascape
Previously, we were using scroll direction POSITIVE as a catch all
to mean "up" but in seascape, we actually want NEGATIVE. Added
getUpDirection() to capture that. Tried to clarify the code a bit
by putting all the methods used solely by TaskViewTouchController
together with documentation. It's still pretty confusing and feels
redundant, but couldn't think of an obvious way to simplify.

Test: Swipe up and down on a task in all permutations of:
- 3 button mode
- Gesture navigation
- Portrait
- Landscape
- Seascape
- LTR
- RTL
- Home rotation allowed
- Home rotation disallowed

Fixes: 174009771
Fixes: 173567204
Change-Id: Id0f8d6f4365d888eb46182d8544d18206795dfb8
2020-12-11 17:30:41 -08:00
TreeHugger Robot 38cdbb4690 Merge "Add null check to AbstractStateChangeTouchController#onDragEnd()" 2020-12-11 22:57:44 +00:00
Jon Miranda 73dcc9878d Add FeatureFlag for ENABLE_FOUR_COLUMNS.
Will be paired with new device profile used to dogfood
upcoming grid changes.

Bug: 175329686
Change-Id: Iab08d9ed0dec14fd6a05c4485ac4e066533d2540
2020-12-11 14:19:13 -08:00
Sunny Goyal cfcefb0c47 Synchronizing model data access
Test: Presubmit
Bug: 173328873
Change-Id: Ifc1724e17ebfa2ee5f21bb3f272986b8a14fdbc1
2020-12-10 16:24:19 -08:00
Samuel Fufa 06ade42dd7 Merge "Resolve Flaky work tab tests" 2020-12-10 23:49:34 +00:00
Samuel Fufa b8df6a573a Resolve Flaky work tab tests
In cases where test execution and launcher relayout overlap, mLauncher.getAppsView().getContentView() returns a recyclerview instead of pagedView. This is resolved when rebindAdapters is later called with showTabs=true. The issue here is we are keeping a stale value of mLauncher.getAppsView().getContentView() in WorkEduView which is problematic as pagedView is required to set the right tab index for the test.

This behavior also affects work testWorkEduIntermittent as we need to verify the a pagedView is visible before text execution.
Bug: 149867607
Bug: 159671700
Test: flake -t com.android.launcher3.ui.WorkTabTest

Change-Id: I4b0968d6b9daa5c8fe741d4b1ed090f9c7acabed
2020-12-10 11:02:13 -06:00
Hyunyoung Song e387285f0f Merge "Fix NPE inside SEarchResultThumbnailView on cropping Bug: 175161949 Test: builds. Created screenshot of landscape portion and verified" 2020-12-10 05:53:19 +00:00
Hyunyoung Song 4b2403bbdf Fix NPE inside SEarchResultThumbnailView on cropping
Bug: 175161949
Test: builds. Created screenshot of landscape portion and verified

Change-Id: Ib80147bcb40cf73364e8bed91f38019716aa71c8
2020-12-09 14:33:32 -08:00
Samuel Fufa df0ae18170 Merge "Fix flaky enter key" 2020-12-09 20:12:39 +00:00
Sunny Goyal 9b1d362f78 Merge "Keeping Launcher in overview UI if activity is restarting due to UI mode changes" 2020-12-09 19:22:38 +00:00
Samuel Fufa d0ae95aa04 Merge "Separate QSB from on device search" 2020-12-09 18:55:59 +00:00
Samuel Fufa 2ea01e4871 Separate QSB from on device search
Bug: 175125073
[Preview attached to BR]

Change-Id: If967d95e32b58263ede5eb8a3c1b773cef789f28
2020-12-09 12:46:30 -06:00
Sunny Goyal 6c0c61acd8 Keeping Launcher in overview UI if activity is restarting
due to UI mode changes

Test: Verified Launcher behavior locally
Bug: 148988542
Change-Id: Id83e5e0892666af1420e8f8c711b83f1ea355188
2020-12-08 19:22:01 -08:00