Commit Graph

7977 Commits

Author SHA1 Message Date
Sunny Goyal d6692cedff Revert "Set mState = mCurrentStableState in onAnimationCancel"
This reverts commit 8935d9515c.

Reason for revert:
Bug: 109814458
Bug: 79935289

Change-Id: I33e4933a68060b6055ad7af8e45cffceec14880d
2018-06-06 18:47:59 +00:00
Tony Wickham 8935d9515c Set mState = mCurrentStableState in onAnimationCancel
mState is set when the transition starts toward that state even if it is
never reached. If the animation is canceled, therefore, we should reset
mState = mCurrentStableState since that is the state we came from.

For instance, when swiping up from overview, mState = ALL_APPS, but when
swiping back down we cancel that animation and create the task launch
animation. When creating the task launch animation, we reapplyState(),
which, before this change, was still ALL_APPS instead of OVERVIEW.

Bug: 79935289
Change-Id: I59c5799e92350747e4ef1d99a80ba678a2ce7b98
2018-05-29 21:58:52 +00:00
Sunny Goyal 9bb8ffb5e3 Various quickscrub fixes
> Fixing PagedView resetting the currentPage, if scrollToPage was called before first layout
  This causes quickscrub to jump back to the current task if launcher activity was dead.
> Fixing missing callbacks in DeferredTouchConsumer causing missed quick scrub flings
> Sending the resents animation callbacks on the motion queue thread, to avoid synchronization
  issues with sysui callbacks.
> Waiting until the recents animation is received before starting the scale down animation
> Calculating the offset for quickscrub statically incase launcher activity was dead

Bug: 80214390
Change-Id: I1b7d00b7b266655a92fcd6239f25ba191655150f
2018-05-29 12:17:20 -07:00
TreeHugger Robot 03aaced252 Merge "Fix clipping of adaptive icons Bug:62372639" into ub-launcher3-edmonton 2018-05-29 17:38:28 +00:00
Hyunyoung Song 49df554dc2 Fix clipping of adaptive icons
Bug:62372639

Context: only noticeable on large form factor AND Large display setting
Ceiling operation is needed to calculate offset of the drawing.

Change-Id: I7c77fa53f0811990b8cfdc3a12e2b43eb4d2d73e
2018-05-25 16:30:23 -07:00
Vadim Tryshev 5c17a390d2 Merge "Reporting range of visible tasks" into ub-launcher3-edmonton 2018-05-25 19:55:39 +00:00
Vadim Tryshev 528b9e0615 Reporting range of visible tasks
Also fixes task position being incorrectly reported specifically for
swipe events due to using stale getCurrentPage().

Bug: 72222505
Test: Manual
Change-Id: Ic79b67f8a6ffbfabc397b411b14afc309405197e
2018-05-25 12:24:40 -07:00
Sunny Goyal 4308bd232e Merge "Fixing launcher going to a different state when dragging an icon from different activity" into ub-launcher3-edmonton 2018-05-25 19:17:28 +00:00
Sunny Goyal 4dcda06542 Fixing launcher going to a different state when dragging an icon from different activity
Bug: 80191074
Change-Id: I45ea646dc2bd21627e8b724dac9c9fc23c18797d
2018-05-25 11:56:53 -07:00
Sunny Goyal db9f86a472 Accounting for view translation when calculating the focus location
Bug: 80160107
Change-Id: Ibb0cb82c33c141bb3abf9b7576be4253630cb8c5
2018-05-25 17:52:49 +00:00
Jon Miranda 012d39a0e9 Fix crash caused by removing update listener in update listener.
Bug: 80236772
Test: Fling all apps open, and catch it before it reaches the top
Change-Id: I082a26b97afb7dbc162758ff9654e4a3707f9d7e
2018-05-25 10:41:16 -07:00
Jon Miranda 31942e788b Fix bug where icon 'jumps' on long press.
Bug: 76155869
Change-Id: I739b00564b0ebe00b3aff326b3c1d62deea9d1d3
2018-05-25 01:49:37 +00:00
TreeHugger Robot 159d6949a1 Merge "Fix prediction tip shows when user attempts but does not swipe up all the way to All Apps when quickstep is disabled." into ub-launcher3-edmonton 2018-05-25 00:49:23 +00:00
Tracy Zhou 5d89e1be98 Fix prediction tip shows when user attempts but does not swipe up all the way to All Apps when quickstep is disabled.
Bug: 80268964
Test: Manual test
Change-Id: I9b0620d57ccd466392c1db4c4899da3368a854db
2018-05-24 17:24:23 -07:00
TreeHugger Robot a252a07562 Merge "Adding support for dark text on dark theme" into ub-launcher3-edmonton 2018-05-24 21:09:16 +00:00
Sunny Goyal a6afdffbbd Adding support for dark text on dark theme
Bug: 80253867
Change-Id: Ib81a2fe884f68cd2dd4af1e573bd8c836f374f16
2018-05-24 13:50:27 -07:00
Vadim Tryshev 1b0c5032d1 Fixing keyboard navigation when Overview list is empty
Bug: 80155387
Change-Id: Ife86fe4b718ef01291a04b21020155110d75fa7b
Testing: Manual
2018-05-24 13:06:18 -07:00
TreeHugger Robot 1ab656460b Merge "Removing discovery bouncer from accessibility" into ub-launcher3-edmonton 2018-05-24 00:03:17 +00:00
Vadim Tryshev 17839d5f62 Removing discovery bouncer from accessibility
It was obstructing views under it.

Solves both Talkback and Switch Access issues.

Bug: 80192025
Test: Manual
Change-Id: Ia7fad91e1fcb857afbf68f879550c670279cee68
2018-05-23 16:51:41 -07:00
Sunny Goyal 7f28fd55ff Increasing the overview size while in QuickScrub mode
Bug: 80139193
Change-Id: I19ea05d3cc083628364651e9d9f581fe1aaaeaaa
2018-05-23 15:55:51 -07:00
Sunny Goyal d5377ca4b3 Merge "Remove custom focus logic" into ub-launcher3-edmonton 2018-05-23 21:29:41 +00:00
Tony Wickham 65e8311222 Merge "Only log swipe interaction on swipe end" into ub-launcher3-edmonton 2018-05-23 20:51:40 +00:00
Tony Wickham 422e1f9c69 Only log swipe interaction on swipe end
Previously we were logging new states as we swipe past them; now we just
log the start and end states when lifting your finger.

Bug: 80102083
Change-Id: Icec6c3dab1441023a3cdcadb7b56ecef8313cb8c
2018-05-23 13:20:10 -07:00
TreeHugger Robot 4e057b5f97 Merge "Log the parent of the PREDICTION container type (ALLAPPS OR TASKSWITCHER) Bug: 79423536" into ub-launcher3-edmonton 2018-05-23 20:16:15 +00:00
Hyunyoung Song 46d07f7cb0 Log the parent of the PREDICTION container type (ALLAPPS OR TASKSWITCHER)
Bug: 79423536

Change-Id: I23ff0d4d0aa3fec781e9b6c8792d2d7a738ca6c8
2018-05-23 11:35:02 -07:00
TreeHugger Robot 39ac161095 Merge "Add mStartState to determine if user swipes up from Home." into ub-launcher3-edmonton 2018-05-23 17:57:58 +00:00
Sunny Goyal e598699dc5 Remove custom focus logic
Using the system logic for focus handling so that partially visible contents are
properly handled, eg in overview only hotseat is visible
This does changes the focus logic on workspace when both icons and widgets or different sizes
are present, we may consider reviving (parts of) this logic in the future

Bug: 80189843
Change-Id: I874e284e0a62b579c24d36db9b74da3de7a7e367
2018-05-23 10:54:18 -07:00
Jon Miranda 1d19e2f152 Start springs for All Apps when user flings up.
Bug: 77695481
Change-Id: Ifecfbbb89601947118f620f522662aee8a61946e
2018-05-23 09:13:07 -07:00
TreeHugger Robot c0928c3ba0 Merge "Enable new open app transitions when in multiwindow mode." into ub-launcher3-edmonton 2018-05-23 00:35:22 +00:00
Jon Miranda 73c27ec176 Enable new open app transitions when in multiwindow mode.
Bug: 79118278
Change-Id: Iba79948256d70c913af0a9a584eb040f3a8b4151
2018-05-22 17:25:11 -07:00
Tracy Zhou 788c051493 Add mStartState to determine if user swipes up from Home.
Bug: 80146880
Test: Manual test
Change-Id: Ia0743bff3f2a5b3998a798743138b012ec461a94
2018-05-22 16:25:37 -07:00
TreeHugger Robot 5454fa1f6e Merge "Making caret visibility part of state definition" into ub-launcher3-edmonton 2018-05-22 23:08:42 +00:00
Sunny Goyal 56e1019e95 Making caret visibility part of state definition
> Hiding the caret in fast overview state
> Hiding caret in task swipe down interaction

Bug: 79700605
Change-Id: I984d535bc75802501e8aeb13c8f37387f331e5bc
2018-05-22 15:58:20 -07:00
Sunny Goyal 36b2fca3bd Merge "Reset the vertical progress when the discovery bounce is closed" into ub-launcher3-edmonton 2018-05-22 22:20:54 +00:00
TreeHugger Robot 085cebc741 Merge "Skip processing fallback icons as they are already badged and have shadow" into ub-launcher3-edmonton 2018-05-22 22:00:05 +00:00
TreeHugger Robot d1134a0295 Merge "Making overview panel accessible via Tab" into ub-launcher3-edmonton 2018-05-22 22:00:02 +00:00
Vadim Tryshev f1507a6a64 Making overview panel accessible via Tab
Keyboard navigation of AllAppsContainerView is broken in TOT; disabling
focusing there is necessary for Recents.

Bug: 72222505
Test: Manual
Change-Id: I85d544f7c8dbdaf12e49de51c6626bbc3dc32917
2018-05-22 14:47:44 -07:00
Sunny Goyal 0bd0244a73 Reset the vertical progress when the discovery bounce is closed
Since discovery bounce runs on absolute values, it can sometime leave the vertical progress
at an old value, if it is closed after the state change.
Also simplifying discovery bounce animation to use xml everytime.

Bug: 80099242
Change-Id: Iebc249dd02f474cbed85b695eeeb8c2bf60b935d
2018-05-22 11:40:58 -07:00
Tony Wickham 4e21c1b552 Cleanup how we set back button alpha
Add BackButtonAlphaHandler to set back button alpha, instead of setting
it from multiple places.

Also force back button alpha to be 1 if swipe up is disabled (b/80091187)

Change-Id: I49b63a0e6b033a3a947a847669a398f1b9ff0564
2018-05-22 11:05:01 -07:00
TreeHugger Robot 52cb0a73a4 Merge "Go back to previous state when hitting back from discovery bounce" into ub-launcher3-edmonton 2018-05-21 23:11:56 +00:00
Tony Wickham 52c1b66f46 Go back to previous state when hitting back from discovery bounce
Normally when you hit back, we just close the floating view if there
is one. This makes less sense for DiscoveryBounce, since it doesn't
feel like a different state even though it's technically a floating
view. So in that case, don't consume the back press; let launcher
handle it to go to the previous state.

Bug: 80075741
Change-Id: I7270b61be70509cb2101400a12929478a5d082aa
2018-05-21 16:01:49 -07:00
Hyunyoung Song bd6fba9f58 onResume event should be logged (not twice but once)
Bug: 79541772

Change-Id: I5fe1271007e4579e1ec95d51c215ef48d0c6eedd
2018-05-21 12:27:46 -07:00
Tony Wickham e542e91191 Merge "Cleanup UserManagerCompatVP to not use reflection" into ub-launcher3-edmonton 2018-05-21 18:18:47 +00:00
Tony Wickham a9cc397673 Cleanup UserManagerCompatVP to not use reflection
Change-Id: I1e4afc9c36f9d8641799b70e83f6b9801aec2e3d
2018-05-21 10:54:09 -07:00
Tony Wickham e2116daa88 Merge "Don't prevent animations in power save mode" into ub-launcher3-edmonton 2018-05-21 17:51:35 +00:00
Vadim Tryshev 98913d0c95 Remove code duplication
Bug: 72222505
Test: Manual
Change-Id: I6ae6ac7474b44c16bd765635e32d2e843bc02cac
2018-05-18 18:41:34 -07:00
Vadim Tryshev 4ae69dea49 Merge "Fixing reverted order of accessibility scrolling in Recents" into ub-launcher3-edmonton 2018-05-19 00:54:37 +00:00
Tony Wickham 8155fa2aa5 Don't prevent animations in power save mode
Now that batter saver mode doesn't get rid of animations in P, we
shouldn't use custom logic to prevent them either.

Also updated ATLEAST_P to use version code.

Bug: 79990054
Change-Id: If17cf369035c976f3d9d81f35432a045f1956ce5
2018-05-18 17:18:49 -07:00
Tony Wickham f9d38098ca Merge "Fix a couple issues with swiping up from home" into ub-launcher3-edmonton 2018-05-18 16:50:47 +00:00
Matthew Ng 8b92fe336b Fade back button in and out tied with the overview/shelf (2/3)
Back button changes opacity when moving the shelf during swipe up
between home screen and overview. The alpha changes depending on the
progress of the swipe up animation. When going from app to home and vice
versa, the fade animation does not tie with the swipe up progress. The
fade animation also masks the back button drawable when ime visibility
changes.

Change-Id: I51e42930640ba711e81880b385bb722d7ee8ad33
Fixes: 74581837
Fixes: 76900236
Test: swipe up from home screen to overview
2018-05-18 00:48:51 +00:00