Commit Graph

12520 Commits

Author SHA1 Message Date
Tony Wickham d552132d0b Reset RecentsView#mNextPage when swiping to home
This ensures that we don't inadvertently update mCurrentPage to be
mNextPage in computeScrollHelper(), which would in turn mess up
calculations such as RecentsView#getHorizontalOffsetSize().

Also removed resetNextPage parameter from forceFinishScroller(), as
resetNextPage was always passed as true anyway.

Test: Swipe up and to the right to home, ensure adjacent page goes all
the way off screen
Fixes: 199927699

Change-Id: Iee1ffac10e5195f0c3a124a23b06d5411ecd7ba2
2021-09-14 14:38:15 -07:00
Vinit Nayak ca549695aa Merge "Set GroupedTaskView child thumbnails in onMeasure" into sc-v2-dev 2021-09-14 17:34:52 +00:00
Vinit Nayak e6abfca7ab Set GroupedTaskView child thumbnails in onMeasure
* Also add indicator if split was originally started
in portrait of landscape, so we know which dimension
of the divider bar to use if user goes to overview
and then rotates device (horizontal divider vs
vertical)

Fixes: 199461137
Test: Swipe to overview with staged split
Rotate device with and without live tile
Doesn't overlap with overview actions

Change-Id: I8b7f104f16d5b7265828f1b3d98ba3426b28d44f
2021-09-13 18:07:09 -07:00
TreeHugger Robot adfcd9daea Merge "Introduce haptic when all apps state transition happens." into sc-v2-dev 2021-09-12 22:53:47 +00:00
Hyunyoung Song 862415a142 Introduce haptic when all apps state transition happens.
Bug: 195679234
Test: manual
Change-Id: Id923f1641bb49579c972e3dbb9de094293d00f93
Merged-In: Id923f1641bb49579c972e3dbb9de094293d00f93
2021-09-12 21:48:52 +00:00
Thiru Ramasamy 8c8dc56495 Merge "Implement LauncherLayoutSnapshot pulled atom callback." into sc-v2-dev 2021-09-10 22:59:00 +00:00
TreeHugger Robot f8d4041c84 Merge "Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask" into sc-v2-dev 2021-09-10 20:55:18 +00:00
Thiru Ramasamy d495e8c8b4 Implement LauncherLayoutSnapshot pulled atom callback.
This change will pull only the workspace items but not the launcher settings such as grid layout etc. Future CLs will address it.

Bug: 181703659
Test: Manual-`statsd_testdrive 10108` http://gpaste/4894958784872448
Change-Id: I0e7d7da62034c411edb26ff9205a81b0e2e891a0
2021-09-10 13:29:27 -07:00
TreeHugger Robot 8b30227f58 Merge "Explicitly set X and Y values when offsetting split tasks" into sc-v2-dev 2021-09-10 18:05:18 +00:00
TreeHugger Robot b94401646d Merge "Fix wrong screenId when committing emptyScreens" into sc-v2-dev 2021-09-10 15:36:22 +00:00
Alex Chau d63c58d7d1 Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY in RestoreDbTask
- Follow-up of ag/15795679: allow restore in RestoreDbTask as well

Bug: 199407109
Test: manual
Change-Id: I2a8e2d9c28ee777f53a6d3554e31f7318422401f
2021-09-10 15:16:36 +01:00
TreeHugger Robot 81a3e6e7e7 Merge "Fix two dragging related bugs in Launcher home" into sc-v2-dev 2021-09-10 13:39:26 +00:00
Alex Chau 1d5929dd82 Fix wrong screenId when committing emptyScreens
- Need to increment newScreenId whenever the screen is already bound
- Also cleaned up placeholder on w1 as we now have page pairing logic

Bug: 199160559
Bug: 175939730
Fix: 199131780
Test: drag and drop after clear data
Change-Id: Ic42f3bddfa6cf11b8b726d6181ed2477defde19d
2021-09-10 14:36:36 +01:00
Andras Kloczl 9732df1add Fix two dragging related bugs in Launcher home
- accessibility bug: 199394124
- dragging on side bug: http://shortn/_LFBdIllupk

Test: manual
Bug: 199394124
Change-Id: I478e31332119f337bf0f8b6c92926845eb4889c4
2021-09-10 12:16:03 +01:00
Thales Lima 02a5019cf3 Merge "launcher: correct page spacing for multiple panels in RTL" into sc-v2-dev 2021-09-10 09:53:40 +00:00
Vinit Nayak 6835115c13 Explicitly set X and Y values when offsetting split tasks
* Race condition where DeviceProfile that gets set on
TaskViewSimulator initially has incorrect values
(dp.isLandscape is incorrect)
* The correct one eventually gets set, but in the meantime
we set the split offset assuming in incorrect value in
PagedOrientationHandler#setLeashSplitOffset()
* Once corrected, we weren't removing the old offset
that was set. Now we ensure only either an X or Y offset set.

Bug: 199376724
Test: Enter split, rotate device and quickswitch.
Both tasks should be visible throughout the gesture

Change-Id: I9fa44642ab440a0200c0b0eb9b37574e47b7100d
2021-09-09 16:27:59 -07:00
Tony Wickham 94c673c64d Merge changes I032f7ffc,I384d7af0 into sc-v2-dev
* changes:
  Add ability to start DeveloperOptionsFragment with filter pre-applied
  Add option to reset Onboarding Flows in Developer Options
2021-09-09 20:09:03 +00:00
TreeHugger Robot 8f0de5d711 Merge "Introduces haptic feedback to launcher overview" into sc-v2-dev 2021-09-09 19:19:26 +00:00
Thales Lima c2a6f6f4ae launcher: correct page spacing for multiple panels in RTL
Fixes 199043583
Test: manual testing in unfolded state in portrait and landscape

Change-Id: Idf5bdabb50742498701681e4654e72260054ab47
2021-09-09 19:13:19 +01:00
Alex Chau fef4d0e081 Allow restore between TYPE_PHONE AND TYPE_MULTI_DISPLAY
Bug: 199407109
Test: manual
Change-Id: I6eb982a79f4130925a9d7e0972faf0f01a6aac20
2021-09-09 18:24:51 +01:00
Lais Andrade cc5c8843df Introduces haptic feedback to launcher overview
Haptics introduced at the key moments:

- Task scroll in overview or quick switch, trigger when a new task comes
to the center of the screen;
- Task scroll in overview when overscroll animation is triggered;
- Task dismissed in overview;

There is also a configured min gap between two scroll haptics set to
20ms to prevent fast scrolls from creating a chain of cancelled effects.

Fix: 182382085
Test: manual
Change-Id: I43c0f8c879a06f317e8a660240dafb7f7abe79f7
2021-09-09 14:08:01 +01:00
TreeHugger Robot 3f8f61cb40 Merge "Slight polish for split screen gesture animation" into sc-v2-dev 2021-09-09 03:17:23 +00:00
Samuel Fufa 8aecc9ac36 Merge "[Work] Fix work apps showing in personal tab" into sc-v2-dev 2021-09-09 01:09:01 +00:00
Vinit Nayak d1a70eeb75 Slight polish for split screen gesture animation
* Divider bar dimensions manually calculated since
the leash that is provided has bounds larger than
the space that is visually shown between the two split
apps

Bug: 181704764
Test: Swipe up on large and normal screen,
w/ and w/o home rotation enabled

Change-Id: I1fde053151d47c6ce3e11f16f8ae4a153d273871
2021-09-08 17:39:49 -07:00
TreeHugger Robot fd744975cc Merge "Fix crash when Workspace item is added to two panel home" into sc-v2-dev 2021-09-08 22:09:53 +00:00
Samuel Fufa 564e9ca223 [Work] Fix work apps showing in personal tab
The problem here is that we are tracking hasWorkApps and usingTabs using the same value.
 This leads to work/personal apps showing together when clearing search since mUsingTabs is overridden to false on setLastSearchQuery and later used to determine if tabs should show.
Bug: 198546279
Test: Manual

Change-Id: I7df5d65472703bedcc9dd688847d9ebd146d5f61
2021-09-08 15:02:24 -07:00
Tony Wickham 9ac2800849 Don't allow starting DeveloperOptionsFragment on non-debug builds am: a343699760
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15787659

Change-Id: I268204c3f0597fb4609437a94efdffcdfdb6b4f0
2021-09-08 21:28:46 +00:00
Tony Wickham 534bd2205b Add ability to start DeveloperOptionsFragment with filter pre-applied
Repurposing EXTRA_FRAGMENT_ARG_KEY to set an initial filter.

Test: adb shell 'am start -n com.google.android.apps.nexuslauncher/com.android.launcher3.settings.SettingsActivity --es ":settings:fragment" "com.android.launcher3.settings.DeveloperOptionsFragment" --es ":settings:fragment_args_key" "Education"'
Bug: 199299382
Change-Id: I032f7ffc373daed51c8d381f3cacf722fb3fb198
2021-09-08 13:51:29 -07:00
Tony Wickham 281786a841 Add option to reset Onboarding Flows in Developer Options
Test: Go to Developer Options, reset Hybrid Hotseat Education, then long press on a predicted hotseat item and ensure edu toast appears
Bug: 199299382
Change-Id: I384d7af08fc8b842bc3a1333b9f8017cca3680e6
2021-09-08 13:51:25 -07:00
Alex Chau 817e0fa812 Fix crash when Workspace item is added to two panel home
Test: Run com.android.launcher3.ui.widgetRequestPinItemTest#testPinShortcut tests
      and com.android.launcher3.ui.TaplTestsLauncher3#testWorkspace
Bug: 199150824
Change-Id: I8550970806eb0b9bfc246d4fb76ffbd0415b7647
2021-09-08 21:01:10 +01:00
Tony Wickham a343699760 Don't allow starting DeveloperOptionsFragment on non-debug builds
Test: adb shell am start -n com.google.android.apps.nexuslauncher/com.android.launcher3.settings.SettingsActivity --es ":settings:fragment" "com.android.launcher3.settings.DeveloperOptionsFragment"
Fixes: 199302659
Change-Id: I33dd4db3444c0ccabbe4dc3bb80db4167aec6a03
2021-09-08 19:11:59 +00:00
TreeHugger Robot 8d9eaf0c7d Merge "Fixing itemInfoMatcher not working for folders" into sc-v2-dev 2021-09-08 19:10:20 +00:00
TreeHugger Robot b44b73ee3a Merge "Moving roboelectic tests to instrumentation tests" into sc-v2-dev 2021-09-08 18:40:37 +00:00
Sunny Goyal 266905160a Fixing itemInfoMatcher not working for folders
Bug: 197686628
Test: Manual
Change-Id: Ie43a55be6cce4bc73e38525388d744a649dbc740
2021-09-08 12:29:13 -04:00
Sunny Goyal 3e9a29c4d6 Moving roboelectic tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I197bc47181308bb0b79f3815a892b733abbcd1fd
2021-09-08 10:23:30 -04:00
Thales Lima 9223c1e27c Merge "launcher: show smartspace date card on Wallpaper & style" into sc-v2-dev 2021-09-08 09:58:11 +00:00
TreeHugger Robot 11438429a8 Merge "Prevent NPE when init device profile" into sc-v2-dev 2021-09-08 02:14:31 +00:00
Jerry Chang bfac46a30c Prevent NPE when init device profile
Fix: 198871283
Test: manual
Change-Id: Ie303ff4f3dc05f419e80038e41e195dc874ba40a
2021-09-08 08:34:39 +08:00
TreeHugger Robot d213914214 Merge "Fixing leak in model tests" into sc-v2-dev 2021-09-07 21:31:34 +00:00
Tony Wickham 437e44810d Merge "Fix wallpaper picker crash if folder is in hotseat" into sc-v2-dev 2021-09-07 20:52:44 +00:00
Samuel Fufa 832043d1c9 Merge "[Search] Update AllApps header protection" into sc-qpr1-dev 2021-09-07 19:57:31 +00:00
Sunny Goyal b45aef3f1c Fixing leak in model tests
> InstallSessionTracker is not released immediately causing large memory objects
  being held by tests

Bug: 198719724
Test: Presubmit
Change-Id: I1d19a2a498a9f255077818dc7d78422367ec1749
2021-09-07 15:34:48 -04:00
Tony Wickham 302eff9c84 Fix wallpaper picker crash if folder is in hotseat
Only use mWorkspaceScreens if info.container == CONTAINER_DESKTOP, otherwise assume it's in mHotseat instead.

Test: have a folder in hotseat, open wallpaper picker and can see the preview and set wallpaper
Fixes: 199179718
Change-Id: I6f1dbd8dc387783bb8b76e2bc469508c079a85f8
2021-09-07 12:04:47 -07:00
Andras Kloczl d888e77145 Fix crash when hotseat icon is dragged onto Workspace
Test: manual
Bug: 198820019
Change-Id: I53bb858feb7aad45472803b133ef3d026dd9f319
2021-09-06 16:43:01 +01:00
TreeHugger Robot 69fd5cb959 Merge "Remove widget panel related leftover workspace items" into sc-v2-dev 2021-09-06 12:39:54 +00:00
Andras Kloczl 929e3a2742 Remove widget panel related leftover workspace items
Upgrade launcher DB version and remove items with
widget panel IDs from the database.

Test: follow test instructions (in CL comment)
Bug: 198254728
Change-Id: I077a5f70ee93b7eca738b38f6b0e788d49f7ce70
2021-09-06 11:58:32 +01:00
Alex Chau 62f129b878 Fix getPagesToBindSynchronously returning wrong page pairs
- Use WorkSpace.getPagePair instead for accurate value

Bug: 191657065
Test: manual
Change-Id: I584f1705fb5ed2f0d2bd776eb6cf4f60c69238ac
2021-09-06 10:58:48 +01:00
András Klöczl 4926bf706a Merge "Add two extra empty pages on two panel launcher home" into sc-v2-dev 2021-09-05 21:05:53 +00:00
Andras Kloczl 408a54f2e7 Add two extra empty pages on two panel launcher home
Add a new screen ID for the second extra empty page
and add that new screen as well when the existing
extra empty page is added so that users can put items
on both sides of Workspace.

Test: manual
Bug: 196376162
Change-Id: I0b4f2e818407a10d8a7c032788a7bd7a61267779
2021-09-05 22:03:07 +01:00
TreeHugger Robot 5ea5f90397 Merge "[Work] Fix duplicate work button issue" into sc-qpr1-dev 2021-09-04 06:36:28 +00:00