Commit Graph

7520 Commits

Author SHA1 Message Date
Tony Wickham cdb2df88bd Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev am: f9d2082cf3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15988588

Change-Id: I2a2f4c65e2cfc2649d5c590e7aa855b79f1f4b28
2021-10-06 17:48:39 +00:00
Tony Wickham f9d2082cf3 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev 2021-10-06 17:36:45 +00:00
Tony Wickham 66ed0ff23e Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
2021-10-05 18:14:51 -07:00
Vinit Nayak c8b7fef784 Merge "Reset state after split launch animation finishes" into sc-v2-dev am: 6ab0d1e7be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15986152

Change-Id: Iac00a062f0f3531fa1d59cb2e2ade6b17e7cb73c
2021-10-06 01:14:28 +00:00
Vinit Nayak 6ab0d1e7be Merge "Reset state after split launch animation finishes" into sc-v2-dev 2021-10-06 00:56:48 +00:00
TreeHugger Robot e77cae7f0d Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev am: 1bf753f7a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15947750

Change-Id: Id67d2342b0715896faa6832e59116b6ea42fcf05
2021-10-06 00:26:54 +00:00
TreeHugger Robot 1bf753f7a6 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev 2021-10-06 00:14:46 +00:00
Vinit Nayak 0516737146 Reset state after split launch animation finishes
Previously we were clearing SplitSelectStateController
state too soon for fake landscape case where
as soon as the tasks launch the device does a rotation
animation since the new split tasks are in landscape.
Move restting state after animation finishes.

Fixes: 201980666

Change-Id: I23efd59fad444c47ae6c2048888a8570f22610fd
2021-10-05 15:29:24 -07:00
Vinit Nayak 9b79688147 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev am: 0ff2ad6ff4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15956593

Change-Id: Ifc5c08374ce590e7c417be6355ae1abdfc36796b
2021-10-05 21:49:00 +00:00
Vinit Nayak 0ff2ad6ff4 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev 2021-10-05 21:44:34 +00:00
Alex Chau 60818c3de0 Adjust min/max scroll according to mSplitPlaceholderSize am: 516584e648
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15982847

Change-Id: I8647b3135284dc504b3ac839f5191c26abf5d9b3
2021-10-05 18:13:46 +00:00
Pat Manning a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak 01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00
Alex Chau 516584e648 Adjust min/max scroll according to mSplitPlaceholderSize
- RTL is not handled yet due to split select broken

Bug: 200537659
Test: Split left and split right, check if min/max scroll is correct
Change-Id: I734d890bb955601da52cd806074014ed2e7eba55
2021-10-05 17:22:05 +01:00
Jerry Chang 6d6c9de783 Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev am: b001ce602f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15903128

Change-Id: Ifeca97e0646eb7049db438d54a2dfc217e65673a
2021-10-05 01:01:17 +00:00
Jerry Chang b001ce602f Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev 2021-10-05 00:46:36 +00:00
TreeHugger Robot d7b202e642 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-02 07:17:55 +00:00
Jerry Chang d41c032afd Update side stage outline visibility with swipe gesture
Bug: 200850654
Test: enabled side stage outline, observed the outline updates its
      visibility with swipe gesture properly.
Change-Id: I59fcb1fdbb07f5ad5327036972ebbe20ebeb11b7
2021-10-02 10:04:32 +08:00
TreeHugger Robot a5a22a2970 Merge "Don't snap to task when tapping task icon in overview grid" into sc-v2-dev am: f5942afeb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15960194

Change-Id: Ia7a35418185b4b66af7736213eb79c34618d323a
2021-10-01 19:32:12 +00:00
Alex Chau d4864e5cbc Don't snap to task when tapping task icon in overview grid
- Open task menu directly instead of snapping to task, as there are spaces to do so unlike small screen

Fix: 201428316
Test: Tap task icon with clear all button shown in overview grid, no snapping
Test: Tap task icon with clear all button shown in non-grid overview, snapped to last task
Change-Id: Ief79f7c758c4109e5c7722b2f35647db98a9f05c
2021-10-01 18:23:25 +01:00
Bill Yi 57df7bdcb5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I755d11f0b11cbfb1ecb44609b0cde8398a8a3492
2021-10-01 11:37:57 +00:00
TreeHugger Robot 5587d7a493 Merge "Overview - Remove Chips code" into sc-v2-dev am: d1ad84c6df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15942463

Change-Id: I247caed049c46dda4ee96bd175c8f15fbd82f41c
2021-09-30 22:29:52 +00:00
TreeHugger Robot d1ad84c6df Merge "Overview - Remove Chips code" into sc-v2-dev 2021-09-30 22:14:41 +00:00
Alex Chau f017e1bfcc Switch to rest state when display changes am: 90d24f4b9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15951262

Change-Id: Ibf9ec4de2feda386615404063283b7b093327301
2021-09-30 19:15:24 +00:00
Alex Chau 90d24f4b9b Switch to rest state when display changes
Fix: 199463580
Test: Unfold device from overview (both from app and from home), overview should close
Change-Id: I7786f3ec46857075e123fa2a093c7b55ca616fc1
2021-09-30 17:26:05 +01:00
TreeHugger Robot 8775a79741 Merge "Remove the Share button option from Overview." into sc-v2-dev am: 70cc9ffe7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15935390

Change-Id: I34365ae2b2f97536e1bc992ec583b11ce00bdc75
2021-09-30 04:23:41 +00:00
TreeHugger Robot 70cc9ffe7c Merge "Remove the Share button option from Overview." into sc-v2-dev 2021-09-30 04:11:47 +00:00
Tony Wickham 631a02507d Merge "Aniamte stashed handle color changes" into sc-v2-dev am: 6db0cf1e22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943405

Change-Id: I0c8c6fa69350a93a2a9de79f5609906e43658ba0
2021-09-30 02:29:33 +00:00
Tony Wickham b3ade306da Merge "Update stashed handle region to only include the handle" into sc-v2-dev am: ad3de8eab8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15943399

Change-Id: Id5e5a3829e96f36c977fcc06ddce8df385a19c9a
2021-09-30 02:29:29 +00:00
Tony Wickham 6db0cf1e22 Merge "Aniamte stashed handle color changes" into sc-v2-dev 2021-09-30 02:17:18 +00:00
Tony Wickham ad3de8eab8 Merge "Update stashed handle region to only include the handle" into sc-v2-dev 2021-09-30 02:17:03 +00:00
Tony Wickham 0ede0fa405 Aniamte stashed handle color changes
Test: Swipe from light background to dark background, ensure handle animates the color change
Bug: 193938970
Change-Id: I815c3a364019935bdf3d69309e695ac34b119c5e
2021-09-29 16:19:49 -07:00
Tony Wickham a93e158352 Update stashed handle region to only include the handle
Before it included the whole width/height of the view, rather than just the outline where the handle is drawn.

Test: Swipe up from a light app on dark wallpaper, ensure handle changes color as soon as the white app background is past halfway through the handle
Bug: 193938970
Change-Id: Ic8b83f60976f05b8ff56590422bd9b2fa6140e76
2021-09-29 15:47:58 -07:00
Samuel Fufa aab3edf950 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev am: abb827b376
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882894

Change-Id: I663deca71027dc1d558f012dfbf04e743a5719de
2021-09-29 22:21:48 +00:00
Samuel Fufa abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
Zak Cohen 71c527126b Overview - Remove Chips code
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.

Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
2021-09-29 14:43:27 -07:00
Zak Cohen 283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Pat Manning 148b8bd2eb Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev am: 429b8df180
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15804385

Change-Id: I7f5979e5d94ff8d3cc280af4cd694425e28f838c
2021-09-29 21:20:48 +00:00
Pat Manning 429b8df180 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev 2021-09-29 21:03:46 +00:00
Zak Cohen a3553ac013 Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev am: ba4b8e145d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15936271

Change-Id: I16cf062e888a898c3c2f24947c342f393b1865cd
2021-09-29 20:29:53 +00:00
Zak Cohen ba4b8e145d Merge "Remove RecentsExtraCard plugin hook." into sc-v2-dev 2021-09-29 20:15:14 +00:00
Schneider Victor-tulias 70c43e7f13 Merge "Update gesture navigation tutorial for foldable devices." into sc-v2-dev am: 5b563706e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15779642

Change-Id: I50c8c97a29427bbbeab2ae814c28e52a76b0326d
2021-09-29 19:59:46 +00:00
Schneider Victor-tulias 5b563706e3 Merge "Update gesture navigation tutorial for foldable devices." into sc-v2-dev 2021-09-29 19:42:43 +00:00
TreeHugger Robot d60f4bf549 Merge "Remove check that system rotation must be allowed for recents rotation to be allowed." into sc-v2-dev am: 42b5b78bbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15940373

Change-Id: I657a42949480520af4985053e273a7803c50bf07
2021-09-29 16:56:03 +00:00
TreeHugger Robot 42b5b78bbf Merge "Remove check that system rotation must be allowed for recents rotation to be allowed." into sc-v2-dev 2021-09-29 16:36:09 +00:00
Pat Manning da71f41263 Remove check that system rotation must be allowed for recents rotation
to be allowed.

This check existed before the user was able to rotate via the rotation
button while autorotate setting is off.

Test: manual
Fix: 201511975
Change-Id: I920886cb42ec5b8f4d3eb0bdd80b216cd7c3c849
2021-09-29 14:06:55 +00:00
Pat Manning fa0df11f45 Merge "Prevent repeated haptics on task dismissal." into sc-v2-dev am: 9fe8109b35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15934464

Change-Id: Ic7b442f62f1c8139be530225217dedbe17c551d0
2021-09-29 13:32:39 +00:00
Pat Manning 9fe8109b35 Merge "Prevent repeated haptics on task dismissal." into sc-v2-dev 2021-09-29 13:28:37 +00:00
Pat Manning 35231f3041 Add TAPL tests for hiding the actions view when scrolling away from
focused task in overview.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ie44a5bd99d7c9ffbc5405973c0ba1950cd90665c
2021-09-29 10:30:18 +00:00
Vinit Nayak b1e429e011 Merge "Add toast instructing user to select second split app" into sc-v2-dev am: 31e400d62e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15925826

Change-Id: I22f1a08cf06cfc0e9b374b12b8c4265ccad6e77b
2021-09-29 03:00:28 +00:00