Commit Graph

2992 Commits

Author SHA1 Message Date
Jon Miranda 892667cdf5 Track overview animation as atomic animation.
This fixed the bug where user can't double swipe up to All Apps. This is
needed before All Apps spring can be enabled, because the spring makes it
easier to get into this state.

To repo bug:
1. Hold shelf up so that overview starts to peek
2. Release
3. Before overview peek animation finishes, swipe up again to go to All Apps.

Bug: 79878197
Change-Id: I8c87b742d7da31d23be4decb72b45e9f21788af9
2020-01-30 19:53:26 -08:00
TreeHugger Robot ed6aa18992 Merge "Making setActiveOverlay and getCurrentOverlayPackage public" into ub-launcher3-master 2020-01-30 23:39:45 +00:00
Sunny Goyal 9c2b96090b Adding SecondaryDisplayLauncher in Launcher using common listener
Bug: 141596722
Change-Id: I480bfadf592f7d0309f17c33a3fe14bb77fb5586
2020-01-30 08:27:27 +00:00
vadimt 4809121c02 Making setActiveOverlay and getCurrentOverlayPackage public
These will be used by memory tests

Bug: 139137636
Change-Id: I213966e8a0443b122412a4fd9fc6415870db2c05
2020-01-30 02:39:26 +00:00
TreeHugger Robot 6f7f380dde Merge "Verifying the event for pressing square button" into ub-launcher3-master 2020-01-29 19:01:56 +00:00
TreeHugger Robot 89321dde65 Merge "Tracing for another "Launcher didn't initialize" failure" into ub-launcher3-master 2020-01-29 18:38:49 +00:00
TreeHugger Robot 657fa570da Merge "Fixing another reference to Launcher activity after its destruction" into ub-launcher3-master 2020-01-29 18:37:49 +00:00
TreeHugger Robot 0618d689e8 Merge changes from topic "state-supplier" into ub-launcher3-master
* changes:
  Translate recents slightly while dragging after pausing
  Two-zone model: swipe up from nav bar vs above it
  Change LauncherState to Supplier<LauncherState> in tests
2020-01-29 03:06:04 +00:00
Tony Wickham fd239cafbe Translate recents slightly while dragging after pausing
There's a lot of resistance, but feels better than nothing
responding to your movement.

Bug: 143361609
Change-Id: I9d7e06279ebdbaa0317909ce96d6f001dbe9699a
2020-01-28 18:31:14 -08:00
Tony Wickham 4fdba14cfb Two-zone model: swipe up from nav bar vs above it
When ENABLE_OVERVIEW_ACTIONS flag is enabled, swiping up from the nav
bar goes to overview if you hold, or the first home screen if you don't.

- Added NoButtonNavBarToOverviewTouchController, which extends
  FlingAndHoldTouchController but only works if you start from the nav
  bar. Otherwise it falls back to PortraitStatesTouchController to
  handle normal state transition to all apps.
- Added HintState. This is where the workspace/hotseat/qsb scale down
  when you swipe up from the nav bar, to hint that you're about to
  either go to overview or the first home screen.
  - Added getQsbScaleAndTranslation() to allow Overview and Hint states
    to treat it as part of the hotseat.
  - Since Overview needs to show above the QSB as it's animating, bring
    Overview to the front and update OverviewScrim to handle the case
    where there's no view above Overview to draw the scrim beneath.
- ENABLE_OVERVIEW_ACTIONS is always false in 2-button mode, since the
  shelf is crucial to that mode.

Bug: 143361609
Change-Id: I743481bb239dc77f7024dc98ba68a43534da2637
2020-01-28 18:31:10 -08:00
vadimt 8196e7984a Verifying the event for pressing square button
Change-Id: If7e3cf29e3a069a295f2612800ddbbfc27653c32
2020-01-28 18:23:05 -08:00
Tony Wickham 8a054061ef Change LauncherState to Supplier<LauncherState> in tests
This prevents the test from statically initializing LauncherState and
all its static dependencies, which might lead to runtime exceptions in
out-of-proc tests.

Change-Id: I0e4e09dfb31a8b256c2c0c0b3d1d2ecd0cc92230
2020-01-28 18:07:33 -08:00
vadimt a931e1981d Fixing another reference to Launcher activity after its destruction
Bug: 139137636
Change-Id: Id7a3a3d8c49d28dae964852661dfa330a8535375
2020-01-28 15:14:59 -08:00
vadimt c8b09709ff Tracing for another "Launcher didn't initialize" failure
This simply restored logging used for one of earlier investigations

Bug: 148313079
Change-Id: Idafed13208dc5610d577986fc487d1d44bc0ef5e
2020-01-27 17:48:49 -08:00
Zak Cohen 4b26b21424 Merge "Revert "Revert "Use autogenerated SysUiStatsLog for statsd logging""" into ub-launcher3-master 2020-01-27 23:49:50 +00:00
Zak Cohen ef01e6e86b Revert "Revert "Use autogenerated SysUiStatsLog for statsd logging""
This reverts commit 3b7209d0d6.

Reason for revert: replacing after the lib drop

Change-Id: Ide0a88da611d4a9dfe0c7ba980fabdc14ac96b31
2020-01-27 23:49:12 +00:00
Zak Cohen 7db9e7b92c SystemUiProxy - add screenshot method.
Test: build, manual integration
Bug: 145297320
Change-Id: Ia19e4b88a669c4f8d4d29a2e8e61207fee279ac3
2020-01-27 15:38:36 -08:00
Samuel Fufa 4bbed19012 Work profile edu
+ Move bottom sheet edu resources to launcher3

Bug: 140099753
Test: Manual
Change-Id: I933acea2b503c0f98362322d24a067c33a1bb2a7
2020-01-27 10:09:04 -08:00
Becky Qiu 01f0964129 Merge "[Overview Actions] Let RecentsView child match system LTR setting." into ub-launcher3-master 2020-01-25 23:00:12 +00:00
Hyunyoung Song ce67572ec8 Merge "Revert "Use autogenerated SysUiStatsLog for statsd logging"" into ub-launcher3-master 2020-01-25 02:20:56 +00:00
Hyunyoung Song 3b7209d0d6 Revert "Use autogenerated SysUiStatsLog for statsd logging"
This reverts commit a315ec5f17.

Reason for revert: This CL should've been in the same topic as the sharedlib. Currently sharedlib is reverted, hence without this change ub-launcher3-master build is broken.

Change-Id: I80d529c1facb3245ad81f2a63f472337a2e1d9fa
2020-01-25 02:19:25 +00:00
TreeHugger Robot 39ac994e12 Merge "Avoid confusing errors "Launcher pid should be 0" when test setup fails" into ub-launcher3-master 2020-01-25 01:46:20 +00:00
Becky Qiu 4c31c860b4 [Overview Actions] Let RecentsView child match system LTR setting.
Test:local

Change-Id: I0342701d76e2115e249b6d51d0f4a224a0f022e4
2020-01-24 16:52:41 -08:00
vadimt fcaab044a3 Avoid confusing errors "Launcher pid should be 0" when test setup fails
Change-Id: Ic5e8114a0f86d1a08738785c4098645e59a24975
2020-01-24 14:30:40 -08:00
Muhammad Qureshi a315ec5f17 Use autogenerated SysUiStatsLog for statsd logging
StatsLogCompat is not needed because we can autogenerate StatsLog write
calls that are public. This CL switches uses of StatsLogCompat to using
SysUiStatsLog from SystemUI.

Bug: 145952197
Test: m
Test: fastboot flashall
Test: adb shell cmd stats print-logs && adb logcat "*:S statsd:*" and
inspect LAUNCHER_EVENT logging

Change-Id: Ib4f90a79f436cdd7e058fdb7027c09a5a59cc4f9
(cherry picked from commit 33ec1e182e)
2020-01-24 21:57:31 +00:00
TreeHugger Robot 8f76378bf5 Merge "Adding events checking for Launcher starting apps" into ub-launcher3-master 2020-01-24 20:23:39 +00:00
vadimt 6098a8c8c0 Adding events checking for Launcher starting apps
Change-Id: Id651397f643280a9f99a470df029479bd1b41e5c
2020-01-23 19:12:19 -08:00
Samuel Fufa 93d7917f39 Merge "Log App Predictions from AiAi" into ub-launcher3-master 2020-01-24 01:28:20 +00:00
Samuel Fufa 68c57419c0 Log App Predictions from AiAi
+ Update edu screen strings

Bug:142753423
Test:Manual
Change-Id: If2424d134a5f9d2cafa248949a249ee2c7296276
2020-01-23 16:42:31 -08:00
Vadim Tryshev 8cf7b03cad Merge "Adding auto-investigation of one more flake" into ub-launcher3-master 2020-01-23 20:17:33 +00:00
vadimt 29d8b54957 Disabling events checks for successful gestures by default
Launcher tests will still perform checks upon every gesture completion.

All tests using tapl will still use events for diagnostics if the
gesture fails.

The benefit is that system health and other platform tests won't have to
use expensive logcat, and moreover, wait seconds for the events to
appear in logcat because of buffering in logcat.

Change-Id: I3b5a0965d9432144d0c4a8b40ebe2fa89b19a689
2020-01-22 19:16:32 -08:00
vadimt f51cbd8e69 Use wrapped launcher animation runner for app launch
- Prevents a lingering reference to the icon view

Bug: 139137636
Change-Id: I576dd4f55609dbe75ef37a5f264eb808e571863d
2020-01-22 11:24:28 -08:00
vadimt 2c6316be46 Adding auto-investigation of one more flake
Reshuffling the tests to make the investigator the outmost rule and run
the code that throws the original exception inside the investigator.

Change-Id: I714717a9b616862db5ce59116138ba7ea6ceb971
2020-01-21 19:06:59 -08:00
Sunny Goyal 94fa76fbeb Updating feature flags subclassing
> Preventing debug flags to get change listener on release device

Bug: 147913781
Change-Id: I2bd0456918c5d3224c714b153c4565b1ef41d7c0
2020-01-21 14:22:58 -08:00
Winson Chung 24ab40cebe Move remote animation definition runner to wrapped class
- Add call to unregister for remote animations from the system
  when the launcher activity is destroyed to prevent a lingering
  reference from the system to the old activity. But separately,
  to not have to wait for the system to GC before clearing the
  binder ref, we also wrap all runner implementations so that
  they can be cleaned up after a GC in our process only.

Bug: 139137636

Change-Id: Ib6276cac80b446440ec101fe00eae6ca41fdf32c
2020-01-17 21:34:54 +00:00
vadimt d8827bad12 Verifying that Launcher didn't crash in TaplTestsQuickstep
TaplTestsLauncher3 already do this

Change-Id: I17fe638b81cbef4cf5230a6bd49b165e4f9e7855
2020-01-16 17:28:43 -08:00
Tony Wickham 0e4cc09738 Merge "If RecentsView is empty when starting quickswitch, listen for tasks to load" into ub-launcher3-master 2020-01-16 00:18:19 +00:00
TreeHugger Robot a97958a22a Merge "Swipe up from nav bar in fallback recents to go home" into ub-launcher3-master 2020-01-15 22:56:41 +00:00
Vadim Tryshev f7b2d40347 Merge "TAPL: Verifying some interactions with system" into ub-launcher3-master 2020-01-15 22:32:13 +00:00
vadimt 252d012ed0 TAPL: Verifying some interactions with system
Investigation of TAPL failures, especially flakes is complex, partially
because it’s hard to tell whether it’s Launcher who is wrong or the
system.

We need to introduce a framework that looks at Launcher interaction with
the system and reports when interactions deviate from the expected
course, and who made the first wrong step.

This is first, proof-of-concept CL.

It analyzes long-press events. We had multiple cases when long-presses
didn’t happen or happened unexpectedly.

Launcher registers the events, TAPL retrieves and compares against the
sequence of expected regular expressions. This diagnostic is used when
something fails and at the end of public methods.

Change-Id: I07aa3a027267c03422c99c73ccd8808445c55fe8
2020-01-15 13:31:18 -08:00
TreeHugger Robot 14bd192275 Merge "Track bottom of the app window when ENABLE_OVERVIEW_ACTIONS is true" into ub-launcher3-master 2020-01-14 23:33:02 +00:00
Tony Wickham 011439e353 If RecentsView is empty when starting quickswitch, listen for tasks to load
When first doing quick switch, RecentsView might be empty but tasks subsequently
load. In that case, we can update our animators to have the correct scale etc.

Test: From home, toggle dark theme or RTL from quick setting tiles,
then quick switch; ensure RecentsView comes in scaled up.

Bug: 126596417
Change-Id: I28d79455431b1da634372d6f31182406aa24cd06
2020-01-14 21:27:59 +00:00
Tony Wickham 107dd8dd66 Track bottom of the app window when ENABLE_OVERVIEW_ACTIONS is true
- Fix the shelf tracking distance since there's no shelf.
- Pullback against a swipe up from an app later

Bug: 143361609
Change-Id: I296fb9bcb20d7d45931006f20512f0dc4a54212b
2020-01-10 14:44:29 -08:00
Sunny Goyal 2000228dc0 Merge "Adding support for multiple Model clients" into ub-launcher3-master 2020-01-10 22:21:20 +00:00
Sunny Goyal a7a5bf3101 Adding support for multiple Model clients
Bug: 137568159
Change-Id: Ia4db800b19cc80c695fcb9ea28e07709dfd08c6a
2020-01-10 12:23:27 -08:00
TreeHugger Robot 0e7a81ea0a Merge "Change hotseat edu strings" into ub-launcher3-master 2020-01-10 17:29:39 +00:00
TreeHugger Robot c85ab32e88 Merge "Use same content description for Recent apps" into ub-launcher3-master 2020-01-10 17:08:54 +00:00
Samuel Fufa 3db240a134 Change hotseat edu strings
Bug: 142753423
Change-Id: I0de86073b75eb1866d827d9e3fc35236accc67a0
2020-01-10 08:34:49 -08:00
Tracy Zhou 4d7b244f3f Render user's actual workspace in ThemePicker preview (Part 2)
With this change, we can also render folders in preview. It's built on top of part 1.

Test: Go to grid options, choose a different grid option, and see user's workspace rendered in the preview
Bug: 144052839
Change-Id: Iaf6d8af6b909ece4147ea250d95dec3d2c0019d3
2020-01-08 15:42:58 -08:00
Jonathan Miranda 1b4ed6dd9b Merge "Enable working springs. Move unstable springs to a seperate feature flag." into ub-launcher3-master 2020-01-08 21:17:49 +00:00