Commit Graph

10007 Commits

Author SHA1 Message Date
Sunny Goyal d4995e1eec Adding TaskViewSimulator for simulating taskView layout on a remote target am: f2393f1d20
Change-Id: I020e4b56de42e455b92c078bf4c8502fa3f0713c
2020-04-21 19:46:57 +00:00
Sunny Goyal f2393f1d20 Adding TaskViewSimulator for simulating taskView layout on a remote target
1. Tanslating contents of RecentsView instead of recentsView itself. When
   translating, we keep the current TaskView from moving. This allows
   the remoteTarget to follow an individual taskView.
2. Removing translationY in recentsView and setting the pivot instead
3. Using TaskViewSimulator for swipe handler. This allows using similar
   animation creation as Launcher window animation.

Change-Id: I0b7b16c367d9d8cd8dd0ed59061e46853e2f8c83
2020-04-21 11:16:21 -07:00
TreeHugger Robot 528a6029c0 Merge "Updates folder creation logging." into ub-launcher3-master 2020-04-21 02:34:45 +00:00
TreeHugger Robot 7ccd2daa62 Merge "ItemInfo null check inside BaseDraggingActivity" into ub-launcher3-rvc-dev 2020-04-21 02:07:12 +00:00
thiruram 9a3671e80e Updates folder creation logging.
After ag/11020901, folder creation process will not open gboard and hence drag and drop events resulting in folder creation should send additional folder creation event.

Fixes NPE with ItemInfo.java.

Bug: 153768241

Change-Id: I52c996a62dee52bf07feef4252aadc2a28c79752
2020-04-20 17:11:34 -07:00
Hyunyoung Song 103e8e36aa ItemInfo null check inside BaseDraggingActivity
Bug: 153611516
Change-Id: I0b9fed9134a103e3f7162756fd91ea4ad89e09bb
2020-04-20 16:29:04 -07:00
TreeHugger Robot bb74388420 Merge "Using inbuild smooth scroller instead of custom fastscrolling logic" into ub-launcher3-rvc-dev 2020-04-20 19:32:02 +00:00
TreeHugger Robot 5a5a39f084 Merge "add FeatureFlag type to the dump / also sort them" into ub-launcher3-rvc-dev 2020-04-20 18:45:12 +00:00
Sunny Goyal 355e845851 Using inbuild smooth scroller instead of custom fastscrolling logic
Change-Id: I9208720c3bf164bd664e5bacd75b672573fe7601
2020-04-20 11:15:34 -07:00
TreeHugger Robot f01f25b579 Merge "Fixing actions view getting visible sometimes" into ub-launcher3-rvc-dev 2020-04-20 17:52:03 +00:00
Sunny Goyal 01d8541f14 Fixing actions view getting visible sometimes
> Linking actions view to state flags
> Creating multiple visibility channels that can be controlled separately

Bug: 153906903
Change-Id: I33d20f5fdc8bcdf0520dae3aac986548eb7e0058
2020-04-20 09:59:13 -07:00
jayaprakashs 12cf1e5440 Add getScore() method to FolderNameInfo class.
getScore() is not used in launcher3 but exposed for testing purpose.

Change-Id: I22e674dabc3c24879c1c1b5881f9fc6005404998
2020-04-19 18:30:26 -07:00
Vinit Nayak 8699bf5626 Merge "Re-enable home screen rotation" into ub-launcher3-rvc-dev 2020-04-18 05:22:26 +00:00
TreeHugger Robot 3e54ddc010 Merge "Remove tracing for widgets scroll bug" into ub-launcher3-rvc-dev 2020-04-18 03:14:44 +00:00
vadimt 822efc9e82 Remove tracing for widgets scroll bug
Bug: 152354290
Change-Id: Iff56460f3f673f7089d647d08bb621c3965c7444
2020-04-17 19:04:41 -07:00
Adam Cohen b212e28c62 Merge "Decouple the scaling / translation of widget views necessary in split-screen" into ub-launcher3-rvc-dev 2020-04-17 23:35:19 +00:00
Adam Cohen d916206271 Decouple the scaling / translation of widget views necessary in split-screen
=> We pull apart the scale and translation that are set in a fairly
   static way due to split-screen vs. the general translation and scale
   properties that might be used more dynamically, in this case
   for re-order animations
=> This allows removal of some code that breaks reorder animations
   due to the accrual of translations / scales in certain edge cases.
=> TODO in future CL: address other translation cases and make the throw
   case for calling base setTranslationX/Y for Workspace Items unconditional

issue 149438360

test: manual
Change-Id: Ic3fde172f669e215cd25db0fcd4e1c3c873d314f
2020-04-17 15:36:44 -07:00
Hyunyoung Song 14a3ace27e add FeatureFlag type to the dump / also sort them
Bug: 152660449

$ adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
SERVICE com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService d4107aa pid=27740
  Client:
    DeviceFlags:
      APP_SEARCH_IMPROVEMENTS, defaultValue=true, mCurrentValue=true, mDefaultValueInCode=true
      ENABLE_HYBRID_HOTSEAT, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
      ENABLE_SUGGESTED_ACTIONS_OVERVIEW, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
      FOLDER_NAME_SUGGEST, defaultValue=true, mCurrentValue=true, mDefaultValueInCode=true
      HOTSEAT_MIGRATE_TO_FOLDER, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
    DebugFlags:
      ADAPTIVE_ICON_WINDOW_ANIM, defaultValue=true, mCurrentValue=true
      ALWAYS_USE_HARDWARE_OPTIMIZATION_FOR_FOLDER_ANIMATIONS, defaultValue=false, mCurrentValue=false
      APPLY_CONFIG_AT_RUNTIME, defaultValue=true, mCurrentValue=true
      ASSISTANT_GIVES_LAUNCHER_FOCUS, defaultValue=false, mCurrentValue=false
      ENABLE_DATABASE_RESTORE, defaultValue=true, mCurrentValue=true
      ENABLE_DEEP_SHORTCUT_ICON_CACHE, defaultValue=true, mCurrentValue=true
      ENABLE_FIXED_ROTATION_TRANSFORM, defaultValue=true, mCurrentValue=true
      ENABLE_LAUNCHER_PREVIEW_IN_GRID_PICKER, defaultValue=true, mCurrentValue=true
      ENABLE_LSQ_VELOCITY_PROVIDER, defaultValue=true, mCurrentValue=true
      ENABLE_OVERVIEW_ACTIONS, defaultValue=true, mCurrentValue=false
      ENABLE_PREDICTION_DISMISS, defaultValue=false, mCurrentValue=false
      ENABLE_QUICK_CAPTURE_GESTURE, defaultValue=true, mCurrentValue=true
      ENABLE_QUICKSTEP_LIVE_TILE, defaultValue=false, mCurrentValue=false
      ENABLE_SELECT_MODE, defaultValue=true, mCurrentValue=true
      ENABLE_UNIVERSAL_SMARTSPACE, defaultValue=false, mCurrentValue=false
      FORCE_LOCAL_OVERSCROLL_PLUGIN, defaultValue=false, mCurrentValue=false
      KEYGUARD_ANIMATION, defaultValue=false, mCurrentValue=false
      MULTI_DB_GRID_MIRATION_ALGO, defaultValue=false, mCurrentValue=false
      PROMISE_APPS_IN_ALL_APPS, defaultValue=false, mCurrentValue=false
      PROMISE_APPS_NEW_INSTALLS, defaultValue=true, mCurrentValue=true
      QUICKSTEP_SPRINGS, defaultValue=true, mCurrentValue=true
      UNSTABLE_SPRINGS, defaultValue=false, mCurrentValue=false
      USE_SURFACE_VIEW_FOR_GRID_PREVIEW, defaultValue=true, mCurrentValue=true
    PluginManager:
      numEnabledPlugins=1
      numDisabledPlugins=0
      enabledPlugins=[ComponentInfo{com.android.launcher.plugins.AllAppsSearchPlugin/com.android.launcher.plugins.AllAppsSearch}]
      disabledPlugins=[]



Change-Id: Ifefc02683834e52e3b78f93861a90f97a72c01d8
2020-04-17 15:08:52 -07:00
Jon Miranda a28e0f474a Fix NPE when closing folder.
There is a race condition where Folder is closing, it unbinds, and then
another call to AbstractFloatingView.closeAllOpenViews tries to close the
Folder again. But since the contents are unbound and removed from the folder,
it produces a NPE.

Bug: 153625271
Change-Id: Ia6c55f15cf7517e26af8f499bc0c1a4828737480
2020-04-17 15:03:33 -07:00
Vinit Nayak 326d93bd56 Re-enable home screen rotation
Launcher home screen rotation now works with fixed
transform. When using Quickstep while holding
the phone from an orientation different than
the orientation of the touch, the overview
shown will be that of the phone orientation,
not the touch orientation.
Easier to see this be quickswitching from
portrait to landscape app, turning phone, then
going to overview from the original region you
swiped.

Fixes: 150214193
Test: Created test apps and fixed them
to various rotations to test.

Change-Id: Ic6565cd0ed33c951f45ccb97278045c6070e438e
2020-04-17 14:38:12 -07:00
Tony Wickham c09e8fbe9d Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev 2020-04-17 19:35:49 +00:00
TreeHugger Robot 2a14c83515 Merge "Prevent two overlapping long press actions." into ub-launcher3-rvc-dev 2020-04-16 22:25:34 +00:00
TreeHugger Robot 64abef8ca1 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev 2020-04-16 21:58:47 +00:00
Jon Miranda a1567d50d0 Prevent two overlapping long press actions.
We add a check in CheckLongPressHelper to not trigger long press if the
view is already in the pressed state.

This fixes the bug where a stranded DragView is left in the DragLayer.

Repo's every 50 tries:
- Open folder
- Long click and slightly drag the same item over and over in slightly
  different directions.

Logs show that long click on folder item initiates the first long click,
and then later on CheckLongPressHelper triggers another long press before the
initial one is finished.

Bug: 151053858
Change-Id: Ifbb6919e4f0153aaef2904f704baa284e78f1e83
2020-04-16 14:00:50 -07:00
Jonathan Miranda a976a2212d Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev 2020-04-16 20:10:05 +00:00
Hyunyoung Song 6dde528c82 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev 2020-04-16 19:45:26 +00:00
Hyunyoung Song 3f82135f06 Add AllAppsSearchPlugin
Bug: 151089843

Change-Id: I6d61fb9c7855bafee731f47147b3070a1b672071
2020-04-16 11:50:04 -07:00
Andy Wickham 4f66dc3bef Adds dummy HomeGestureTutorialFragment.
- Adds a new launch target in Dev options
 - Moves Back handling to the parent TutorialFragment
   (so all Tutorials can handle it as necessary)
 - Currently uses a dummy translating rectangle in
   place of a proper hand animation
 - No actual home gesture recognition is in place yet

Test: Manual
Bug: 148542211
Change-Id: Ic5a545eb9f5003914803272c8ffe367220d63336
2020-04-16 18:23:08 +00:00
jayaprakashs 86932724e7 Don't open the Folder and IME when Folder is created.
Bug: 153751859
Change-Id: I8169d0890a43b614b293ca29f504e19c532b90ee
(cherry picked from commit 09066ffeb2)
2020-04-16 02:43:36 +00:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot 62d493d50b Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-15 21:57:31 +00:00
TreeHugger Robot 1fe0a4e080 Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev 2020-04-15 21:41:34 +00:00
Tony Wickham cfb803c42c Address race condition with drag from external window
When dragging from another window, e.g. when pinning an app shortcut,
there's a race condition as follows if launcher is killed:
- System drag starts
- Workspace loads and starts binding, canceling the drag

With this change, the drag will get onDragStart() again after this
case and allow completion of the drop.

Change-Id: I3f1c786ad1d451ecda9bbac5e9a9a3e0d8b66f73
2020-04-15 15:56:57 -05:00
vadimt f528fa6518 Removing tracing for a fixed bug
Bug: 138251824
Change-Id: Icd0d5001bfce0b1dabc102a2bbb0212a57d5839a
2020-04-15 13:51:47 -07:00
vadimt cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
TreeHugger Robot ce2d7134f6 Merge "Manually marking widgets recycler as non-scrollable of frozen" into ub-launcher3-rvc-dev 2020-04-15 18:12:13 +00:00
TreeHugger Robot c730304898 Merge "Revert "Use UiEvent for constants inside StatsLogManager"" into ub-launcher3-rvc-dev 2020-04-15 17:32:22 +00:00
vadimt 31fa653ef3 Manually marking widgets recycler as non-scrollable of frozen
There was hope that freezing automatically marks it as non-scrollable,
but this happened to be not true.

Sending accessibility event per pweaver@'s instructions.

Bug: 152354290
Change-Id: Idd04c69cef9e8e621775ef86112f35e3d9d9d2da
2020-04-15 10:21:14 -07:00
Hyunyoung Song 1505d2f2e6 Revert "Use UiEvent for constants inside StatsLogManager"
This reverts commit 6b99a7d397.

Reason for revert: Launcher3 AOSP cannot link to uieventloggerlib because it's private API

Change-Id: Id652b8a4cba54b97d1d8b8644c2939903cc0e88a
2020-04-15 16:52:19 +00:00
Sunny Goyal ae190ff807 Revert "Have consistent All Apps UI between grid size changes."
Revert submission 557031-1571265377317-631e3e5

Reason for revert: Breaks multiwindow and secondary display layout
Reverted Changes:
Idee087e31:Remove numAllAppsColumns, allAppsIconSize, allApps...
I6235862c9:Have consistent All Apps UI between grid size chan...

Change-Id: I64156123a8fbaba1a7d2b64cddd5376671123aa2
2020-04-14 17:19:47 -07:00
TreeHugger Robot 2fc1c88448 Merge "Revert "Show all apps app names in multi window landscape"" into ub-launcher3-rvc-dev 2020-04-15 00:12:21 +00:00
Hyunyoung Song a613217bd0 Merge "Use UiEvent for constants inside StatsLogManager" into ub-launcher3-rvc-dev 2020-04-15 00:09:13 +00:00
Sunny Goyal 604e7bd667 Revert "Show all apps app names in multi window landscape"
This reverts commit 1c3c3b1d6f.

Reason for revert: Broke multi-window rotation and secondary display

Change-Id: I907b21ca82cf2e25f8abe7a09eafd6dec817f81b
(cherry picked from commit 157e666058)
2020-04-14 23:24:02 +00:00
Jon Miranda f8df99fd0a Fix bug where view stays invisible due to view recycling before it gets reset.
Repo steps:
* Drag item out of folder into a space where it won't fit (ie. full workspace)
* Drop item before folder finishes closing

The issue is that the drop completes and we unbind the folder contents
before the postDelayed callback runs to set the view back to visible.

Bug: 153267452
Change-Id: I0bd4e41cc6dda8b908eed3c8789ced54da4ac38a
2020-04-14 14:39:08 -07:00
Hyunyoung Song 6b99a7d397 Use UiEvent for constants inside StatsLogManager
Bug: 137777105
Bug: 148533500
Change-Id: I8ebf1110e8d25ab28f7496add9734bd7386b272f
2020-04-14 13:59:31 -07:00
TreeHugger Robot eb916b560b Merge "Remove swipe support on WorkModeSwitch" into ub-launcher3-rvc-dev 2020-04-14 09:04:29 +00:00
TreeHugger Robot dafb4d10ae Merge "Resolve RTL Work tab highlight" into ub-launcher3-rvc-dev 2020-04-14 05:57:22 +00:00
Samuel Fufa b2b1a0b351 Remove swipe support on WorkModeSwitch
Bug: 153063698
Test: Manual
Change-Id: I0c59617772e1cedff364fd18413dcaec8031cd06
2020-04-13 21:54:58 -07:00
Samuel Fufa 73911d6545 Resolve RTL Work tab highlight
Bug: 153682566
Test: Manual
Change-Id: Ibe2160f10233bae3aa5e86942ac69a9a40fc13e3
2020-04-13 13:45:27 -07:00